Hello community, here is the log from the commit of package xf86-video-intel for openSUSE:Factory checked in at 2018-05-25 21:35:24 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/xf86-video-intel (Old) and /work/SRC/openSUSE:Factory/.xf86-video-intel.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "xf86-video-intel" Fri May 25 21:35:24 2018 rev:77 rq:611659 version:2.99.917+git781.c8990575 Changes: -------- --- /work/SRC/openSUSE:Factory/xf86-video-intel/xf86-video-intel.changes 2017-09-29 11:50:52.560963498 +0200 +++ /work/SRC/openSUSE:Factory/.xf86-video-intel.new/xf86-video-intel.changes 2018-05-25 21:35:25.684065364 +0200 @@ -1,0 +2,6 @@ +Thu May 10 13:02:31 UTC 2018 - [email protected] + +- n_fix-build-on-i686.patch + * Fix build on i686 with GCC8. (bnc#1092541) + +------------------------------------------------------------------- New: ---- n_fix-build-on-i686.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ xf86-video-intel.spec ++++++ --- /var/tmp/diff_new_pack.0hPXUn/_old 2018-05-25 21:35:26.280043795 +0200 +++ /var/tmp/diff_new_pack.0hPXUn/_new 2018-05-25 21:35:26.288043505 +0200 @@ -1,7 +1,7 @@ # # spec file for package xf86-video-intel # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -31,6 +31,7 @@ # Created using git archive. Source0: %{name}-%{version}.tar.xz Source99: baselibs.conf +Patch0: n_fix-build-on-i686.patch BuildRequires: autoconf BuildRequires: automake BuildRequires: libtool @@ -134,6 +135,11 @@ %prep %setup -qn %{name} +%ifarch %{ix86} +# Applied only on 32bit architectures because only those need it to build with +# GCC8. It may slightly hurt performance, so lets not apply it where not needed. +%patch0 -p1 +%endif %build autoreconf -fvi ++++++ n_fix-build-on-i686.patch ++++++ Author: Adam Jackson <[email protected]> Date: Tue, 6 Mar 2018 12:07:46 -0500 Subject: Fix build on i686 Patch-upstream: Never References: bnc#1092541 Presumably this only matters for i686 because amd64 implies sse2, but: BUILDSTDERR: In file included from gen4_vertex.c:34: BUILDSTDERR: gen4_vertex.c: In function 'emit_vertex': BUILDSTDERR: sna_render_inline.h:40:26: error: inlining failed in call to always_inline 'vertex_emit_2s': target specific option mismatch BUILDSTDERR: static force_inline void vertex_emit_2s(struct sna *sna, int16_t x, int16_t y) BUILDSTDERR: ^~~~~~~~~~~~~~ BUILDSTDERR: gen4_vertex.c:308:25: note: called from here BUILDSTDERR: #define OUT_VERTEX(x,y) vertex_emit_2s(sna, x,y) /* XXX assert(!too_large(x, y)); */ BUILDSTDERR: ^~~~~~~~~~~~~~~~~~~~~~~~ BUILDSTDERR: gen4_vertex.c:360:2: note: in expansion of macro 'OUT_VERTEX' BUILDSTDERR: OUT_VERTEX(dstX, dstY); BUILDSTDERR: ^~~~~~~~~~ The bug here appears to be that emit_vertex() is declared 'sse2' but vertex_emit_2s is merely always_inline. gcc8 decides that since you said always_inline you need to have explicitly cloned it for every permutation of targets. Merely saying inline seems to do the job of cloning vertex_emit_2s as much as necessary. So to reiterate: if you say always-inline, it won't, but if you just say maybe inline, it will. Thanks gcc, that's helpful. - ajax --- src/sna/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sna/compiler.h b/src/sna/compiler.h index 3c176a16..bc447c7a 100644 --- a/src/sna/compiler.h +++ b/src/sna/compiler.h @@ -32,7 +32,7 @@ #define likely(expr) (__builtin_expect (!!(expr), 1)) #define unlikely(expr) (__builtin_expect (!!(expr), 0)) #define noinline __attribute__((noinline)) -#define force_inline inline __attribute__((always_inline)) +#define force_inline inline #define fastcall __attribute__((regparm(3))) #define must_check __attribute__((warn_unused_result)) #define constant __attribute__((const)) -- 2.16.2
