Hello community, here is the log from the commit of package knotifications for openSUSE:Factory checked in at 2018-06-22 13:21:55 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/knotifications (Old) and /work/SRC/openSUSE:Factory/.knotifications.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "knotifications" Fri Jun 22 13:21:55 2018 rev:55 rq:616777 version:5.47.0 Changes: -------- --- /work/SRC/openSUSE:Factory/knotifications/knotifications.changes 2018-05-18 14:22:41.545845210 +0200 +++ /work/SRC/openSUSE:Factory/.knotifications.new/knotifications.changes 2018-06-22 13:21:56.904442795 +0200 @@ -1,0 +2,10 @@ +Tue Jun 12 21:35:07 UTC 2018 - [email protected] + +- Update to 5.47.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.47.0.php +- Changes since 5.46.0: + * Fix crashes in NotifyByAudio when closing applications + +------------------------------------------------------------------- Old: ---- knotifications-5.46.0.tar.xz New: ---- knotifications-5.47.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ knotifications.spec ++++++ --- /var/tmp/diff_new_pack.s3K3JT/_old 2018-06-22 13:21:57.628416044 +0200 +++ /var/tmp/diff_new_pack.s3K3JT/_new 2018-06-22 13:21:57.628416044 +0200 @@ -18,13 +18,13 @@ %bcond_without lang %define lname libKF5Notifications5 -%define _tar_path 5.46 +%define _tar_path 5.47 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %global _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: knotifications -Version: 5.46.0 +Version: 5.47.0 Release: 0 %define kf5_version %{version} BuildRequires: cmake >= 3.0 ++++++ knotifications-5.46.0.tar.xz -> knotifications-5.47.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knotifications-5.46.0/CMakeLists.txt new/knotifications-5.47.0/CMakeLists.txt --- old/knotifications-5.46.0/CMakeLists.txt 2018-05-05 14:59:22.000000000 +0200 +++ new/knotifications-5.47.0/CMakeLists.txt 2018-06-02 20:02:31.000000000 +0200 @@ -1,12 +1,12 @@ cmake_minimum_required(VERSION 3.0) -set(KF5_VERSION "5.46.0") # handled by release scripts -set(KF5_DEP_VERSION "5.46.0") # handled by release scripts +set(KF5_VERSION "5.47.0") # handled by release scripts +set(KF5_DEP_VERSION "5.47.0") # handled by release scripts project(KNotifications VERSION ${KF5_VERSION}) # ECM setup include(FeatureSummary) -find_package(ECM 5.46.0 NO_MODULE) +find_package(ECM 5.47.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knotifications-5.46.0/po/zh_CN/knotifications5_qt.po new/knotifications-5.47.0/po/zh_CN/knotifications5_qt.po --- old/knotifications-5.46.0/po/zh_CN/knotifications5_qt.po 2018-05-05 14:59:22.000000000 +0200 +++ new/knotifications-5.47.0/po/zh_CN/knotifications5_qt.po 2018-06-02 20:02:31.000000000 +0200 @@ -13,7 +13,7 @@ msgid "" msgstr "" "Project-Id-Version: kdeorg\n" -"PO-Revision-Date: 2018-04-26 05:21-0400\n" +"PO-Revision-Date: 2018-05-18 06:23-0400\n" "Last-Translator: guoyunhebrave <[email protected]>\n" "Language-Team: Chinese Simplified\n" "Language: zh_CN\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/knotifications-5.46.0/src/notifybyaudio.cpp new/knotifications-5.47.0/src/notifybyaudio.cpp --- old/knotifications-5.46.0/src/notifybyaudio.cpp 2018-05-05 14:59:22.000000000 +0200 +++ new/knotifications-5.47.0/src/notifybyaudio.cpp 2018-06-02 20:02:31.000000000 +0200 @@ -142,6 +142,15 @@ KNotification *notification = m_notifications.value(m, nullptr); + if (!notification) { + // This means that close was called already so there's nothing else to do. + // Ideally we should not be getting here if close has already been called + // since stoping a mediaobject means it won't emit finished() *BUT* + // since the finished signal is a queued connection in phonon it can happen + // that the playing had already finished and we just had not got the signal yet + return; + } + //if the sound is short enough, we can't guarantee new sounds are //enqueued before finished is emitted. //so to make sure we are looping restart it when the sound finished
