Hello community, here is the log from the commit of package libXaw for openSUSE:Factory checked in at 2018-06-25 11:34:05 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libXaw (Old) and /work/SRC/openSUSE:Factory/.libXaw.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libXaw" Mon Jun 25 11:34:05 2018 rev:12 rq:618283 version:1.0.13 Changes: -------- --- /work/SRC/openSUSE:Factory/libXaw/libXaw.changes 2015-05-06 07:47:43.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.libXaw.new/libXaw.changes 2018-06-25 11:34:13.479588062 +0200 @@ -1,0 +2,6 @@ +Thu Jun 21 08:46:58 UTC 2018 - [email protected] + +- U_NULL-pointer-dereference-in-XawAsciiSinkInitialize.patch + * Fix crash when required font is not installed. (bsc#1098411) + +------------------------------------------------------------------- New: ---- U_NULL-pointer-dereference-in-XawAsciiSinkInitialize.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libXaw.spec ++++++ --- /var/tmp/diff_new_pack.ewArIN/_old 2018-06-25 11:34:13.939571085 +0200 +++ /var/tmp/diff_new_pack.ewArIN/_new 2018-06-25 11:34:13.943570937 +0200 @@ -1,7 +1,7 @@ # # spec file for package libXaw # -# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -28,6 +28,7 @@ #Git-Web: http://cgit.freedesktop.org/xorg/lib/libXaw/ Source: http://xorg.freedesktop.org/releases/individual/lib/%{name}-%{version}.tar.bz2 Source1: baselibs.conf +Patch0: U_NULL-pointer-dereference-in-XawAsciiSinkInitialize.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build #git#BuildRequires: autoconf >= 2.60, automake, libtool BuildRequires: pkgconfig @@ -102,6 +103,7 @@ %prep %setup -q +%patch0 -p1 %build %configure --docdir=%_docdir/%name --disable-static ++++++ U_NULL-pointer-dereference-in-XawAsciiSinkInitialize.patch ++++++ Git-commit: ba7321b6a52726cdb9964b82c5111518dc1f437d Author: Tobias Stoeckmann <[email protected]> Subject: NULL pointer dereference in XawAsciiSinkInitialize References: bsc#1098411 Patch-Mainline: Upstream Signed-off-by: Michal Srb <[email protected]> The function XawAsciiSinkInitialize is prone to a NULL pointer dereference if no font is available. Even though a specific check for a NULL font exists, it is called after GetGC(), which in turn would trigger the NPE in such a case. Spotted by calling xmessage on a system with an incomplete x font setup: $ xmessage -b text Warning: Unable to load any usable ISO8859 font Segmentation fault $ _ Signed-off-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Peter Hutterer <[email protected]> Signed-off-by: Peter Hutterer <[email protected]> --- src/AsciiSink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/AsciiSink.c b/src/AsciiSink.c index d776895..1cccb1c 100644 --- a/src/AsciiSink.c +++ b/src/AsciiSink.c @@ -1704,10 +1704,10 @@ XawAsciiSinkInitialize(Widget request, Widget cnew, { AsciiSinkObject sink = (AsciiSinkObject)cnew; - GetGC(sink); - if (!sink->ascii_sink.font) XtError("Aborting: no font found\n"); + GetGC(sink); + sink->ascii_sink.cursor_position = 0; sink->ascii_sink.laststate = XawisOff; sink->ascii_sink.cursor_x = sink->ascii_sink.cursor_y = 0; -- 2.13.6
