Hello community, here is the log from the commit of package rubygem-js-routes for openSUSE:Factory checked in at 2018-07-18 22:50:09 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/rubygem-js-routes (Old) and /work/SRC/openSUSE:Factory/.rubygem-js-routes.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rubygem-js-routes" Wed Jul 18 22:50:09 2018 rev:17 rq:621010 version:1.4.4 Changes: -------- --- /work/SRC/openSUSE:Factory/rubygem-js-routes/rubygem-js-routes.changes 2018-03-06 10:45:19.636534016 +0100 +++ /work/SRC/openSUSE:Factory/.rubygem-js-routes.new/rubygem-js-routes.changes 2018-07-18 22:50:11.835705507 +0200 @@ -1,0 +2,12 @@ +Mon May 7 12:04:09 UTC 2018 - [email protected] + +- updated to version 1.4.4 + see installed CHANGELOG.md + + * More informative stack trace for ParameterMissing error #235 + + ## v1.4.3 + + * Proper implementation of the :subdomain option in routes generation + +------------------------------------------------------------------- Old: ---- js-routes-1.4.3.gem New: ---- js-routes-1.4.4.gem ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rubygem-js-routes.spec ++++++ --- /var/tmp/diff_new_pack.Wx8U6f/_old 2018-07-18 22:50:13.551699818 +0200 +++ /var/tmp/diff_new_pack.Wx8U6f/_new 2018-07-18 22:50:13.579699725 +0200 @@ -24,7 +24,7 @@ # Name: rubygem-js-routes -Version: 1.4.3 +Version: 1.4.4 Release: 0 %define mod_name js-routes %define mod_full_name %{mod_name}-%{version} ++++++ js-routes-1.4.3.gem -> js-routes-1.4.4.gem ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/CHANGELOG.md new/CHANGELOG.md --- old/CHANGELOG.md 2017-12-18 14:37:02.000000000 +0100 +++ new/CHANGELOG.md 2018-05-07 13:15:41.000000000 +0200 @@ -1,5 +1,11 @@ ## master +* More informative stack trace for ParameterMissing error #235 + +## v1.4.3 + +* Proper implementation of the :subdomain option in routes generation + ## v1.4.2 * Added JsRoutes namespace to Engine #230 Binary files old/checksums.yaml.gz and new/checksums.yaml.gz differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/js_routes/version.rb new/lib/js_routes/version.rb --- old/lib/js_routes/version.rb 2017-12-18 14:37:03.000000000 +0100 +++ new/lib/js_routes/version.rb 2018-05-07 13:15:41.000000000 +0200 @@ -1,3 +1,3 @@ class JsRoutes - VERSION = "1.4.3" + VERSION = "1.4.4" end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/routes.js new/lib/routes.js --- old/lib/routes.js 2017-12-18 14:37:03.000000000 +0100 +++ new/lib/routes.js 2018-05-07 13:15:41.000000000 +0200 @@ -10,11 +10,33 @@ root = typeof exports !== "undefined" && exports !== null ? exports : this; - ParameterMissing = function(message) { - this.message = message; - }; + function ParameterMissing(message, fileName, lineNumber) { + var instance = new Error(message, fileName, lineNumber); + if(Object.setPrototypeOf) { + Object.setPrototypeOf(instance, Object.getPrototypeOf(this)); + } else { + instance.__proto__ = this.__proto__; + } + if (Error.captureStackTrace) { + Error.captureStackTrace(instance, ParameterMissing); + } + return instance; + } - ParameterMissing.prototype = new Error(); + ParameterMissing.prototype = Object.create(Error.prototype, { + constructor: { + value: Error, + enumerable: false, + writable: true, + configurable: true + } + }); + + if (Object.setPrototypeOf){ + Object.setPrototypeOf(ParameterMissing, Error); + } else { + ParameterMissing.__proto__ = Error; + } NodeTypes = NODE_TYPES; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/routes.js.coffee new/lib/routes.js.coffee --- old/lib/routes.js.coffee 2017-12-18 14:37:03.000000000 +0100 +++ new/lib/routes.js.coffee 2018-05-07 13:15:41.000000000 +0200 @@ -5,8 +5,27 @@ # root is this root = (exports ? this) -ParameterMissing = (@message) -> # -ParameterMissing:: = new Error() +ParameterMissing = (message, fileName, lineNumber) -> + instance = new Error(message, fileName, lineNumber) + if Object.setPrototypeOf + Object.setPrototypeOf instance, Object.getPrototypeOf(this) + else + instance.__proto__ = this.__proto__ + if Error.captureStackTrace + Error.captureStackTrace instance, ParameterMissing + instance + +ParameterMissing.prototype = Object.create(Error.prototype, constructor: + value: Error + enumerable: false + writable: true + configurable: true +) + +if Object.setPrototypeOf + Object.setPrototypeOf(ParameterMissing, Error) +else + ParameterMissing.__proto__ = Error NodeTypes = NODE_TYPES SpecialOptionsKey = SPECIAL_OPTIONS_KEY diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metadata new/metadata --- old/metadata 2017-12-18 14:37:02.000000000 +0100 +++ new/metadata 2018-05-07 13:15:41.000000000 +0200 @@ -1,14 +1,14 @@ --- !ruby/object:Gem::Specification name: js-routes version: !ruby/object:Gem::Version - version: 1.4.3 + version: 1.4.4 platform: ruby authors: - Bogdan Gusiev autorequire: bindir: bin cert_chain: [] -date: 2017-12-18 00:00:00.000000000 Z +date: 2018-05-07 00:00:00.000000000 Z dependencies: - !ruby/object:Gem::Dependency name: railties diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/spec/js_routes/rails_routes_compatibility_spec.rb new/spec/js_routes/rails_routes_compatibility_spec.rb --- old/spec/js_routes/rails_routes_compatibility_spec.rb 2017-12-18 14:37:03.000000000 +0100 +++ new/spec/js_routes/rails_routes_compatibility_spec.rb 2018-05-07 13:15:41.000000000 +0200 @@ -25,6 +25,19 @@ .to raise_error('Route parameter missing: title') end + it "should produce error stacktraces including function names" do + stacktrace = evaljs(" + (function(){ + try { + Routes.thing_path() + } catch(e) { + return e.stack; + } + })() + ") + expect(stacktrace).to include "thing_path" + end + it "should support 0 as a member parameter" do expect(evaljs("Routes.inbox_path(0)")).to eq(test_routes.inbox_path(0)) end
