Hello community,

here is the log from the commit of package iputils for openSUSE:Factory checked 
in at 2018-08-02 14:49:50
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/iputils (Old)
 and      /work/SRC/openSUSE:Factory/.iputils.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "iputils"

Thu Aug  2 14:49:50 2018 rev:44 rq:625585 version:s20180629

Changes:
--------
--- /work/SRC/openSUSE:Factory/iputils/iputils.changes  2018-07-06 
10:38:40.407491819 +0200
+++ /work/SRC/openSUSE:Factory/.iputils.new/iputils.changes     2018-08-02 
14:49:51.735448435 +0200
@@ -1,0 +2,7 @@
+Thu Jul 26 09:17:45 UTC 2018 - [email protected]
+
+- Backport upstream patch fixing tracepath6 (poo#38492)
+  e0baf20 tracepath: Fix copying input IPv6 address
+  0001-tracepath-Fix-copying-input-IPv6-address.patch
+
+-------------------------------------------------------------------

New:
----
  0001-tracepath-Fix-copying-input-IPv6-address.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ iputils.spec ++++++
--- /var/tmp/diff_new_pack.X9t8Pl/_old  2018-08-02 14:49:52.535449967 +0200
+++ /var/tmp/diff_new_pack.X9t8Pl/_new  2018-08-02 14:49:52.539449974 +0200
@@ -25,8 +25,9 @@
 Url:            https://github.com/iputils/iputils
 Source0:        https://github.com/iputils/iputils/archive/%{version}.tar.gz
 Source1:        rarpd.service
-Patch8:         iputils-sec-ping-unblock.diff
-Patch9:         iputils-ping-interrupt.diff
+Patch1:         iputils-sec-ping-unblock.diff
+Patch2:         iputils-ping-interrupt.diff
+Patch3:         0001-tracepath-Fix-copying-input-IPv6-address.patch
 BuildRequires:  docbook-xsl-stylesheets
 BuildRequires:  docbook_3
 BuildRequires:  iso_ent
@@ -63,8 +64,9 @@
 
 %prep
 %setup -q
-%patch8 -p1
-%patch9 -p1
+%patch1 -p1
+%patch2 -p1
+%patch3 -p1
 
 %build
 

++++++ 0001-tracepath-Fix-copying-input-IPv6-address.patch ++++++
>From e0baf20067a75f093d690bd51a6db3f5afabca77 Mon Sep 17 00:00:00 2001
From: Petr Vorel <[email protected]>
Date: Tue, 17 Jul 2018 17:56:10 +0200
Subject: [PATCH] tracepath: Fix copying input IPv6 address

Commit e669c86 broke copying input IPv6 address.
tracepath recover from it, but it's slower.

Previously was address too short:

    strace ./tracepath -6 fe80::8895:e2af:e96e:fd8f
    sendto(3, 
"\1\0\0\0\0\0\0\0\307\36N[\0\0\0\0w_\f\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 127952, 
0, {sa_family=AF_INET6, sin6_port=htons(44444), inet_pton(AF_INET6, "fe80::", 
&sin6_addr), sin6_flowinfo=htonl(0), sin6_scope_id=0}, 28) = -1 EMSGSIZE 
(Message too long)

After fix is correct:

    sendto(3, 
"\1\0\0\0\0\0\0\0\300\36N[\0\0\0\0'B\3\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 127952, 
0, {sa_family=AF_INET6, sin6_port=htons(44444), inet_pton(AF_INET6, 
"fe80::8895:e2af:e96e:fd8f", &sin6_addr), sin6_flowinfo=htonl(0), 
sin6_scope_id=0}, 28) = -1 EMSGSIZE (Message too long)

Bug found by LTP test.

Fixes: e669c86 tracepath: fix heap-buffer-overflow [asan]
Fixes: #137
---
 tracepath.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tracepath.c b/tracepath.c
index 53bda16..539a7a1 100644
--- a/tracepath.c
+++ b/tracepath.c
@@ -475,7 +475,7 @@ int main(int argc, char **argv)
                fd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);
                if (fd < 0)
                        continue;
-               memcpy(&target, ai->ai_addr, sizeof(*ai->ai_addr));
+               memcpy(&target, ai->ai_addr, ai->ai_addrlen);
                targetlen = ai->ai_addrlen;
                break;
        }
-- 
2.18.0


Reply via email to