Hello community, here is the log from the commit of package suck for openSUSE:Factory checked in at 2018-08-02 14:59:47 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/suck (Old) and /work/SRC/openSUSE:Factory/.suck.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "suck" Thu Aug 2 14:59:47 2018 rev:20 rq:626913 version:4.3.4 Changes: -------- --- /work/SRC/openSUSE:Factory/suck/suck.changes 2017-10-26 18:46:19.274526522 +0200 +++ /work/SRC/openSUSE:Factory/.suck.new/suck.changes 2018-08-02 15:00:39.120531483 +0200 @@ -1,0 +2,10 @@ +Wed Aug 1 13:57:43 UTC 2018 - [email protected] + +- Update to 4.3.4: + * Fix invalid memory access in both.c (Debian bug #858040) + * Fix SIGSEV in connect_to_nntphost (Debian bugs #716448, + #716510, #716606) + * Fix stack smash in lmove.c and suckutils.c (Debian bug #832265) + * Fix manpage formatting (Debian bug #858262) + +------------------------------------------------------------------- Old: ---- 4.3.3.tar.gz New: ---- 4.3.4.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ suck.spec ++++++ --- /var/tmp/diff_new_pack.vtNWf2/_old 2018-08-02 15:00:39.932532857 +0200 +++ /var/tmp/diff_new_pack.vtNWf2/_new 2018-08-02 15:00:39.932532857 +0200 @@ -1,7 +1,7 @@ # # spec file for package suck # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -21,7 +21,7 @@ BuildRequires: automake BuildRequires: inn-devel BuildRequires: openssl-devel -Version: 4.3.3 +Version: 4.3.4 Release: 0 Url: https://github.com/lazarus-pkgs/suck Summary: Reading News Offline ++++++ 4.3.3.tar.gz -> 4.3.4.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/CHANGELOG new/suck-4.3.4/CHANGELOG --- old/suck-4.3.3/CHANGELOG 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/CHANGELOG 2018-08-01 15:54:24.000000000 +0200 @@ -1,5 +1,14 @@ CHANGES ======= +-- Changes from suck-4.3.3 -> Suck-4.3.4 + +- Fix invalid memory access in both.c (Debian bug #858040) +- Fix SIGSEV in connect_to_nntphost (Debian bugs #716448, #716510, #716606) +- Fix stack smash in lmove.c and suckutils.c (Debian bug #832265) +- Fix manpage formatting (Debian bug #858262) + +August 01, 2018 - Suck-4.3.4 released + -- Changes from suck-4.3.2 -> Suck-4.3.3 - General code cleanup diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/Makefile.in new/suck-4.3.4/Makefile.in --- old/suck-4.3.3/Makefile.in 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/Makefile.in 2018-08-01 15:54:24.000000000 +0200 @@ -103,7 +103,7 @@ PKGNAME=suck VERSION_MAJOR=4 VERSION_MINOR=3 -VERSION_PATCH=3 +VERSION_PATCH=4 VERSION=$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_PATCH) CC = @CC@ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/both.c new/suck-4.3.4/both.c --- old/suck-4.3.3/both.c 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/both.c 2018-08-01 15:54:24.000000000 +0200 @@ -162,6 +162,11 @@ struct addrinfo * ai; char buffer[60]; // if not given by caller. NI_MAXHOST would be better, but that's ok as well. + if (host == NULL) { + error_log(ERRLOG_REPORT, both_phrases[0], NULL); + return sockfd; + } + #ifdef HAVE_LIBSSL SSL *ssl_struct = NULL; SSL_CTX *test1 = NULL; @@ -626,7 +631,10 @@ } vprint_phrases(fptr, fmt, args); if(debug == TRUE) { + va_list args; + va_start(args, fmt); do_debug_vl(fmt, args); + va_end(args); } if(fptr != stderr) { fclose(fptr); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/lmove.c new/suck-4.3.4/lmove.c --- old/suck-4.3.3/lmove.c 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/lmove.c 2018-08-01 15:54:24.000000000 +0200 @@ -669,8 +669,10 @@ sprintf(lockfile, "%s/%s", master->basedir, N_LMOVE_LOCKFILE); if((f_lock = fopen(lockfile, "r")) != NULL) { /* okay, let's try and see if this sucker is truly alive */ - fscanf(f_lock, "%ld", (long *) &pid); + long tmp = 0; + fscanf(f_lock, "%ld", &tmp); fclose(f_lock); + pid = (pid_t)tmp; if(pid <= 0) { error_log(ERRLOG_REPORT, lmove_phrases[14], lockfile, NULL); retval = RETVAL_ERROR; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/lpost.c new/suck-4.3.4/lpost.c --- old/suck-4.3.3/lpost.c 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/lpost.c 2018-08-01 15:54:24.000000000 +0200 @@ -42,7 +42,7 @@ } } else { - (void) fput(line, pfp); + (void) fputs(line, pfp); } } /* end while */ exit(retval); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/man/suck.1 new/suck-4.3.4/man/suck.1 --- old/suck-4.3.3/man/suck.1 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/man/suck.1 2018-08-01 15:54:24.000000000 +0200 @@ -192,7 +192,8 @@ \hostname The hostname may optionally include the port number, in the form -.BI Host:Port. If this option is used, any port number specified +.BI Host:Port. +If this option is used, any port number specified via the -N option is ignored. \@filename diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/suck.spec new/suck-4.3.4/suck.spec --- old/suck-4.3.3/suck.spec 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/suck.spec 2018-08-01 15:54:24.000000000 +0200 @@ -1,4 +1,4 @@ -%define version 4.3.3 +%define version 4.3.4 %define name suck %define release 1 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/suck-4.3.3/suckutils.c new/suck-4.3.4/suckutils.c --- old/suck-4.3.3/suckutils.c 2017-10-25 18:22:09.000000000 +0200 +++ new/suck-4.3.4/suckutils.c 2018-08-01 15:54:24.000000000 +0200 @@ -177,8 +177,10 @@ lockfile = full_path(FP_GET, FP_TMPDIR, N_LOCKFILE); if((f_lock = fopen(lockfile, "r")) != NULL) { /* okay, let's try and see if this sucker is truly alive */ - fscanf(f_lock, "%ld", (long *) &pid); + long tmp = 0; + fscanf(f_lock, "%ld", &tmp); fclose(f_lock); + pid = (pid_t)tmp; if(pid <= 0) { error_log(ERRLOG_REPORT, sucku_phrases[2], lockfile, NULL); retval = RETVAL_ERROR;
