Hello community,
here is the log from the commit of package yast2-network for openSUSE:Factory
checked in at 2018-08-04 21:50:43
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-network (Old)
and /work/SRC/openSUSE:Factory/.yast2-network.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network"
Sat Aug 4 21:50:43 2018 rev:390 rq:625829 version:4.1.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes
2018-07-03 23:32:11.728594535 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-network.new/yast2-network.changes
2018-08-04 21:50:48.456985515 +0200
@@ -1,0 +2,9 @@
+Thu Jul 12 11:46:53 UTC 2018 - mfi...@suse.com
+
+- bnc#964856
+ - dropped calls to obsolete NetworkInterfaces API
+ - CLI: setting device type explicitly using new type option is
+ mandatory when adding new device
+- 4.1.4
+
+-------------------------------------------------------------------
@@ -20 +29 @@
- Jun 26 09:18:50 UTC 2018 - mfi...@suse.com
+Tue Jun 26 09:18:50 UTC 2018 - mfi...@suse.com
Old:
----
yast2-network-4.1.3.tar.bz2
New:
----
yast2-network-4.1.4.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-network.spec ++++++
--- /var/tmp/diff_new_pack.SRNazB/_old 2018-08-04 21:50:48.940986423 +0200
+++ /var/tmp/diff_new_pack.SRNazB/_new 2018-08-04 21:50:48.940986423 +0200
@@ -17,7 +17,7 @@
Name: yast2-network
-Version: 4.1.3
+Version: 4.1.4
Release: 0
BuildArch: noarch
@@ -69,7 +69,7 @@
Provides: yast2-network-devel-doc = %{version}
Summary: YaST2 - Network Configuration
-License: GPL-2.0
+License: GPL-2.0-only
Group: System/YaST
%build
++++++ yast2-network-4.1.3.tar.bz2 -> yast2-network-4.1.4.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.1.3/package/yast2-network.changes
new/yast2-network-4.1.4/package/yast2-network.changes
--- old/yast2-network-4.1.3/package/yast2-network.changes 2018-07-02
16:34:41.000000000 +0200
+++ new/yast2-network-4.1.4/package/yast2-network.changes 2018-07-27
19:19:00.000000000 +0200
@@ -1,4 +1,13 @@
-------------------------------------------------------------------
+Thu Jul 12 11:46:53 UTC 2018 - mfi...@suse.com
+
+- bnc#964856
+ - dropped calls to obsolete NetworkInterfaces API
+ - CLI: setting device type explicitly using new type option is
+ mandatory when adding new device
+- 4.1.4
+
+-------------------------------------------------------------------
Mon Jul 2 16:20:55 CEST 2018 - sch...@suse.de
- lan_test: stubbin Host.GetModified call (bnc#1052042).
@@ -17,7 +26,7 @@
- Added additional searchkeys to desktop file (fate#321043).
-------------------------------------------------------------------
- Jun 26 09:18:50 UTC 2018 - mfi...@suse.com
+Tue Jun 26 09:18:50 UTC 2018 - mfi...@suse.com
- removed NetworkStorage as it is unused (had been replaced by
storage-ng)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.1.3/package/yast2-network.spec
new/yast2-network-4.1.4/package/yast2-network.spec
--- old/yast2-network-4.1.3/package/yast2-network.spec 2018-07-02
16:34:41.000000000 +0200
+++ new/yast2-network-4.1.4/package/yast2-network.spec 2018-07-27
19:19:00.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-network
-Version: 4.1.3
+Version: 4.1.4
Release: 0
BuildArch: noarch
@@ -69,7 +69,7 @@
Provides: yast2-network-devel-doc = %{version}
Summary: YaST2 - Network Configuration
-License: GPL-2.0
+License: GPL-2.0-only
Group: System/YaST
%build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.1.3/src/clients/lan.rb
new/yast2-network-4.1.4/src/clients/lan.rb
--- old/yast2-network-4.1.3/src/clients/lan.rb 2018-07-02 16:34:41.000000000
+0200
+++ new/yast2-network-4.1.4/src/clients/lan.rb 2018-07-27 19:19:00.000000000
+0200
@@ -170,6 +170,11 @@
# Commandline option help
"help" => _("Interfaces for Bridging"),
"type" => "string"
+ },
+ "type" => {
+ # Commandline option help
+ "help" => _("Type of the device (eth, vlan, ...)"),
+ "type" => "string"
}
},
"mappings" => {
@@ -182,6 +187,7 @@
"netmask",
"prefix",
"slaves",
+ "type",
"ethdevice",
"bridge_ports"
],
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.1.3/src/include/network/lan/address.rb
new/yast2-network-4.1.4/src/include/network/lan/address.rb
--- old/yast2-network-4.1.3/src/include/network/lan/address.rb 2018-07-02
16:34:41.000000000 +0200
+++ new/yast2-network-4.1.4/src/include/network/lan/address.rb 2018-07-27
19:19:00.000000000 +0200
@@ -1151,8 +1151,7 @@
# TODO: dynamic for dummy. or add dummy from outside?
no_dhcp =
is_ptp ||
- type == "dummy" ||
- LanItems.alias != ""
+ type == "dummy"
address_p2p_contents = Frame(
"", # labelless frame
@@ -1370,17 +1369,12 @@
LanItems.Rollback if ret == :abort
if ret != :back && ret != :abort
- ifcfgname = Ops.get_string(LanItems.getCurrentItem, "ifcfg", "")
# general tab
LanItems.startmode = Ops.get_string(@settings, "STARTMODE", "")
LanItems.firewall_zone = @settings.fetch("FWZONE", "")
LanItems.mtu = Ops.get_string(@settings, "MTU", "")
# address tab
- if LanItems.operation == :add
- LanItems.device = NetworkInterfaces.device_num(ifcfgname)
- end
-
bootproto = @settings.fetch("BOOTPROTO", "")
ipaddr = @settings.fetch("IPADDR", "")
@@ -1430,9 +1424,7 @@
end
# proceed with WLAN settings if appropriate, #42420
- if ret == :next && LanItems.type == "wlan" && LanItems.alias == ""
- ret = :wire
- end
+ ret = :wire if ret == :next && LanItems.type == "wlan"
Routing.SetDevices(NetworkInterfaces.List("")) if ret == :routing
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.1.3/src/include/network/lan/cmdline.rb
new/yast2-network-4.1.4/src/include/network/lan/cmdline.rb
--- old/yast2-network-4.1.3/src/include/network/lan/cmdline.rb 2018-07-02
16:34:41.000000000 +0200
+++ new/yast2-network-4.1.4/src/include/network/lan/cmdline.rb 2018-07-27
19:19:00.000000000 +0200
@@ -194,9 +194,9 @@
[LanItems.current, "ifcfg"],
Ops.get(options, "name", "")
)
- LanItems.type = NetworkInterfaces.device_type(
- Ops.get(options, "name", "")
- )
+ LanItems.type = options["type"]
+ raise "Device type is mandatory." if !LanItems.type
+
if LanItems.type == "bond"
LanItems.bond_slaves = Builtins.splitstring(
Ops.get(options, "slaves", ""),
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.1.3/src/modules/LanItems.rb
new/yast2-network-4.1.4/src/modules/LanItems.rb
--- old/yast2-network-4.1.3/src/modules/LanItems.rb 2018-07-02
16:34:41.000000000 +0200
+++ new/yast2-network-4.1.4/src/modules/LanItems.rb 2018-07-27
19:19:00.000000000 +0200
@@ -94,8 +94,6 @@
@type = ""
# ifcfg name for the @current device
@device = ""
- # FIXME: always empty string - remove all occuriences
- @alias = ""
@current = -1
@hotplug = ""
@@ -1880,9 +1878,6 @@
Ops.set(@Items, [@current, "ifcfg"], NetworkInterfaces.Name)
end
- # FIXME: alias: how to prefill new alias?
- @alias = ""
-
# general stuff
@description = BuildDescription(@type, @device, devmap, @Hardware)
@@ -1912,8 +1907,6 @@
# Sets device map items for device when it is not alias
def setup_basic_device_options(devmap)
- return devmap if !@alias.empty?
-
devmap["MTU"] = @mtu
devmap["ETHTOOL_OPTIONS"] = @ethtool_options
devmap["STARTMODE"] = @startmode
@@ -2233,9 +2226,7 @@
NetworkInterfaces.Edit(@device)
@type = Ops.get_string(getCurrentItem, ["hwinfo", "type"], "")
- @type = NetworkInterfaces.GetType(@device) if IsEmpty(@type)
-
- @alias = NetworkInterfaces.alias_num(@device)
+ @type = NetworkInterfaces.GetType(@device) if @type.empty?
# general stuff
devmap = deep_copy(NetworkInterfaces.Current)
