Hello community, here is the log from the commit of package attica-qt5 for openSUSE:Factory checked in at 2018-08-24 16:50:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/attica-qt5 (Old) and /work/SRC/openSUSE:Factory/.attica-qt5.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "attica-qt5" Fri Aug 24 16:50:29 2018 rev:57 rq:630577 version:5.49.0 Changes: -------- --- /work/SRC/openSUSE:Factory/attica-qt5/attica-qt5.changes 2018-07-21 10:09:55.191174794 +0200 +++ /work/SRC/openSUSE:Factory/.attica-qt5.new/attica-qt5.changes 2018-08-24 16:50:32.837109896 +0200 @@ -1,0 +2,11 @@ +Sun Aug 19 09:18:39 UTC 2018 - [email protected] + +- Update to 5.49.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.49.0.php +- Changes since 5.48.0: + * Don't instantiate a QStringRef into a QString only to search in a QStringList + * Define elements when they're declared + +------------------------------------------------------------------- Old: ---- attica-5.48.0.tar.xz New: ---- attica-5.49.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ attica-qt5.spec ++++++ --- /var/tmp/diff_new_pack.aZlreD/_old 2018-08-24 16:50:33.261110395 +0200 +++ /var/tmp/diff_new_pack.aZlreD/_new 2018-08-24 16:50:33.261110395 +0200 @@ -19,28 +19,27 @@ %define sonum 5 %define rname attica %define _libname KF5Attica -%define _tar_path 5.48 +%define _tar_path 5.49 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: attica-qt5 -Version: 5.48.0 +Version: 5.49.0 Release: 0 Summary: Open Collaboration Service client library License: LGPL-2.1-or-later Group: System/GUI/KDE -Url: https://projects.kde.org/attica +URL: http://www.kde.org Source: http://download.kde.org/stable/frameworks/%{_tar_path}/%{rname}-%{version}.tar.xz Source99: baselibs.conf BuildRequires: cmake >= 3.0 BuildRequires: extra-cmake-modules >= %{_kf5_bugfix_version} BuildRequires: fdupes BuildRequires: kf5-filesystem -BuildRequires: pkg-config +BuildRequires: pkgconfig BuildRequires: cmake(Qt5Core) >= 5.6.0 BuildRequires: cmake(Qt5Network) >= 5.6.0 -BuildRoot: %{_tmppath}/%{name}-%{version}-build %description Attica is a library to access Open Collaboration Service servers. @@ -77,21 +76,19 @@ %fdupes %{buildroot} %post -n lib%{_libname}%{sonum} -p /sbin/ldconfig - %postun -n lib%{_libname}%{sonum} -p /sbin/ldconfig %files -%defattr(-,root,root) -%doc COPYING* README* +%license COPYING* +%doc README* %config %{_kf5_configdir}/attica.categories %files -n lib%{_libname}%{sonum} -%defattr(-,root,root) -%doc COPYING* README* +%license COPYING* +%doc README* %{_libqt5_libdir}/lib%{_libname}*.so.* %files -n attica-qt5-devel -%defattr(-,root,root) %{_kf5_libdir}/cmake/KF5Attica/ %{_libqt5_libdir}/lib%{_libname}*.so %{_libqt5_libdir}/pkgconfig/libKF5Attica.pc ++++++ attica-5.48.0.tar.xz -> attica-5.49.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.48.0/CMakeLists.txt new/attica-5.49.0/CMakeLists.txt --- old/attica-5.48.0/CMakeLists.txt 2018-07-07 23:51:40.000000000 +0200 +++ new/attica-5.49.0/CMakeLists.txt 2018-08-04 10:41:29.000000000 +0200 @@ -1,11 +1,11 @@ cmake_minimum_required(VERSION 3.0) -set(KF5_VERSION "5.48.0") # handled by release scripts +set(KF5_VERSION "5.49.0") # handled by release scripts project(Attica VERSION ${KF5_VERSION}) # ECM setup include(FeatureSummary) -find_package(ECM 5.48.0 NO_MODULE) +find_package(ECM 5.49.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.48.0/src/downloaddescription.cpp new/attica-5.49.0/src/downloaddescription.cpp --- old/attica-5.48.0/src/downloaddescription.cpp 2018-07-07 23:51:40.000000000 +0200 +++ new/attica-5.49.0/src/downloaddescription.cpp 2018-08-04 10:41:29.000000000 +0200 @@ -30,9 +30,9 @@ class DownloadDescription::Private : public QSharedData { public: - int id; - Attica::DownloadDescription::Type type; - bool hasPrice; + int id = 0; + Attica::DownloadDescription::Type type = Attica::DownloadDescription::FileDownload; + bool hasPrice = false; QString category; QString name; QString link; @@ -43,11 +43,7 @@ QString gpgSignature; QString packageName; QString repository; - uint size; - - Private() : id(0), type(Attica::DownloadDescription::FileDownload), hasPrice(false), size(0) - { - } + uint size = 0; }; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.48.0/src/parser.cpp new/attica-5.49.0/src/parser.cpp --- old/attica-5.48.0/src/parser.cpp 2018-07-07 23:51:40.000000000 +0200 +++ new/attica-5.49.0/src/parser.cpp 2018-08-04 10:41:29.000000000 +0200 @@ -27,6 +27,15 @@ using namespace Attica; +static bool stringList_contains_stringRef(const QStringList &stringList, const QStringRef &str) +{ + for (const auto &string : stringList) { + if (str == string) + return true; + } + return false; +} + template <class T> Parser<T>::~Parser() { @@ -46,7 +55,7 @@ if (xml.isStartElement()) { if (xml.name() == QLatin1String("meta")) { parseMetadataXml(xml); - } else if (elements.contains(xml.name().toString())) { + } else if (stringList_contains_stringRef(elements, xml.name())) { item = parseXml(xml); } } @@ -128,7 +137,7 @@ break; } - if (xml.isStartElement() && elements.contains(xml.name().toString())) { + if (xml.isStartElement() && stringList_contains_stringRef(elements, xml.name())) { //qCDebug(ATTICA) << "xxxxxxxxx New Item!" << xml.name().toString(); items.append(parseXml(xml)); }
