Hello community,

here is the log from the commit of package python-natsort for openSUSE:Factory 
checked in at 2018-09-18 11:43:51
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/python-natsort (Old)
 and      /work/SRC/openSUSE:Factory/.python-natsort.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "python-natsort"

Tue Sep 18 11:43:51 2018 rev:7 rq:636118 version:5.4.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/python-natsort/python-natsort.changes    
2018-09-11 17:18:20.779313576 +0200
+++ /work/SRC/openSUSE:Factory/.python-natsort.new/python-natsort.changes       
2018-09-18 11:44:09.607865249 +0200
@@ -1,0 +2,7 @@
+Sun Sep 16 15:39:46 UTC 2018 - Arun Persaud <[email protected]>
+
+- update to version 5.4.1:
+  * Fix error in a newly added test.
+  * Changed code format and quality checking infrastructure.
+
+-------------------------------------------------------------------

Old:
----
  natsort-5.4.0.tar.gz

New:
----
  natsort-5.4.1.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ python-natsort.spec ++++++
--- /var/tmp/diff_new_pack.kWy4Ty/_old  2018-09-18 11:44:10.691864119 +0200
+++ /var/tmp/diff_new_pack.kWy4Ty/_new  2018-09-18 11:44:10.691864119 +0200
@@ -12,13 +12,13 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:           python-natsort
-Version:        5.4.0
+Version:        5.4.1
 Release:        0
 Summary:        Natural sorting in Python
 License:        MIT

++++++ natsort-5.4.0.tar.gz -> natsort-5.4.1.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/.travis.yml 
new/natsort-5.4.1/.travis.yml
--- old/natsort-5.4.0/.travis.yml       2018-07-08 02:08:43.000000000 +0200
+++ new/natsort-5.4.1/.travis.yml       2018-09-10 05:00:33.000000000 +0200
@@ -1,5 +1,6 @@
 language: python
-matrix:
+
+jobs:
   include:
     - python: "2.7"
       dist: trusty
@@ -41,6 +42,12 @@
       dist: xenial
       sudo: true
       env: WITH_EXTRAS=""
+    - stage: code-quality
+      python: "3.6"
+      dist: trusty
+      sudo: false
+      install: pip install flake8 flake8-import-order flake8-bugbear 
pep8-naming
+      script: flake8
 
 install:
 - pip install -U pip
@@ -49,6 +56,10 @@
 script:
 - tox
 
+stages:
+- code-quality
+- test
+
 after_success:
 - coverage xml
 - python-codacy-coverage -r coverage.xml
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/PKG-INFO new/natsort-5.4.1/PKG-INFO
--- old/natsort-5.4.0/PKG-INFO  2018-09-07 05:05:49.000000000 +0200
+++ new/natsort-5.4.1/PKG-INFO  2018-09-10 05:14:40.000000000 +0200
@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: natsort
-Version: 5.4.0
+Version: 5.4.1
 Summary: Simple yet flexible natural sorting in Python.
 Home-page: https://github.com/SethMMorton/natsort
 Author: Seth M. Morton
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/Pipfile new/natsort-5.4.1/Pipfile
--- old/natsort-5.4.0/Pipfile   2018-09-05 04:45:35.000000000 +0200
+++ new/natsort-5.4.1/Pipfile   2018-09-10 03:45:17.000000000 +0200
@@ -1,11 +1,9 @@
 [dev-packages]
-coverage      = "*"
-pytest        = ">=3.5"
-pytest-cov    = "*"
-pytest-flakes = "*"
-pytest-pep8   = "*"
-pytest-mock   = ">=1.1"
-hypothesis    = ">=3.8.0"
+coverage            = "*"
+pytest              = ">=3.5"
+pytest-cov          = "*"
+pytest-mock         = ">=1.1"
+hypothesis          = ">=3.8.0"
 pytest-faulthandler = {version = "*", platform_python_implementation = "== 
'CPython'"}
 
 # These packages are standard on newer python versions.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/docs/source/changelog.rst 
new/natsort-5.4.1/docs/source/changelog.rst
--- old/natsort-5.4.0/docs/source/changelog.rst 2018-09-07 04:58:22.000000000 
+0200
+++ new/natsort-5.4.1/docs/source/changelog.rst 2018-09-10 05:12:32.000000000 
+0200
@@ -3,6 +3,12 @@
 Changelog
 ---------
 
+09-09-2018 v. 5.4.1
++++++++++++++++++++
+
+   - Fix error in a newly added test.
+   - Changed code format and quality checking infrastructure.
+
 09-06-2018 v. 5.4.0
 +++++++++++++++++++
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/docs/source/conf.py 
new/natsort-5.4.1/docs/source/conf.py
--- old/natsort-5.4.0/docs/source/conf.py       2018-09-07 04:58:22.000000000 
+0200
+++ new/natsort-5.4.1/docs/source/conf.py       2018-09-10 05:12:32.000000000 
+0200
@@ -57,7 +57,7 @@
 # built documents.
 #
 # The full version, including alpha/beta/rc tags.
-release = '5.4.0'
+release = '5.4.1'
 # The short X.Y version.
 version = '.'.join(release.split('.')[0:2])
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/__init__.py 
new/natsort-5.4.1/natsort/__init__.py
--- old/natsort-5.4.0/natsort/__init__.py       2018-09-07 04:58:22.000000000 
+0200
+++ new/natsort-5.4.1/natsort/__init__.py       2018-09-10 05:12:32.000000000 
+0200
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-from __future__ import print_function, division, unicode_literals, 
absolute_import
+from __future__ import absolute_import, division, print_function, 
unicode_literals
 
 import sys
 
@@ -25,7 +25,7 @@
 if float(sys.version[:3]) < 3:
     from natsort.natsort import natcmp
 
-__version__ = "5.4.0"
+__version__ = "5.4.1"
 
 __all__ = [
     "natsort_key",
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/compat/fake_fastnumbers.py 
new/natsort-5.4.1/natsort/compat/fake_fastnumbers.py
--- old/natsort-5.4.0/natsort/compat/fake_fastnumbers.py        2018-09-05 
04:29:25.000000000 +0200
+++ new/natsort-5.4.1/natsort/compat/fake_fastnumbers.py        2018-09-10 
03:57:31.000000000 +0200
@@ -37,6 +37,7 @@
 NAN_INF.extend(["+" + x[:2] for x in NAN_INF] + ["-" + x[:2] for x in NAN_INF])
 NAN_INF = frozenset(NAN_INF)
 ASCII_NUMS = "0123456789+-"
+POTENTIAL_FIRST_CHAR = frozenset(decimal_chars + list(ASCII_NUMS + "."))
 
 
 # noinspection PyIncorrectDocstring
@@ -46,7 +47,7 @@
     nan=None,
     _uni=unicodedata.numeric,
     _nan_inf=NAN_INF,
-    _first_char=frozenset(decimal_chars + list(ASCII_NUMS + ".")),
+    _first_char=POTENTIAL_FIRST_CHAR,
 ):
     """
     Convert a string to a float quickly, return input as-is if not possible.
@@ -89,7 +90,7 @@
     x,
     key=lambda x: x,
     _uni=unicodedata.digit,
-    _first_char=frozenset(decimal_chars + list(ASCII_NUMS)),
+    _first_char=POTENTIAL_FIRST_CHAR,
 ):
     """
     Convert a string to a int quickly, return input as-is if not possible.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/compat/fastnumbers.py 
new/natsort-5.4.1/natsort/compat/fastnumbers.py
--- old/natsort-5.4.0/natsort/compat/fastnumbers.py     2018-09-07 
04:56:22.000000000 +0200
+++ new/natsort-5.4.1/natsort/compat/fastnumbers.py     2018-09-10 
03:57:31.000000000 +0200
@@ -3,7 +3,7 @@
 Interface for natsort to access fastnumbers functions without
 having to worry if it is actually installed.
 """
-from __future__ import print_function, division, unicode_literals, 
absolute_import
+from __future__ import absolute_import, division, print_function, 
unicode_literals
 
 from distutils.version import StrictVersion
 
@@ -17,4 +17,4 @@
     if StrictVersion(fn_ver) < StrictVersion("2.0.0"):
         raise ImportError  # pragma: no cover
 except ImportError:
-    from natsort.compat.fake_fastnumbers import fast_float, fast_int
+    from natsort.compat.fake_fastnumbers import fast_float, fast_int  # noqa: 
F401
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/compat/locale.py 
new/natsort-5.4.1/natsort/compat/locale.py
--- old/natsort-5.4.0/natsort/compat/locale.py  2018-09-05 04:29:25.000000000 
+0200
+++ new/natsort-5.4.1/natsort/compat/locale.py  2018-09-10 03:57:31.000000000 
+0200
@@ -3,7 +3,7 @@
 Interface for natsort to access locale functionality without
 having to worry about if it is using PyICU or the built-in locale.
 """
-from __future__ import print_function, division, unicode_literals, 
absolute_import
+from __future__ import absolute_import, division, print_function, 
unicode_literals
 
 # Std. lib imports.
 import sys
@@ -20,7 +20,7 @@
 # Make the strxfrm function from strcoll on Python2
 # It can be buggy (especially on BSD-based systems),
 # so prefer icu if available.
-try:
+try:  # noqa: C901
     import icu
     from locale import getlocale
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/compat/pathlib.py 
new/natsort-5.4.1/natsort/compat/pathlib.py
--- old/natsort-5.4.0/natsort/compat/pathlib.py 2018-09-05 04:29:25.000000000 
+0200
+++ new/natsort-5.4.1/natsort/compat/pathlib.py 2018-09-10 03:57:31.000000000 
+0200
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-from __future__ import print_function, division, unicode_literals, 
absolute_import
+from __future__ import absolute_import, division, print_function, 
unicode_literals
 
 try:
     from pathlib import PurePath  # PurePath is the base object for Paths.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/natsort.py 
new/natsort-5.4.1/natsort/natsort.py
--- old/natsort-5.4.0/natsort/natsort.py        2018-09-05 06:34:45.000000000 
+0200
+++ new/natsort-5.4.1/natsort/natsort.py        2018-09-10 03:57:31.000000000 
+0200
@@ -640,7 +640,7 @@
 if float(sys.version[:3]) < 3:
     # pylint: disable=unused-variable
     # noinspection PyUnresolvedReferences,PyPep8Naming
-    class natcmp(object):
+    class natcmp(object):  # noqa: N801
         """
         Compare two objects using a key and an algorithm.
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/ns_enum.py 
new/natsort-5.4.1/natsort/ns_enum.py
--- old/natsort-5.4.0/natsort/ns_enum.py        2018-09-05 04:29:25.000000000 
+0200
+++ new/natsort-5.4.1/natsort/ns_enum.py        2018-09-10 03:57:31.000000000 
+0200
@@ -3,7 +3,7 @@
 This module defines the "ns" enum for natsort is used to determine
 what algorithm natsort uses.
 """
-from __future__ import print_function, division, unicode_literals, 
absolute_import
+from __future__ import absolute_import, division, print_function, 
unicode_literals
 
 import collections
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/unicode_numbers.py 
new/natsort-5.4.1/natsort/unicode_numbers.py
--- old/natsort-5.4.0/natsort/unicode_numbers.py        2018-09-05 
04:29:25.000000000 +0200
+++ new/natsort-5.4.1/natsort/unicode_numbers.py        2018-09-10 
04:27:42.000000000 +0200
@@ -2,7 +2,7 @@
 """
 Pre-determine the collection of unicode decimals, digits, and numerals.
 """
-from __future__ import division, print_function, absolute_import, 
unicode_literals
+from __future__ import absolute_import, division, print_function, 
unicode_literals
 
 import unicodedata
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort/utils.py 
new/natsort-5.4.1/natsort/utils.py
--- old/natsort-5.4.0/natsort/utils.py  2018-09-05 05:40:40.000000000 +0200
+++ new/natsort-5.4.1/natsort/utils.py  2018-09-10 03:57:31.000000000 +0200
@@ -637,9 +637,12 @@
         return lambda split_val, val: tuple(split_val)
 
 
+lower_function = methodcaller("casefold" if NEWPY else "lower")
+
+
 # noinspection PyIncorrectDocstring
 @u_format
-def groupletters(x, _low=methodcaller("casefold" if NEWPY else "lower")):
+def groupletters(x, _low=lower_function):
     """
     Double all characters, making doubled letters lowercase.
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/natsort.egg-info/PKG-INFO 
new/natsort-5.4.1/natsort.egg-info/PKG-INFO
--- old/natsort-5.4.0/natsort.egg-info/PKG-INFO 2018-09-07 05:05:48.000000000 
+0200
+++ new/natsort-5.4.1/natsort.egg-info/PKG-INFO 2018-09-10 05:14:40.000000000 
+0200
@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: natsort
-Version: 5.4.0
+Version: 5.4.1
 Summary: Simple yet flexible natural sorting in Python.
 Home-page: https://github.com/SethMMorton/natsort
 Author: Seth M. Morton
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/setup.cfg new/natsort-5.4.1/setup.cfg
--- old/natsort-5.4.0/setup.cfg 2018-09-07 05:05:49.000000000 +0200
+++ new/natsort-5.4.1/setup.cfg 2018-09-10 05:14:40.000000000 +0200
@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 5.4.0
+current_version = 5.4.1
 commit = True
 tag = True
 tag_name = {new_version}
@@ -49,23 +49,22 @@
 search = XX-XX-XXXX v. X.X.X
 replace = {now:%%m-%%d-%%Y} v. {new_version}
 
-[tool:pytest]
-flakes-ignore = 
-       natsort/compat/py23.py UndefinedName
-       natsort/__init__.py UnusedImport
-       natsort/compat/* UnusedImport
-       docs/source/conf.py ALL
-       test_natsort/test_natsort.py UnusedImport RedefinedWhileUnused
-       test_natsort/test_locale_help.py UnusedImport RedefinedWhileUnused
-       test_natsort/compat/* UnusedImport
-pep8ignore = 
-       natsort/ns_enum.py E126 E241 E123 E221
-       test_natsort/test_*.py E501 E241 E221
-       test_natsort/test_natsort_keygen.py E501 E241 E221 E701
-       test_natsort/profile_natsorted.py ALL
-       docs/source/conf.py ALL
-       * W503
-pep8maxlinelength = 90
+[flake8]
+max-line-length = 89
+import-order-style = pycharm
+doctests = True
+max-complexity = 10
+exclude = 
+       natsort.egg-info,
+       .tox,
+       .cache,
+       .git,
+       __pycache__,
+       build,
+       dist,
+       docs,
+       .venv,
+       natsort/compat/py23.py
 
 [egg_info]
 tag_build = 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/setup.py new/natsort-5.4.1/setup.py
--- old/natsort-5.4.0/setup.py  2018-09-07 04:58:22.000000000 +0200
+++ new/natsort-5.4.1/setup.py  2018-09-10 05:12:32.000000000 +0200
@@ -1,9 +1,9 @@
 #! /usr/bin/env python
 
-from setuptools import setup, find_packages
+from setuptools import find_packages, setup
 setup(
     name='natsort',
-    version='5.4.0',
+    version='5.4.1',
     packages=find_packages(),
     install_requires=["argparse; python_version < '2.7'"],
     entry_points={'console_scripts': ['natsort = natsort.__main__:main']},
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/test_natsort/conftest.py 
new/natsort-5.4.1/test_natsort/conftest.py
--- old/natsort-5.4.0/test_natsort/conftest.py  2018-09-05 04:29:25.000000000 
+0200
+++ new/natsort-5.4.1/test_natsort/conftest.py  2018-09-10 03:57:31.000000000 
+0200
@@ -2,9 +2,10 @@
 Fixtures for pytest.
 """
 
-import pytest
 import locale
 
+import pytest
+
 
 def load_locale(x):
     """Convenience to load a locale, trying ISO8859-1 first."""
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/natsort-5.4.0/test_natsort/test_final_data_transform_factory.py 
new/natsort-5.4.1/test_natsort/test_final_data_transform_factory.py
--- old/natsort-5.4.0/test_natsort/test_final_data_transform_factory.py 
2018-09-05 04:29:25.000000000 +0200
+++ new/natsort-5.4.1/test_natsort/test_final_data_transform_factory.py 
2018-09-10 03:57:31.000000000 +0200
@@ -3,7 +3,7 @@
 from __future__ import unicode_literals
 
 import pytest
-from hypothesis import given, example
+from hypothesis import example, given
 from hypothesis.strategies import floats, integers, text
 from natsort.compat.py23 import py23_str
 from natsort.ns_enum import ns, ns_DUMB
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/natsort-5.4.0/test_natsort/test_input_string_transform_factory.py 
new/natsort-5.4.1/test_natsort/test_input_string_transform_factory.py
--- old/natsort-5.4.0/test_natsort/test_input_string_transform_factory.py       
2018-09-05 04:29:25.000000000 +0200
+++ new/natsort-5.4.1/test_natsort/test_input_string_transform_factory.py       
2018-09-10 03:57:31.000000000 +0200
@@ -3,7 +3,7 @@
 from __future__ import unicode_literals
 
 import pytest
-from hypothesis import given, example
+from hypothesis import example, given
 from hypothesis.strategies import integers, text
 from natsort.compat.py23 import NEWPY
 from natsort.ns_enum import ns, ns_DUMB
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/test_natsort/test_main.py 
new/natsort-5.4.1/test_natsort/test_main.py
--- old/natsort-5.4.0/test_natsort/test_main.py 2018-09-05 04:29:25.000000000 
+0200
+++ new/natsort-5.4.1/test_natsort/test_main.py 2018-09-10 03:57:31.000000000 
+0200
@@ -147,7 +147,7 @@
 # and a test that uses the hypothesis module.
 
 
-def 
test_range_check_returns_range_as_is_but_with_floats_if_first_is_less_than_second_example():
+def test_range_check_returns_range_as_is_but_with_floats_example():
     assert range_check(10, 11) == (10.0, 11.0)
     assert range_check(6.4, 30) == (6.4, 30.0)
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/test_natsort/test_natsort_cmp.py 
new/natsort-5.4.1/test_natsort/test_natsort_cmp.py
--- old/natsort-5.4.0/test_natsort/test_natsort_cmp.py  2018-09-05 
04:29:25.000000000 +0200
+++ new/natsort-5.4.1/test_natsort/test_natsort_cmp.py  2018-09-10 
03:57:31.000000000 +0200
@@ -10,7 +10,7 @@
 from hypothesis import given
 from hypothesis.strategies import floats, integers, lists
 from natsort import ns
-from natsort.compat.py23 import py23_cmp, PY_VERSION
+from natsort.compat.py23 import PY_VERSION, py23_cmp
 
 if PY_VERSION < 3:
     from natsort import natcmp
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/test_natsort/test_natsorted.py 
new/natsort-5.4.1/test_natsort/test_natsorted.py
--- old/natsort-5.4.0/test_natsort/test_natsorted.py    2018-09-05 
04:29:25.000000000 +0200
+++ new/natsort-5.4.1/test_natsort/test_natsorted.py    2018-09-10 
03:57:31.000000000 +0200
@@ -8,7 +8,7 @@
 from operator import itemgetter
 
 import pytest
-from natsort import natsorted, ns, as_utf8
+from natsort import as_utf8, natsorted, ns
 from natsort.compat.py23 import PY_VERSION
 from pytest import raises
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/natsort-5.4.0/test_natsort/test_natsorted_convenience.py 
new/natsort-5.4.1/test_natsort/test_natsorted_convenience.py
--- old/natsort-5.4.0/test_natsort/test_natsorted_convenience.py        
2018-09-05 04:29:25.000000000 +0200
+++ new/natsort-5.4.1/test_natsort/test_natsorted_convenience.py        
2018-09-10 03:57:31.000000000 +0200
@@ -5,9 +5,9 @@
 """
 from __future__ import print_function, unicode_literals
 
-import pytest
 from operator import itemgetter
 
+import pytest
 from natsort import (
     as_ascii,
     as_utf8,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/natsort-5.4.0/test_natsort/test_string_component_transform_factory.py 
new/natsort-5.4.1/test_natsort/test_string_component_transform_factory.py
--- old/natsort-5.4.0/test_natsort/test_string_component_transform_factory.py   
2018-09-05 04:29:25.000000000 +0200
+++ new/natsort-5.4.1/test_natsort/test_string_component_transform_factory.py   
2018-09-10 03:57:31.000000000 +0200
@@ -17,13 +17,15 @@
 # library on BSD systems that has nothing to do with natsort (a ValueError is
 # raised by strxfrm). Let's filter them out.
 try:
-    bad_uni_chars = set(py23_unichr(x) for x in py23_range(0X10fefd, 0X10ffff 
+ 1))
+    bad_uni_chars = frozenset(
+        py23_unichr(x) for x in py23_range(0X10fefd, 0X10ffff + 1)
+    )
 except ValueError:
     # Narrow unicode build... no worries.
-    bad_uni_chars = set()
+    bad_uni_chars = frozenset()
 
 
-def no_bad_uni_chars(x, _bad_chars=frozenset(bad_uni_chars)):
+def no_bad_uni_chars(x, _bad_chars=bad_uni_chars):
     """Ensure text does not contain bad unicode characters"""
     return not any(y in _bad_chars for y in x)
 
@@ -41,7 +43,7 @@
         (ns.FLOAT, partial(fast_float, nan=float("-inf"))),
         (ns.FLOAT | ns.NANLAST, partial(fast_float, nan=float("+inf"))),
         (ns.GROUPLETTERS, partial(fast_int, key=groupletters)),
-        (ns.LOCALE, partial(fast_int, key=get_strxfrm())),
+        (ns.LOCALE, partial(fast_int, key=lambda x: get_strxfrm()(x))),
         (
             ns.GROUPLETTERS | ns.LOCALE,
             partial(fast_int, key=lambda x: get_strxfrm()(groupletters(x))),
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/test_natsort/test_utils.py 
new/natsort-5.4.1/test_natsort/test_utils.py
--- old/natsort-5.4.0/test_natsort/test_utils.py        2018-09-05 
04:29:25.000000000 +0200
+++ new/natsort-5.4.1/test_natsort/test_utils.py        2018-09-10 
04:08:51.000000000 +0200
@@ -11,7 +11,7 @@
 from hypothesis import given
 from hypothesis.strategies import integers, lists, sampled_from, text
 from natsort import utils
-from natsort.compat.py23 import py23_cmp, py23_str, py23_lower, py23_int
+from natsort.compat.py23 import py23_cmp, py23_int, py23_lower, py23_str
 from natsort.ns_enum import ns
 
 
@@ -41,7 +41,8 @@
     ],
 )
 def test_args_to_enum(kwargs, expected):
-    assert utils.args_to_enum(**kwargs) == expected
+    with pytest.warns(DeprecationWarning):
+        assert utils.args_to_enum(**kwargs) == expected
 
 
 @pytest.mark.parametrize(
@@ -58,7 +59,7 @@
     ],
 )
 def test_regex_chooser_returns_correct_regular_expression_object(alg, 
expected):
-    assert utils.regex_chooser(alg) == expected
+    assert utils.regex_chooser(alg).pattern == expected.pattern
 
 
 @pytest.mark.parametrize(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/natsort-5.4.0/tox.ini new/natsort-5.4.1/tox.ini
--- old/natsort-5.4.0/tox.ini   2018-05-18 05:39:08.000000000 +0200
+++ new/natsort-5.4.1/tox.ini   2018-09-10 04:27:50.000000000 +0200
@@ -5,7 +5,7 @@
 
 [tox]
 envlist =
-    py27, py34, py35, py36, py37, pypy
+    flake8, py27, py34, py35, py36, py37, pypy
 # Other valid evironments are:
 #   docs
 #   release
@@ -29,7 +29,16 @@
     pytest README.rst docs/source/intro.rst docs/source/examples.rst
     pytest --doctest-modules {envsitepackagesdir}/natsort
     # Full test suite. Allow the user to pass command-line objects.
-    pytest --flakes --pep8 --tb=short --cov {envsitepackagesdir}/natsort 
--cov-report term-missing {posargs:}
+    pytest --tb=short --cov {envsitepackagesdir}/natsort --cov-report 
term-missing {posargs:}
+
+# Check code quality.
+[testenv:flake8]
+deps =
+    flake8
+    flake8-import-order
+    flake8-bugbear
+    pep8-naming
+commands = flake8
 
 # Build documentation.
 [testenv:docs]
@@ -39,6 +48,7 @@
 commands =
     {envpython} setup.py build_sphinx
 
+# Release the code to PyPI
 [testenv:release]
 deps =
     twine


Reply via email to