Hello community, here is the log from the commit of package kcmutils for openSUSE:Factory checked in at 2018-10-01 08:04:15 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kcmutils (Old) and /work/SRC/openSUSE:Factory/.kcmutils.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kcmutils" Mon Oct 1 08:04:15 2018 rev:57 rq:635978 version:5.50.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kcmutils/kcmutils.changes 2018-09-03 10:44:55.145859548 +0200 +++ /work/SRC/openSUSE:Factory/.kcmutils.new/kcmutils.changes 2018-10-01 08:05:03.906396170 +0200 @@ -1,0 +2,15 @@ +Thu Sep 13 21:58:44 UTC 2018 - [email protected] + +- Update to 5.50.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.50.0.php +- Changes since 5.49.0: + * Use custom QScrollArea with size hint not limited by font size (kde#389585) +- Dropped patches, now upstream: + * 0001-Use-custom-QScrollArea-with-size-hint-not-limited-by.patch +- Add upstream patch 0001-Manually-resize-KCMUtilDialog-to-sizeHint.patch: + * Workaround for QTBUG-3459 to prevent too small windows when + system settings modules are opened standalone (kde#389585) + +------------------------------------------------------------------- Old: ---- 0001-Use-custom-QScrollArea-with-size-hint-not-limited-by.patch kcmutils-5.49.0.tar.xz New: ---- 0001-Manually-resize-KCMUtilDialog-to-sizeHint.patch kcmutils-5.50.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kcmutils.spec ++++++ --- /var/tmp/diff_new_pack.wZmXbz/_old 2018-10-01 08:05:04.710395738 +0200 +++ /var/tmp/diff_new_pack.wZmXbz/_new 2018-10-01 08:05:04.722395732 +0200 @@ -12,19 +12,19 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # %define lname libKF5KCMUtils5 -%define _tar_path 5.49 +%define _tar_path 5.50 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} %bcond_without lang Name: kcmutils -Version: 5.49.0 +Version: 5.50.0 Release: 0 Summary: Classes to work with KCModules License: LGPL-2.1-or-later @@ -33,7 +33,7 @@ Source: http://download.kde.org/stable/frameworks/%{_tar_path}/%{name}-%{version}.tar.xz Source1: baselibs.conf # PATCH-FIX-UPSTREAM -Patch1: 0001-Use-custom-QScrollArea-with-size-hint-not-limited-by.patch +Patch0: 0001-Manually-resize-KCMUtilDialog-to-sizeHint.patch BuildRequires: cmake >= 3.0 BuildRequires: extra-cmake-modules >= %{_kf5_bugfix_version} BuildRequires: fdupes ++++++ 0001-Manually-resize-KCMUtilDialog-to-sizeHint.patch ++++++ >From cc4ecfdcd48a52a67f60eb69ed69e91ca42ee405 Mon Sep 17 00:00:00 2001 From: Valeriy Malov <[email protected]> Date: Mon, 10 Sep 2018 17:39:40 +0300 Subject: [PATCH] Manually resize KCMUtilDialog to sizeHint() Summary: Workaround for https://bugreports.qt.io/browse/QTBUG-3459 Currently adjustSize() is limited to 2/3 of the screen size for windows This adds unnecessary scrollbars on dialogs that would otherwise fit the screen Manually resize the window after adjustSize() happens to avoid this limitation CCBUG: 389585 Test Plan: Tested on a 1366x768 laptop, with this patch networkmanagement window opens in full screen height (respecting the panel) Reviewers: #frameworks, ngraham Reviewed By: ngraham Subscribers: davidedmundson, acrouthamel, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D15406 --- src/kcmultidialog.cpp | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/kcmultidialog.cpp b/src/kcmultidialog.cpp index d5f2f10..2fd7cb8 100644 --- a/src/kcmultidialog.cpp +++ b/src/kcmultidialog.cpp @@ -27,8 +27,10 @@ #include "kcmoduleproxy.h" +#include <QApplication> #include <QDebug> #include <QDesktopServices> +#include <QDesktopWidget> #include <QProcess> #include <QPushButton> #include <QScrollArea> @@ -261,9 +263,18 @@ KCMultiDialog::~KCMultiDialog() void KCMultiDialog::showEvent(QShowEvent *ev) { - resize(QSize(800, 550)); - adjustSize(); KPageDialog::showEvent(ev); + adjustSize(); + /** + * adjustSize() relies on sizeHint but is limited to 2/3 of the desktop size + * Workaround for https://bugreports.qt.io/browse/QTBUG-3459 + * + * We adjust the size after passing the show event + * because otherwise window pos is set to (0,0) + */ + const QSize maxSize = QApplication::desktop()->availableGeometry(pos()).size(); + resize(qMin(sizeHint().width(), maxSize.width()), + qMin(sizeHint().height(), maxSize.height())); } void KCMultiDialog::slotDefaultClicked() -- 2.18.0 ++++++ kcmutils-5.49.0.tar.xz -> kcmutils-5.50.0.tar.xz ++++++ ++++ 1991 lines of diff (skipped)
