Hello community, here is the log from the commit of package clementine for openSUSE:Factory checked in at 2018-10-31 13:14:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/clementine (Old) and /work/SRC/openSUSE:Factory/.clementine.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "clementine" Wed Oct 31 13:14:07 2018 rev:44 rq:645266 version:1.3.1 Changes: -------- --- /work/SRC/openSUSE:Factory/clementine/clementine.changes 2017-12-22 12:19:19.440720093 +0100 +++ /work/SRC/openSUSE:Factory/.clementine.new/clementine.changes 2018-10-31 13:15:30.819392568 +0100 @@ -1,0 +2,10 @@ +Mon Oct 29 12:10:39 UTC 2018 - Jan Engelhardt <jeng...@inai.de> + +- Trim bias and openSUSE-irrelevant wording from description. + +------------------------------------------------------------------- +Sun Oct 28 19:56:58 UTC 2018 - Andrey Karepin <egdf...@opensuse.org> + +- added patch 6103.patch with fix track change hang + +------------------------------------------------------------------- New: ---- 6103.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ clementine.spec ++++++ --- /var/tmp/diff_new_pack.aTxjDo/_old 2018-10-31 13:15:32.103391342 +0100 +++ /var/tmp/diff_new_pack.aTxjDo/_new 2018-10-31 13:15:32.103391342 +0100 @@ -1,7 +1,7 @@ # # spec file for package clementine # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,15 +12,15 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # Name: clementine Version: 1.3.1 Release: 0 -Summary: A cross-platform Music Player derived from Amarok 1.4 -License: GPL-3.0+ +Summary: A music player derived from Amarok 1.4 +License: GPL-3.0-or-later Group: Productivity/Multimedia/Sound/Players Url: https://clementine-player.org/ Source: https://github.com/clementine-player/Clementine/releases/download/%{version}/%{name}-%{version}.tar.xz @@ -36,6 +36,8 @@ Patch4: clementine-gcc7fix.patch # PATCH-FIX-UPSTREAM clementine-1.3.1-support-chromaprint-1.4.patch -- backported commit #ded3126 Patch5: clementine-1.3.1-support-chromaprint-1.4.patch +# PATCH-FIX-UPSTREAM 6103.patch -- Fix track change hang gh#clementine-player/Clementine#6103 +Patch6: 6103.patch %if 0%{?suse_version} > 1325 BuildRequires: libboost_headers-devel %else @@ -87,7 +89,7 @@ Obsoletes: %{name}-kde < %{version} %description -Clementine is a modern music player and library organiser. +Clementine is a music player and library organiser. Clementine is a fork of Amarok 1.4, with some features rewritten to take advantage of Qt4. @@ -96,7 +98,6 @@ * Search and play your local music library. * Listen to internet radio from Last.FM and SomaFM. * Edit tags on MP3 and OGG files, organise your music. - * Cross-platform - works on GNU/Linux, Windows, and OS X. * Native desktop notifications. %prep @@ -107,6 +108,7 @@ %patch3 %patch4 %patch5 -p1 +%patch6 -p1 # NOTE: Build using system versions of libraries. rm -rvf 3rdparty/taglib #rm -rvf 3rdparty/libmygpo-qt ++++++ 6103.patch ++++++ commit 2b280de663bc53b4f37dbb3f875cd630bad22c82 Author: Mark Furneaux <m...@furneaux.ca> Date: Sun Jul 8 22:15:57 2018 -0400 Attempt to fix track change hang When switching between tracks with different sample rates, the probe queue blocks before the pipeline can emit EOS. This prevents the track change from proceeding without manual intervention. This appears to be because the queue element doesn't handle the rate change correctly (either due to buffer length, or cap negotiation). The queue2 element however does handle this without blocking indefinitely. diff --git a/src/engines/gstenginepipeline.cpp b/src/engines/gstenginepipeline.cpp index add3f27e9..a47d32aa6 100644 --- a/src/engines/gstenginepipeline.cpp +++ b/src/engines/gstenginepipeline.cpp @@ -276,7 +276,7 @@ bool GstEnginePipeline::Init() { audioconvert_ = engine_->CreateElement("audioconvert", audiobin_); tee = engine_->CreateElement("tee", audiobin_); - probe_queue = engine_->CreateElement("queue", audiobin_); + probe_queue = engine_->CreateElement("queue2", audiobin_); probe_converter = engine_->CreateElement("audioconvert", audiobin_); probe_sink = engine_->CreateElement("fakesink", audiobin_);
