Hello community, here is the log from the commit of package socket_wrapper for openSUSE:Factory checked in at 2018-11-14 14:43:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/socket_wrapper (Old) and /work/SRC/openSUSE:Factory/.socket_wrapper.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "socket_wrapper" Wed Nov 14 14:43:53 2018 rev:10 rq:648869 version:1.2.1 Changes: -------- --- /work/SRC/openSUSE:Factory/socket_wrapper/socket_wrapper.changes 2018-11-13 17:49:32.067629538 +0100 +++ /work/SRC/openSUSE:Factory/.socket_wrapper.new/socket_wrapper.changes 2018-11-14 14:44:38.202594488 +0100 @@ -1,0 +2,6 @@ +Wed Nov 14 08:43:12 UTC 2018 - Andreas Schneider <[email protected]> + +- Update to version 1.2.1 + * Removed error message to fix applications doing stupid things + +------------------------------------------------------------------- Old: ---- socket_wrapper-1.2.0.tar.gz socket_wrapper-1.2.0.tar.gz.asc New: ---- socket_wrapper-1.2.1.tar.gz socket_wrapper-1.2.1.tar.gz.asc ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ socket_wrapper.spec ++++++ --- /var/tmp/diff_new_pack.3kdchK/_old 2018-11-14 14:44:39.306593185 +0100 +++ /var/tmp/diff_new_pack.3kdchK/_new 2018-11-14 14:44:39.314593175 +0100 @@ -24,7 +24,7 @@ ############################# NOTE ################################## Name: socket_wrapper -Version: 1.2.0 +Version: 1.2.1 Release: 0 Summary: A library passing all socket communications trough Unix sockets License: BSD-3-Clause ++++++ socket_wrapper-1.2.0.tar.gz -> socket_wrapper-1.2.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/socket_wrapper-1.2.0/CMakeLists.txt new/socket_wrapper-1.2.1/CMakeLists.txt --- old/socket_wrapper-1.2.0/CMakeLists.txt 2018-11-13 13:56:59.000000000 +0100 +++ new/socket_wrapper-1.2.1/CMakeLists.txt 2018-11-14 09:17:20.000000000 +0100 @@ -11,7 +11,7 @@ include(DefineCMakeDefaults) include(DefineCompilerFlags) -project(socket_wrapper VERSION 1.2.0 LANGUAGES C) +project(socket_wrapper VERSION 1.2.1 LANGUAGES C) # global needed variables set(APPLICATION_NAME ${PROJECT_NAME}) @@ -23,7 +23,7 @@ # Increment AGE. Set REVISION to 0 # If the source code was changed, but there were no interface changes: # Increment REVISION. -set(LIBRARY_VERSION "0.1.10") +set(LIBRARY_VERSION "0.1.11") set(LIBRARY_SOVERSION "0") # add definitions diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/socket_wrapper-1.2.0/ChangeLog new/socket_wrapper-1.2.1/ChangeLog --- old/socket_wrapper-1.2.0/ChangeLog 2018-11-13 13:56:59.000000000 +0100 +++ new/socket_wrapper-1.2.1/ChangeLog 2018-11-14 09:17:20.000000000 +0100 @@ -1,6 +1,9 @@ ChangeLog ========== +version 1.2.1 (released 2018-11-14) + * Removed error message to fix applications doing stupid things + version 1.2.0 (released 2018-11-13) * Added threading support * Moved to modern cmake diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/socket_wrapper-1.2.0/src/socket_wrapper.c new/socket_wrapper-1.2.1/src/socket_wrapper.c --- old/socket_wrapper-1.2.0/src/socket_wrapper.c 2018-11-13 13:56:59.000000000 +0100 +++ new/socket_wrapper-1.2.1/src/socket_wrapper.c 2018-11-13 19:22:01.000000000 +0100 @@ -1539,12 +1539,24 @@ return -1; } - if (fd >= socket_fds_max) { + if ((size_t)fd >= socket_fds_max) { + /* + * Do not add a log here as some applications do stupid things + * like: + * + * for (fd = 0; fd <= getdtablesize(); fd++) { + * close(fd) + * }; + * + * This would produce millions of lines of debug messages. + */ +#if 0 SWRAP_LOG(SWRAP_LOG_ERROR, - "The max socket index limit of %zu has been reached, " - "trying to add %d", - socket_fds_max, - fd); + "Looking for a socket info for the fd %d is over the " + "max socket index limit of %zu.", + fd, + socket_fds_max); +#endif return -1; } @@ -1590,7 +1602,7 @@ { int idx; - if (fd >= socket_fds_max) { + if ((size_t)fd >= socket_fds_max) { SWRAP_LOG(SWRAP_LOG_ERROR, "The max socket index limit of %zu has been reached, " "trying to add %d", @@ -3161,9 +3173,10 @@ } SWRAP_LOG(SWRAP_LOG_TRACE, - "Created %s socket for protocol %s", + "Created %s socket for protocol %s, fd=%d", family == AF_INET ? "IPv4" : "IPv6", - real_type == SOCK_DGRAM ? "UDP" : "TCP"); + real_type == SOCK_DGRAM ? "UDP" : "TCP", + fd); return fd; }
