Hello community, here is the log from the commit of package remmina for openSUSE:Factory checked in at 2018-11-20 22:43:52 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/remmina (Old) and /work/SRC/openSUSE:Factory/.remmina.new.19453 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "remmina" Tue Nov 20 22:43:52 2018 rev:30 rq:650376 version:1.2.32.1 Changes: -------- --- /work/SRC/openSUSE:Factory/remmina/remmina.changes 2018-10-23 20:37:52.708724363 +0200 +++ /work/SRC/openSUSE:Factory/.remmina.new.19453/remmina.changes 2018-11-20 22:44:33.770234857 +0100 @@ -1,0 +2,11 @@ +Tue Nov 20 11:06:23 UTC 2018 - [email protected] + +- Upgraded to 1.2.32.1 + * Add desktop-gnome-platform and fix themes in SNAP + * Implement smartcard name setting + * man+help: elaborate on file types of -connect and -edit cmd line options + * RDP: add FREERDP_ERROR_SERVER_DENIED_CONNECTION message + * Removing X11Forwarding code as it is wrong and causing issues + * Updated turkish translation + +------------------------------------------------------------------- Old: ---- Remmina-v1.2.32.tar.bz2 New: ---- Remmina-v1.2.32.1.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ remmina.spec ++++++ --- /var/tmp/diff_new_pack.COanQe/_old 2018-11-20 22:44:35.198234309 +0100 +++ /var/tmp/diff_new_pack.COanQe/_new 2018-11-20 22:44:35.246234290 +0100 @@ -18,7 +18,7 @@ %bcond_with nx Name: remmina -Version: 1.2.32 +Version: 1.2.32.1 Release: 0 Summary: Versatile Remote Desktop Client License: GPL-2.0-or-later ++++++ Remmina-v1.2.32.tar.bz2 -> Remmina-v1.2.32.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/CHANGELOG.md new/Remmina-v1.2.32.1/CHANGELOG.md --- old/Remmina-v1.2.32/CHANGELOG.md 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/CHANGELOG.md 2018-11-14 21:16:45.000000000 +0100 @@ -1,5 +1,22 @@ # Changelog +## [v1.2.32.1](https://gitlab.com/Remmina/Remmina/tags/v1.2.32.1) (2018-11-14) + +- Add desktop-gnome-platform and fix themes in SNAP, fixes issue #1730 and fixes missing SNAP localization (Giovanni Panozzo) +- Fix SNAP icon (Giovanni Panozzo) +- flatpak: update libssh from 0.8.2 to 0.8.3 (Denis Ollier) +- flatpak: update libssh from 0.8.3 to 0.8.4 (Denis Ollier) +- flatpak: update libssh from 0.8.4 to 0.8.5 (Denis Ollier) +- flatpak: update lz4 from 1.8.2 to 1.8.3 (Denis Ollier) +- flatpak: update pyparsing from 2.2.0 to 2.2.1 (Denis Ollier) +- flatpak: update pyparsing from 2.2.1 to 2.2.2 (Denis Ollier) +- flatpak: update pyparsing from 2.2.2 to 2.3.0 (Denis Ollier) +- Implement smartcard name setting. Should fix #1737 (Antenore Gatta) +- man+help: elaborate on file types of -connect and -edit cmd line options (Mikkel Kirkgaard Nielsen) +- RDP: add FREERDP_ERROR_SERVER_DENIED_CONNECTION message (Giovanni Panozzo) +- Removing X11Forwarding code as it is wrong and causing issues (Antenore Gatta) +- Update fix tr.po (Serdar Sağlam) + ## [v1.2.32](https://gitlab.com/Remmina/Remmina/tags/v1.2.32) (2018-10-06) - Avoid to save last_success property if stats are not enabled. @antenore diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/CMakeLists.txt new/Remmina-v1.2.32.1/CMakeLists.txt --- old/Remmina-v1.2.32/CMakeLists.txt 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/CMakeLists.txt 2018-11-14 21:16:45.000000000 +0100 @@ -211,9 +211,9 @@ set(REMMINA_VERSION_MAJOR "1") set(REMMINA_VERSION_MINOR "2") set(REMMINA_VERSION_REVISION "32") -#set(REMMINA_VERSION_SUFFIX "4") -#set(REMMINA_VERSION "${REMMINA_VERSION_MAJOR}.${REMMINA_VERSION_MINOR}.${REMMINA_VERSION_REVISION}.${REMMINA_VERSION_SUFFIX}") -set(REMMINA_VERSION "${REMMINA_VERSION_MAJOR}.${REMMINA_VERSION_MINOR}.${REMMINA_VERSION_REVISION}") +set(REMMINA_VERSION_SUFFIX "1") +set(REMMINA_VERSION "${REMMINA_VERSION_MAJOR}.${REMMINA_VERSION_MINOR}.${REMMINA_VERSION_REVISION}.${REMMINA_VERSION_SUFFIX}") +#set(REMMINA_VERSION "${REMMINA_VERSION_MAJOR}.${REMMINA_VERSION_MINOR}.${REMMINA_VERSION_REVISION}") message(STATUS "Remmina version: ${REMMINA_VERSION}") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/flatpak/org.remmina.Remmina.json new/Remmina-v1.2.32.1/flatpak/org.remmina.Remmina.json --- old/Remmina-v1.2.32/flatpak/org.remmina.Remmina.json 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/flatpak/org.remmina.Remmina.json 2018-11-14 21:16:45.000000000 +0100 @@ -187,13 +187,13 @@ "name": "python-pyparsing", "buildsystem": "simple", "build-commands": [ - "pip3 install --target=/app/build-aux ./pyparsing-2.2.0-py2.py3-none-any.whl" + "pip3 install --target=/app/build-aux ./pyparsing-2.3.0-py2.py3-none-any.whl" ], "sources": [ { "type": "file", - "url": "https://pypi.python.org/packages/6a/8a/718fd7d3458f9fab8e67186b00abdd345b639976bc7fb3ae722e1b026a50/pyparsing-2.2.0-py2.py3-none-any.whl";, - "sha256": "fee43f17a9c4087e7ed1605bd6df994c6173c1e977d7ade7b651292fab2bd010" + "url": "https://files.pythonhosted.org/packages/71/e8/6777f6624681c8b9701a8a0a5654f3eb56919a01a78e12bf3c73f5a3c714/pyparsing-2.3.0-py2.py3-none-any.whl";, + "sha256": "40856e74d4987de5d01761a22d1621ae1c7f8774585acae358aa5c5936c6c90b" } ] }, @@ -220,8 +220,8 @@ "sources": [ { "type": "archive", - "url": "https://github.com/lz4/lz4/archive/v1.8.2/lz4-1.8.2.tar.gz";, - "sha256": "0963fbe9ee90acd1d15e9f09e826eaaf8ea0312e854803caf2db0a6dd40f4464" + "url": "https://github.com/lz4/lz4/archive/v1.8.3/lz4-1.8.3.tar.gz";, + "sha256": "33af5936ac06536805f9745e0b6d61da606a1f8b4cc5c04dd3cbaca3b9b4fc43" } ] }, @@ -274,8 +274,8 @@ "sources": [ { "type": "archive", - "url": "https://www.libssh.org/files/0.8/libssh-0.8.2.tar.xz";, - "sha256": "8d1290f0fac4f8a75a9001dd404a8a093daba4e86c90c45ecf77d62f14c7b8a5" + "url": "https://www.libssh.org/files/0.8/libssh-0.8.5.tar.xz";, + "sha256": "07d2c431240fc88f6b06bcb36ae267f9afeedce2e32f6c42f8844b205ab5a335" } ], "modules": [ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/plugins/rdp/rdp_plugin.c new/Remmina-v1.2.32.1/plugins/rdp/rdp_plugin.c --- old/Remmina-v1.2.32/plugins/rdp/rdp_plugin.c 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/plugins/rdp/rdp_plugin.c 2018-11-14 21:16:45.000000000 +0100 @@ -1123,7 +1123,10 @@ smartcard->Type = RDPDR_DTYP_SMARTCARD; - smartcard->Name = _strdup("scard"); + const gchar* sn = remmina_plugin_service->file_get_string(remminafile, "smartcardname"); + if ( sn != NULL && sn[0] != '\0' ) { + smartcard->Name = _strdup(sn); + } rfi->settings->DeviceRedirection = TRUE; rfi->settings->RedirectSmartCards = TRUE; @@ -1235,8 +1238,13 @@ } break; #endif +#ifdef FREERDP_ERROR_SERVER_DENIED_CONNECTION + case FREERDP_ERROR_SERVER_DENIED_CONNECTION: + remmina_plugin_service->protocol_plugin_set_error(gp, _("Server %s denied the connection."), rfi->settings->ServerHostname ); + break; +#endif default: - g_printf("%08X %08X\n", e, (unsigned)ERRCONNECT_POST_CONNECT_FAILED); + g_printf("libfreerdp returned code is %08X\n", e); remmina_plugin_service->protocol_plugin_set_error(gp, _("Unable to connect to RDP server %s"), rfi->settings->ServerHostname); break; } @@ -1581,6 +1589,7 @@ { REMMINA_PROTOCOL_SETTING_TYPE_TEXT, "loadbalanceinfo", N_("Load Balance Info"), FALSE, NULL, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_TEXT, "printername", N_("Local Printer Name"), FALSE, NULL, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_TEXT, "printerdriver", N_("Local Printer Driver"), FALSE, NULL, NULL}, + { REMMINA_PROTOCOL_SETTING_TYPE_TEXT, "smartcardname", N_("Smartcard Name"), FALSE, NULL, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_CHECK, "shareprinter", N_("Share local printers"), TRUE, NULL, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_CHECK, "sharesmartcard", N_("Share smartcard"), TRUE, NULL, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_CHECK, "microphone", N_("Redirect local microphone"), TRUE, NULL, NULL}, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/po/tr.po new/Remmina-v1.2.32.1/po/tr.po --- old/Remmina-v1.2.32/po/tr.po 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/po/tr.po 2018-11-14 21:16:45.000000000 +0100 @@ -1,7 +1,7 @@ # Turkish translation for remmina # Copyright (c) 2012 Rosetta Contributors and Canonical Ltd 2012 # This file is distributed under the same license as the remmina package. -# FIRST AUTHOR <EMAIL@ADDRESS>, 2012. +# Serdar Sağlam <[email protected]>, 2018. # msgid "" msgstr "" @@ -9,7 +9,7 @@ "Report-Msgid-Bugs-To: [email protected]\n" "POT-Creation-Date: 2018-09-05 11:02+0200\n" "PO-Revision-Date: 2013-04-17 11:18+0000\n" -"Last-Translator: Serdar Sağlam <Unknown>\n" +"Last-Translator: Serdar Sağlam <[email protected]>\n" "Language-Team: Turkish <[email protected]>\n" "Language: tr\n" "MIME-Version: 1.0\n" @@ -1030,9 +1030,9 @@ " ripper https://launchpad.net/~ismail-proturk\n"; " ubuntuki https://launchpad.net/~aleverzurumlu\n"; " zeugma https://launchpad.net/~sunder67\n"; -" Şâkir Aşçı https://launchpad.net/~sakirasci"; +" Şâkir Aşçı https://launchpad.net/~sakirasci\n"; " Serdar Sağlam https://launchpad.net/~serdarsaglam\n"; -msgstr "translator-credits" +msgstr "çeviri takımı" "Launchpad Contributions:\n" " Fatih Aydın https://launchpad.net/~editorfatih\n"; " Hasan Yılmaz https://launchpad.net/~hasanyilmaz\n"; @@ -1043,7 +1043,7 @@ " ripper https://launchpad.net/~ismail-proturk\n"; " ubuntuki https://launchpad.net/~aleverzurumlu\n"; " zeugma https://launchpad.net/~sunder67\n"; -" Şâkir Aşçı https://launchpad.net/~sakirasci"; +" Şâkir Aşçı https://launchpad.net/~sakirasci\n"; " Serdar Sağlam https://launchpad.net/~serdarsaglam\n"; #: src/remmina_applet_menu_item.c:121 @@ -1400,11 +1400,11 @@ #: src/remmina_mpchange.c:325 msgid "The multi password changer cannot work without a secret plugin.\n" -msgstr "Çok parola değiştirici gizli bir eklenti olmadan çalışmaz.\n" +msgstr "Çoklu şifre değiştirici gizli bir eklenti olmadan çalışmaz.\n" #: src/remmina_mpchange.c:328 msgid "The multi password changer does not work without a secret service.\n" -msgstr "çok parola değiştirici gizli bir hizmet olmadan çalışmaz.\n" +msgstr "Çoklu şifre değiştirici gizli servis olmadan çalışmıyor.\n" #: src/remmina_mpchange.c:417 #, c-format @@ -1477,11 +1477,11 @@ #: src/remmina_ssh_plugin.c:879 src/remmina_sftp_plugin.c:327 msgid "SSH agent" -msgstr "" +msgstr "SSH istemci" #: src/remmina_ssh_plugin.c:881 src/remmina_sftp_plugin.c:329 msgid "Kerberos (GSSAPI)" -msgstr "" +msgstr "Kerberos (Ağ)" #: src/remmina_ssh_plugin.c:956 data/ui/remmina_main.glade:97 #: data/ui/remmina_main.glade:98 @@ -1518,7 +1518,7 @@ #: src/remmina_ssh_plugin.c:998 msgid "Terminal color scheme" -msgstr "Terminal renk düzeni" +msgstr "Uçbirim renk düzeni" #: src/remmina_ssh_plugin.c:1000 msgid "SSH Proxy Command" @@ -2306,7 +2306,7 @@ #: data/ui/remmina_preferences.glade:1287 msgid "Terminal font" -msgstr "Terminal yazı tipi" +msgstr "Uçbirim yazı tipi" #: data/ui/remmina_preferences.glade:1300 msgid "Scrollback lines" @@ -2444,11 +2444,11 @@ #: data/ui/remmina_preferences.glade:1833 msgid "Terminal Color Scheme file chooser" -msgstr "Terminal renk şeması dosya seçici" +msgstr "Uçbirim renk şeması dosya seçici" #: data/ui/remmina_preferences.glade:1923 msgid "Terminal" -msgstr "Terminal" +msgstr "Uçbirim" #: data/ui/remmina_snap_info_dialog.glade:46 msgid "" @@ -2462,7 +2462,7 @@ "Anahtarlık şifre tasarrufu gibi bazı önemli özelliklere erişim ve " "RDP yazıcı paylaşımı için, lütfen yazılım merkezinizi açın ve " "uygun izinler kalır. Alternatif olarak, " -"Terminal penceresinde aşağıdaki komutlar:" +"Uçbirim penceresinde aşağıdaki komutlar:" #: data/ui/remmina_snap_info_dialog.glade:82 msgid "Do not show this message again" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/snap/snapcraft.yaml new/Remmina-v1.2.32.1/snap/snapcraft.yaml --- old/Remmina-v1.2.32/snap/snapcraft.yaml 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/snap/snapcraft.yaml 2018-11-14 21:16:45.000000000 +0100 @@ -15,6 +15,27 @@ grade: stable confinement: strict +plugs: + gnome-3-26-1604: + interface: content + target: $SNAP/gnome-platform + default-provider: gnome-3-26-1604:gnome-3-26-1604 + gtk-3-themes: + interface: content + target: $SNAP/share/themes + default-provider: gtk-common-themes:gtk-3-themes + icon-themes: + interface: content + target: $SNAP/share/icons + default-provider: gtk-common-themes:icon-themes + sound-themes: + interface: content + target: $SNAP/share/sounds + default-provider: gtk-common-themes:sounds-themes + +environment: + XDG_DATA_DIRS: $SNAP/share:$XDG_DATA_DIRS + parts: freerdp: plugin: cmake @@ -135,6 +156,31 @@ - libssh-0.8 - freerdp - desktop-gtk3 + override-prime: | + set -eu + snapcraftctl prime + # Fix application icon lookup + sed --in-place 's|^Icon=.*|Icon=\${SNAP}/meta/gui/icon.svg|' usr/share/applications/org.remmina.Remmina.desktop + + app: + after: + - desktop-gnome-platform + plugin: nil + build-attributes: + - no-system-libraries + stage-packages: + - gtk-3-examples + override-build: | + set -ex + snapcraftctl build + mkdir -p $SNAPCRAFT_PART_INSTALL/share/themes + mkdir -p $SNAPCRAFT_PART_INSTALL/share/icons + mkdir -p $SNAPCRAFT_PART_INSTALL/share/sounds + stage: + - usr/bin/gtk3-demo + - share/icons + - share/themes + - share/sounds # Removing files that are accessible thanks to desktop plug desktop-gtk3: @@ -177,6 +223,7 @@ - unity7 - password-manager-service - wayland + - x11 winpr-makecert: command: winpr-makecert diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/src/remmina.1 new/Remmina-v1.2.32.1/src/remmina.1 --- old/Remmina-v1.2.32/src/remmina.1 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/src/remmina.1 2018-11-14 21:16:45.000000000 +0100 @@ -6,8 +6,8 @@ .Sh SYNOPSIS .Nm .Op Fl a|i|n|q|v -.Op Fl c Ar FILE.remmina -.Op Fl e Ar FILE.remmina +.Op Fl c Ar FILE +.Op Fl e Ar FILE .Op Fl p Ar PAGENR .Op Fl s Ar SERVER .Op Fl t Ar PROTOCOL @@ -45,9 +45,9 @@ .It Fl a Show about dialog .It Fl c, -connect\fR=\fIFILE\fR -Connect to a .remmina file +Directly connect to desktop using options described by file, file type can be either .remmina or one supported by a file import capable plugin .It Fl e, -edit\fR=\fIFILE\fR -Edit a .remmina file +Open and edit desktop connection using options described by file, file type can be either .remmina or one supported by a file import capable plugin .It Fl k, -kiosk\fR Start Remmina in kiosk mode (thin client) .It Fl n, -new\fR diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/src/remmina.c new/Remmina-v1.2.32.1/src/remmina.c --- old/Remmina-v1.2.32/src/remmina.c 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/src/remmina.c 2018-11-14 21:16:45.000000000 +0100 @@ -79,9 +79,9 @@ static GOptionEntry remmina_options[] = { { "about", 'a', 0, G_OPTION_ARG_NONE, NULL, N_("Show about dialog"), NULL }, - { "connect", 'c', 0, G_OPTION_ARG_FILENAME, NULL, N_("Connect to a .remmina file"), "FILE" }, - { G_OPTION_REMAINING, '\0', 0, G_OPTION_ARG_FILENAME_ARRAY, NULL, N_("Connect to a .remmina file"), "FILE" }, - { "edit", 'e', 0, G_OPTION_ARG_FILENAME, NULL, N_("Edit a .remmina file"), "FILE" }, + { "connect", 'c', 0, G_OPTION_ARG_FILENAME, NULL, N_("Connect to desktop described by file (.remmina or type supported by plugin)"), "FILE" }, + { G_OPTION_REMAINING, '\0', 0, G_OPTION_ARG_FILENAME_ARRAY, NULL, N_("Connect to desktop described by file (.remmina or type supported by plugin)"), "FILE" }, + { "edit", 'e', 0, G_OPTION_ARG_FILENAME, NULL, N_("Edit desktop connection described by file (.remmina or type supported by plugin)"), "FILE" }, { "help", '?', G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_NONE, NULL, NULL, NULL }, { "kiosk", 'k', 0, G_OPTION_ARG_NONE, NULL, N_("Start Remmina in Kiosk mode"), NULL }, { "new", 'n', 0, G_OPTION_ARG_NONE, NULL, N_("Create a new connection profile"), NULL }, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Remmina-v1.2.32/src/remmina_ssh.c new/Remmina-v1.2.32.1/src/remmina_ssh.c --- old/Remmina-v1.2.32/src/remmina_ssh.c 2018-10-06 21:44:26.000000000 +0200 +++ new/Remmina-v1.2.32.1/src/remmina_ssh.c 2018-11-14 21:16:45.000000000 +0100 @@ -1581,7 +1581,7 @@ gint buf_len; gint len; gint i, ret; - gint screen; + //gint screen; LOCK_SSH(shell) @@ -1596,12 +1596,20 @@ ssh_channel_request_pty(channel); - screen = gdk_x11_get_default_screen (); - ret = ssh_channel_request_x11 (channel, FALSE, NULL, NULL, screen); + /* ssh_channel_request_x11 works but I do not know yet how to use the + * channel. At the momonet I leave the code here, commented, for future + * investigations. + */ + //screen = gdk_x11_screen_get_screen_number(gdk_screen_get_default()); + //ret = ssh_channel_request_x11 (channel, FALSE, NULL, NULL, screen); /* TODO: We should have a callback that intercept an x11 request to use * ssh_channel_accept_x11 */ - if ( ret != SSH_OK ) - g_print ("[SSH] X11 channel error: %d\n", ret); + //if ( ret != SSH_OK ) { + //g_print ("[SSH] X11 channel error: %d\n", ret); + //}else { + //ssh_channel_accept_x11 ( channel, 50); + //} + if (shell->exec && shell->exec[0]) { ret = ssh_channel_request_exec(channel, shell->exec);
