Hello community, here is the log from the commit of package lollypop for openSUSE:Factory checked in at 2018-12-21 08:21:51 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lollypop (Old) and /work/SRC/openSUSE:Factory/.lollypop.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lollypop" Fri Dec 21 08:21:51 2018 rev:58 rq:660119 version:0.9.906 Changes: -------- --- /work/SRC/openSUSE:Factory/lollypop/lollypop.changes 2018-12-19 13:51:08.551141216 +0100 +++ /work/SRC/openSUSE:Factory/.lollypop.new.28833/lollypop.changes 2018-12-21 08:21:53.473543479 +0100 @@ -1,0 +2,8 @@ +Wed Dec 19 20:00:07 UTC 2018 - [email protected] + +- Update to version 0.9.906: + * Fix bug where cover was never shown. +- Changes from version 0.9.905: + * Bugfixes. + +------------------------------------------------------------------- Old: ---- lollypop-0.9.904.tar.xz New: ---- lollypop-0.9.906.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lollypop.spec ++++++ --- /var/tmp/diff_new_pack.OCGj88/_old 2018-12-21 08:21:53.949543033 +0100 +++ /var/tmp/diff_new_pack.OCGj88/_new 2018-12-21 08:21:53.953543029 +0100 @@ -17,7 +17,7 @@ Name: lollypop -Version: 0.9.904 +Version: 0.9.906 Release: 0 Summary: GNOME music playing application License: GPL-3.0-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.OCGj88/_old 2018-12-21 08:21:53.977543007 +0100 +++ /var/tmp/diff_new_pack.OCGj88/_new 2018-12-21 08:21:53.981543003 +0100 @@ -1,7 +1,7 @@ <services> <service mode="disabled" name="tar_scm"> <param name="changesgenerate">enable</param> - <param name="revision">0.9.904</param> + <param name="revision">0.9.906</param> <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> <param name="versionformat">@PARENT_TAG@</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.OCGj88/_old 2018-12-21 08:21:53.997542988 +0100 +++ /var/tmp/diff_new_pack.OCGj88/_new 2018-12-21 08:21:53.997542988 +0100 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> - <param name="changesrevision">6b9b9b605f5dd53e0ea3effeddf1767966bb4099</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">5a6551cd34ce8f76650b7cea5b93157ee9e6ad40</param></service></servicedata> \ No newline at end of file ++++++ lollypop-0.9.904.tar.xz -> lollypop-0.9.906.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/data/ToolbarEnd.ui new/lollypop-0.9.906/data/ToolbarEnd.ui --- old/lollypop-0.9.904/data/ToolbarEnd.ui 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/data/ToolbarEnd.ui 2018-12-19 19:35:36.000000000 +0100 @@ -147,6 +147,7 @@ </child> <child> <object class="GtkToggleButton" id="list-button"> + <property name="sensitive">False</property> <property name="visible">True</property> <property name="can_focus">False</property> <property name="receives_default">False</property> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/container_views.py new/lollypop-0.9.906/lollypop/container_views.py --- old/lollypop-0.9.904/lollypop/container_views.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/container_views.py 2018-12-19 19:35:36.000000000 +0100 @@ -10,11 +10,10 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -from gi.repository import Gtk - from lollypop.shown import ShownLists from lollypop.loader import Loader from lollypop.objects import Track, Album +from lollypop.view import View from lollypop.define import App, Type, RowListType, SelectionListMask @@ -262,7 +261,7 @@ decades.append(decade) return decades if App().window.is_adaptive: - view = Gtk.Grid() + view = View() else: from lollypop.view_albums_decade_box import AlbumsDecadeBoxView view = AlbumsDecadeBoxView() @@ -285,7 +284,7 @@ for album_id in items] if App().window.is_adaptive: from lollypop.view_albums_list import AlbumsListView - view = AlbumsListView(RowListType.DEFAULT, [Type.YEARS], years) + view = AlbumsListView(RowListType.DEFAULT, years, [Type.YEARS]) else: from lollypop.view_albums_box import AlbumsBoxView view = AlbumsBoxView([Type.YEARS], years) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/controller_information.py new/lollypop-0.9.906/lollypop/controller_information.py --- old/lollypop-0.9.904/lollypop/controller_information.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/controller_information.py 2018-12-19 19:35:36.000000000 +0100 @@ -129,6 +129,7 @@ if surface is None: self._artwork.hide() else: + self._artwork.show() self._artwork.set_from_surface(surface) def __on_radio_artwork(self, surface): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/player.py new/lollypop-0.9.906/lollypop/player.py --- old/lollypop-0.9.904/lollypop/player.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/player.py 2018-12-19 19:35:36.000000000 +0100 @@ -115,6 +115,7 @@ self.set_next() self.set_prev() self.emit("album-added", album.id) + self.emit("playlist-changed") def remove_album(self, album): """ @@ -129,6 +130,7 @@ self.set_next() self.set_prev() self.emit("album-removed", album.id) + self.emit("playlist-changed") except Exception as e: Logger.error("Player::remove_album(): %s" % e) @@ -141,12 +143,13 @@ for album in self._albums: if album.id == album_id: self.remove_album(album) + self.emit("playlist-changed") except Exception as e: Logger.error("Player::remove_album_by_id(): %s" % e) def remove_disc(self, disc, album_id): """ - Remove all instance of album with id from albums + Remove disc for album_id @param disc as Disc @param album_id as int """ @@ -161,6 +164,7 @@ removed.append(album) for album in removed: self._albums.remove(album) + self.emit("playlist-changed") except Exception as e: Logger.error("Player::remove_disc(): %s" % e) @@ -181,6 +185,7 @@ track = album.tracks[0] self.load(track) self._albums = [album] + self.emit("playlist-changed") def play_albums(self, album_id, filter1_ids, filter2_ids): """ @@ -283,6 +288,7 @@ self._albums.append(album) if track is not None: self.load(track) + self.emit("playlist-changed") def clear_albums(self): """ @@ -291,6 +297,7 @@ self._albums = [] self.set_next() self.set_prev() + self.emit("playlist-changed") def get_current_artists(self): """ @@ -361,6 +368,7 @@ self.seek(position / Gst.SECOND) else: Logger.info("Player::restore_state(): track missing") + self.emit("playlist-changed") except Exception as e: Logger.error("Player::restore_state(): %s" % e) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/player_base.py new/lollypop-0.9.906/lollypop/player_base.py --- old/lollypop-0.9.904/lollypop/player_base.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/player_base.py 2018-12-19 19:35:36.000000000 +0100 @@ -24,6 +24,7 @@ "current-changed": (GObject.SignalFlags.RUN_FIRST, None, ()), "album-added": (GObject.SignalFlags.RUN_FIRST, None, (int,)), "album-removed": (GObject.SignalFlags.RUN_FIRST, None, (int,)), + "playlist-changed": (GObject.SignalFlags.RUN_FIRST, None, ()), "next-changed": (GObject.SignalFlags.RUN_FIRST, None, ()), "prev-changed": (GObject.SignalFlags.RUN_FIRST, None, ()), "seeked": (GObject.SignalFlags.RUN_FIRST, None, (int,)), diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/player_playlist.py new/lollypop-0.9.906/lollypop/player_playlist.py --- old/lollypop-0.9.904/lollypop/player_playlist.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/player_playlist.py 2018-12-19 19:35:36.000000000 +0100 @@ -38,6 +38,7 @@ self._playlist_tracks.insert(position, track) self.set_next() self.set_prev() + self.emit("playlist-changed") def remove_track(self, track_id): """ @@ -50,6 +51,7 @@ break self.set_next() self.set_prev() + self.emit("playlist-changed") def populate_playlist_by_tracks(self, tracks, playlist_ids): """ @@ -63,6 +65,7 @@ self._playlist_ids = playlist_ids self.set_next() self.set_prev() + self.emit("playlist-changed") def update_playlist(self, tracks): """ @@ -72,6 +75,7 @@ if self._albums: return self._playlist_tracks = tracks + self.emit("playlist-changed") def next(self, force): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/player_shuffle.py new/lollypop-0.9.906/lollypop/player_shuffle.py --- old/lollypop-0.9.904/lollypop/player_shuffle.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/player_shuffle.py 2018-12-19 19:35:36.000000000 +0100 @@ -122,6 +122,7 @@ for album_id in album_ids: album = Album(album_id, [], [], True) self._albums.append(album) + self.emit("playlist-changed") @property def is_party(self): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/toolbar_end.py new/lollypop-0.9.906/lollypop/toolbar_end.py --- old/lollypop-0.9.904/lollypop/toolbar_end.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/toolbar_end.py 2018-12-19 19:35:36.000000000 +0100 @@ -105,6 +105,7 @@ self.__on_list_button_query_tooltip) self.__list_popover = None App().player.connect("lock-changed", self.__on_lock_changed) + App().player.connect("playlist-changed", self.__on_playlist_changed) self.__set_shuffle_icon() def on_next_changed(self, player): @@ -429,3 +430,13 @@ widget.set_tooltip_text(_("Playing playlists")) else: widget.set_tooltip_text(_("Playing albums")) + + def __on_playlist_changed(self, player): + """ + Update playback button status + @param player as Player + """ + if player.albums or player.playlist_ids or player.queue: + self.__list_button.set_sensitive(True) + else: + self.__list_button.set_sensitive(False) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/view.py new/lollypop-0.9.906/lollypop/view.py --- old/lollypop-0.9.904/lollypop/view.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/view.py 2018-12-19 19:35:36.000000000 +0100 @@ -284,7 +284,7 @@ if not widget.is_populated: widget.populate() else: - GLib.idle_add(self.lazy_loading) + self.lazy_loading() ####################### # PRIVATE # diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/view_albums_list.py new/lollypop-0.9.906/lollypop/view_albums_list.py --- old/lollypop-0.9.904/lollypop/view_albums_list.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/view_albums_list.py 2018-12-19 19:35:36.000000000 +0100 @@ -125,7 +125,7 @@ action_icon = "media-playback-start-symbolic" action_tooltip_text = _("Play") elif self.__list_type & RowListType.DND: - action_icon = "user-trash-symbolic" + action_icon = "list-remove-symbolic" action_tooltip_text = _("Remove from current playlist") if self.__list_type & (RowListType.SEARCH | RowListType.DND): self.__action_button = Gtk.Button.new_from_icon_name( diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/view_current_albums.py new/lollypop-0.9.906/lollypop/view_current_albums.py --- old/lollypop-0.9.904/lollypop/view_current_albums.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/view_current_albums.py 2018-12-19 19:35:36.000000000 +0100 @@ -108,3 +108,7 @@ self.__clear_button.set_sensitive(False) self.__jump_button.set_sensitive(False) self.__save_button.set_sensitive(False) + App().player.emit("status-changed") + popover = self.get_ancestor(Gtk.Popover) + if popover is not None: + popover.popdown() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/view_information.py new/lollypop-0.9.906/lollypop/view_information.py --- old/lollypop-0.9.904/lollypop/view_information.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/view_information.py 2018-12-19 19:35:36.000000000 +0100 @@ -115,6 +115,7 @@ builder.add_from_resource( "/org/gnome/Lollypop/ArtistInformation.ui") builder.connect_signals(self) + self.__scrolled = builder.get_object("scrolled") widget = builder.get_object("widget") self.add(widget) self.__stack = builder.get_object("stack") @@ -158,22 +159,8 @@ for album_id in App().albums.get_ids([artist_id], []): albums.append(Album(album_id)) albums_view.populate(albums) - content = InformationStore.get_bio(self.__artist_name) - if content is not None: - self.__bio_label.set_markup( - GLib.markup_escape_text(content.decode("utf-8"))) - elif not App().settings.get_value("network-access"): - if self.__minimal: - self.__stack.set_visible_child_name("data") - self.__artist_label.set_text( - _("No information for %s") % self.__artist_name) - self.__artist_label.show() - else: - builder.get_object("scrolled").hide() - else: - self.__bio_label.set_text(_("Loading information")) - App().task_helper.run(self.__get_bio_content, - callback=(self.__set_bio_content,)) + App().task_helper.run(InformationStore.get_bio, self.__artist_name, + callback=(self.__on_get_bio,)) ####################### # PROTECTED # @@ -228,7 +215,8 @@ @param content as bytes """ if content is not None: - InformationStore.add_artist_bio(self.__artist_name, content) + App().task_helper.run(InformationStore.add_artist_bio, + self.__artist_name, content) self.__bio_label.set_markup( GLib.markup_escape_text(content.decode("utf-8"))) else: @@ -291,3 +279,24 @@ self.__artist_artwork.hide() else: self.__artist_artwork.set_from_surface(surface) + + def __on_get_bio(self, content): + """ + Set bio content or get a new one if None + @param content as bytes + """ + if content is not None: + self.__bio_label.set_markup( + GLib.markup_escape_text(content.decode("utf-8"))) + elif not App().settings.get_value("network-access"): + if self.__minimal: + self.__stack.set_visible_child_name("data") + self.__artist_label.set_text( + _("No information for %s") % self.__artist_name) + self.__artist_label.show() + else: + self.__scrolled.hide() + else: + self.__bio_label.set_text(_("Loading information")) + App().task_helper.run(self.__get_bio_content, + callback=(self.__set_bio_content,)) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/view_playlists.py new/lollypop-0.9.906/lollypop/view_playlists.py --- old/lollypop-0.9.904/lollypop/view_playlists.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/view_playlists.py 2018-12-19 19:35:36.000000000 +0100 @@ -17,7 +17,7 @@ from lollypop.view import View from lollypop.widgets_playlist import PlaylistsWidget -from lollypop.define import App, Type +from lollypop.define import App, Type, RowListType from lollypop.controller_view import ViewController, ViewControllerType @@ -35,6 +35,7 @@ """ View.__init__(self, True) ViewController.__init__(self, ViewControllerType.ALBUM) + self.__list_type = list_type self.__playlist_ids = playlist_ids self.__signal_id1 = App().playlists.connect( "playlist-track-added", @@ -72,6 +73,7 @@ self.__playlists_widget = PlaylistsWidget(playlist_ids, list_type) self.__playlists_widget.set_filter_func(self._filter_func) + self.__playlists_widget.connect("populated", self.__on_populated) self.__playlists_widget.show() self.add(builder.get_object("widget")) self._viewport.add(self.__playlists_widget) @@ -288,6 +290,13 @@ except: pass + def __on_populated(self, playlists_widget): + """ + Update jump button on populated + @param playlists_widget as PlaylistsWidget + """ + self.__update_jump_button() + def __on_playlist_track_added(self, playlists, playlist_id, uri, pos): """ Update tracks widgets @@ -327,7 +336,9 @@ @param widget as Gtk.Widget @param orientation as Gtk.Orientation """ - if orientation == Gtk.Orientation.VERTICAL: + if orientation == Gtk.Orientation.VERTICAL and ( + App().window.is_adaptive or + self.__list_type & RowListType.POPOVER): self.__split_button.hide() else: self.__split_button.show() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/widgets_row.py new/lollypop-0.9.906/lollypop/widgets_row.py --- old/lollypop-0.9.904/lollypop/widgets_row.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/widgets_row.py 2018-12-19 19:35:36.000000000 +0100 @@ -258,10 +258,9 @@ if self.__preview_timeout_id is not None: GLib.source_remove(self.__preview_timeout_id) self.__preview_timeout_id = None - self.set_indicator( - App().player.current_track.id == self._track.id, - self._track.loved) App().player.preview.set_state(Gst.State.NULL) + self.set_indicator(App().player.current_track.id == self._track.id, + self._track.loved) def __on_button_release_event(self, widget, event): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/lollypop/widgets_row_playlist.py new/lollypop-0.9.906/lollypop/widgets_row_playlist.py --- old/lollypop-0.9.904/lollypop/widgets_row_playlist.py 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/lollypop/widgets_row_playlist.py 2018-12-19 19:35:36.000000000 +0100 @@ -164,8 +164,6 @@ Row._on_destroy(self, widget) DNDRow._on_destroy(self, widget) self.__artwork = None - if self._list_type & RowListType.POPOVER: - App().player.remove_track(self._track.id) ####################### # PRIVATE # diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/meson.build new/lollypop-0.9.906/meson.build --- old/lollypop-0.9.904/meson.build 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/meson.build 2018-12-19 19:35:36.000000000 +0100 @@ -1,5 +1,5 @@ project('lollypop', - version: '0.9.904', + version: '0.9.906', meson_version: '>= 0.40.0' ) i18n = import('i18n') diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.904/subprojects/po/nl.po new/lollypop-0.9.906/subprojects/po/nl.po --- old/lollypop-0.9.904/subprojects/po/nl.po 2018-12-17 23:17:29.000000000 +0100 +++ new/lollypop-0.9.906/subprojects/po/nl.po 2018-12-19 19:35:36.000000000 +0100 @@ -13,7 +13,7 @@ "Project-Id-Version: lollypop\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2018-12-17 22:36+0100\n" -"PO-Revision-Date: 2018-12-14 22:47+0000\n" +"PO-Revision-Date: 2018-12-18 12:44+0000\n" "Last-Translator: Heimen Stoffels <[email protected]>\n" "Language-Team: Dutch <https://hosted.weblate.org/projects/gnumdk/lollypop/nl/"; ">\n" @@ -590,7 +590,7 @@ #: ../data/LastfmPopover.ui:46 msgid "No results" -msgstr "" +msgstr "Geen resultaten" #: ../data/LyricsView.ui:75 msgid "Translate" @@ -1416,7 +1416,7 @@ #: ../lollypop/view_information.py:167 ../lollypop/view_information.py:236 #, python-format msgid "No information for %s" -msgstr "" +msgstr "Geen informatie over %s" #: ../lollypop/view_information.py:172 ../lollypop/view_information.py:200 msgid "Loading information"
