Hello community,

here is the log from the commit of package festival for openSUSE:Factory 
checked in at 2018-12-21 08:22:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/festival (Old)
 and      /work/SRC/openSUSE:Factory/.festival.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "festival"

Fri Dec 21 08:22:27 2018 rev:34 rq:660260 version:2.5.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/festival/festival.changes        2018-11-26 
10:33:49.232780931 +0100
+++ /work/SRC/openSUSE:Factory/.festival.new.28833/festival.changes     
2018-12-21 08:22:32.825506623 +0100
@@ -1,0 +2,5 @@
+Mon Dec 17 10:32:14 UTC 2018 - Jan Engelhardt <[email protected]>
+
+- Do not ignore errors from useradd/groupadd.
+
+-------------------------------------------------------------------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ festival.spec ++++++
--- /var/tmp/diff_new_pack.bgm4Ov/_old  2018-12-21 08:22:33.573505922 +0100
+++ /var/tmp/diff_new_pack.bgm4Ov/_new  2018-12-21 08:22:33.577505919 +0100
@@ -12,7 +12,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
@@ -58,8 +58,8 @@
 BuildRequires:  ncurses-devel
 BuildRequires:  pkgconfig
 PreReq:         %{fillup_prereq}
-PreReq:         /usr/sbin/useradd
-PreReq:         /usr/sbin/groupadd
+Requires(pre):  /usr/sbin/useradd
+Requires(pre):  /usr/sbin/groupadd
 PreReq:         insserv-compat
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
@@ -175,8 +175,10 @@
 rm -f %{buildroot}%{_docdir}/%{name}/INSTALL
 
 %pre
-%{_sbindir}/groupadd -r %{name} 2> /dev/null || :
-%{_sbindir}/useradd -r -g %{name} -s /bin/false -c "Festival daemon" -d 
%{_datadir}/%{name}/ %{name} 2> /dev/null || :
+getent group %{name} >/dev/null || %{_sbindir}/groupadd -r %{name}
+getent passwd %{name} >/dev/null || \
+       %{_sbindir}/useradd -r -g %{name} -s /bin/false -c "Festival daemon" \
+       -d %{_datadir}/%{name}/ %{name}
 %service_add_pre %{name}.service
 
 %post


Reply via email to