Hello community, here is the log from the commit of package libinstpatch for openSUSE:Factory checked in at 2019-01-08 12:29:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libinstpatch (Old) and /work/SRC/openSUSE:Factory/.libinstpatch.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libinstpatch" Tue Jan 8 12:29:07 2019 rev:2 rq:663297 version:1.0.0 Changes: -------- --- /work/SRC/openSUSE:Factory/libinstpatch/libinstpatch.changes 2017-11-27 22:17:34.828443660 +0100 +++ /work/SRC/openSUSE:Factory/.libinstpatch.new.28833/libinstpatch.changes 2019-01-08 12:31:22.744082539 +0100 @@ -1,0 +2,10 @@ +Sat Dec 29 11:43:30 UTC 2018 - Tom Mbrt <[email protected]> + +- Add the following patches to fix incorrect GValue assignments: + * 0001-Fix-improper-GValue-type-assignments-in-ipatch_dls2_.patch + * 0002-fix-incorrect-usage-of-g_value_set_flags.patch +- Add the following patches to fix incorrect mutex (un-)locking + * 0003-missing-mutex-unlock.patch + * 0004-more-locking-issues.patch + +------------------------------------------------------------------- New: ---- 0001-Fix-improper-GValue-type-assignments-in-ipatch_dls2_.patch 0002-fix-incorrect-usage-of-g_value_set_flags.patch 0003-missing-mutex-unlock.patch 0004-more-locking-issues.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libinstpatch.spec ++++++ --- /var/tmp/diff_new_pack.C463lV/_old 2019-01-08 12:31:23.220082022 +0100 +++ /var/tmp/diff_new_pack.C463lV/_new 2019-01-08 12:31:23.224082018 +0100 @@ -30,6 +30,10 @@ Source1: libinstpatch-snapshot.sh # .pc file fixes. Patch sent upstream via their mailing list Patch0: libinstpatch-cmake-fixes.patch +Patch1: 0001-Fix-improper-GValue-type-assignments-in-ipatch_dls2_.patch +Patch2: 0002-fix-incorrect-usage-of-g_value_set_flags.patch +Patch3: 0003-missing-mutex-unlock.patch +Patch4: 0004-more-locking-issues.patch BuildRequires: cmake BuildRequires: pkgconfig BuildRequires: pkgconfig(glib-2.0) @@ -63,6 +67,10 @@ %prep %setup -q %patch0 -p1 -b .pkgconfig +%patch1 -p2 +%patch2 -p2 +%patch3 -p2 +%patch4 -p2 %build %cmake ++++++ 0001-Fix-improper-GValue-type-assignments-in-ipatch_dls2_.patch ++++++ >From 4a73f7125c11b38bd86d23297263f603cfa7ee35 Mon Sep 17 00:00:00 2001 From: Element Green <[email protected]> Date: Fri, 15 Jul 2016 17:00:10 -0600 Subject: [PATCH 01/13] Fix improper GValue type assignments in ipatch_dls2_sample_info_notify_changes(). --- libinstpatch/libinstpatch/IpatchDLS2Sample.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libinstpatch/libinstpatch/IpatchDLS2Sample.c b/libinstpatch/libinstpatch/IpatchDLS2Sample.c index c01662d..ef0217a 100644 --- a/libinstpatch/libinstpatch/IpatchDLS2Sample.c +++ b/libinstpatch/libinstpatch/IpatchDLS2Sample.c @@ -802,8 +802,8 @@ ipatch_dls2_sample_info_notify_changes (IpatchItem *item, { g_value_init (&newval, G_TYPE_INT); g_value_init (&oldval, G_TYPE_INT); - g_value_set_flags (&newval, newinfo->root_note); - g_value_set_flags (&oldval, oldinfo->root_note); + g_value_set_int (&newval, newinfo->root_note); + g_value_set_int (&oldval, oldinfo->root_note); ipatch_item_prop_notify (item, found_pspec_cache[2], &newval, &oldval); g_value_unset (&newval); g_value_unset (&oldval); @@ -813,8 +813,8 @@ ipatch_dls2_sample_info_notify_changes (IpatchItem *item, { g_value_init (&newval, G_TYPE_INT); g_value_init (&oldval, G_TYPE_INT); - g_value_set_flags (&newval, newinfo->fine_tune); - g_value_set_flags (&oldval, oldinfo->fine_tune); + g_value_set_int (&newval, newinfo->fine_tune); + g_value_set_int (&oldval, oldinfo->fine_tune); ipatch_item_prop_notify (item, found_pspec_cache[3], &newval, &oldval); g_value_unset (&newval); g_value_unset (&oldval); @@ -824,8 +824,8 @@ ipatch_dls2_sample_info_notify_changes (IpatchItem *item, { g_value_init (&newval, G_TYPE_INT); g_value_init (&oldval, G_TYPE_INT); - g_value_set_flags (&newval, newinfo->gain); - g_value_set_flags (&oldval, oldinfo->gain); + g_value_set_int (&newval, newinfo->gain); + g_value_set_int (&oldval, oldinfo->gain); ipatch_item_prop_notify (item, found_pspec_cache[4], &newval, &oldval); g_value_unset (&newval); g_value_unset (&oldval); @@ -835,8 +835,8 @@ ipatch_dls2_sample_info_notify_changes (IpatchItem *item, { g_value_init (&newval, G_TYPE_UINT); g_value_init (&oldval, G_TYPE_UINT); - g_value_set_flags (&newval, newinfo->loop_start); - g_value_set_flags (&oldval, oldinfo->loop_start); + g_value_set_uint (&newval, newinfo->loop_start); + g_value_set_uint (&oldval, oldinfo->loop_start); ipatch_item_prop_notify (item, found_pspec_cache[5], &newval, &oldval); g_value_unset (&newval); g_value_unset (&oldval); @@ -846,8 +846,8 @@ ipatch_dls2_sample_info_notify_changes (IpatchItem *item, { g_value_init (&newval, G_TYPE_UINT); g_value_init (&oldval, G_TYPE_UINT); - g_value_set_flags (&newval, newinfo->loop_end); - g_value_set_flags (&oldval, oldinfo->loop_end); + g_value_set_uint (&newval, newinfo->loop_end); + g_value_set_uint (&oldval, oldinfo->loop_end); ipatch_item_prop_notify (item, found_pspec_cache[6], &newval, &oldval); g_value_unset (&newval); g_value_unset (&oldval); -- 2.16.4 ++++++ 0002-fix-incorrect-usage-of-g_value_set_flags.patch ++++++ >From 45647bbf07b3a1ee2d8b44b836e445dea3e5cea1 Mon Sep 17 00:00:00 2001 From: derselbst <[email protected]> Date: Fri, 28 Dec 2018 16:26:48 +0100 Subject: [PATCH 13/13] fix incorrect usage of g_value_set_flags() --- libinstpatch/libinstpatch/IpatchDLS2Sample.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libinstpatch/libinstpatch/IpatchDLS2Sample.c b/libinstpatch/libinstpatch/IpatchDLS2Sample.c index ef0217a..0bf8743 100644 --- a/libinstpatch/libinstpatch/IpatchDLS2Sample.c +++ b/libinstpatch/libinstpatch/IpatchDLS2Sample.c @@ -779,8 +779,8 @@ ipatch_dls2_sample_info_notify_changes (IpatchItem *item, { g_value_init (&newval, IPATCH_TYPE_SAMPLE_LOOP_TYPE); g_value_init (&oldval, IPATCH_TYPE_SAMPLE_LOOP_TYPE); - g_value_set_flags (&newval, newinfo->options & IPATCH_DLS2_SAMPLE_LOOP_MASK); - g_value_set_flags (&oldval, oldinfo->options & IPATCH_DLS2_SAMPLE_LOOP_MASK); + g_value_set_enum (&newval, newinfo->options & IPATCH_DLS2_SAMPLE_LOOP_MASK); + g_value_set_enum (&oldval, oldinfo->options & IPATCH_DLS2_SAMPLE_LOOP_MASK); ipatch_item_prop_notify (item, found_pspec_cache[0], &newval, &oldval); g_value_unset (&newval); g_value_unset (&oldval); -- 2.16.4 ++++++ 0003-missing-mutex-unlock.patch ++++++ >From 0b2c5ce218495fb1695e9b79d133cb32dc5d6e76 Mon Sep 17 00:00:00 2001 From: derselbst <[email protected]> Date: Sat, 29 Dec 2018 22:12:39 +0100 Subject: [PATCH 1/2] missing mutex unlock --- libinstpatch/libinstpatch/IpatchDLS2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libinstpatch/libinstpatch/IpatchDLS2.c b/libinstpatch/libinstpatch/IpatchDLS2.c index 402d6d1..5a79028 100644 --- a/libinstpatch/libinstpatch/IpatchDLS2.c +++ b/libinstpatch/libinstpatch/IpatchDLS2.c @@ -407,6 +407,7 @@ ipatch_dls2_container_make_unique (IpatchContainer *container, { g_critical ("Invalid child type '%s' for IpatchDLS2 object", g_type_name (G_TYPE_FROM_INSTANCE (item))); + IPATCH_ITEM_WUNLOCK (dls); return; } -- 2.16.4 ++++++ 0004-more-locking-issues.patch ++++++ >From 187fa661a347894b933be0c71c71ec7fc0e26059 Mon Sep 17 00:00:00 2001 From: derselbst <[email protected]> Date: Sat, 29 Dec 2018 22:27:43 +0100 Subject: [PATCH 2/2] more locking issues --- libinstpatch/libinstpatch/IpatchBase.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libinstpatch/libinstpatch/IpatchBase.c b/libinstpatch/libinstpatch/IpatchBase.c index d81c76b..9e6ae5e 100644 --- a/libinstpatch/libinstpatch/IpatchBase.c +++ b/libinstpatch/libinstpatch/IpatchBase.c @@ -293,7 +293,7 @@ ipatch_base_get_file (IpatchBase *base) IPATCH_ITEM_RLOCK (base); file = base->file; if (file) g_object_ref (file); - IPATCH_ITEM_RLOCK (base); + IPATCH_ITEM_RUNLOCK (base); return (file); } @@ -337,7 +337,7 @@ ipatch_base_real_set_file_name (IpatchBase *base, const char *file_name) return; } ipatch_file_set_name (base->file, file_name); - IPATCH_ITEM_WUNLOCK (base); + IPATCH_ITEM_RUNLOCK (base); } /** -- 2.16.4
