Hello community,

here is the log from the commit of package php7-smbclient for openSUSE:Factory 
checked in at 2019-01-15 09:16:43
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/php7-smbclient (Old)
 and      /work/SRC/openSUSE:Factory/.php7-smbclient.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "php7-smbclient"

Tue Jan 15 09:16:43 2019 rev:3 rq:664692 version:1.0.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/php7-smbclient/php7-smbclient.changes    
2018-12-24 11:47:15.817140589 +0100
+++ /work/SRC/openSUSE:Factory/.php7-smbclient.new.28833/php7-smbclient.changes 
2019-01-15 09:16:45.002214585 +0100
@@ -1,0 +2,8 @@
+Fri Jan 11 13:41:36 UTC 2019 - Cristian Rodríguez <[email protected]>
+
+- Upgrade to version 1.0.0
+ * stream optimization: reuse previous connections (Remi)
+- 0001-fix-incorrect-deallocation-of-zend_string.patch: zend_strings
+  are to be zend_string_release()'ed not efree()'ed.
+
+-------------------------------------------------------------------

Old:
----
  php7-smbclient-fix_for_PHP_7.3.patch
  smbclient-0.9.0.tgz

New:
----
  0001-fix-incorrect-deallocation-of-zend_string.patch
  smbclient-1.0.0.tgz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ php7-smbclient.spec ++++++
--- /var/tmp/diff_new_pack.tkCLVl/_old  2019-01-15 09:16:45.570214056 +0100
+++ /var/tmp/diff_new_pack.tkCLVl/_new  2019-01-15 09:16:45.570214056 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package php7-smbclient
 #
-# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -12,24 +12,23 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
 %define pkg_name smbclient
 Name:           php7-smbclient
-Version:        0.9.0
+Version:        1.0.0
 Release:        0
 Summary:        A PHP wrapper for libsmbclient
 License:        PHP-3.01
 Group:          Productivity/Networking/Web/Servers
 URL:            http://pecl.php.net/package/smbclient
 Source:         http://pecl.php.net/get/%{pkg_name}-%{version}.tgz
-# PATCH-FIX-UPSTREAM php7-smbclient-fix_for_PHP_7.3.patch -- fix to allow 
building for PHP 7.3
-Patch0:         php7-smbclient-fix_for_PHP_7.3.patch
 BuildRequires:  php7-devel >= 7.0
 BuildRequires:  pkgconfig
 BuildRequires:  pkgconfig(smbclient)
+Patch0:         0001-fix-incorrect-deallocation-of-zend_string.patch
 Requires:       php(api) = %{php_core_api}
 Requires:       php(zend-abi) = %{php_zend_api}
 Provides:       php-smbclient = %{version}
@@ -42,7 +41,6 @@
 %prep
 %setup -q -n %{pkg_name}-%{version}
 %patch0 -p1
-
 %build
 export CFLAGS="%{optflags} -fvisibility=hidden"
 %{_bindir}/phpize

++++++ 0001-fix-incorrect-deallocation-of-zend_string.patch ++++++
>From 8945cd9d07069af37aedd42593638cf6b49c815f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cristian=20Rodr=C3=ADguez?= <[email protected]>
Date: Fri, 11 Jan 2019 10:24:50 -0300
Subject: [PATCH] fix incorrect deallocation of zend_string

zend_strings are to be zend_string_release'd and emalloc'ed
memory efree'd.
---
 smbclient.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/smbclient.c b/smbclient.c
index 81ebd5a..bae1d54 100644
--- a/smbclient.c
+++ b/smbclient.c
@@ -1345,15 +1345,16 @@ PHP_FUNCTION(smbclient_read)
 
        if ((ZSTR_LEN(buf) = smbc_read(state->ctx, file, ZSTR_VAL(buf), count)) 
>= 0) {
                RETURN_STR(buf);
+               zend_string_release(buf);
 #else
        void *buf = emalloc(count);
        ssize_t nbytes;
 
        if ((nbytes = smbc_read(state->ctx, file, buf, count)) >= 0) {
                RETURN_STRINGL(buf, nbytes, 0);
+               efree(buf);
 #endif
        }
-       efree(buf);
        switch (state->err = errno) {
                case EISDIR: php_error(E_WARNING, "Read error: Is a 
directory"); break;
                case EBADF: php_error(E_WARNING, "Read error: Not a valid file 
resource or not open for reading"); break;
-- 
2.20.1

++++++ smbclient-0.9.0.tgz -> smbclient-1.0.0.tgz ++++++
++++ 9676 lines of diff (skipped)


Reply via email to