Hello community, here is the log from the commit of package attica-qt5 for openSUSE:Factory checked in at 2019-01-21 10:17:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/attica-qt5 (Old) and /work/SRC/openSUSE:Factory/.attica-qt5.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "attica-qt5" Mon Jan 21 10:17:27 2019 rev:62 rq:665765 version:5.54.0 Changes: -------- --- /work/SRC/openSUSE:Factory/attica-qt5/attica-qt5.changes 2018-12-19 13:38:17.568221936 +0100 +++ /work/SRC/openSUSE:Factory/.attica-qt5.new.28833/attica-qt5.changes 2019-01-21 10:17:30.194246967 +0100 @@ -1,0 +2,11 @@ +Mon Jan 14 06:08:40 UTC 2019 - [email protected] + +- Update to 5.54.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.54.0.php +- Changes since 5.53.0: + * Fix providertest. exec() only once, with the right settings upfront. + * Notify if a default provider failed to download + +------------------------------------------------------------------- Old: ---- attica-5.53.0.tar.xz New: ---- attica-5.54.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ attica-qt5.spec ++++++ --- /var/tmp/diff_new_pack.6eE7Gc/_old 2019-01-21 10:17:30.662246496 +0100 +++ /var/tmp/diff_new_pack.6eE7Gc/_new 2019-01-21 10:17:30.666246492 +0100 @@ -1,7 +1,7 @@ # # spec file for package attica-qt5 # -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -19,13 +19,13 @@ %define sonum 5 %define rname attica %define _libname KF5Attica -%define _tar_path 5.53 +%define _tar_path 5.54 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: attica-qt5 -Version: 5.53.0 +Version: 5.54.0 Release: 0 Summary: Open Collaboration Service client library License: LGPL-2.1-or-later ++++++ attica-5.53.0.tar.xz -> attica-5.54.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.53.0/CMakeLists.txt new/attica-5.54.0/CMakeLists.txt --- old/attica-5.53.0/CMakeLists.txt 2018-12-01 15:37:41.000000000 +0100 +++ new/attica-5.54.0/CMakeLists.txt 2019-01-04 22:40:13.000000000 +0100 @@ -1,11 +1,11 @@ -cmake_minimum_required(VERSION 3.0) +cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.53.0") # handled by release scripts +set(KF5_VERSION "5.54.0") # handled by release scripts project(Attica VERSION ${KF5_VERSION}) # ECM setup include(FeatureSummary) -find_package(ECM 5.53.0 NO_MODULE) +find_package(ECM 5.54.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.53.0/autotests/providertest.cpp new/attica-5.54.0/autotests/providertest.cpp --- old/attica-5.53.0/autotests/providertest.cpp 2018-12-01 15:37:41.000000000 +0100 +++ new/attica-5.54.0/autotests/providertest.cpp 2019-01-04 22:40:13.000000000 +0100 @@ -93,10 +93,10 @@ connect(m_manager, SIGNAL(providerAdded(Attica::Provider)), this, SLOT(providerAdded(Attica::Provider))); m_manager->addProviderFile(url); m_timer.singleShot(5000, this, SLOT(slotTimeout())); - m_checkFail = true; m_eventloop->exec(); } + void ProviderTest::testFetchValidProvider() { initProvider(QUrl(QLatin1String("https://autoconfig.kde.org/ocs/providers.xml";))); @@ -138,10 +138,8 @@ void ProviderTest::testFetchInvalidProvider() { // TODO error state could only be checked indirectly by timeout - initProvider(QUrl(QLatin1String("https://invalid-url.org/ocs/providers.xml";))); - m_timer.singleShot(5000, this, SLOT(slotTimeout())); m_checkFail = false; - m_eventloop->exec(); + initProvider(QUrl(QLatin1String("https://invalid-url.org/ocs/providers.xml";))); QVERIFY(m_manager->providers().size() == 0); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.53.0/src/providermanager.cpp new/attica-5.54.0/src/providermanager.cpp --- old/attica-5.53.0/src/providermanager.cpp 2018-12-01 15:37:41.000000000 +0100 +++ new/attica-5.54.0/src/providermanager.cpp 2019-01-04 22:40:13.000000000 +0100 @@ -160,7 +160,10 @@ void ProviderManager::fileFinished(const QString &url) { QNetworkReply *reply = d->m_downloads.take(url); - parseProviderFile(QLatin1String(reply->readAll()), QUrl(url)); + if (reply->error()) + Q_EMIT failedToLoad(QUrl(url), reply->error()); + else + parseProviderFile(QLatin1String(reply->readAll()), QUrl(url)); reply->deleteLater(); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.53.0/src/providermanager.h new/attica-5.54.0/src/providermanager.h --- old/attica-5.53.0/src/providermanager.h 2018-12-01 15:37:41.000000000 +0100 +++ new/attica-5.54.0/src/providermanager.h 2019-01-04 22:40:13.000000000 +0100 @@ -26,6 +26,7 @@ #define ATTICA_PROVIDERMANAGER_H #include <QUrl> +#include <QNetworkReply> #include "provider.h" #include "attica_export.h" @@ -151,6 +152,7 @@ void providerAdded(const Attica::Provider &provider); void defaultProvidersLoaded(); void authenticationCredentialsMissing(const Provider &provider); + void failedToLoad(const QUrl& provider, QNetworkReply::NetworkError error); private Q_SLOTS: void fileFinished(const QString &url);
