Hello community,

here is the log from the commit of package kiconthemes for openSUSE:Factory 
checked in at 2019-01-21 10:20:28
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kiconthemes (Old)
 and      /work/SRC/openSUSE:Factory/.kiconthemes.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "kiconthemes"

Mon Jan 21 10:20:28 2019 rev:66 rq:665811 version:5.54.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/kiconthemes/kiconthemes.changes  2019-01-08 
12:15:48.409076168 +0100
+++ /work/SRC/openSUSE:Factory/.kiconthemes.new.28833/kiconthemes.changes       
2019-01-21 10:20:30.078066219 +0100
@@ -1,0 +2,13 @@
+Mon Jan 14 06:08:47 UTC 2019 - [email protected]
+
+- Update to 5.54.0
+  * New feature release
+  * For more details please see:
+  * https://www.kde.org/announcements/kde-frameworks-5.54.0.php
+- Changes since 5.53.0:
+  * Use for(...:...)
+  * Don't check twice if the icon exists from ::availableSizes
+  * ksvg2icns : use QStringLiteral()
+  * ksvg2icns : use Qt 5.9+ QTemporaryDir API
+
+-------------------------------------------------------------------

Old:
----
  kiconthemes-5.53.0.tar.xz

New:
----
  kiconthemes-5.54.0.tar.xz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ kiconthemes.spec ++++++
--- /var/tmp/diff_new_pack.AoqiDv/_old  2019-01-21 10:20:30.566065728 +0100
+++ /var/tmp/diff_new_pack.AoqiDv/_new  2019-01-21 10:20:30.566065728 +0100
@@ -17,14 +17,14 @@
 
 
 %define lname   libKF5IconThemes5
-%define _tar_path 5.53
+%define _tar_path 5.54
 # Full KF5 version (e.g. 5.33.0)
 %{!?_kf5_version: %global _kf5_version %{version}}
 # Last major and minor KF5 version (e.g. 5.33)
 %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | 
awk -F. '{print $1"."$2}')}
 %bcond_without lang
 Name:           kiconthemes
-Version:        5.53.0
+Version:        5.54.0
 Release:        0
 Summary:        Icon GUI utilities
 License:        LGPL-2.1-or-later AND GPL-2.0-or-later

++++++ kiconthemes-5.53.0.tar.xz -> kiconthemes-5.54.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/CMakeLists.txt 
new/kiconthemes-5.54.0/CMakeLists.txt
--- old/kiconthemes-5.53.0/CMakeLists.txt       2018-12-01 15:56:02.000000000 
+0100
+++ new/kiconthemes-5.54.0/CMakeLists.txt       2019-01-06 21:22:54.000000000 
+0100
@@ -1,12 +1,12 @@
-cmake_minimum_required(VERSION 3.0)
+cmake_minimum_required(VERSION 3.5)
 
-set(KF5_VERSION "5.53.0") # handled by release scripts
-set(KF5_DEP_VERSION "5.53.0") # handled by release scripts
+set(KF5_VERSION "5.54.0") # handled by release scripts
+set(KF5_DEP_VERSION "5.54.0") # handled by release scripts
 project(KIconThemes VERSION ${KF5_VERSION})
 
 # ECM setup
 include(FeatureSummary)
-find_package(ECM 5.53.0  NO_MODULE)
+find_package(ECM 5.54.0  NO_MODULE)
 set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake 
Modules." URL 
"https://projects.kde.org/projects/kdesupport/extra-cmake-modules";)
 feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND 
FATAL_ON_MISSING_REQUIRED_PACKAGES)
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/po/ca/kiconthemes5.po 
new/kiconthemes-5.54.0/po/ca/kiconthemes5.po
--- old/kiconthemes-5.53.0/po/ca/kiconthemes5.po        2018-12-01 
15:56:02.000000000 +0100
+++ new/kiconthemes-5.54.0/po/ca/kiconthemes5.po        2019-01-06 
21:22:54.000000000 +0100
@@ -1,5 +1,5 @@
 # Translation of kiconthemes5.po to Catalan
-# Copyright (C) 2014-2018 This_file_is_part_of_KDE
+# Copyright (C) 1998-2018 This_file_is_part_of_KDE
 # This file is distributed under the license LGPL version 2.1 or
 # version 3 or later versions approved by the membership of KDE e.V.
 #
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/po/ca@valencia/kiconthemes5.po 
new/kiconthemes-5.54.0/po/ca@valencia/kiconthemes5.po
--- old/kiconthemes-5.53.0/po/ca@valencia/kiconthemes5.po       2018-12-01 
15:56:02.000000000 +0100
+++ new/kiconthemes-5.54.0/po/ca@valencia/kiconthemes5.po       2019-01-06 
21:22:54.000000000 +0100
@@ -1,5 +1,5 @@
 # Translation of kiconthemes5.po to Catalan (Valencian)
-# Copyright (C) 2014-2018 This_file_is_part_of_KDE
+# Copyright (C) 1998-2018 This_file_is_part_of_KDE
 # This file is distributed under the license LGPL version 2.1 or
 # version 3 or later versions approved by the membership of KDE e.V.
 #
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/po/uk/kiconthemes5.po 
new/kiconthemes-5.54.0/po/uk/kiconthemes5.po
--- old/kiconthemes-5.53.0/po/uk/kiconthemes5.po        2018-12-01 
15:56:02.000000000 +0100
+++ new/kiconthemes-5.54.0/po/uk/kiconthemes5.po        2019-01-06 
21:22:54.000000000 +0100
@@ -26,7 +26,7 @@
 #: kicondialog.cpp:261 kicondialog.cpp:273 kicondialog.cpp:605
 #, kde-format
 msgid "Select Icon"
-msgstr "Вибрати піктограму"
+msgstr "Виберіть піктограму"
 
 #: kicondialog.cpp:290
 #, kde-format
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/po/zh_CN/kiconthemes5.po 
new/kiconthemes-5.54.0/po/zh_CN/kiconthemes5.po
--- old/kiconthemes-5.53.0/po/zh_CN/kiconthemes5.po     2018-12-01 
15:56:02.000000000 +0100
+++ new/kiconthemes-5.54.0/po/zh_CN/kiconthemes5.po     2019-01-06 
21:22:54.000000000 +0100
@@ -17,7 +17,7 @@
 "Project-Id-Version: kdeorg\n"
 "Report-Msgid-Bugs-To: http://bugs.kde.org\n";
 "POT-Creation-Date: 2018-10-26 03:46+0200\n"
-"PO-Revision-Date: 2018-11-12 09:13\n"
+"PO-Revision-Date: 2019-01-05 20:42\n"
 "Last-Translator: guoyunhe <[email protected]>\n"
 "Language-Team: Chinese Simplified\n"
 "Language: zh_CN\n"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/po/zh_TW/kiconthemes5.po 
new/kiconthemes-5.54.0/po/zh_TW/kiconthemes5.po
--- old/kiconthemes-5.53.0/po/zh_TW/kiconthemes5.po     2018-12-01 
15:56:02.000000000 +0100
+++ new/kiconthemes-5.54.0/po/zh_TW/kiconthemes5.po     2019-01-06 
21:22:54.000000000 +0100
@@ -1,16 +1,15 @@
 # translation of kio4.po to Chinese Traditional
 # Copyright (C) 2001, 2002, 2006, 2007, 2008 Free Software Foundation, Inc.
-#
-# This file referenced zh_CN translation (as of 2002-11-08)
 # Chih-Wei Huang <[email protected]>, 2001.
 # Kenduest Lee <[email protected]>, 2001, 2002.
 # Jouston Huang (Huang, Jiun-Jeng) <[email protected]>, 2002.
-# Frank Weng (a.k.a. Franklin) <franklin at goodhorse dot idv dot tw>, 2006, 
2007, 2008, 2009, 2010.
 # Frank Weng (a.k.a. Franklin) <[email protected]>, 2009.
-# Franklin Weng <[email protected]>, 2010, 2011, 2012.
 # Franklin Weng <[email protected]>, 2010, 2011, 2012.
 # Jeff Huang <[email protected]>, 2016.
 # pan93412 <[email protected]>, 2018.
+#
+# This file referenced zh_CN translation (as of 2002-11-08)
+# Frank Weng (a.k.a. Franklin) <franklin at goodhorse dot idv dot tw>, 2006, 
2007, 2008, 2009, 2010.
 msgid ""
 msgstr ""
 "Project-Id-Version: kio4\n"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/src/kicondialog.cpp 
new/kiconthemes-5.54.0/src/kicondialog.cpp
--- old/kiconthemes-5.53.0/src/kicondialog.cpp  2018-12-01 15:56:02.000000000 
+0100
+++ new/kiconthemes-5.54.0/src/kicondialog.cpp  2019-01-06 21:22:54.000000000 
+0100
@@ -436,7 +436,7 @@
     } else {
         // List PNG files found directly in the kiconload search paths.
         const QStringList pngNameFilter(QStringLiteral("*.png"));
-        Q_FOREACH (const QString &relDir, 
KIconLoader::global()->searchPaths()) {
+        for (const QString &relDir : KIconLoader::global()->searchPaths()) {
             const QStringList dirs = 
QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, relDir, 
QStandardPaths::LocateDirectory);
             for (const QString &dir : dirs) {
                 const auto files = QDir(dir).entryList(pngNameFilter);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/src/kiconengine.cpp 
new/kiconthemes-5.54.0/src/kiconengine.cpp
--- old/kiconthemes-5.53.0/src/kiconengine.cpp  2018-12-01 15:56:02.000000000 
+0100
+++ new/kiconthemes-5.54.0/src/kiconengine.cpp  2019-01-06 21:22:54.000000000 
+0100
@@ -138,7 +138,7 @@
         return QList<QSize>();
     }
 
-    bool found = mIconLoader->hasIcon(iconName());
+    const bool found = mIconLoader->hasIcon(mIconName);
     return found ? *sSizes : QList<QSize>();
 }
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/src/kiconloader.cpp 
new/kiconthemes-5.54.0/src/kiconloader.cpp
--- old/kiconthemes-5.53.0/src/kiconloader.cpp  2018-12-01 15:56:02.000000000 
+0100
+++ new/kiconthemes-5.54.0/src/kiconloader.cpp  2019-01-06 21:22:54.000000000 
+0100
@@ -1142,7 +1142,7 @@
 
 QString KIconLoaderPrivate::locate(const QString &fileName)
 {
-    Q_FOREACH (const QString &dir, searchPaths) {
+    for (const QString &dir : qAsConst(searchPaths)) {
         const QString path = dir + QLatin1Char('/') + fileName;
         if (QDir(dir).isAbsolute()) {
             if (QFileInfo::exists(path)) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/kiconthemes-5.53.0/src/tools/kiconfinder/kiconfinder.cpp 
new/kiconthemes-5.54.0/src/tools/kiconfinder/kiconfinder.cpp
--- old/kiconthemes-5.53.0/src/tools/kiconfinder/kiconfinder.cpp        
2018-12-01 15:56:02.000000000 +0100
+++ new/kiconthemes-5.54.0/src/tools/kiconfinder/kiconfinder.cpp        
2019-01-06 21:22:54.000000000 +0100
@@ -39,7 +39,7 @@
     if(parser.positionalArguments().isEmpty())
         parser.showHelp();
 
-    Q_FOREACH(const QString& iconName, parser.positionalArguments()) {
+    for(const QString& iconName : parser.positionalArguments()) {
         const QString icon = KIconLoader::global()->iconPath(iconName, 
KIconLoader::Desktop /*TODO configurable*/, true);
         if ( !icon.isEmpty() ) {
             printf("%s\n", icon.toLocal8Bit().constData());
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kiconthemes-5.53.0/src/tools/ksvg2icns/ksvg2icns.cpp 
new/kiconthemes-5.54.0/src/tools/ksvg2icns/ksvg2icns.cpp
--- old/kiconthemes-5.53.0/src/tools/ksvg2icns/ksvg2icns.cpp    2018-12-01 
15:56:02.000000000 +0100
+++ new/kiconthemes-5.54.0/src/tools/ksvg2icns/ksvg2icns.cpp    2019-01-06 
21:22:54.000000000 +0100
@@ -71,8 +71,8 @@
 {
     QGuiApplication app(argc, argv);
 
-    app.setApplicationName("ksvg2icns");
-    app.setApplicationVersion(KICONTHEMES_VERSION_STRING);
+    app.setApplicationName(QStringLiteral("ksvg2icns"));
+    app.setApplicationVersion(QStringLiteral(KICONTHEMES_VERSION_STRING));
     QCommandLineParser parser;
     parser.setApplicationDescription(app.translate("main", "Creates an icns 
file from an svg image"));
     parser.addPositionalArgument("iconname", app.translate("main", "The svg 
icon to convert"));
@@ -87,16 +87,15 @@
     bool isOk;
 
     // create a temporary dir to create an iconset
-    QTemporaryDir tmpDir("ksvg2icns");
-    tmpDir.setAutoRemove(true);
+    QTemporaryDir tmpDir(QDir::tempPath() + QStringLiteral("/ksvg2icns"));
 
     isOk = tmpDir.isValid();
     EXIT_ON_ERROR(isOk, "Unable to create temporary directory\n");
 
-    isOk = QDir(tmpDir.path()).mkdir("out.iconset");
-    EXIT_ON_ERROR(isOk, "Unable to create out.iconset directory\n");
+    const QString outPath = tmpDir.filePath(QStringLiteral("out.iconset"));
 
-    const QString outPath = tmpDir.path() + "/out.iconset";
+    isOk = QDir(tmpDir.path()).mkpath(outPath);
+    EXIT_ON_ERROR(isOk, "Unable to create out.iconset directory\n");
 
     const QStringList &args = app.arguments();
     EXIT_ON_ERROR(args.size() == 2,
@@ -122,13 +121,13 @@
 
     // create the pngs in various resolutions
     const OutFiles outFiles[] = {
-        { 1024, outPath + "/[email protected]", QString() },
-        {  512, outPath + "/icon_512x512.png",    outPath + 
"/[email protected]" },
-        {  256, outPath + "/icon_256x256.png",    outPath + 
"/[email protected]" },
-        {  128, outPath + "/icon_128x128.png",    QString() },
-        {   64, outPath + "/[email protected]",   QString() },
-        {   32, outPath + "/icon_32x32.png",       outPath + 
"/[email protected]" },
-        {   16, outPath + "/icon_16x16.png",       QString() }
+        { 1024, outPath + QStringLiteral("/[email protected]"), QString() },
+        {  512, outPath + QStringLiteral("/icon_512x512.png"),    outPath + 
QStringLiteral("/[email protected]") },
+        {  256, outPath + QStringLiteral("/icon_256x256.png"),    outPath + 
QStringLiteral("/[email protected]") },
+        {  128, outPath + QStringLiteral("/icon_128x128.png"),    QString() },
+        {   64, outPath + QStringLiteral("/[email protected]"),   QString() },
+        {   32, outPath + QStringLiteral("/icon_32x32.png"),      outPath + 
QStringLiteral("/[email protected]") },
+        {   16, outPath + QStringLiteral("/icon_16x16.png"),      QString() }
     };
 
     for (size_t i = 0; i < sizeof(outFiles) / sizeof(OutFiles); ++i) {
@@ -140,7 +139,7 @@
 
     // convert the iconset to icns using the "iconutil" command
 
-    const QString outIcns = QFileInfo(svgFileName).baseName() + ".icns";
+    const QString outIcns = QFileInfo(svgFileName).baseName() + 
QStringLiteral(".icns");
 
     const QStringList utilArgs = QStringList()
             << "-c" << "icns"
@@ -148,10 +147,8 @@
             << outPath;
 
     QProcess iconUtil;
-    iconUtil.setProgram("iconUtil");
-    iconUtil.setArguments(utilArgs);
 
-    iconUtil.start("iconutil", utilArgs, QIODevice::ReadOnly);
+    iconUtil.start(QStringLiteral("iconutil"), utilArgs, QIODevice::ReadOnly);
     isOk = iconUtil.waitForFinished(-1);
     EXIT_ON_ERROR(isOk, "Unable to launch iconutil: %s\n", 
qPrintable(iconUtil.errorString()));
 


Reply via email to