Hello community, here is the log from the commit of package skiboot for openSUSE:Factory checked in at 2019-01-28 20:49:39 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/skiboot (Old) and /work/SRC/openSUSE:Factory/.skiboot.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "skiboot" Mon Jan 28 20:49:39 2019 rev:11 rq:669000 version:5.10 Changes: -------- --- /work/SRC/openSUSE:Factory/skiboot/skiboot.changes 2018-04-24 15:32:51.242819937 +0200 +++ /work/SRC/openSUSE:Factory/.skiboot.new.28833/skiboot.changes 2019-01-28 20:50:32.293772723 +0100 @@ -1,0 +2,7 @@ +Thu Jan 24 21:43:04 UTC 2019 - Michal Suchanek <[email protected]> + +- Fix build on Tumbleweed. + - add hdata-i2c.c-fix-building-with-gcc8.patch + - add libffs-fix-string-truncation.patch + +------------------------------------------------------------------- New: ---- hdata-i2c.c-fix-building-with-gcc8.patch libffs-fix-string-truncation.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ skiboot.spec ++++++ --- /var/tmp/diff_new_pack.pVAufM/_old 2019-01-28 20:50:32.861772124 +0100 +++ /var/tmp/diff_new_pack.pVAufM/_new 2019-01-28 20:50:32.861772124 +0100 @@ -1,7 +1,7 @@ # # spec file for package skiboot # -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # @@ -24,6 +24,8 @@ Group: System/Management Url: https://github.com/open-power/skiboot Source: skiboot-%{version}.tar.gz +Patch1: hdata-i2c.c-fix-building-with-gcc8.patch +Patch2: libffs-fix-string-truncation.patch BuildRequires: libopenssl-devel BuildRequires: linux-glibc-devel BuildRequires: systemd-rpm-macros @@ -66,7 +68,8 @@ services to the OS (Linux) on IBM Power and OpenPower systems. %prep -%setup -q -n %{name}-%{version} +%setup -q +%autopatch -p1 %build SKIBOOT_VERSION=%version CROSS= make V=1 %{?_smp_mflags} ++++++ hdata-i2c.c-fix-building-with-gcc8.patch ++++++ >From 70d544de8739abbc381398cbfd07a6bd6dc8c1a5 Mon Sep 17 00:00:00 2001 From: Stewart Smith <[email protected]> Date: Tue, 29 May 2018 14:54:10 +1000 Subject: [PATCH] hdata/i2c.c: fix building with gcc8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Patch-mainline: v6.1-rc1 Git-commit: 70d544de8739abbc381398cbfd07a6bd6dc8c1a5 hdata/test/../i2c.c:200:1: error: alignment 1 of ‘struct host_i2c_hdr’ is less than 4 [-Werror=packed-not-aligned] } __packed; ^ Fixes: https://github.com/open-power/skiboot/issues/160 Signed-off-by: Stewart Smith <[email protected]> --- hdata/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hdata/i2c.c b/hdata/i2c.c index 5cb56faf..9bbec665 100644 --- a/hdata/i2c.c +++ b/hdata/i2c.c @@ -197,7 +197,7 @@ static bool is_zeros(const void *p, size_t size) struct host_i2c_hdr { const struct HDIF_array_hdr hdr; __be32 version; -} __packed; +} __packed __align(0x4); int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index, struct dt_node *xscom) -- 2.19.1 ++++++ libffs-fix-string-truncation.patch ++++++ >From 235a280711265ed67d35b3781f6c7d6e7e83bda9 Mon Sep 17 00:00:00 2001 From: Michal Suchanek <[email protected]> Date: Fri, 25 Jan 2019 12:54:12 +0100 Subject: [PATCH] libffs: Fix string truncation gcc warning. Allow one more byte copied. The allocated space has extra byte anyway. --- libflash/libffs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libflash/libffs.c b/libflash/libffs.c index 221c2b02..4eb0ffa9 100644 --- a/libflash/libffs.c +++ b/libflash/libffs.c @@ -522,7 +522,7 @@ int ffs_part_info(struct ffs_handle *ffs, uint32_t part_idx, n = calloc(1, FFS_PART_NAME_MAX + 1); if (!n) return FLASH_ERR_MALLOC_FAILED; - strncpy(n, ent->name, FFS_PART_NAME_MAX); + strncpy(n, ent->name, FFS_PART_NAME_MAX + 1); *name = n; } return 0; -- 2.19.1
