Hello community, here is the log from the commit of package libsmpp34 for openSUSE:Factory checked in at 2019-02-01 11:44:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libsmpp34 (Old) and /work/SRC/openSUSE:Factory/.libsmpp34.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libsmpp34" Fri Feb 1 11:44:53 2019 rev:3 rq:669396 version:1.13.0 Changes: -------- --- /work/SRC/openSUSE:Factory/libsmpp34/libsmpp34.changes 2017-10-11 23:03:19.447721685 +0200 +++ /work/SRC/openSUSE:Factory/.libsmpp34.new.28833/libsmpp34.changes 2019-02-01 11:44:55.832584215 +0100 @@ -1,0 +2,12 @@ +Mon Jan 28 22:11:23 UTC 2019 - Jan Engelhardt <[email protected]> + +- Rename libsmpp34-0-devel to libsmpp34-devel. + +------------------------------------------------------------------- +Mon Jan 28 21:28:18 UTC 2019 - [email protected] + +- Update to new upstream release 1.13.0 + * No user-visible changes +- Drop patch build-fixes.diff (not longer needed) + +------------------------------------------------------------------- Old: ---- build-fixes.diff libsmpp34-1.12.8.tar.xz New: ---- libsmpp34-1.13.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libsmpp34.spec ++++++ --- /var/tmp/diff_new_pack.AgUxmA/_old 2019-02-01 11:44:56.308583725 +0100 +++ /var/tmp/diff_new_pack.AgUxmA/_new 2019-02-01 11:44:56.308583725 +0100 @@ -1,7 +1,7 @@ # # spec file for package libsmpp34 # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # Copyright (c) 2016, Martin Hauke <[email protected]> # # All modifications and additions to the file contributed by third parties @@ -13,48 +13,49 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # +%define sover 1 Name: libsmpp34 -Version: 1.12.8 +Version: 1.13.0 Release: 0 Summary: PDU SMPP packaging and unpackaging tool -License: GPL-2.0+ and LGPL-2.1+ +License: GPL-2.0-or-later AND LGPL-2.1-or-later Group: Development/Libraries/C and C++ Url: https://osmocom.org/projects/libsmpp34 - Source: %name-%version.tar.xz -Patch1: build-fixes.diff BuildRequires: autoconf >= 2.57 BuildRequires: libtool BuildRequires: pkg-config >= 0.20 BuildRequires: pkgconfig(libxml-2.0) -BuildRoot: %{_tmppath}/%{name}-%{version}-build %description The library provides the PDU handling of the SMPP-3.4 protocol. -%package -n libsmpp34-0 +%package -n libsmpp34-%sover Summary: SMPP-3.4 protocol library -License: LGPL-2.1+ +License: LGPL-2.1-or-later Group: System/Libraries -%description -n libsmpp34-0 +%description -n libsmpp34-%sover This library provides the Protocol Data Unit (PDU) handling of the SMPP-3.4 protocol. SMPP (Short Message Peer-to-Peer) is a protocol providing a data communication interface for the transfer of short message data between External Short Messaging Entities, Routing Entitites and Message Centres. -%package -n libsmpp34-0-devel +%package devel Summary: Development files for the SMPP-3.4 protocol library -License: GPL-2.0+ +License: GPL-2.0-or-later Group: Development/Libraries/C and C++ -Requires: libsmpp34-0 = %version +Requires: libsmpp34-%sover = %version +# Wrong package name +Obsoletes: libsmpp34-0-devel <= %version-%release +Provides: libsmpp34-0-devel = %version-%release -%description -n libsmpp34-0-devel +%description devel The library provides the PDU handling of the SMPP-3.4 protocol. This subpackage contains libraries and header files for developing @@ -62,8 +63,6 @@ %prep %setup -q -rm -Rf .pc -%patch -P 1 -p1 %build echo "%version" >.tarball-version @@ -75,16 +74,18 @@ %make_install rm -f "%buildroot/%_libdir"/*.la -%post -n libsmpp34-0 -p /sbin/ldconfig -%postun -n libsmpp34-0 -p /sbin/ldconfig +%check +make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) + +%post -n libsmpp34-%sover -p /sbin/ldconfig +%postun -n libsmpp34-%sover -p /sbin/ldconfig + +%files -n libsmpp34-%sover +%_libdir/libsmpp34.so.%{sover}* -%files -n libsmpp34-0 -%defattr(-,root,root) -%_libdir/libsmpp34.so.0* - -%files -n libsmpp34-0-devel -%defattr(-,root,root) -%doc ChangeLog COPYING +%files devel +%license COPYING +%doc ChangeLog %_includedir/%name/ %_libdir/libsmpp34.so %_libdir/pkgconfig/*.pc ++++++ _service ++++++ --- /var/tmp/diff_new_pack.AgUxmA/_old 2019-02-01 11:44:56.332583701 +0100 +++ /var/tmp/diff_new_pack.AgUxmA/_new 2019-02-01 11:44:56.336583697 +0100 @@ -2,9 +2,8 @@ <service name="tar_scm" mode="disabled"> <param name="scm">git</param> <param name="url">git://git.osmocom.org/libsmpp34</param> - <param name="revision">master</param> - <param name="parent-tag">1.12</param> - <param name="versionformat">@PARENT_TAG@.@TAG_OFFSET@</param> + <param name="revision">1.13.0</param> + <param name="versionformat">1.13.0</param> </service> <service name="recompress" mode="disabled"> <param name="file">*.tar</param> ++++++ libsmpp34-1.12.8.tar.xz -> libsmpp34-1.13.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/.pc/.quilt_patches new/libsmpp34-1.13.0/.pc/.quilt_patches --- old/libsmpp34-1.12.8/.pc/.quilt_patches 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/.pc/.quilt_patches 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -quilt-patches diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/.pc/.quilt_series new/libsmpp34-1.13.0/.pc/.quilt_series --- old/libsmpp34-1.12.8/.pc/.quilt_series 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/.pc/.quilt_series 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -series diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/.pc/.version new/libsmpp34-1.13.0/.pc/.version --- old/libsmpp34-1.12.8/.pc/.version 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/.pc/.version 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -2 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/.pc/applied-patches new/libsmpp34-1.13.0/.pc/applied-patches --- old/libsmpp34-1.12.8/.pc/applied-patches 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/.pc/applied-patches 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -oob.diff diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/.pc/oob.diff/src/smpp34_unpack.c new/libsmpp34-1.13.0/.pc/oob.diff/src/smpp34_unpack.c --- old/libsmpp34-1.12.8/.pc/oob.diff/src/smpp34_unpack.c 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/.pc/oob.diff/src/smpp34_unpack.c 1970-01-01 01:00:00.000000000 +0100 @@ -1,253 +0,0 @@ -/* - * Copyright (C) 2006 Raul Tremsal - * File : smpp34_unpack.c - * Author: Raul Tremsal <[email protected]> - * - * This file is part of libsmpp34 (c-open-smpp3.4 library). - * - * The libsmpp34 library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation; either version 2.1 of the - * License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY - * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public - * License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this library; if not, write to the Free Software Foundation, - * Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * - */ -#include <stdio.h> -#include <string.h> -#include <stdlib.h> -#include <sys/types.h> -#include <netinet/in.h> - -#include <stdint.h> - -#include "smpp34.h" -#include "smpp34_structs.h" -#include "smpp34_params.h" - -/* GLOBALS ********************************************************************/ -/* EXTERN *********************************************************************/ -extern int smpp34_errno; -extern char smpp34_strerror[2048]; -extern char *ptrerror; - -/* FUNCTIONS ******************************************************************/ -int -smpp34_unpack(uint32_t type, void* tt, const uint8_t *ptrBuf, int ptrLen) -{ - - char dummy_b[SMALL_BUFF]; - const uint8_t *ini = ptrBuf; - const uint8_t *aux = ptrBuf; - int lenval = 0; - int left = ptrLen; - int lefterror = 0; - - memset(smpp34_strerror, 0, sizeof(smpp34_strerror)); - ptrerror = smpp34_strerror; - lefterror = sizeof(smpp34_strerror); - -#define instancia t1-> - -#define U32( inst, par, _str ){\ - lenval = sizeof( uint32_t );\ - if( lenval > left ){\ - PUTLOG("[%s:%08X(%s)]", par, inst par,\ - "Value length exceed buffer length");\ - return( -1 );\ - };\ - memcpy(&inst par, aux, lenval);\ - left -= lenval; aux += lenval;\ - inst par = ntohl( inst par );\ - _str(inst par, dummy_b);\ - if( strcmp("", dummy_b) == 0 ){\ - PUTLOG( "[%s:%08X(%s)]", par, inst par, "Invalid value");\ - return( -1 );\ - };\ - PUTLOG("[%s:%08X(%s)]", par, inst par, "OK");\ -}; - -#define U16( inst, par, _str ){\ - lenval = sizeof( uint16_t );\ - if( lenval > left ){\ - PUTLOG("[%s:%04X(%s)]", par, inst par,\ - "Value length exceed buffer length");\ - return( -1 );\ - }\ - memcpy(&inst par, aux, lenval);\ - left -= lenval; aux += lenval;\ - inst par = ntohs( inst par );\ - _str(inst par, dummy_b);\ - if( strcmp("", dummy_b) == 0 ){\ - PUTLOG("[%s:%04X(%s)]", par, inst par, "Invalid value");\ - return( -1 );\ - };\ - PUTLOG("[%s:%04X(%s)]", par, inst par, "OK");\ -}; - -#define U08( inst, par, _str ){\ - lenval = sizeof( uint8_t );\ - if( lenval > left ){\ - PUTLOG("[%s:%02X(%s)]", par, inst par,\ - "Value length exceed buffer length");\ - return( -1 );\ - };\ - memcpy(&inst par, aux, lenval);\ - left -= lenval; aux += lenval;\ - _str(inst par, dummy_b);\ - if( strcmp("", dummy_b) == 0 ){\ - PUTLOG( "[%s:%02X(%s)]", par, inst par, "Invalid value");\ - return( -1 );\ - };\ - PUTLOG("[%s:%02X(%s)]", par, inst par, "OK");\ -}; - -/* NOTA: Importante, Los WARNINGs de los octetos, advierten de una - * inconsistencia de largo en los octets/c_octets recibidos, segun se - * decida el grado de restriccion estos pueden ser errores graves. - * La accion a tomar es truncar estos datos a los largos permitidos en la - * especicacion, pero seguir parseando (saltando segun los largos - * invalidos) los datos recibidos. - */ -#define O_C_OCTET( inst, par, sizeval ){\ - if( !(inst command_status) ){\ - C_OCTET( inst, par, sizeval );\ - } else {\ - PUTLOG("[%s:%s(%s)]", par, inst par, "OK");\ - };\ -} - - -#define C_OCTET( inst, par, size ){\ - lenval = strlen( (char*) aux ) + 1;\ - if( lenval > left ){\ - PUTLOG("[len(%s):%d(%s)]", par, lenval, \ - "Value length exceed buffer length");\ - return( -1 );\ - };\ - if( lenval > size ){\ - PUTLOG("[%s:%s(%s)]", par, inst par, "Data length is invalid");\ - return( -1 );\ - } else {\ - /*snprintf(inst par, (lenval>size)?size:lenval, "%s", aux); */ \ - memcpy(inst par, aux, lenval);\ - left -= lenval; aux += lenval;\ - PUTLOG("[%s:%s(%s)]", par, inst par, "OK");\ - };\ -} - -#define OCTET8( inst, par, size ){\ - lenval = *((inst par) - 1);\ - if( lenval > left ){\ - PUTLOG("[leng %s:%d(%s)]", par, lenval,\ - "Value length exceed buffer length");\ - return( -1 );\ - };\ - if( lenval > size ){\ - PUTLOG("[%s:%s(%s)]", par, "<bin>",\ - "Data length is invalid (truncate)");\ - return( -1 );\ - };\ - memcpy(&inst par, aux, (lenval>size)?size:lenval);\ - left -= lenval; aux += lenval;\ - PUTLOG("[%s:%s(%s)]", par, "<bin>", "OK");\ -} - -#define OCTET16( inst, par, size ){\ - uint16_t l_lenval = 0; /* VERIFICAR ESTO */\ - memcpy(&l_lenval, (inst par - sizeof(uint16_t)), sizeof(uint16_t));\ - if( l_lenval > left ){\ - PUTLOG("[leng %s:%d(%s)]", par, l_lenval,\ - "Value length exceed buffer length");\ - return( -1 );\ - };\ - if( l_lenval > size ){\ - PUTLOG("[%s:%s(%s)]", par, "<bin>", "Data length is invalid");\ - return( -1 );\ - };\ - PUTLOG("[%s:%s(%s)]", par, "<bin>", "OK");\ - memcpy(&(inst par), aux, (l_lenval>size)?size:l_lenval);\ - left -= l_lenval; aux += l_lenval;\ -} - -#define TLV( inst, tlv3, do_tlv ){\ - tlv_t *aux_tlv = NULL;\ - while( (aux - ini) < t1->command_length ){\ - aux_tlv = (tlv_t *) malloc(sizeof( tlv_t ));\ - memset(aux_tlv, 0, sizeof(tlv_t));\ - do_tlv( aux_tlv );\ - aux_tlv->next = inst tlv3;\ - inst tlv3 = aux_tlv;\ - };\ -}; - -#define UDAD( inst, udad3, do_udad ){\ - udad_t *aux_udad = NULL;\ - int c = 0;\ - while( c < t1->no_unsuccess ){\ - aux_udad = (udad_t *) malloc(sizeof( udad_t ));\ - memset(aux_udad, 0, sizeof(udad_t));\ - do_udad( aux_udad );\ - aux_udad->next = inst udad3;\ - inst udad3 = aux_udad;\ - c++;\ - };\ -}; - -#define DAD( inst, dad3, do_dad ){\ - dad_t *aux_dad = NULL;\ - int c = 0;\ - while( c < t1->number_of_dests ){\ - aux_dad = (dad_t *) malloc(sizeof( dad_t ));\ - memset(aux_dad, 0, sizeof(dad_t));\ - do_dad( aux_dad );\ - aux_dad->next = inst dad3;\ - inst dad3 = aux_dad;\ - c++;\ - };\ -}; - -#include "def_frame/alert_notification.tlv" -#include "def_frame/bind_receiver_resp.tlv" -#include "def_frame/bind_transceiver_resp.tlv" -#include "def_frame/bind_transmitter_resp.tlv" -#include "def_frame/data_sm.tlv" -#include "def_frame/data_sm_resp.tlv" -#include "def_frame/deliver_sm.tlv" -#include "def_frame/submit_multi_resp.udad" -#include "def_frame/submit_multi.dad" -#include "def_frame/submit_multi.tlv" -#include "def_frame/submit_sm.tlv" -#include "def_list/smpp34_protocol.def" - - { /* Hace algunas Verificaciones **************************************/ - uint32_t len_orig; - uint32_t l; - memcpy(&len_orig, tt, sizeof(uint32_t)); - l = ntohl( len_orig ); - if( len_orig != (aux - ini) ){ - PUTLOG("[%s:(Error in PDU length %d!=%d)]",PDU,len_orig,(uint32_t)(aux-ini)); - return( -1 ); - }; - }; - -#include "def_frame/clean.frame" - return( 0 ); -}; - -int -smpp34_unpack2(void* tt, const uint8_t *ptrBuf, int ptrLen) -{ - uint32_t cmdid; - uint32_t tempo; - memcpy(&tempo, ptrBuf + 4, sizeof(uint32_t)); /* get command_id PDU */ - cmdid = ntohl( tempo ); - return( smpp34_unpack(cmdid, tt, ptrBuf, ptrLen) ); -}; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/Makefile.am new/libsmpp34-1.13.0/Makefile.am --- old/libsmpp34-1.12.8/Makefile.am 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/Makefile.am 2018-05-03 18:04:11.000000000 +0200 @@ -17,7 +17,8 @@ test_apps/esme.xml\ test_apps/sendwp.xml\ test_apps/recv_and_unpack.inc \ - README.md + README.md \ + .version @RELMAKE@ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/binaries/Makefile.am new/libsmpp34-1.13.0/binaries/Makefile.am --- old/libsmpp34-1.12.8/binaries/Makefile.am 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/binaries/Makefile.am 2018-05-03 18:04:11.000000000 +0200 @@ -9,7 +9,7 @@ include $(top_srcdir)/test_apps/Makefile.am include $(top_srcdir)/src/Makefile.am -LDADD = $(top_builddir)/binaries/libsmpp34.la +LDADD = libsmpp34.la AM_CPPFLAGS = -D_REENTRANT -DBSD_COMP -D_POSIX_PTHREAD_SEMANTICS AM_CFLAGS = @CFLAGS@ -Wall -fPIC # -static INCLUDES = -I$(top_srcdir)/src -I$(top_srcdir) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/configure.ac new/libsmpp34-1.13.0/configure.ac --- old/libsmpp34-1.12.8/configure.ac 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/configure.ac 2018-05-03 18:04:11.000000000 +0200 @@ -40,6 +40,40 @@ # Checks for library functions. AC_FUNC_MALLOC AC_CHECK_FUNCS([memset]) + +AC_ARG_ENABLE(sanitize, + [AS_HELP_STRING( + [--enable-sanitize], + [Compile with address sanitizer enabled], + )], + [sanitize=$enableval], [sanitize="no"]) +if test x"$sanitize" = x"yes" +then + CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined" + CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" +fi + +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + AC_OUTPUT([Makefile def_frame/Makefile def_list/Makefile diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/contrib/jenkins.sh new/libsmpp34-1.13.0/contrib/jenkins.sh --- old/libsmpp34-1.12.8/contrib/jenkins.sh 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/contrib/jenkins.sh 2018-05-03 18:04:11.000000000 +0200 @@ -1,9 +1,14 @@ #!/usr/bin/env bash +export PATH="$PATH:$HOME/osmo-ci/scripts" set -ex +osmo-clean-workspace.sh + autoreconf --install --force -./configure -$MAKE CFLAGS="-Werror" CPPFLAGS="-Werror" -# currently broken $MAKE $PARALLEL_MAKE -# currently broken $MAKE distcheck +./configure --enable-sanitize --enable-werror +$MAKE +$MAKE $PARALLEL_MAKE +$MAKE distcheck || cat-testlogs.sh + +osmo-clean-workspace.sh diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/debian/changelog new/libsmpp34-1.13.0/debian/changelog --- old/libsmpp34-1.12.8/debian/changelog 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/debian/changelog 2018-05-03 18:04:11.000000000 +0200 @@ -1,4 +1,4 @@ -libsmpp34 (1.12.0) UNRELEASED; urgency=medium +libsmpp34 (1.13.0) unstable; urgency=medium [ Holger Hans Peter Freyther ] * Move forward towards a new release. @@ -8,8 +8,38 @@ * SMPP_DELIVERY_RECEIPT_* constants * SMPP ESM class parameter definitions * smpp34_tlv_for_each() helper macro + * Fix 'make distcheck' by adding .version to EXTRA_DISTI + * debian/control: Fix Vcs-{Browser,Git} URLs - -- Harald Welte <[email protected]> Mon, 14 Aug 2017 19:08:37 +0200 + [ Max ] + * Use release helper from libosmocore + * Enable sanitize for CI tests + + [ Pau Espin Pedrol ] + * smpp34_dumpBuf.c: remove unused variable + * smpp34_structs.h: Fix trailing whitespace + * smpp34_structs.h: Fix truncated output in str_tlv_id + * smpp34_unpack.c: remove unused variable + * bind_receiver_resp_test.c: Fix compilation warning + * Fix Out of bounds compilation warning in OCTET8 + * contrib: Enable -Werror by default + * src/Makefile.am: Use LIBVERSION variable to set version-info + + [ Alexander Couzens ] + * debian/rules: show testsuite.log when tests are failing + + [ Neels Hofmeyr ] + * jenkins: use osmo-clean-workspace.sh before and after build + * add --enable-sanitize config option + * configure: add --enable-werror + * jenkins.sh: use --enable-werror configure flag, not CFLAGS + + [ Martin Hauke ] + * binaries/Makefile.am: Fix parallel build issue + * jenkins: Enable parallel build and distcheck + * jenkins.sh: output all test logs when 'make check' failed + + -- Pau Espin Pedrol <[email protected]> Thu, 03 May 2018 18:04:10 +0200 libsmpp34 (1.10z1) stable; urgency=low diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/debian/control new/libsmpp34-1.13.0/debian/control --- old/libsmpp34-1.12.8/debian/control 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/debian/control 2018-05-03 18:04:11.000000000 +0200 @@ -13,11 +13,11 @@ pkg-config, libxml2-dev Standards-Version: 3.9.6 -Vcs-Browser: http://git.osmocom.org/gitweb?p=libosmocore.git;a=summary -Vcs-Git: git://git.osmocom.org/libosmocore.git +Vcs-Browser: http://git.osmocom.org/libsmpp34/ +Vcs-Git: git://git.osmocom.org/libsmpp34.git Homepage: https://projects.osmocom.org/projects/libsmpp34 -Package: libsmpp0 +Package: libsmpp1 Section: libs Architecture: any Multi-Arch: same @@ -35,7 +35,7 @@ Architecture: any Multi-Arch: same Section: libdevel -Depends: libsmpp0 (= ${binary:Version}), +Depends: libsmpp1 (= ${binary:Version}), ${misc:Depends} Description: Development files for libsmpp34 This library is an implementation for providing the PDU handling of the @@ -55,5 +55,5 @@ Architecture: any Section: debug Priority: extra -Depends: libsmpp0 (= ${binary:Version}), ${misc:Depends} +Depends: libsmpp1 (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for libsmpp34 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/debian/libsmpp0.install new/libsmpp34-1.13.0/debian/libsmpp0.install --- old/libsmpp34-1.12.8/debian/libsmpp0.install 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/debian/libsmpp0.install 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -usr/lib/*/lib*.so.* diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/debian/libsmpp1.install new/libsmpp34-1.13.0/debian/libsmpp1.install --- old/libsmpp34-1.12.8/debian/libsmpp1.install 1970-01-01 01:00:00.000000000 +0100 +++ new/libsmpp34-1.13.0/debian/libsmpp1.install 2018-05-03 18:04:11.000000000 +0200 @@ -0,0 +1 @@ +usr/lib/*/lib*.so.* diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/debian/rules new/libsmpp34-1.13.0/debian/rules --- old/libsmpp34-1.12.8/debian/rules 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/debian/rules 2018-05-03 18:04:11.000000000 +0200 @@ -17,3 +17,7 @@ override_dh_autoreconf: echo $(VERSION) > .tarball-version dh_autoreconf + +# Print test results in case of a failure +override_dh_auto_test: + dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/quilt-patches/oob.diff new/libsmpp34-1.13.0/quilt-patches/oob.diff --- old/libsmpp34-1.12.8/quilt-patches/oob.diff 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/quilt-patches/oob.diff 1970-01-01 01:00:00.000000000 +0100 @@ -1,33 +0,0 @@ - -attempt at addressing the out of bounds access. -lenval = *((t1->short_message) - 1) aka -lenval = t1->short_message[-1] -does not make much sense to me. What seems more logical is that -the len byte pointed to by t1->short_message includes the size -for a header, similar to how netlink attrs work. -Maybe. - -[ 13s] ../src/smpp34_unpack.c:147:14: warning: array subscript is above array bounds [-Warray-bounds] -[ 13s] lenval = *((inst par) - 1);\ -[ 13s] ^~~~~~~~~~~~~~~~~ -[ 13s] ../def_frame/submit_sm.frame:18:2: note: in expansion of macro 'OCTET8' -[ 13s] OCTET8( instancia, short_message, 254 ); -[ 13s] ^~~~~~ - ---- - src/smpp34_unpack.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -Index: libsmpp34-1.10.27/src/smpp34_unpack.c -=================================================================== ---- libsmpp34-1.10.27.orig/src/smpp34_unpack.c -+++ libsmpp34-1.10.27/src/smpp34_unpack.c -@@ -144,7 +144,7 @@ smpp34_unpack(uint32_t type, void* tt, c - } - - #define OCTET8( inst, par, size ){\ -- lenval = *((inst par) - 1);\ -+ lenval = *(inst par) - 1;\ - if( lenval > left ){\ - PUTLOG("[leng %s:%d(%s)]", par, lenval,\ - "Value length exceed buffer length");\ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/quilt-patches/series new/libsmpp34-1.13.0/quilt-patches/series --- old/libsmpp34-1.12.8/quilt-patches/series 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/quilt-patches/series 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -oob.diff diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.12.8/src/Makefile.am new/libsmpp34-1.13.0/src/Makefile.am --- old/libsmpp34-1.12.8/src/Makefile.am 2017-09-17 17:05:54.000000000 +0200 +++ new/libsmpp34-1.13.0/src/Makefile.am 2018-05-03 18:04:11.000000000 +0200 @@ -1,3 +1,6 @@ +# This is _NOT_ the library release version, it's an API version. +# Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification +LIBVERSION=1:0:0 # src/Makefile.am # lib_LTLIBRARIES = libsmpp34.la @@ -22,7 +25,5 @@ libsmpp34_la_CFLAGS = @CFLAGS@ -Wall libsmpp34_la_CFLAGS += -D_REENTRANT -DBSD_COMP -D_POSIX_PTHREAD_SEMANTICS libsmpp34_la_INCLUDES = -I. -I.. -libsmpp34_la_LDFLAGS = @LDFLAGS@ -version-info 0:1:0 +libsmpp34_la_LDFLAGS = @LDFLAGS@ -version-info $(LIBVERSION) -no-undefined libsmpp34_la_LDFLAGS += -lrt -lpthread - -
