Hello community,
here is the log from the commit of package kubernetes-dashboard for
openSUSE:Factory checked in at 2019-02-13 10:05:06
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kubernetes-dashboard (Old)
and /work/SRC/openSUSE:Factory/.kubernetes-dashboard.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kubernetes-dashboard"
Wed Feb 13 10:05:06 2019 rev:3 rq:673585 version:27408f19
Changes:
--------
---
/work/SRC/openSUSE:Factory/kubernetes-dashboard/kubernetes-dashboard.changes
2018-07-17 09:43:58.216944193 +0200
+++
/work/SRC/openSUSE:Factory/.kubernetes-dashboard.new.28833/kubernetes-dashboard.changes
2019-02-13 10:05:16.153562957 +0100
@@ -1,0 +2,6 @@
+Fri Sep 21 08:24:59 UTC 2018 - Bernhard Wiedemann <[email protected]>
+
+- Add reproducible.patch to drop build time (boo#1047218)
+- Drop binaries from node_modules and build them in OBS
+
+-------------------------------------------------------------------
New:
----
reproducible.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ kubernetes-dashboard.spec ++++++
--- /var/tmp/diff_new_pack.daX7AU/_old 2019-02-13 10:05:23.593561089 +0100
+++ /var/tmp/diff_new_pack.daX7AU/_new 2019-02-13 10:05:23.593561089 +0100
@@ -25,13 +25,18 @@
Url: https://github.com/kubernetes/dashboard
Source: %{name}-%{version}.tar.xz
Source1: node_modules.tar.xz
+Patch0: reproducible.patch
# For now node_modules.tar.xz provides only x86_64 compatibles files
ExclusiveArch: x86_64
BuildRequires: fdupes
+BuildRequires: gcc-c++
BuildRequires: go >= 1.8
BuildRequires: golang-packaging
+BuildRequires: gyp
BuildRequires: java-1_8_0-openjdk
BuildRequires: nodejs8
+BuildRequires: nodejs8-devel
+BuildRequires: npm8
BuildRequires: xz
%{go_nostrip}
%{go_provides}
@@ -143,11 +148,22 @@
Kubernetes Dashboard is a general purpose, web-based UI for Kubernetes
clusters. It allows users to manage applications running in the cluster and
troubleshoot them, as well as manage the cluster itself.
%prep
-tar -C %{_builddir} -xJf ../SOURCES/%{name}-%{version}.tar.xz
-tar -C %{_builddir} -xJf %{SOURCE1}
+tar -C %{_builddir} -xf %{SOURCE0}
+tar -C %{_builddir} -xf %{SOURCE1}
+%autopatch -p1
%build
-node node_modules/gulp/bin/gulp.js build
+mkdir -p ~/.node-gyp/8.11.4/include && ln -sf /usr/include/node8
~/.node-gyp/8.11.4/include/node
+
+nodegyp=`pwd`/node_modules/node-gyp/bin/node-gyp.js
+# dirs have been prepared online with node-gyp configure
+for dir in node_modules/libxmljs-mt
node_modules/gulp-xslt/node_modules/libxslt node_modules/node-sass ; do
+# (cd $dir && $nodegyp build)
+ make -C $dir/build %{?_smp_mflags}
+done
+cp -l node_modules/node-sass/{build/Release/binding.node,vendor/linux-x64-57/}
+# taskset required to avoid race from parallelism
https://github.com/kubernetes/dashboard/issues/3234
+taskset 1 node node_modules/gulp/bin/gulp.js build
%install
mkdir -p %{buildroot}%{_bindir}
++++++ node_modules.tar.xz ++++++
/work/SRC/openSUSE:Factory/kubernetes-dashboard/node_modules.tar.xz
/work/SRC/openSUSE:Factory/.kubernetes-dashboard.new.28833/node_modules.tar.xz
differ: char 13, line 1
++++++ reproducible.patch ++++++
https://github.com/kubernetes/dashboard/pull/3233
commit 35b0e02a7fffdb3e8290413f85445cb8e697e26b
Author: Bernhard M. Wiedemann <[email protected]>
Date: Sat Aug 25 12:39:39 2018 +0200
Don't claim copyright for future years
When building the kubernetes-dashboard openSUSE package
in future years, files differed because they contained
something like
this.latestCopyrightYear="2033"
See https://reproducible-builds.org/ for why this matters.
And
https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated
suggests that expiry should not be a concern anyway.
https://github.com/kubernetes/kubernetes/pull/59172 fixed this for
kubernetes.
diff --git a/build/conf.js b/build/conf.js
index 55de47375..143861949 100644
--- a/build/conf.js
+++ b/build/conf.js
@@ -64,6 +64,10 @@ const version = {
* Version name of the head release of the project.
*/
head: 'head',
+ /**
+ * Year of last change of the project
+ */
+ year: '2018',
};
/**
diff --git a/build/script.js b/build/script.js
index 2ff598925..6fdd8b3bf 100644
--- a/build/script.js
+++ b/build/script.js
@@ -242,7 +242,7 @@ function patchBuildInformation() {
patterns: [
{match: 'BUILD_GIT_COMMIT', replacement: commit},
{match: 'BUILD_DASHBOARD_VERSION', replacement:
conf.deploy.version.release},
- {match: 'BUILD_YEAR', replacement: new
Date().getFullYear()},
+ {match: 'BUILD_YEAR', replacement:
conf.deploy.version.year},
],
}));
}
