Hello community, here is the log from the commit of package NetworkManager for openSUSE:Factory checked in at 2019-02-17 12:19:15 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/NetworkManager (Old) and /work/SRC/openSUSE:Factory/.NetworkManager.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "NetworkManager" Sun Feb 17 12:19:15 2019 rev:192 rq:676258 version:1.14.4 Changes: -------- --- /work/SRC/openSUSE:Factory/NetworkManager/NetworkManager.changes 2018-11-22 13:23:03.854153808 +0100 +++ /work/SRC/openSUSE:Factory/.NetworkManager.new.28833/NetworkManager.changes 2019-02-17 12:19:16.668234580 +0100 @@ -1,0 +2,8 @@ +Thu Jan 31 01:12:35 UTC 2019 - [email protected] + +- Add NM-add-wifi-scan-polkit-rule.patch: Adding a new polkit + action "org.freedesktop.NetworkManager.wifi-scan" so that + distributions can add specific rule to allow Wi-Fi scans + (bsc#1122262, glfo#NetworkManager/NetworkManager!68). + +------------------------------------------------------------------- New: ---- NM-add-wifi-scan-polkit-rule.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ NetworkManager.spec ++++++ --- /var/tmp/diff_new_pack.U5QFXI/_old 2019-02-17 12:19:17.668234305 +0100 +++ /var/tmp/diff_new_pack.U5QFXI/_new 2019-02-17 12:19:17.668234305 +0100 @@ -1,7 +1,7 @@ # # spec file for package NetworkManager # -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -48,6 +48,8 @@ Patch5: NetworkManager-1.10.6-netconfig.patch # PATCH-FIX-UPSTREAM NetworkManager-1.12.2-docker-unmanaged.patch Patch6: NetworkManager-1.12.2-docker-unmanaged.patch +# PATCH-FIX-UPSTREAM NM-add-wifi-scan-polkit-rule.patch bsc#1122262, glfo#NetworkManager/NetworkManager!68 [email protected] -- Adding a new polkit action "org.freedesktop.NetworkManager.wifi-scan" so that distributions can add specific rule to allow Wi-Fi scans. +Patch7: NM-add-wifi-scan-polkit-rule.patch BuildRequires: dnsmasq BuildRequires: fdupes @@ -238,6 +240,7 @@ %patch4 -p1 %patch5 -p1 %patch6 -p1 +%patch7 -p1 %build NOCONFIGURE=1 ./autogen.sh ++++++ NM-add-wifi-scan-polkit-rule.patch ++++++ >From e491ef1692b71f3b540a86ea99034139c438275b Mon Sep 17 00:00:00 2001 From: Jonathan Kang <[email protected]> Date: Fri, 25 Jan 2019 15:29:10 +0800 Subject: [PATCH] Add polkit action for Wi-Fi scans Previously, Wi-Fi scans uses polkit action "org.freedesktop.NetworkManager.network-control". This is introduced in commit 5e3e19d0. But in a system with restrict polkit rules, for example "org.freedesktop.NetworkManager.network-control" was set as auth_admin. When you open the network panel of GNOME Control Center, a polkit dialog will keep showing up asking for admin password, as GNOME Control Center scans the Wi-Fi list every 15 seconds. Fix that by adding a new polkit action "org.freedesktop.NetworkManager.wifi-scan" so that distributions can add specific rule to allow Wi-Fi scans. --- clients/cli/general.c | 2 ++ ...rg.freedesktop.NetworkManager.policy.in.in | 10 +++++++ libnm-glib/nm-client.c | 2 ++ libnm-glib/nm-client.h | 24 +++++++++-------- libnm/nm-client.h | 26 ++++++++++--------- libnm/nm-manager.c | 2 ++ shared/nm-common-macros.h | 1 + src/devices/wifi/nm-device-iwd.c | 2 +- src/devices/wifi/nm-device-wifi.c | 2 +- 9 files changed, 46 insertions(+), 25 deletions(-) Index: NetworkManager-1.14.4/clients/cli/general.c =================================================================== --- NetworkManager-1.14.4.orig/clients/cli/general.c +++ NetworkManager-1.14.4/clients/cli/general.c @@ -146,6 +146,8 @@ permission_to_string (NMClientPermission return NM_AUTH_PERMISSION_ENABLE_DISABLE_STATISTICS; case NM_CLIENT_PERMISSION_ENABLE_DISABLE_CONNECTIVITY_CHECK: return NM_AUTH_PERMISSION_ENABLE_DISABLE_CONNECTIVITY_CHECK; + case NM_CLIENT_PERMISSION_WIFI_SCAN: + return NM_AUTH_PERMISSION_WIFI_SCAN; default: return _("unknown"); } Index: NetworkManager-1.14.4/data/org.freedesktop.NetworkManager.policy.in.in =================================================================== --- NetworkManager-1.14.4.orig/data/org.freedesktop.NetworkManager.policy.in.in +++ NetworkManager-1.14.4/data/org.freedesktop.NetworkManager.policy.in.in @@ -73,6 +73,16 @@ <allow_active>yes</allow_active> </defaults> </action> + + <action id="org.freedesktop.NetworkManager.wifi-scan"> + <_description>Allow control of Wi-Fi scans</_description> + <_message>System policy prevents Wi-Fi scans</_message> + <defaults> + <allow_any>auth_admin</allow_any> + <allow_inactive>yes</allow_inactive> + <allow_active>yes</allow_active> + </defaults> + </action> <action id="org.freedesktop.NetworkManager.wifi.share.protected"> <_description>Connection sharing via a protected WiFi network</_description> Index: NetworkManager-1.14.4/libnm/nm-client.h =================================================================== --- NetworkManager-1.14.4.orig/libnm/nm-client.h +++ NetworkManager-1.14.4/libnm/nm-client.h @@ -107,6 +107,7 @@ G_BEGIN_DECLS * statistics can be globally enabled or disabled * @NM_CLIENT_PERMISSION_ENABLE_DISABLE_CONNECTIVITY_CHECK: controls whether * connectivity check can be enabled or disabled + * @NM_CLIENT_PERMISSION_WIFI_SCAN: controls whether wifi scans can be performed * @NM_CLIENT_PERMISSION_LAST: a reserved boundary value * * #NMClientPermission values indicate various permissions that NetworkManager @@ -130,8 +131,9 @@ typedef enum { NM_CLIENT_PERMISSION_CHECKPOINT_ROLLBACK = 14, NM_CLIENT_PERMISSION_ENABLE_DISABLE_STATISTICS = 15, NM_CLIENT_PERMISSION_ENABLE_DISABLE_CONNECTIVITY_CHECK = 16, + NM_CLIENT_PERMISSION_WIFI_SCAN = 17, - NM_CLIENT_PERMISSION_LAST = 16, + NM_CLIENT_PERMISSION_LAST = 17, } NMClientPermission; /** Index: NetworkManager-1.14.4/libnm/nm-manager.c =================================================================== --- NetworkManager-1.14.4.orig/libnm/nm-manager.c +++ NetworkManager-1.14.4/libnm/nm-manager.c @@ -312,6 +312,8 @@ nm_permission_to_client (const char *nm) return NM_CLIENT_PERMISSION_ENABLE_DISABLE_STATISTICS; else if (!strcmp (nm, NM_AUTH_PERMISSION_ENABLE_DISABLE_CONNECTIVITY_CHECK)) return NM_CLIENT_PERMISSION_ENABLE_DISABLE_CONNECTIVITY_CHECK; + else if (!strcmp (nm, NM_AUTH_PERMISSION_WIFI_SCAN)) + return NM_CLIENT_PERMISSION_WIFI_SCAN; return NM_CLIENT_PERMISSION_NONE; } Index: NetworkManager-1.14.4/shared/nm-common-macros.h =================================================================== --- NetworkManager-1.14.4.orig/shared/nm-common-macros.h +++ NetworkManager-1.14.4/shared/nm-common-macros.h @@ -40,6 +40,7 @@ #define NM_AUTH_PERMISSION_CHECKPOINT_ROLLBACK "org.freedesktop.NetworkManager.checkpoint-rollback" #define NM_AUTH_PERMISSION_ENABLE_DISABLE_STATISTICS "org.freedesktop.NetworkManager.enable-disable-statistics" #define NM_AUTH_PERMISSION_ENABLE_DISABLE_CONNECTIVITY_CHECK "org.freedesktop.NetworkManager.enable-disable-connectivity-check" +#define NM_AUTH_PERMISSION_WIFI_SCAN "org.freedesktop.NetworkManager.wifi-scan" #define NM_CLONED_MAC_PRESERVE "preserve" #define NM_CLONED_MAC_PERMANENT "permanent" Index: NetworkManager-1.14.4/src/devices/wifi/nm-device-iwd.c =================================================================== --- NetworkManager-1.14.4.orig/src/devices/wifi/nm-device-iwd.c +++ NetworkManager-1.14.4/src/devices/wifi/nm-device-iwd.c @@ -1013,7 +1013,7 @@ _nm_device_iwd_request_scan (NMDeviceIwd NM_DEVICE_AUTH_REQUEST, invocation, NULL, - NM_AUTH_PERMISSION_NETWORK_CONTROL, + NM_AUTH_PERMISSION_WIFI_SCAN, TRUE, dbus_request_scan_cb, options ? g_variant_ref (options) : NULL); Index: NetworkManager-1.14.4/src/devices/wifi/nm-device-wifi.c =================================================================== --- NetworkManager-1.14.4.orig/src/devices/wifi/nm-device-wifi.c +++ NetworkManager-1.14.4/src/devices/wifi/nm-device-wifi.c @@ -1197,7 +1197,7 @@ _nm_device_wifi_request_scan (NMDeviceWi NM_DEVICE_AUTH_REQUEST, invocation, NULL, - NM_AUTH_PERMISSION_NETWORK_CONTROL, + NM_AUTH_PERMISSION_WIFI_SCAN, TRUE, dbus_request_scan_cb, options ? g_variant_ref (options) : NULL);
