Hello community, here is the log from the commit of package yast2-registration for openSUSE:Factory checked in at 2019-02-24 18:03:36 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-registration (Old) and /work/SRC/openSUSE:Factory/.yast2-registration.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-registration" Sun Feb 24 18:03:36 2019 rev:31 rq:677395 version:4.1.17 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-registration/yast2-registration.changes 2019-02-06 15:45:15.207338025 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-registration.new.28833/yast2-registration.changes 2019-02-24 18:03:38.671769591 +0100 @@ -1,0 +2,6 @@ +Mon Feb 18 13:11:12 UTC 2019 - [email protected] + +- Fixed "can't modify frozen String" crash (bsc#1125006) +- 4.1.17 + +------------------------------------------------------------------- Old: ---- yast2-registration-4.1.16.tar.bz2 New: ---- yast2-registration-4.1.17.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-registration.spec ++++++ --- /var/tmp/diff_new_pack.6rZpxB/_old 2019-02-24 18:03:39.139769431 +0100 +++ /var/tmp/diff_new_pack.6rZpxB/_new 2019-02-24 18:03:39.139769431 +0100 @@ -17,7 +17,7 @@ Name: yast2-registration -Version: 4.1.16 +Version: 4.1.17 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-registration-4.1.16.tar.bz2 -> yast2-registration-4.1.17.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.1.16/package/yast2-registration.changes new/yast2-registration-4.1.17/package/yast2-registration.changes --- old/yast2-registration-4.1.16/package/yast2-registration.changes 2019-02-04 17:17:45.000000000 +0100 +++ new/yast2-registration-4.1.17/package/yast2-registration.changes 2019-02-19 16:20:08.000000000 +0100 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Feb 18 13:11:12 UTC 2019 - [email protected] + +- Fixed "can't modify frozen String" crash (bsc#1125006) +- 4.1.17 + +------------------------------------------------------------------- Fri Feb 1 12:18:35 UTC 2019 - [email protected] - Improved the message in the registration skipping dialog diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.1.16/package/yast2-registration.spec new/yast2-registration-4.1.17/package/yast2-registration.spec --- old/yast2-registration-4.1.16/package/yast2-registration.spec 2019-02-04 17:17:45.000000000 +0100 +++ new/yast2-registration-4.1.17/package/yast2-registration.spec 2019-02-19 16:20:08.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-registration -Version: 4.1.16 +Version: 4.1.17 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.1.16/src/lib/registration/ui/not_installed_products_dialog.rb new/yast2-registration-4.1.17/src/lib/registration/ui/not_installed_products_dialog.rb --- old/yast2-registration-4.1.16/src/lib/registration/ui/not_installed_products_dialog.rb 2019-02-04 17:17:45.000000000 +0100 +++ new/yast2-registration-4.1.17/src/lib/registration/ui/not_installed_products_dialog.rb 2019-02-19 16:20:08.000000000 +0100 @@ -44,8 +44,6 @@ REGISTRATION_CHECK_MSG = N_("Checking registration status") - attr_accessor :registration, :registration_ui - def self.run dialog = NotInstalledProductsDialog.new dialog.run @@ -53,9 +51,6 @@ def initialize textdomain "registration" - - self.registration = Registration.new(UrlHelpers.registration_url) - self.registration_ui = RegistrationUI.new(registration) end def run @@ -74,6 +69,14 @@ private + def registration + @registration ||= Registration.new(UrlHelpers.registration_url) + end + + def registration_ui + @registration_ui ||= RegistrationUI.new(registration) + end + def content VBox( MinWidth(80, @@ -152,11 +155,11 @@ # not installed. (1/2) summary = _("<p>The addons listed below are registered but not installed: </p>") - summary << "<ul>#{not_installed_addon_names.map { |a| "<li>#{a}</li>" }.join("")}</ul>" + summary += "<ul>#{not_installed_addon_names.map { |a| "<li>#{a}</li>" }.join("")}</ul>" # TRANSLATORS: A RichText warning about all the products registered but # not installed. (2/2) - summary << _("<p>It's preferable to <b>deactivate</b> your products at your " \ + summary += _("<p>It's preferable to <b>deactivate</b> your products at your " \ "registration server if you don't plan to use them anymore.</p>") summary diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.1.16/test/registration/ui/not_installed_products_dialog.rb new/yast2-registration-4.1.17/test/registration/ui/not_installed_products_dialog.rb --- old/yast2-registration-4.1.16/test/registration/ui/not_installed_products_dialog.rb 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-registration-4.1.17/test/registration/ui/not_installed_products_dialog.rb 2019-02-19 16:20:08.000000000 +0100 @@ -0,0 +1,54 @@ +#!/usr/bin/env rspec +# ------------------------------------------------------------------------------ +# Copyright (c) 2018 SUSE LLC, All Rights Reserved. +# +# This program is free software; you can redistribute it and/or modify it under +# the terms of version 2 of the GNU General Public License as published by the +# Free Software Foundation. +# +# This program is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS +# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. +# ------------------------------------------------------------------------------ + +require_relative "../../spec_helper" +require "registration/ui/not_installed_products_dialog" + +describe Registration::UI::NotInstalledProductsDialog do + describe "#run" do + before do + allow(Yast::UI).to receive(:OpenDialog) + allow(Yast::UI).to receive(:CloseDialog) + allow(Yast::UI).to receive(:SetFocus) + + allow(Yast::Popup).to receive(:Feedback).and_yield + allow(subject).to receive(:handle_dialog) + + # the translated strings are frozen + allow(subject).to receive(:_), &:freeze + end + + context "when there is a registered but not installed product" do + before do + allow(Registration::Addon).to receive(:registered_not_installed).and_return( + [ + double(name: "not_installed_product") + ] + ) + end + + it "displays a product summary popup" do + expect(Yast::UI).to receive(:OpenDialog) do |_opts, content| + # find the RichText widget in the content + term = content.nested_find do |t| + t.respond_to?(:value) && t.value == :RichText + end + + expect(term.params[1]).to match(/registered but not installed: .*not_installed_product/) + end + + subject.run + end + end + end +end
