Hello community, here is the log from the commit of package lollypop for openSUSE:Factory checked in at 2019-02-28 21:44:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lollypop (Old) and /work/SRC/openSUSE:Factory/.lollypop.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lollypop" Thu Feb 28 21:44:27 2019 rev:69 rq:679941 version:0.9.923 Changes: -------- --- /work/SRC/openSUSE:Factory/lollypop/lollypop.changes 2019-02-26 22:22:16.422068869 +0100 +++ /work/SRC/openSUSE:Factory/.lollypop.new.28833/lollypop.changes 2019-02-28 21:44:32.189496067 +0100 @@ -1,0 +2,10 @@ +Wed Feb 27 18:10:56 UTC 2019 - [email protected] + +- Update to version 0.9.923: + * Fix a crash when adding a track to a playlist + (glgo#World/lollypop#1684). + * Update icons using colors of the GNOME palette. + * Replace Ctrl+s with Ctrl+, for accessing settings + (glgo#World/lollypop#1623). + +------------------------------------------------------------------- Old: ---- lollypop-0.9.922.tar.xz New: ---- lollypop-0.9.923.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lollypop.spec ++++++ --- /var/tmp/diff_new_pack.Fw6kG1/_old 2019-02-28 21:44:32.733495835 +0100 +++ /var/tmp/diff_new_pack.Fw6kG1/_new 2019-02-28 21:44:32.733495835 +0100 @@ -17,7 +17,7 @@ Name: lollypop -Version: 0.9.922 +Version: 0.9.923 Release: 0 Summary: GNOME music playing application License: GPL-3.0-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.Fw6kG1/_old 2019-02-28 21:44:32.761495823 +0100 +++ /var/tmp/diff_new_pack.Fw6kG1/_new 2019-02-28 21:44:32.761495823 +0100 @@ -1,7 +1,7 @@ <services> <service mode="disabled" name="tar_scm"> <param name="changesgenerate">enable</param> - <param name="revision">0.9.922</param> + <param name="revision">0.9.923</param> <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> <param name="versionformat">@PARENT_TAG@</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.Fw6kG1/_old 2019-02-28 21:44:32.773495817 +0100 +++ /var/tmp/diff_new_pack.Fw6kG1/_new 2019-02-28 21:44:32.773495817 +0100 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> - <param name="changesrevision">1234f9b9e90d25be6d2ed277d8601ce42da0d98d</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">e104f4356cc91ef45078c888aeae8e76c3dbff42</param></service></servicedata> \ No newline at end of file ++++++ lollypop-0.9.922.tar.xz -> lollypop-0.9.923.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.922/data/Shortcuts.ui new/lollypop-0.9.923/data/Shortcuts.ui --- old/lollypop-0.9.922/data/Shortcuts.ui 2019-02-25 16:34:22.000000000 +0100 +++ new/lollypop-0.9.923/data/Shortcuts.ui 2019-02-27 18:12:43.000000000 +0100 @@ -15,7 +15,7 @@ <object class="GtkShortcutsShortcut"> <property name="visible">True</property> <property name="title" translatable="yes" context="shortcut window">Settings</property> - <property name="accelerator"><Primary>S</property> + <property name="accelerator"><Primary>,</property> </object> </child> <child> Binary files old/lollypop-0.9.922/data/icons/hicolor/16x16/apps/org.gnome.Lollypop.png and new/lollypop-0.9.923/data/icons/hicolor/16x16/apps/org.gnome.Lollypop.png differ Binary files old/lollypop-0.9.922/data/icons/hicolor/22x22/apps/org.gnome.Lollypop.png and new/lollypop-0.9.923/data/icons/hicolor/22x22/apps/org.gnome.Lollypop.png differ Binary files old/lollypop-0.9.922/data/icons/hicolor/256x256/apps/org.gnome.Lollypop.png and new/lollypop-0.9.923/data/icons/hicolor/256x256/apps/org.gnome.Lollypop.png differ Binary files old/lollypop-0.9.922/data/icons/hicolor/32x32/apps/org.gnome.Lollypop.png and new/lollypop-0.9.923/data/icons/hicolor/32x32/apps/org.gnome.Lollypop.png differ Binary files old/lollypop-0.9.922/data/icons/hicolor/48x48/apps/org.gnome.Lollypop.png and new/lollypop-0.9.923/data/icons/hicolor/48x48/apps/org.gnome.Lollypop.png differ Binary files old/lollypop-0.9.922/data/icons/hicolor/512x512/apps/org.gnome.Lollypop.png and new/lollypop-0.9.923/data/icons/hicolor/512x512/apps/org.gnome.Lollypop.png differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.922/data/icons/hicolor/scalable/apps/org.gnome.Lollypop.svg new/lollypop-0.9.923/data/icons/hicolor/scalable/apps/org.gnome.Lollypop.svg --- old/lollypop-0.9.922/data/icons/hicolor/scalable/apps/org.gnome.Lollypop.svg 2019-02-25 16:34:22.000000000 +0100 +++ new/lollypop-0.9.923/data/icons/hicolor/scalable/apps/org.gnome.Lollypop.svg 2019-02-27 18:12:43.000000000 +0100 @@ -17,7 +17,7 @@ height="250" id="svg11300" sodipodi:version="0.32" - inkscape:version="0.92.2 2405546, 2018-03-11" + inkscape:version="0.92.4 (unknown)" sodipodi:docname="org.gnome.Lollypop.svg" inkscape:output_extension="org.inkscape.output.svg.inkscape" version="1.0" @@ -34,17 +34,17 @@ inkscape:pageopacity="0" inkscape:pageshadow="2" inkscape:zoom="1.4142136" - inkscape:cx="35.149546" - inkscape:cy="134.8333" - inkscape:current-layer="layer5" + inkscape:cx="18.861702" + inkscape:cy="132.00487" + inkscape:current-layer="g6843" showgrid="false" inkscape:grid-bbox="true" inkscape:document-units="px" inkscape:showpageshadow="false" - inkscape:window-width="1680" - inkscape:window-height="986" - inkscape:window-x="0" - inkscape:window-y="27" + inkscape:window-width="1920" + inkscape:window-height="1043" + inkscape:window-x="1920" + inkscape:window-y="0" width="400px" height="300px" inkscape:snap-nodes="false" @@ -119,29 +119,6 @@ </linearGradient> <radialGradient inkscape:collect="always" - xlink:href="#linearGradient5432" - id="radialGradient5136" - cx="80.386749" - cy="852.18683" - fx="80.386749" - fy="852.18683" - r="109.64706" - gradientUnits="userSpaceOnUse" - gradientTransform="matrix(0.76001888,0.76001888,-0.90000762,0.90000762,785.13388,23.083241)" /> - <linearGradient - id="linearGradient5432" - inkscape:collect="always"> - <stop - id="stop5434" - offset="0" - style="stop-color:#ffbcac;stop-opacity:1" /> - <stop - id="stop5436" - offset="1" - style="stop-color:#ff3677;stop-opacity:1" /> - </linearGradient> - <radialGradient - inkscape:collect="always" xlink:href="#linearGradient4814" id="radialGradient5450" cx="64.786438" @@ -163,27 +140,6 @@ offset="1" id="stop4818" /> </linearGradient> - <linearGradient - inkscape:collect="always" - xlink:href="#linearGradient5436" - id="linearGradient5442" - x1="128" - y1="1031.1857" - x2="127.05883" - y2="815.65631" - gradientUnits="userSpaceOnUse" /> - <linearGradient - inkscape:collect="always" - id="linearGradient5436"> - <stop - style="stop-color:#c50047;stop-opacity:0.57823128" - offset="0" - id="stop5438" /> - <stop - style="stop-color:#ffc1d7;stop-opacity:0.71372551" - offset="1" - id="stop5440" /> - </linearGradient> <clipPath clipPathUnits="userSpaceOnUse" id="clipPath5154"> @@ -320,19 +276,6 @@ y1="233.34361" x2="312.46051" y2="223.41736" /> - <filter - inkscape:collect="always" - style="color-interpolation-filters:sRGB" - id="filter4760" - x="-0.10481427" - width="1.2096285" - y="-0.11000777" - height="1.2200155"> - <feGaussianBlur - inkscape:collect="always" - stdDeviation="9.5771471" - id="feGaussianBlur4762" /> - </filter> </defs> <metadata id="metadata4"> @@ -428,28 +371,19 @@ cy="923.43225" cx="127.91108" id="path5128" - style="opacity:1;fill:url(#radialGradient5136);fill-opacity:1;stroke:none;stroke-width:1.00148869;stroke-opacity:1" /> + style="display:inline;opacity:1;fill:#e73434;fill-opacity:1;stroke:none;stroke-width:1.00148869;stroke-opacity:1" /> <path sodipodi:nodetypes="ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc" id="circle5142" d="m 105.17325,806.18572 c -3.06859,0.56361 -6.11393,1.24721 -9.129005,2.04923 -3.838255,1.06506 -7.62084,2.32142 -11.333578,3.76438 -3.712189,1.44307 -7.34989,3.07087 -10.899472,4.87732 -3.549153,1.80656 -7.005749,3.78947 -10.35684,5.94129 -3.351877,2.15253 -6.593991,4.47137 -9.714191,6.94783 -3.119992,2.47544 -6.114241,5.10535 -8.971529,7.87988 -0.367219,0.38909 -0.731819,0.78065 -1.093777,1.17464 2.60205,17.85956 16.832359,40.03752 30.863064,55.74236 -4.76734,8.84435 -7.265993,18.73329 -7.272057,28.78068 0.02104,2.87431 0.246096,5.7435 0.673482,8.58593 -20.257302,-9.18513 -43.077023,-26.53494 -52.798465,-47.36396 -0.440667,1.15171 -0.863474,2.31018 -1.268271,3.47498 -1.176789,3.80495 -2.162562,7.66637 -2.953625,11.56979 -0.79154,3.90311 -1.3874065,7.84335 -1.7853678,11.80598 -0.39733,3.96334 -0.5961891,7.94407 -0.5958321,11.92728 -4.394e-4,2.81936 0.098928,5.63785 0.2979155,8.45018 0.282275,3.97319 0.763088,7.92978 1.4406374,11.85493 0.625626,3.51826 1.408798,7.00668 2.347153,10.45473 16.778133,6.68355 43.114514,5.45001 63.748015,1.14301 6.818545,11.02763 16.987182,19.58379 29.018153,24.41667 -18.071844,12.93645 -44.490188,24.02095 -67.37308,22.03245 1.384097,1.665 2.813203,3.2921 4.285735,4.8794 2.774977,2.8571 5.691103,5.5737 8.737453,8.1395 3.046107,2.5658 6.218619,4.9777 9.505651,7.2266 3.287242,2.2488 6.684891,4.3319 10.180217,6.2413 3.495379,1.9096 7.084075,3.6433 10.752641,5.1944 3.66896,1.5509 7.413193,2.9174 11.218668,4.0942 1.438565,0.3959 2.884421,0.7648 4.336807,1.1066 14.138748,-11.1844 26.206378,-34.5828 32.780368,-54.56406 12.95816,-0.38251 25.45395,-4.90132 35.65955,-12.89544 2.15922,22.12638 -1.46693,50.5581 -14.64692,69.3832 3.06859,-0.5636 6.11393,-1.2473 9.129,-2.0493 3.83826,-1.0651 7.62084,-2.3214 11.33358,-3.7644 3.71219,-1.4431 7.34989,-3.0709 10.89947,-4.8773 3.54915,-1.8066 7.00575,-3.7895 10.35684,-5.9413 3.35188,-2.1525 6.59399,-4.4714 9.71419,-6.9478 3.11999,-2.4754 6.11424,-5.1054 8.97153,-7.8799 0.36722,-0.3891 0.73182,-0.7806 1.09378,-1.1746 -2.60204,-17.85957 -16.83236,-40.03755 -30.86307,-55.74238 4.76735,-8.84435 7.266,-18.7333 7.27207,-28.78069 -0.021,-2.8743 -0.24611,-5.74349 -0.6735,-8.58592 20.25731,9.18513 43.07704,26.53494 52.79848,47.36396 0.44067,-1.15171 0.86347,-2.31018 1.26827,-3.47499 1.17679,-3.80495 2.16256,-7.66636 2.95362,-11.56978 0.79154,-3.90311 1.38741,-7.84335 1.78537,-11.80598 0.39733,-3.96334 0.59619,-7.94408 0.59583,-11.92729 4.4e-4,-2.81936 -0.0989,-5.63784 -0.29791,-8.45017 -0.28228,-3.97319 -0.76309,-7.92978 -1.44064,-11.85493 -0.62776,-3.53416 -1.41449,-7.03823 -2.35779,-10.50154 -20.56165,-7.32804 -45.89823,-4.79548 -63.74906,-1.11372 -6.81835,-11.01918 -16.98234,-19.56874 -29.00647,-24.39915 18.07184,-12.93645 44.49019,-24.02091 67.37307,-22.03241 -1.38409,-1.66502 -2.8132,-3.2921 -4.28573,-4.87944 -2.77498,-2.85712 -5.6911,-5.57368 -8.73745,-8.13949 -3.04611,-2.56581 -6.21862,-4.97769 -9.50565,-7.22659 -3.28724,-2.24885 -6.68489,-4.3319 -10.18022,-6.24135 -3.49538,-1.90963 -7.08407,-3.64325 -10.75264,-5.19438 -3.66896,-1.55092 -7.41319,-2.91736 -11.21867,-4.09421 -1.42662,-0.39262 -2.86041,-0.75869 -4.30063,-1.09804 -14.14688,11.18369 -26.2293,34.57475 -32.8107,54.55552 -12.96018,0.38127 -25.4582,4.90015 -35.665394,12.89544 -2.15922,-22.12637 1.466931,-50.55807 14.646924,-69.38315 z" - style="opacity:1;fill:url(#radialGradient5450);fill-opacity:1;stroke:none;stroke-opacity:1" + style="display:inline;opacity:1;fill:url(#radialGradient5450);fill-opacity:1;stroke:none;stroke-opacity:1" inkscape:connector-curvature="0" /> - <ellipse - transform="matrix(1.0878997,0,0,1.0878997,-11.25116,-82.269989)" - ry="104.47059" - rx="109.64706" - clip-path="url(#clipPath5154)" - style="opacity:0.36363639;fill:none;fill-opacity:1;stroke:url(#linearGradient5442);stroke-width:16.0961895;stroke-opacity:1;filter:url(#filter4760)" - id="circle5150" - cx="128" - cy="924.36218" /> <path sodipodi:nodetypes="ccccccccccc" inkscape:connector-curvature="0" id="path6015" d="m 106.16138,887.65367 c -2.31266,-0.054 -4.2168,1.80513 -4.21754,4.11776 v 33.62193 33.62192 c -3e-5,3.17143 3.43384,5.15384 6.18143,3.56859 l 29.1243,-16.81096 29.12631,-16.81097 c 2.74619,-1.58612 2.74619,-5.54903 0,-7.13515 l -29.12631,-16.81096 -29.1243,-16.81097 c -0.5981,-0.34534 -1.2734,-0.53488 -1.96389,-0.55119 z" - style="color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:sans-serif;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;baseline-shift:baseline;text-anchor:start;white-space:normal;clip-rule:nonzero;display:inline;overflow:visible;visibility:visible;opacity:1;isolation:auto;mix-blend-mode:normal;color-interpolation:sRGB;color-interpolation-filters:linearRGB;solid-color:#000000;solid-opacity:1;fill:#ff3878;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;color-rendering:auto;image-rendering:auto;shape-rendering:auto;text-rendering:auto;enable-background:accumulate" /> + style="color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:sans-serif;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;baseline-shift:baseline;text-anchor:start;white-space:normal;clip-rule:nonzero;display:inline;overflow:visible;visibility:visible;opacity:1;isolation:auto;mix-blend-mode:normal;color-interpolation:sRGB;color-interpolation-filters:linearRGB;solid-color:#000000;solid-opacity:1;fill:#e73434;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;color-rendering:auto;image-rendering:auto;shape-rendering:auto;text-rendering:auto;enable-background:accumulate" /> </g> </g> </g> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.922/lollypop/widgets_playlist.py new/lollypop-0.9.923/lollypop/widgets_playlist.py --- old/lollypop-0.9.922/lollypop/widgets_playlist.py 2019-02-25 16:34:22.000000000 +0100 +++ new/lollypop-0.9.923/lollypop/widgets_playlist.py 2019-02-27 18:12:43.000000000 +0100 @@ -165,7 +165,7 @@ """ length = len(self.children) position = length + 1 - widgets = {self.__tracks_widget_left: ([Track(track_id)], position)} + widgets = {self.__tracks_widget_right: [(Track(track_id), position)]} self.__add_tracks(OrderedDict(widgets)) self.__make_homogeneous() @@ -236,11 +236,11 @@ self.__tracks_widget_left.remove(child) self.__tracks_widget_right.insert(child, 0) - def __add_tracks(self, widgets): + def __add_tracks(self, widgets, previous_tracks=[]): """ Add tracks to list @param widgets as OrderedDict - @param previous_row as Row + @internal previous_tracks """ if self.__cancellable.is_cancelled(): return @@ -251,15 +251,18 @@ tracks = widgets[widget] if not tracks: - # Link last left and first right - left_children = self.__tracks_widget_left.get_children() - right_children = self.__tracks_widget_right.get_children() - if left_children and right_children: - last_left = left_children[-1] - first_right = right_children[0] - last_left.set_next_row(first_right) - first_right.set_previous_row(last_left) - self.emit("populated") + if not previous_tracks: + # Link last left and first right + left_children = self.__tracks_widget_left.get_children() + right_children = self.__tracks_widget_right.get_children() + if left_children and right_children: + last_left = left_children[-1] + first_right = right_children[0] + last_left.set_next_row(first_right) + first_right.set_previous_row(last_left) + self.emit("populated") + else: + GLib.idle_add(self.__add_tracks, widgets, tracks) return (track, position) = tracks.pop(0) track.set_number(position + 1) @@ -275,7 +278,7 @@ row.connect("do-selection", self.__on_do_selection) row.show() widget.insert(row, position) - GLib.idle_add(self.__add_tracks, widgets) + GLib.idle_add(self.__add_tracks, widgets, tracks) def __on_size_allocate(self, widget, allocation): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.922/lollypop/widgets_row.py new/lollypop-0.9.923/lollypop/widgets_row.py --- old/lollypop-0.9.922/lollypop/widgets_row.py 2019-02-25 16:34:22.000000000 +0100 +++ new/lollypop-0.9.923/lollypop/widgets_row.py 2019-02-27 18:12:43.000000000 +0100 @@ -225,6 +225,8 @@ """ def on_closed(widget): self.get_style_context().remove_class("track-menu-selected") + self.set_indicator(App().player.current_track.id == self._track.id, + self._track.loved) from lollypop.pop_menu import TrackMenuPopover, RemoveMenuPopover if self.get_state_flags() & Gtk.StateFlags.SELECTED: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.922/lollypop/window.py new/lollypop-0.9.923/lollypop/window.py --- old/lollypop-0.9.922/lollypop/window.py 2019-02-25 16:34:22.000000000 +0100 +++ new/lollypop-0.9.923/lollypop/window.py 2019-02-27 18:12:43.000000000 +0100 @@ -132,7 +132,7 @@ ["<Control><Alt>a"]) App().set_accels_for_action("app.shortcut::show_sidebar", ["F9"]) App().set_accels_for_action("app.update_db", ["<Control>u"]) - App().set_accels_for_action("app.settings(-14)", ["<Control>s"]) + App().set_accels_for_action("app.settings(-14)", ["<Control>comma"]) App().set_accels_for_action("app.fullscreen", ["F11", "F7"]) App().set_accels_for_action("app.mini", ["<Control>m"]) App().set_accels_for_action("app.about", ["F3"]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.922/meson.build new/lollypop-0.9.923/meson.build --- old/lollypop-0.9.922/meson.build 2019-02-25 16:34:22.000000000 +0100 +++ new/lollypop-0.9.923/meson.build 2019-02-27 18:12:43.000000000 +0100 @@ -1,5 +1,5 @@ project('lollypop', - version: '0.9.922', + version: '0.9.923', meson_version: '>= 0.40.0' ) i18n = import('i18n')
