Hello community,

here is the log from the commit of package sblim-sfcb for openSUSE:Factory 
checked in at 2019-03-01 16:48:24
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/sblim-sfcb (Old)
 and      /work/SRC/openSUSE:Factory/.sblim-sfcb.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "sblim-sfcb"

Fri Mar  1 16:48:24 2019 rev:55 rq:680077 version:1.4.9

Changes:
--------
--- /work/SRC/openSUSE:Factory/sblim-sfcb/sblim-sfcb.changes    2018-05-17 
18:05:26.371834293 +0200
+++ /work/SRC/openSUSE:Factory/.sblim-sfcb.new.28833/sblim-sfcb.changes 
2019-03-01 16:48:27.785775546 +0100
@@ -1,0 +2,12 @@
+Fri Feb 22 07:15:56 UTC 2019 - Franck Bui <[email protected]>
+
+- Drop use of $FIRST_ARG in .spec
+
+  The use of $FIRST_ARG was probably required because of the
+  %service_* rpm macros were playing tricks with the shell positional
+  parameters. This is bad practice and error prones so let's assume
+  that no macros should do that anymore and hence it's safe to assume
+  that positional parameters remains unchanged after any rpm macro
+  call.
+
+-------------------------------------------------------------------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ sblim-sfcb.spec ++++++
--- /var/tmp/diff_new_pack.PlKBNu/_old  2019-03-01 16:48:28.985775094 +0100
+++ /var/tmp/diff_new_pack.PlKBNu/_new  2019-03-01 16:48:28.985775094 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package sblim-sfcb
 #
-# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -12,7 +12,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
@@ -302,7 +302,6 @@
 %endif
 
 %post
-test -n "$FIRST_ARG" || FIRST_ARG=$1
 %if 0%{?has_systemd}
 %service_add_post sblim-sfcb.service
 %else
@@ -312,7 +311,7 @@
 %{fillup_and_insserv -f sfcb}
 %endif
 %endif
-if test "$FIRST_ARG" -eq 1 ; then
+if test $1 -eq 1 ; then
    sfcbrepos -f 2> /dev/null || :
 fi
 # else we do it in postun instead.
@@ -327,9 +326,8 @@
 %endif
 
 %postun
-test -n "$FIRST_ARG" || FIRST_ARG=$1
 /sbin/ldconfig
-if test "$FIRST_ARG" -ge 1 ; then
+if test $1 -ge 1 ; then
    sfcbrepos -f 2> /dev/null || :
 fi
 %if 0%{?has_systemd}


Reply via email to