Hello community, here is the log from the commit of package threadweaver for openSUSE:Factory checked in at 2019-03-21 09:50:42 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/threadweaver (Old) and /work/SRC/openSUSE:Factory/.threadweaver.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "threadweaver" Thu Mar 21 09:50:42 2019 rev:64 rq:686787 version:5.56.0 Changes: -------- --- /work/SRC/openSUSE:Factory/threadweaver/threadweaver.changes 2019-02-28 21:33:48.549726886 +0100 +++ /work/SRC/openSUSE:Factory/.threadweaver.new.28833/threadweaver.changes 2019-03-21 09:50:46.578829809 +0100 @@ -1,0 +2,10 @@ +Sun Mar 10 20:15:38 UTC 2019 - [email protected] + +- Update to 5.56.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.56.0.php +- Changes since 5.55.0: + * Make it compile without foreach + +------------------------------------------------------------------- Old: ---- threadweaver-5.55.0.tar.xz New: ---- threadweaver-5.56.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ threadweaver.spec ++++++ --- /var/tmp/diff_new_pack.f9Iy1Y/_old 2019-03-21 09:50:47.586829536 +0100 +++ /var/tmp/diff_new_pack.f9Iy1Y/_new 2019-03-21 09:50:47.590829535 +0100 @@ -17,13 +17,13 @@ %define lname libKF5ThreadWeaver5 -%define _tar_path 5.55 +%define _tar_path 5.56 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: threadweaver -Version: 5.55.0 +Version: 5.56.0 Release: 0 Summary: KDE Helper for multithreaded programming License: LGPL-2.1-or-later ++++++ threadweaver-5.55.0.tar.xz -> threadweaver-5.56.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/threadweaver-5.55.0/CMakeLists.txt new/threadweaver-5.56.0/CMakeLists.txt --- old/threadweaver-5.55.0/CMakeLists.txt 2019-02-02 18:25:44.000000000 +0100 +++ new/threadweaver-5.56.0/CMakeLists.txt 2019-03-02 14:32:08.000000000 +0100 @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.55.0") # handled by release scripts +set(KF5_VERSION "5.56.0") # handled by release scripts project(ThreadWeaver VERSION ${KF5_VERSION}) include(FeatureSummary) -find_package(ECM 5.55.0 NO_MODULE) +find_package(ECM 5.56.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -34,7 +34,8 @@ PACKAGE_VERSION_FILE "${CMAKE_CURRENT_BINARY_DIR}/KF5ThreadWeaverConfigVersion.cmake" SOVERSION 5) # -- - +add_definitions(-DQT_NO_FOREACH) +#add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x060000) add_subdirectory(src) if (BUILD_TESTING) add_subdirectory(autotests) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/threadweaver-5.55.0/autotests/JobTests.cpp new/threadweaver-5.56.0/autotests/JobTests.cpp --- old/threadweaver-5.55.0/autotests/JobTests.cpp 2019-02-02 18:25:44.000000000 +0100 +++ new/threadweaver-5.56.0/autotests/JobTests.cpp 2019-03-02 14:32:08.000000000 +0100 @@ -800,7 +800,8 @@ AppendCharacterJob g('g', &sequence); Collection collection; collection << a << b << c << d << e << f << g; - Q_FOREACH(AppendCharacterJob* job, QList<AppendCharacterJob*>() << &a << &b << &c << &d << &e << &f << &g) { + const QList<AppendCharacterJob*> lstJob = { &a, &b, &c, &d, &e, &f, &g }; + for (AppendCharacterJob* job : lstJob) { QMutexLocker l(job->mutex()); job->assignQueuePolicy(&restriction); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/threadweaver-5.55.0/benchmarks/QueueBenchmarks.cpp new/threadweaver-5.56.0/benchmarks/QueueBenchmarks.cpp --- old/threadweaver-5.55.0/benchmarks/QueueBenchmarks.cpp 2019-02-02 18:25:44.000000000 +0100 +++ new/threadweaver-5.56.0/benchmarks/QueueBenchmarks.cpp 2019-03-02 14:32:08.000000000 +0100 @@ -294,8 +294,8 @@ const QList<int> threads = singleThreaded ? QList<int>() << 1 : QList<int>() << 1 << 2 << 4 << 8 << 16 << 32 << 64 << 128; const QList<int> ms = QList<int>() << 1 << 10 << 100 << 1000 << 10000 << 100000; - Q_FOREACH (int m, ms) { - Q_FOREACH (int t, threads) { + for (int m : ms) { + for (int t : threads) { const QString name = QString::fromLatin1("%1 threads, %2 values").arg(t).arg(m); // newRow expects const char*, but then qstrdup's it in the QTestData constructor. Eeeew. QTest::newRow(qPrintable(name)) << m << 256 << 256 << t; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/threadweaver-5.55.0/examples/ThumbNailer/Model.cpp new/threadweaver-5.56.0/examples/ThumbNailer/Model.cpp --- old/threadweaver-5.55.0/examples/ThumbNailer/Model.cpp 2019-02-02 18:25:44.000000000 +0100 +++ new/threadweaver-5.56.0/examples/ThumbNailer/Model.cpp 2019-03-02 14:32:08.000000000 +0100 @@ -158,7 +158,7 @@ queue.flush(); Queue::instance()->finish(); // figure out result: - foreach (const Image& image, m_images) { + for (const Image& image : qAsConst(m_images)) { if (image.progress().first != Image::Step_NumberOfSteps) return false; } return true; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/threadweaver-5.55.0/src/weaver.cpp new/threadweaver-5.56.0/src/weaver.cpp --- old/threadweaver-5.55.0/src/weaver.cpp 2019-02-02 18:25:44.000000000 +0100 +++ new/threadweaver-5.56.0/src/weaver.cpp 2019-03-02 14:32:08.000000000 +0100 @@ -224,7 +224,7 @@ if (jobs.isEmpty()) { return; } - Q_FOREACH (const JobPointer &job, jobs) { + for (const JobPointer &job : jobs) { if (job) { Q_ASSERT(job->status() == Job::Status_New); adjustInventory(jobs.size()); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/threadweaver-5.55.0/src/weaver_p.cpp new/threadweaver-5.56.0/src/weaver_p.cpp --- old/threadweaver-5.55.0/src/weaver_p.cpp 2019-02-02 18:25:44.000000000 +0100 +++ new/threadweaver-5.56.0/src/weaver_p.cpp 2019-03-02 14:32:08.000000000 +0100 @@ -117,7 +117,7 @@ void Weaver_Private::deleteExpiredThreads() { Q_ASSERT(!mutex->tryLock()); //mutex has to be held when this method is called - foreach (Thread* thread, expiredThreads) { + for (Thread* thread : qAsConst(expiredThreads)) { thread->wait(); delete thread; }
