Hello community, here is the log from the commit of package libXrandr for openSUSE:Factory checked in at 2019-03-26 22:29:25 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libXrandr (Old) and /work/SRC/openSUSE:Factory/.libXrandr.new.25356 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libXrandr" Tue Mar 26 22:29:25 2019 rev:16 rq:687587 version:1.5.2 Changes: -------- --- /work/SRC/openSUSE:Factory/libXrandr/libXrandr.changes 2017-11-30 12:33:37.183599664 +0100 +++ /work/SRC/openSUSE:Factory/.libXrandr.new.25356/libXrandr.changes 2019-03-26 22:29:26.889748851 +0100 @@ -1,0 +2,13 @@ +Fri Mar 22 11:00:39 UTC 2019 - Stefan Dirsch <sndir...@suse.com> + +- Update to version 1.5.2 + * autogen: add default patch prefix + * autogen.sh: use quoted string variables + * autogen.sh: use exec instead of waiting for configure to finish + * Update configure.ac bug URL for gitlab migration + * Fix memory leak on error paths + * Add description of libXrandr to README.md + * Update README for gitlab migration +- supersedes U_libXrandr_fix-memory-leak.patch + +------------------------------------------------------------------- Old: ---- U_libXrandr_fix-memory-leak.patch libXrandr-1.5.1.tar.bz2 New: ---- libXrandr-1.5.2.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libXrandr.spec ++++++ --- /var/tmp/diff_new_pack.qnJ1LY/_old 2019-03-26 22:29:28.281748516 +0100 +++ /var/tmp/diff_new_pack.qnJ1LY/_new 2019-03-26 22:29:28.317748507 +0100 @@ -1,7 +1,7 @@ # # spec file for package libXrandr # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -18,7 +18,7 @@ Name: libXrandr %define lname libXrandr2 -Version: 1.5.1 +Version: 1.5.2 Release: 0 Summary: X Resize, Rotate and Reflection extension library License: MIT @@ -29,7 +29,6 @@ #Git-Web: http://cgit.freedesktop.org/xorg/lib/libXrandr/ Source: http://xorg.freedesktop.org/releases/individual/lib/%{name}-%{version}.tar.bz2 Source1: baselibs.conf -Patch: U_libXrandr_fix-memory-leak.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build #git#BuildRequires: autoconf >= 2.60, automake, libtool @@ -72,7 +71,6 @@ %prep %setup -q -%patch -p1 %build #git#autoreconf -fi ++++++ libXrandr-1.5.1.tar.bz2 -> libXrandr-1.5.2.tar.bz2 ++++++ ++++ 26360 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/ChangeLog new/libXrandr-1.5.2/ChangeLog --- old/libXrandr-1.5.1/ChangeLog 2016-10-04 22:23:09.000000000 +0200 +++ new/libXrandr-1.5.2/ChangeLog 2019-03-16 21:57:47.000000000 +0100 @@ -1,3 +1,78 @@ +commit 55dcda4518eda8ae03ef25ea29d3c994ad71eb0a +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Mar 16 13:54:20 2019 -0700 + + libXrandr 1.5.2 + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 2a03e8d069fce635981aad248e1cab14ed93e176 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Mar 16 13:53:42 2019 -0700 + + Add description of libXrandr to README.md + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 583d4f114d36e4df87ba3ed1201acae4aefb68dc +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Fri Dec 7 19:48:28 2018 -0800 + + Update configure.ac bug URL for gitlab migration + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 08fab8367ea5357314d1c54edac04bc6a38da074 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Mon Nov 19 22:35:01 2018 -0800 + + Update README for gitlab migration + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 87227e5fc79750d3eccc3c3482a3c5b3f2af2e90 +Author: Tobias Stoeckmann <tob...@stoeckmann.org> +Date: Sat Jan 28 15:37:57 2017 +0100 + + Fix memory leak on error paths + + Introduced in commit a0df3e1c7728205e5c7650b2e6dce684139254a6 "Avoid out + of boundary accesses on illegal responses" + + Signed-off-by: Julien Cristau <jcris...@debian.org> + +commit 5fb14f7a2c6da81c8e6bb325b354141233ab7d0a +Author: Mihail Konev <k....@ya.ru> +Date: Thu Jan 26 13:52:49 2017 +1000 + + autogen: add default patch prefix + + Signed-off-by: Mihail Konev <k....@ya.ru> + +commit e0303d9c61d55081ffe4365a24107d851f457948 +Author: Emil Velikov <emil.l.veli...@gmail.com> +Date: Mon Mar 9 12:00:52 2015 +0000 + + autogen.sh: use quoted string variables + + Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent + fall-outs, when they contain space. + + Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> + Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> + Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> + +commit f26e07fa0fdb7f5cb5c82a3bb0ab5494fe3faa29 +Author: Peter Hutterer <peter.hutte...@who-t.net> +Date: Tue Jan 24 10:32:07 2017 +1000 + + autogen.sh: use exec instead of waiting for configure to finish + + Syncs the invocation of configure with the one from the server. + + Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> + Reviewed-by: Emil Velikov <emil.veli...@collabora.com> + commit 54ac1eb5d14636002b018607227c6d52cca0b754 Author: Matthieu Herrb <matthieu.he...@laas.fr> Date: Tue Oct 4 21:23:23 2016 +0200 @@ -871,7 +946,7 @@ Conflicts: - src/Xrandr.c + src/Xrandr.c commit 00f2e30d0b8296668776d62a4c47f96bf95faa08 Author: Julien Cristau <jcris...@debian.org> @@ -1050,9 +1125,9 @@ Fix read sizes for 64-bit machines. Be consistent in variable usage: - nbytes = network byte length. - rbytes = memory byte length. - nbytesRead = actual network bytes read. + nbytes = network byte length. + rbytes = memory byte length. + nbytesRead = actual network bytes read. Malloc rbytes data to pass to _XRead*, but use nbytes as the amount of data to read (yes, this is insane, welcome to Xlib). Some of this patch is semi-gratuitous, but the goal is to be consistent @@ -1111,7 +1186,7 @@ Conflicts: - configure.ac + configure.ac commit 0dba1be7969aa56f934d93889cbd589b3dafd3d4 Author: Keith Packard <kei...@neko.keithp.com> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/INSTALL new/libXrandr-1.5.2/INSTALL --- old/libXrandr-1.5.1/INSTALL 2016-10-04 22:23:09.000000000 +0200 +++ new/libXrandr-1.5.2/INSTALL 2019-03-16 21:57:47.000000000 +0100 @@ -1,11 +1,13 @@ Installation Instructions ************************* -Copyright (C) 1994, 1995, 1996, 1999, 2000, 2001, 2002, 2004, 2005, -2006, 2007, 2008 Free Software Foundation, Inc. +Copyright (C) 1994-1996, 1999-2002, 2004-2011 Free Software Foundation, +Inc. - This file is free documentation; the Free Software Foundation gives -unlimited permission to copy, distribute and modify it. + Copying and distribution of this file, with or without modification, +are permitted in any medium without royalty provided the copyright +notice and this notice are preserved. This file is offered as-is, +without warranty of any kind. Basic Installation ================== @@ -13,7 +15,11 @@ Briefly, the shell commands `./configure; make; make install' should configure, build, and install this package. The following more-detailed instructions are generic; see the `README' file for -instructions specific to this package. +instructions specific to this package. Some packages provide this +`INSTALL' file but do not implement all of the features documented +below. The lack of an optional feature in a given package is not +necessarily a bug. More recommendations for GNU packages can be found +in *note Makefile Conventions: (standards)Makefile Conventions. The `configure' shell script attempts to guess correct values for various system-dependent variables used during compilation. It uses @@ -42,7 +48,7 @@ you want to change it or regenerate `configure' using a newer version of `autoconf'. -The simplest way to compile this package is: + The simplest way to compile this package is: 1. `cd' to the directory containing the package's source code and type `./configure' to configure the package for your system. @@ -53,12 +59,22 @@ 2. Type `make' to compile the package. 3. Optionally, type `make check' to run any self-tests that come with - the package. + the package, generally using the just-built uninstalled binaries. 4. Type `make install' to install the programs and any data files and - documentation. + documentation. When installing into a prefix owned by root, it is + recommended that the package be configured and built as a regular + user, and only the `make install' phase executed with root + privileges. + + 5. Optionally, type `make installcheck' to repeat any self-tests, but + this time using the binaries in their final installed location. + This target does not install anything. Running this target as a + regular user, particularly if the prior `make install' required + root privileges, verifies that the installation completed + correctly. - 5. You can remove the program binaries and object files from the + 6. You can remove the program binaries and object files from the source code directory by typing `make clean'. To also remove the files that `configure' created (so you can compile the package for a different kind of computer), type `make distclean'. There is @@ -67,8 +83,15 @@ all sorts of other programs in order to regenerate files that came with the distribution. - 6. Often, you can also type `make uninstall' to remove the installed - files again. + 7. Often, you can also type `make uninstall' to remove the installed + files again. In practice, not all packages have tested that + uninstallation works correctly, even though it is required by the + GNU Coding Standards. + + 8. Some packages, particularly those that use Automake, provide `make + distcheck', which can by used by developers to test that all other + targets like `make install' and `make uninstall' work correctly. + This target is generally not run by end users. Compilers and Options ===================== @@ -93,7 +116,8 @@ own directory. To do this, you can use GNU `make'. `cd' to the directory where you want the object files and executables to go and run the `configure' script. `configure' automatically checks for the -source code in the directory that `configure' is in and in `..'. +source code in the directory that `configure' is in and in `..'. This +is known as a "VPATH" build. With a non-GNU `make', it is safer to compile the package for one architecture at a time in the source code directory. After you have @@ -120,7 +144,8 @@ By default, `make install' installs the package's commands under `/usr/local/bin', include files under `/usr/local/include', etc. You can specify an installation prefix other than `/usr/local' by giving -`configure' the option `--prefix=PREFIX'. +`configure' the option `--prefix=PREFIX', where PREFIX must be an +absolute file name. You can specify separate installation prefixes for architecture-specific files and architecture-independent files. If you @@ -131,15 +156,46 @@ In addition, if you use an unusual directory layout you can give options like `--bindir=DIR' to specify different values for particular kinds of files. Run `configure --help' for a list of the directories -you can set and what kinds of files go in them. +you can set and what kinds of files go in them. In general, the +default for these options is expressed in terms of `${prefix}', so that +specifying just `--prefix' will affect all of the other directory +specifications that were not explicitly provided. + + The most portable way to affect installation locations is to pass the +correct locations to `configure'; however, many packages provide one or +both of the following shortcuts of passing variable assignments to the +`make install' command line to change installation locations without +having to reconfigure or recompile. + + The first method involves providing an override variable for each +affected directory. For example, `make install +prefix=/alternate/directory' will choose an alternate location for all +directory configuration variables that were expressed in terms of +`${prefix}'. Any directories that were specified during `configure', +but not in terms of `${prefix}', must each be overridden at install +time for the entire installation to be relocated. The approach of +makefile variable overrides for each directory variable is required by +the GNU Coding Standards, and ideally causes no recompilation. +However, some platforms have known limitations with the semantics of +shared libraries that end up requiring recompilation when using this +method, particularly noticeable in packages that use GNU Libtool. + + The second method involves providing the `DESTDIR' variable. For +example, `make install DESTDIR=/alternate/directory' will prepend +`/alternate/directory' before all installation names. The approach of +`DESTDIR' overrides is not required by the GNU Coding Standards, and +does not work on platforms that have drive letters. On the other hand, +it does better at avoiding recompilation issues, and works well even +when some directory options were not specified in terms of `${prefix}' +at `configure' time. + +Optional Features +================= If the package supports it, you can cause programs to be installed with an extra prefix or suffix on their names by giving `configure' the option `--program-prefix=PREFIX' or `--program-suffix=SUFFIX'. -Optional Features -================= - Some packages pay attention to `--enable-FEATURE' options to `configure', where FEATURE indicates an optional part of the package. They may also pay attention to `--with-PACKAGE' options, where PACKAGE @@ -152,6 +208,13 @@ you can use the `configure' options `--x-includes=DIR' and `--x-libraries=DIR' to specify their locations. + Some packages offer the ability to configure how verbose the +execution of `make' will be. For these packages, running `./configure +--enable-silent-rules' sets the default to minimal output, which can be +overridden with `make V=1'; while running `./configure +--disable-silent-rules' sets the default to verbose, which can be +overridden with `make V=0'. + Particular systems ================== @@ -159,10 +222,15 @@ CC is not installed, it is recommended to use the following options in order to use an ANSI C compiler: - ./configure CC="cc -Ae" + ./configure CC="cc -Ae -D_XOPEN_SOURCE=500" and if that doesn't work, install pre-built binaries of GCC for HP-UX. + HP-UX `make' updates targets which have the same time stamps as +their prerequisites, which makes it generally unusable when shipped +generated files such as `configure' are involved. Use GNU `make' +instead. + On OSF/1 a.k.a. Tru64, some versions of the default C compiler cannot parse its `<wchar.h>' header file. The option `-nodtk' can be used as a workaround. If GNU CC is not installed, it is therefore recommended @@ -174,6 +242,16 @@ ./configure CC="cc -nodtk" + On Solaris, don't put `/usr/ucb' early in your `PATH'. This +directory contains several dysfunctional programs; working variants of +these programs are available in `/usr/bin'. So, if you need `/usr/ucb' +in your `PATH', put it _after_ `/usr/bin'. + + On Haiku, software installed for all users goes in `/boot/common', +not `/usr/local'. It is recommended to use the following options: + + ./configure --prefix=/boot/common + Specifying the System Type ========================== @@ -189,7 +267,8 @@ where SYSTEM can have one of these forms: - OS KERNEL-OS + OS + KERNEL-OS See the file `config.sub' for the possible values of each field. If `config.sub' isn't included in this package, then this package doesn't @@ -277,7 +356,7 @@ `configure' can determine that directory automatically. `--prefix=DIR' - Use DIR as the installation prefix. *Note Installation Names:: + Use DIR as the installation prefix. *note Installation Names:: for more details, including other options available for fine-tuning the installation locations. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/Makefile.am new/libXrandr-1.5.2/Makefile.am --- old/libXrandr-1.5.1/Makefile.am 2016-08-17 14:58:28.000000000 +0200 +++ new/libXrandr-1.5.2/Makefile.am 2019-03-16 21:57:31.000000000 +0100 @@ -35,3 +35,5 @@ $(CHANGELOG_CMD) dist-hook: ChangeLog INSTALL + +EXTRA_DIST = README.md diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/README new/libXrandr-1.5.2/README --- old/libXrandr-1.5.1/README 2016-08-17 14:58:28.000000000 +0200 +++ new/libXrandr-1.5.2/README 1970-01-01 01:00:00.000000000 +0100 @@ -1,25 +0,0 @@ -libXrandr - X Resize, Rotate and Reflection extension library - -All questions regarding this software should be directed at the -Xorg mailing list: - - http://lists.freedesktop.org/mailman/listinfo/xorg - -Please submit bug reports to the Xorg bugzilla: - - https://bugs.freedesktop.org/enter_bug.cgi?product=xorg - -The master development code repository can be found at: - - git://anongit.freedesktop.org/git/xorg/lib/libXrandr - - http://cgit.freedesktop.org/xorg/lib/libXrandr - -For patch submission instructions, see: - - http://www.x.org/wiki/Development/Documentation/SubmittingPatches - -For more information on the git code manager, see: - - http://wiki.x.org/wiki/GitPage - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/README.md new/libXrandr-1.5.2/README.md --- old/libXrandr-1.5.1/README.md 1970-01-01 01:00:00.000000000 +0100 +++ new/libXrandr-1.5.2/README.md 2019-03-16 21:57:31.000000000 +0100 @@ -0,0 +1,21 @@ +libXrandr - X Resize, Rotate and Reflection extension library +-------------------------------------------------------------- + +libXrandr is the libX11-based library for the X Resize, Rotate and +Reflection (RandR) extension. + +All questions regarding this software should be directed at the +Xorg mailing list: + + https://lists.x.org/mailman/listinfo/xorg + +The master development code repository can be found at: + + https://gitlab.freedesktop.org/xorg/lib/libXrandr + +Please submit bug reports and requests to merge patches there. + +For patch submission instructions, see: + + https://www.x.org/wiki/Development/Documentation/SubmittingPatches + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/compile new/libXrandr-1.5.2/compile --- old/libXrandr-1.5.1/compile 2016-10-04 00:54:16.000000000 +0200 +++ new/libXrandr-1.5.2/compile 2019-03-16 21:57:40.000000000 +0100 @@ -3,7 +3,7 @@ scriptversion=2012-10-14.11; # UTC -# Copyright (C) 1999-2013 Free Software Foundation, Inc. +# Copyright (C) 1999-2014 Free Software Foundation, Inc. # Written by Tom Tromey <tro...@cygnus.com>. # # This program is free software; you can redistribute it and/or modify diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/config.h.in new/libXrandr-1.5.2/config.h.in --- old/libXrandr-1.5.1/config.h.in 2016-10-04 21:22:03.000000000 +0200 +++ new/libXrandr-1.5.2/config.h.in 2019-03-16 21:57:39.000000000 +0100 @@ -30,8 +30,7 @@ /* Define to 1 if you have the <unistd.h> header file. */ #undef HAVE_UNISTD_H -/* Define to the sub-directory in which libtool stores uninstalled libraries. - */ +/* Define to the sub-directory where libtool stores uninstalled libraries. */ #undef LT_OBJDIR /* Name of package */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/configure.ac new/libXrandr-1.5.2/configure.ac --- old/libXrandr-1.5.1/configure.ac 2016-10-04 21:14:23.000000000 +0200 +++ new/libXrandr-1.5.2/configure.ac 2019-03-16 21:57:31.000000000 +0100 @@ -29,8 +29,8 @@ # digit in the version number to track changes which don't affect the # protocol, so Xrandr version l.n.m corresponds to protocol version l.n # -AC_INIT([libXrandr], [1.5.1], - [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg], [libXrandr]) +AC_INIT([libXrandr], [1.5.2], + [https://gitlab.freedesktop.org/xorg/lib/libXrandr/issues], [libXrandr]) AC_CONFIG_SRCDIR([Makefile.am]) AC_CONFIG_HEADERS([config.h]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/missing new/libXrandr-1.5.2/missing --- old/libXrandr-1.5.1/missing 2016-10-04 00:54:16.000000000 +0200 +++ new/libXrandr-1.5.2/missing 2019-03-16 21:57:40.000000000 +0100 @@ -3,7 +3,7 @@ scriptversion=2013-10-28.13; # UTC -# Copyright (C) 1996-2013 Free Software Foundation, Inc. +# Copyright (C) 1996-2014 Free Software Foundation, Inc. # Originally written by Fran,cois Pinard <pin...@iro.umontreal.ca>, 1996. # This program is free software; you can redistribute it and/or modify diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/libXrandr-1.5.1/src/XrrCrtc.c new/libXrandr-1.5.2/src/XrrCrtc.c --- old/libXrandr-1.5.1/src/XrrCrtc.c 2016-09-23 09:56:49.000000000 +0200 +++ new/libXrandr-1.5.2/src/XrrCrtc.c 2019-03-16 21:57:31.000000000 +0100 @@ -459,6 +459,7 @@ e = extra; if (e + rep.pendingNbytesFilter > end) { + XFree (attr); XFree (extra); return False; } @@ -468,6 +469,7 @@ for (p = 0; p < rep.pendingNparamsFilter; p++) { INT32 f; if (e + 4 > end) { + XFree (attr); XFree (extra); return False; } @@ -478,6 +480,7 @@ attr->pendingNparams = rep.pendingNparamsFilter; if (e + rep.currentNbytesFilter > end) { + XFree (attr); XFree (extra); return False; } @@ -487,6 +490,7 @@ for (p = 0; p < rep.currentNparamsFilter; p++) { INT32 f; if (e + 4 > end) { + XFree (attr); XFree (extra); return False; }