Hello community, here is the log from the commit of package autoyast2 for openSUSE:Factory checked in at 2019-04-03 09:25:02 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/autoyast2 (Old) and /work/SRC/openSUSE:Factory/.autoyast2.new.25356 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "autoyast2" Wed Apr 3 09:25:02 2019 rev:257 rq:690684 version:4.1.5 Changes: -------- --- /work/SRC/openSUSE:Factory/autoyast2/autoyast2.changes 2019-03-21 09:51:55.790811093 +0100 +++ /work/SRC/openSUSE:Factory/.autoyast2.new.25356/autoyast2.changes 2019-04-03 09:25:04.887732331 +0200 @@ -1,0 +2,7 @@ +Tue Apr 2 10:32:53 UTC 2019 - José Iván López González <[email protected]> + +- Removed check for available devices. When there are no devices, + the proposal issues will be shown (needed for bsc#1130256). +- 4.1.5 + +------------------------------------------------------------------- Old: ---- autoyast2-4.1.4.tar.bz2 New: ---- autoyast2-4.1.5.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ autoyast2.spec ++++++ --- /var/tmp/diff_new_pack.nkbHlI/_old 2019-04-03 09:25:06.063732885 +0200 +++ /var/tmp/diff_new_pack.nkbHlI/_new 2019-04-03 09:25:06.095732900 +0200 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.1.4 +Version: 4.1.5 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ autoyast2-4.1.4.tar.bz2 -> autoyast2-4.1.5.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.1.4/Dockerfile new/autoyast2-4.1.5/Dockerfile --- old/autoyast2-4.1.4/Dockerfile 2019-03-19 14:15:00.000000000 +0100 +++ new/autoyast2-4.1.5/Dockerfile 2019-04-02 16:42:13.000000000 +0200 @@ -1,4 +1,4 @@ -FROM yastdevel/ruby +FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest RUN zypper --gpg-auto-import-keys --non-interactive in --no-recommends \ trang \ libxml2-tools \ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.1.4/package/autoyast2.changes new/autoyast2-4.1.5/package/autoyast2.changes --- old/autoyast2-4.1.4/package/autoyast2.changes 2019-03-19 14:15:00.000000000 +0100 +++ new/autoyast2-4.1.5/package/autoyast2.changes 2019-04-02 16:42:13.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Tue Apr 2 10:32:53 UTC 2019 - José Iván López González <[email protected]> + +- Removed check for available devices. When there are no devices, + the proposal issues will be shown (needed for bsc#1130256). +- 4.1.5 + +------------------------------------------------------------------- Fri Mar 15 15:54:52 CET 2019 - [email protected] - Postpone disabling local repositories if the second stage is diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.1.4/package/autoyast2.spec new/autoyast2-4.1.5/package/autoyast2.spec --- old/autoyast2-4.1.4/package/autoyast2.spec 2019-03-19 14:15:00.000000000 +0100 +++ new/autoyast2-4.1.5/package/autoyast2.spec 2019-04-02 16:42:13.000000000 +0200 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.1.4 +Version: 4.1.5 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.1.4/src/lib/autoinstall/storage_proposal.rb new/autoyast2-4.1.5/src/lib/autoinstall/storage_proposal.rb --- old/autoyast2-4.1.4/src/lib/autoinstall/storage_proposal.rb 2019-03-19 14:15:00.000000000 +0100 +++ new/autoyast2-4.1.5/src/lib/autoinstall/storage_proposal.rb 2019-04-02 16:42:13.000000000 +0200 @@ -119,6 +119,7 @@ # @return [Y2Storage::GuidedProposal] def guided_proposal log.info "Creating a guided proposal" + # TODO: add specific issue when proposal fails because there are no devices Y2Storage::GuidedProposal.initial end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.1.4/src/modules/AutoinstStorage.rb new/autoyast2-4.1.5/src/modules/AutoinstStorage.rb --- old/autoyast2-4.1.4/src/modules/AutoinstStorage.rb 2019-03-19 14:15:00.000000000 +0100 +++ new/autoyast2-4.1.5/src/modules/AutoinstStorage.rb 2019-04-02 16:42:13.000000000 +0200 @@ -57,7 +57,7 @@ # @return [Boolean] success def Import(settings) log.info "entering Import with #{settings.inspect}" - return false unless available_storage? + partitioning = preprocessed_settings(settings) return false unless partitioning @@ -322,20 +322,6 @@ preprocessor = Y2Autoinstallation::PartitioningPreprocessor.new preprocessor.run(settings) end - - # Determine (and warn the user) no storage is available for installation - # - # @return [Boolean] true if there are devices for installation; false otherwise. - def available_storage? - probed = Y2Storage::StorageManager.instance.probed - return true if probed && !probed.empty? - Yast::Popup.Error( - _("No storage devices were found for the installation.\n" \ - "Please, check your hardware or your AutoYaST profile.") - ) - false - end - end AutoinstStorage = AutoinstStorageClass.new diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.1.4/test/autoinst_storage_test.rb new/autoyast2-4.1.5/test/autoinst_storage_test.rb --- old/autoyast2-4.1.4/test/autoinst_storage_test.rb 2019-03-19 14:15:00.000000000 +0100 +++ new/autoyast2-4.1.5/test/autoinst_storage_test.rb 2019-04-02 16:42:13.000000000 +0200 @@ -191,37 +191,6 @@ subject.Import({}) end end - - end - - context "when there are no available storage for installation" do - before do - allow(probed_devicegraph).to receive(:empty?).and_return(true) - end - - it "displays an error" do - expect(Yast::Popup).to receive(:Error).with(/No storage devices/) - subject.Import({}) - end - - it "returns false" do - expect(subject.Import({})).to eq(false) - end - end - - context "when the probed devicegraph is nil" do - before do - allow(storage_manager).to receive(:probed).and_return(nil) - end - - it "displays an error" do - expect(Yast::Popup).to receive(:Error).with(/No storage devices/) - subject.Import({}) - end - - it "returns false" do - expect(subject.Import({})).to eq(false) - end end end
