Hello community,
here is the log from the commit of package kactivities-stats for
openSUSE:Factory checked in at 2019-04-19 21:20:49
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kactivities-stats (Old)
and /work/SRC/openSUSE:Factory/.kactivities-stats.new.5536 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kactivities-stats"
Fri Apr 19 21:20:49 2019 rev:37 rq:695198 version:5.57.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/kactivities-stats/kactivities-stats.changes
2019-03-21 09:44:19.502924845 +0100
+++
/work/SRC/openSUSE:Factory/.kactivities-stats.new.5536/kactivities-stats.changes
2019-04-19 21:22:07.631701761 +0200
@@ -1,0 +2,10 @@
+Sun Apr 14 20:21:41 UTC 2019 - [email protected]
+
+- Update to 5.57.0
+ * New feature release
+ * For more details please see:
+ * https://www.kde.org/announcements/kde-frameworks-5.57.0.php
+- Changes since 5.56.0:
+ * [Kactivities-stats] compile without foreach
+
+-------------------------------------------------------------------
Old:
----
kactivities-stats-5.56.0.tar.xz
New:
----
kactivities-stats-5.57.0.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ kactivities-stats.spec ++++++
--- /var/tmp/diff_new_pack.Cd3hfS/_old 2019-04-19 21:22:09.007703513 +0200
+++ /var/tmp/diff_new_pack.Cd3hfS/_new 2019-04-19 21:22:09.043703560 +0200
@@ -17,13 +17,13 @@
%define lname libKF5ActivitiesStats1
-%define _tar_path 5.56
+%define _tar_path 5.57
# Full KF5 version (e.g. 5.33.0)
%{!?_kf5_version: %global _kf5_version %{version}}
# Last major and minor KF5 version (e.g. 5.33)
%{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} |
awk -F. '{print $1"."$2}')}
Name: kactivities-stats
-Version: 5.56.0
+Version: 5.57.0
Release: 0
Summary: KDE Plasma Activities support
License: LGPL-2.0-or-later
++++++ kactivities-stats-5.56.0.tar.xz -> kactivities-stats-5.57.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.56.0/CMakeLists.txt
new/kactivities-stats-5.57.0/CMakeLists.txt
--- old/kactivities-stats-5.56.0/CMakeLists.txt 2019-03-02 14:24:10.000000000
+0100
+++ new/kactivities-stats-5.57.0/CMakeLists.txt 2019-04-07 09:16:36.000000000
+0200
@@ -2,8 +2,8 @@
cmake_minimum_required(VERSION 3.5)
-set(KF5_VERSION "5.56.0") # handled by release scripts
-set(KF5_DEP_VERSION "5.56.0") # handled by release scripts
+set(KF5_VERSION "5.57.0") # handled by release scripts
+set(KF5_DEP_VERSION "5.57.0") # handled by release scripts
project (KActivitiesStats VERSION ${KF5_VERSION})
set (REQUIRED_QT_VERSION 5.10.0)
@@ -20,7 +20,7 @@
# Extra CMake stuff
include (FeatureSummary)
-find_package (ECM 5.56.0 NO_MODULE)
+find_package (ECM 5.57.0 NO_MODULE)
set_package_properties (ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake
Modules." URL
"https://projects.kde.org/projects/kdesupport/extra-cmake-modules";)
feature_summary (WHAT REQUIRED_PACKAGES_NOT_FOUND
FATAL_ON_MISSING_REQUIRED_PACKAGES)
@@ -81,7 +81,7 @@
PACKAGE_VERSION_FILE
"${CMAKE_CURRENT_BINARY_DIR}/KF5ActivitiesStatsConfigVersion.cmake"
SOVERSION 1
)
-
+add_definitions(-DQT_NO_FOREACH)
add_subdirectory (src)
if(BUILD_TESTING)
add_subdirectory (autotests)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/kactivities-stats-5.56.0/autotests/ResultSetQuickCheckTest.cpp
new/kactivities-stats-5.57.0/autotests/ResultSetQuickCheckTest.cpp
--- old/kactivities-stats-5.56.0/autotests/ResultSetQuickCheckTest.cpp
2019-03-02 14:24:10.000000000 +0100
+++ new/kactivities-stats-5.57.0/autotests/ResultSetQuickCheckTest.cpp
2019-04-07 09:16:36.000000000 +0200
@@ -331,7 +331,7 @@
void ResultSetQuickCheckTest::generateResourceInfos()
{
- foreach (const QString &resource, resourcesList) {
+ for (const QString &resource : qAsConst(resourcesList)) {
// We want every n-th or so to be without the title
if (qrand() % 3) continue;
@@ -363,7 +363,7 @@
void ResultSetQuickCheckTest::generateResourceLinks()
{
- foreach (const QString &resource, resourcesList) {
+ for (const QString &resource : qAsConst(resourcesList)) {
// We don't want all the resources to be linked
// to something
if (qrand() % 2) continue;
@@ -419,7 +419,7 @@
qDebug() << "Inserting" << resourceScoreCaches.size() << "items into
ResourceScoreCache";
int i = 0;
- foreach (const auto &rsc, resourceScoreCaches) {
+ for (const auto &rsc : qAsConst(resourceScoreCaches)) {
std::cerr << '.';
if (++i % 10 == 0) std::cerr << i;
@@ -458,7 +458,7 @@
qDebug() << "Inserting" << resourceInfos.size() << "items into
ResourceInfo";
i = 0;
- foreach (const auto &ri, resourceInfos) {
+ for (const auto &ri : qAsConst(resourceInfos)) {
std::cerr << '.';
if (++i % 10 == 0) std::cerr << i;
@@ -490,7 +490,7 @@
qDebug() << "Inserting" << resourceLinks.size() << "items into
ResourceLink";
i = 0;
- foreach (const auto &rl, resourceLinks) {
+ for (const auto &rl : qAsConst(resourceLinks)) {
std::cerr << '.';
if (++i % 10 == 0) std::cerr << i;
@@ -596,7 +596,7 @@
using boost::sort;
using boost::adaptors::filtered;
- foreach (const auto &agent, agentsList) {
+ for (const auto &agent : qAsConst(agentsList)) {
auto memItems = ResourceScoreCache::groupByResource(
resourceScoreCaches
| filtered(ResourceScoreCache::initiatingAgent() == agent)
@@ -634,7 +634,7 @@
using boost::sort;
using boost::adaptors::filtered;
- foreach (const auto &agent, agentsList) {
+ for (const auto &agent : qAsConst(agentsList)) {
auto memItems = ResourceLink::groupByResource(
resourceLinks
| filtered(ResourceLink::initiatingAgent() == agent)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.56.0/autotests/common/test.cpp
new/kactivities-stats-5.57.0/autotests/common/test.cpp
--- old/kactivities-stats-5.56.0/autotests/common/test.cpp 2019-03-02
14:24:10.000000000 +0100
+++ new/kactivities-stats-5.57.0/autotests/common/test.cpp 2019-04-07
09:16:36.000000000 +0200
@@ -32,10 +32,10 @@
bool Test::inEmptySession()
{
- QStringList services =
+ const QStringList services =
QDBusConnection::sessionBus().interface()->registeredServiceNames();
- foreach (const QString & service, services) {
+ for (const QString & service : services) {
bool kdeServiceAndNotKAMD =
service.startsWith(QStringLiteral("org.kde")) &&
service != KAMD_DBUS_SERVICE;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.56.0/src/resultmodel.cpp
new/kactivities-stats-5.57.0/src/resultmodel.cpp
--- old/kactivities-stats-5.56.0/src/resultmodel.cpp 2019-03-02
14:24:10.000000000 +0100
+++ new/kactivities-stats-5.57.0/src/resultmodel.cpp 2019-04-07
09:16:36.000000000 +0200
@@ -137,7 +137,7 @@
// not others
QStringList linkedItems;
- foreach (const ResultSet::Result &item, m_items) {
+ for (const ResultSet::Result &item : qAsConst(m_items)) {
if (item.linkStatus() == ResultSet::Result::NotLinked) break;
linkedItems << item.resource();
}
@@ -1041,8 +1041,10 @@
void ResultModel::forgetResource(const QString &resource)
{
- foreach (const QString &activity, d->query.activities()) {
- foreach (const QString &agent, d->query.agents()) {
+ const auto lstActivities = d->query.activities();
+ for (const QString &activity : lstActivities) {
+ const auto lstAgents = d->query.agents();
+ for (const QString &agent : lstAgents) {
Stats::forgetResource(
activity,
agent == CURRENT_AGENT_TAG ?
@@ -1055,9 +1057,10 @@
void ResultModel::forgetResource(int row)
{
if (row >= d->cache.size()) return;
-
- foreach (const QString &activity, d->query.activities()) {
- foreach (const QString &agent, d->query.agents()) {
+ const auto lstActivities = d->query.activities();
+ for (const QString &activity : lstActivities) {
+ const auto lstAgents = d->query.agents();
+ for (const QString &agent : lstAgents) {
Stats::forgetResource(
activity,
agent == CURRENT_AGENT_TAG ?
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.56.0/tests/model/window.cpp
new/kactivities-stats-5.57.0/tests/model/window.cpp
--- old/kactivities-stats-5.56.0/tests/model/window.cpp 2019-03-02
14:24:10.000000000 +0100
+++ new/kactivities-stats-5.57.0/tests/model/window.cpp 2019-04-07
09:16:36.000000000 +0200
@@ -140,7 +140,8 @@
ui->comboActivity->addItem(activity);
}
- foreach (const auto &arg, QCoreApplication::arguments()) {
+ const auto argumentsList = QCoreApplication::arguments();
+ for (const auto &arg : argumentsList) {
if (arg == QLatin1String("--used")) {
ui->radioSelectUsedResources->setChecked(true);
