Hello community, here is the log from the commit of package gnome-music for openSUSE:Factory checked in at 2019-05-10 09:16:04 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-music (Old) and /work/SRC/openSUSE:Factory/.gnome-music.new.5148 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-music" Fri May 10 09:16:04 2019 rev:43 rq:701602 version:3.32.2 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-music/gnome-music.changes 2019-05-03 22:11:45.867433685 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-music.new.5148/gnome-music.changes 2019-05-10 09:16:07.852119773 +0200 @@ -1,0 +2,8 @@ +Mon May 6 18:02:58 UTC 2019 - Bjørn Lie <[email protected]> + +- Update to version 3.32.2: + + Fix player scale starting on first song. + + About dialog movable. + + Keep the same app ID as in 3.30. + +------------------------------------------------------------------- Old: ---- gnome-music-3.32.1.tar.xz New: ---- gnome-music-3.32.2.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-music.spec ++++++ --- /var/tmp/diff_new_pack.bgGp74/_old 2019-05-10 09:16:08.328121132 +0200 +++ /var/tmp/diff_new_pack.bgGp74/_new 2019-05-10 09:16:08.328121132 +0200 @@ -17,7 +17,7 @@ Name: gnome-music -Version: 3.32.1 +Version: 3.32.2 Release: 0 Summary: Music Player for GNOME License: SUSE-GPL-2.0-with-plugin-exception AND LGPL-2.1-or-later ++++++ gnome-music-3.32.1.tar.xz -> gnome-music-3.32.2.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/NEWS new/gnome-music-3.32.2/NEWS --- old/gnome-music-3.32.1/NEWS 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/NEWS 2019-05-06 16:49:09.000000000 +0200 @@ -1,6 +1,20 @@ Overview of changes in 3.32.1 ============================= +Bugs fixed: + Fix player scale starting on first song (#274) + About dialog movable (#261) + Keep the same app ID as in 3.30 + +Thanks to ou contributors this release: + Georges Basile Stavacras Neto + Jean Felder + Kalev Lember + Marinus Schraal + +Overview of changes in 3.32.1 +============================= + * MPRIS fixes * Update help application icon * Fix scale update on first song diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/data/org.gnome.Music.appdata.xml.in.in new/gnome-music-3.32.2/data/org.gnome.Music.appdata.xml.in.in --- old/gnome-music-3.32.1/data/org.gnome.Music.appdata.xml.in.in 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/data/org.gnome.Music.appdata.xml.in.in 2019-05-06 16:49:09.000000000 +0200 @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <component type="desktop-application"> - <id>@appid@</id> + <id>@[email protected]</id> <metadata_license>CC0-1.0</metadata_license> <project_license>GPL-2.0+ and LGPL-2.0+ and CC-BY-SA-4.0</project_license> <name>GNOME Music</name> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/data/ui/DiscBox.ui new/gnome-music-3.32.2/data/ui/DiscBox.ui --- old/gnome-music-3.32.1/data/ui/DiscBox.ui 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/data/ui/DiscBox.ui 2019-05-06 16:49:09.000000000 +0200 @@ -32,7 +32,7 @@ <property name="valign">start</property> <property name="orientation">vertical</property> <property name="homogeneous">True</property> - <property name="max_children_per_line">0</property> + <property name="max_children_per_line">1</property> <property name="selection_mode">none</property> </object> <packing> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/gnomemusic/application.py new/gnome-music-3.32.2/gnomemusic/application.py --- old/gnome-music-3.32.1/gnomemusic/application.py 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/gnomemusic/application.py 2019-05-06 16:49:09.000000000 +0200 @@ -91,6 +91,7 @@ def _about(self, action, param): about = AboutDialog() about.props.transient_for = self._window + about.present() @log def do_startup(self): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/gnomemusic/gstplayer.py new/gnome-music-3.32.2/gnomemusic/gstplayer.py --- old/gnome-music-3.32.1/gnomemusic/gstplayer.py 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/gnomemusic/gstplayer.py 2019-05-06 16:49:09.000000000 +0200 @@ -81,15 +81,12 @@ self._on_replaygain_setting_changed( None, self._settings.get_value('replaygain')) - self._bus.connect('message::state-changed', self._on_bus_state_changed) + self._bus.connect('message::async-done', self._on_async_done) self._bus.connect('message::error', self._on_bus_error) self._bus.connect('message::element', self._on_bus_element) self._bus.connect('message::eos', self._on_bus_eos) - self._bus.connect( - 'message::duration-changed', self._on_duration_changed) self._bus.connect('message::new-clock', self._on_new_clock) - self._previous_state = Playback.STOPPED self.props.state = Playback.STOPPED @log @@ -125,46 +122,29 @@ self._player.set_property("audio-filter", None) @log + def _on_async_done(self, bus, message): + success, duration = self._player.query_duration( + Gst.Format.TIME) + + if success: + self.props.duration = duration / Gst.SECOND + else: + self.props.duration = duration + + self.notify('state') + + @log def _on_new_clock(self, bus, message): clock = message.parse_new_clock() id_ = clock.new_periodic_id(0, 1 * Gst.SECOND) clock.id_wait_async(id_, self._on_clock_tick, None) - # TODO: Workaround the first duration change not being emitted - # and hence smoothscale not being initialized properly. - if self.props.duration == -1.: - self._on_duration_changed(None, None) - @log def _on_clock_tick(self, clock, time, id, data): tick = time / Gst.SECOND self.emit('clock-tick', tick) @log - def _on_bus_state_changed(self, bus, message): - # Note: not all state changes are signaled through here, in - # particular transitions between Gst.State.READY and - # Gst.State.NULL are never async and thus don't cause a - # message. In practice, self means only Gst.State.PLAYING and - # Gst.State.PAUSED are. - current_state = self.props.state - if current_state == self._previous_state: - return - - self._previous_state = current_state - self.notify('state') - - @log - def _on_duration_changed(self, bus, message): - success, duration = self._player.query_duration( - Gst.Format.TIME) - - if success: - self.props.duration = duration / Gst.SECOND - else: - self.props.duration = -1. - - @log def _on_bus_element(self, bus, message): if GstPbutils.is_missing_plugin_message(message): self._missing_plugin_messages.append(message) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/gnomemusic/player.py new/gnome-music-3.32.2/gnomemusic/player.py --- old/gnome-music-3.32.1/gnomemusic/player.py 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/gnomemusic/player.py 2019-05-06 16:49:09.000000000 +0200 @@ -664,9 +664,7 @@ and not self._playlist.set_song(song_offset)): return False - url = self._playlist.props.current_song.get_url() - if (url != self._gst_player.props.url - or self._repeat == RepeatMode.SONG): + if self.props.state != Playback.PAUSED: self._load(self._playlist.props.current_song) self._gst_player.props.state = Playback.PLAYING diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/gnomemusic/views/playlistview.py new/gnome-music-3.32.2/gnomemusic/views/playlistview.py --- old/gnome-music-3.32.1/gnomemusic/views/playlistview.py 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/gnomemusic/views/playlistview.py 2019-05-06 16:49:09.000000000 +0200 @@ -749,7 +749,13 @@ @log def _on_playlist_created(self, playlists, playlist): - """Add new playlist to sidebar""" + """Adds new playlist to sidebar + + If the sidebar has not been populated yet, it has no effect: + the playlist will be displayed once the playlists are loaded. + """ + if not self._init: + return self._add_playlist_to_sidebar(playlist) @log diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/gnomemusic/widgets/aboutdialog.py new/gnome-music-3.32.2/gnomemusic/widgets/aboutdialog.py --- old/gnome-music-3.32.1/gnomemusic/widgets/aboutdialog.py 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/gnomemusic/widgets/aboutdialog.py 2019-05-06 16:49:09.000000000 +0200 @@ -42,8 +42,6 @@ self.connect("response", self._about_response) - self.show() - @log def _about_response(self, klass, data=None): klass.destroy() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/gnomemusic/widgets/disclistboxwidget.py new/gnome-music-3.32.2/gnomemusic/widgets/disclistboxwidget.py --- old/gnome-music-3.32.1/gnomemusic/widgets/disclistboxwidget.py 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/gnomemusic/widgets/disclistboxwidget.py 2019-05-06 16:49:09.000000000 +0200 @@ -71,7 +71,7 @@ """ self._columns = columns - children_n = len(self.get_children()) + children_n = max(len(self.get_children()), 1) if children_n % self._columns == 0: max_per_line = children_n / self._columns diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/gnomemusic/widgets/smoothscale.py new/gnome-music-3.32.2/gnomemusic/widgets/smoothscale.py --- old/gnome-music-3.32.1/gnomemusic/widgets/smoothscale.py 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/gnomemusic/widgets/smoothscale.py 2019-05-06 16:49:09.000000000 +0200 @@ -116,7 +116,6 @@ if duration != -1.: self.set_range(0.0, duration * 60) self.set_increments(300, 600) - self._on_state_change(None, None) @log def _on_smooth_scale_seek_finish(self, value): @@ -176,12 +175,7 @@ the slider SmoothScale move smoothly based on the current song duration and scale length. """ - # Do not run until SmoothScale has been realized and GStreamer - # provides a duration. - duration = self._player.props.duration - if (self.get_realized() is False - or duration == -1.): - return + duration = abs(self._player.props.duration) # Update self._timeout. width = self.get_allocated_width() @@ -189,7 +183,7 @@ Gtk.StateFlags.NORMAL) width = max(width - (padding.left + padding.right), 1) - timeout_period = min(1000 * duration // width, 1000) + timeout_period = min(1000 * duration // width, 200) if self._timeout: GLib.source_remove(self._timeout) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-music-3.32.1/meson.build new/gnome-music-3.32.2/meson.build --- old/gnome-music-3.32.1/meson.build 2019-04-09 14:29:42.000000000 +0200 +++ new/gnome-music-3.32.2/meson.build 2019-05-06 16:49:09.000000000 +0200 @@ -1,5 +1,5 @@ project('gnome-music', - version: '3.32.1', + version: '3.32.2', meson_version: '>= 0.46.0' )
