Hello community,

here is the log from the commit of package gnome-settings-daemon for 
openSUSE:Factory checked in at 2019-05-14 13:12:15
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gnome-settings-daemon (Old)
 and      /work/SRC/openSUSE:Factory/.gnome-settings-daemon.new.5148 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "gnome-settings-daemon"

Tue May 14 13:12:15 2019 rev:156 rq:701976 version:3.32.0

Changes:
--------
--- 
/work/SRC/openSUSE:Factory/gnome-settings-daemon/gnome-settings-daemon.changes  
    2019-05-03 22:11:33.363409740 +0200
+++ 
/work/SRC/openSUSE:Factory/.gnome-settings-daemon.new.5148/gnome-settings-daemon.changes
    2019-05-14 13:12:16.952628795 +0200
@@ -1,0 +2,7 @@
+Sun Apr 28 01:15:09 UTC 2019 - Yifan Jiang <[email protected]>
+
+- Add gnome-settings-daemon-round-xft_dpi-to-integer.patch: Round
+  the Xft.dpi setting to an integer (bsc#1086789,
+  glgo#GNOME#gnome-settings-daemon!99).
+
+-------------------------------------------------------------------

New:
----
  gnome-settings-daemon-round-xft_dpi-to-integer.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ gnome-settings-daemon.spec ++++++
--- /var/tmp/diff_new_pack.Hi1YSL/_old  2019-05-14 13:12:17.432630053 +0200
+++ /var/tmp/diff_new_pack.Hi1YSL/_new  2019-05-14 13:12:17.436630063 +0200
@@ -42,6 +42,8 @@
 Patch2:         
gnome-settings-daemon-switch-Japanese-default-input-to-mozc.patch
 # PATCH-FIX-UPSTREAM gnome-settings-daemon-bgo793253.patch bgo#793253 
[email protected] -- Fix no-return-in-nonvoid-function
 Patch3:         gnome-settings-daemon-bgo793253.patch
+# PATCH-FIX-UPSTREAM gnome-settings-daemon-round-xft_dpi-to-integer.patch 
bsc#1086789 glgo#GNOME#gnome-settings-daemon!99 [email protected] -- Round the 
Xft.dpi setting to an integer
+Patch4:         gnome-settings-daemon-round-xft_dpi-to-integer.patch
 
 ## SLE-only patches start at 1000
 # PATCH-FEATURE-SLE gnome-settings-daemon-notify-idle-resumed.patch bnc#439018 
bnc#708182 bgo#575467 [email protected] -- notify user about auto suspend when 
returning from sleep
@@ -149,6 +151,7 @@
 %patch1 -p1
 %patch2 -p1
 %patch3 -p1
+%patch4 -p1
 # SLE-only patches start at 1000
 %if !0%{?is_opensuse}
 %patch1000 -p1

++++++ gnome-settings-daemon-round-xft_dpi-to-integer.patch ++++++
>From 8d889e9545665054e4054ab21467b80e51fe1b49 Mon Sep 17 00:00:00 2001
From: Yifan J <[email protected]>
Date: Thu, 25 Apr 2019 16:09:04 +0800
Subject: [PATCH] xsettings: Round the Xft.dpi setting to an integer

When using gnome-tweaks to set a text scale factor that is not a
multiple of 0.25 (e.g. 1.1), Xft.dpi would be calculated as a
floating point number, which breaks the fdo spec:

https://www.freedesktop.org/wiki/Specifications/XSettingsRegistry/

Although GNOME could handle the floating point Xft.dpi, graphical
programs restrictively followed the above-mentioned spec would be
influenced negatively. For example, QT applications (running on
GNOME desktop) may ignore text scaling factor when Xft.dpi was
calculated as a floating point number:

https://bugreports.qt.io/browse/QTBUG-64738

The patch at the same time has few impact to GNOME itself.
---
 plugins/xsettings/gsd-xsettings-manager.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/xsettings/gsd-xsettings-manager.c 
b/plugins/xsettings/gsd-xsettings-manager.c
index 3b1ebc3a..c3ac7892 100644
--- a/plugins/xsettings/gsd-xsettings-manager.c
+++ b/plugins/xsettings/gsd-xsettings-manager.c
@@ -814,8 +814,8 @@ xft_settings_set_xresources (GsdXftSettings *settings)
 
         g_debug("xft_settings_set_xresources: orig res '%s'", add_string->str);
 
-        update_property (add_string, "Xft.dpi",
-                                g_ascii_dtostr (dpibuf, sizeof (dpibuf), 
(double) settings->scaled_dpi / 1024.0));
+        g_snprintf (dpibuf, sizeof (dpibuf), "%d", (int) (settings->scaled_dpi 
/ 1024.0 + 0.5));
+        update_property (add_string, "Xft.dpi", dpibuf);
         update_property (add_string, "Xft.antialias",
                                 settings->antialias ? "1" : "0");
         update_property (add_string, "Xft.hinting",
-- 
2.21.0


Reply via email to