Hello community, here is the log from the commit of package kemoticons for openSUSE:Factory checked in at 2019-05-21 10:28:01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kemoticons (Old) and /work/SRC/openSUSE:Factory/.kemoticons.new.5148 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kemoticons" Tue May 21 10:28:01 2019 rev:65 rq:703348 version:5.58.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kemoticons/kemoticons.changes 2019-04-19 21:22:36.691738772 +0200 +++ /work/SRC/openSUSE:Factory/.kemoticons.new.5148/kemoticons.changes 2019-05-21 10:28:02.947490882 +0200 @@ -1,0 +2,11 @@ +Wed May 15 18:16:16 UTC 2019 - lbeltr...@kde.org + +- Update to 5.58.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.58.0.php +- Changes since 5.57.0: + * Mark archive and directory as const + * [kemoticons] make it compile without foreach + +------------------------------------------------------------------- Old: ---- kemoticons-5.57.0.tar.xz New: ---- kemoticons-5.58.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kemoticons.spec ++++++ --- /var/tmp/diff_new_pack.4JcpwZ/_old 2019-05-21 10:28:03.943490500 +0200 +++ /var/tmp/diff_new_pack.4JcpwZ/_new 2019-05-21 10:28:03.967490490 +0200 @@ -17,13 +17,13 @@ %define lname libKF5Emoticons5 -%define _tar_path 5.57 +%define _tar_path 5.58 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: kemoticons -Version: 5.57.0 +Version: 5.58.0 Release: 0 Summary: Emoticon to graphical emoticon text converter License: LGPL-2.1-or-later ++++++ kemoticons-5.57.0.tar.xz -> kemoticons-5.58.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kemoticons-5.57.0/CMakeLists.txt new/kemoticons-5.58.0/CMakeLists.txt --- old/kemoticons-5.57.0/CMakeLists.txt 2019-04-07 09:18:05.000000000 +0200 +++ new/kemoticons-5.58.0/CMakeLists.txt 2019-05-05 00:43:16.000000000 +0200 @@ -1,11 +1,11 @@ cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.57.0") # handled by release scripts -set(KF5_DEP_VERSION "5.57.0") # handled by release scripts +set(KF5_VERSION "5.58.0") # handled by release scripts +set(KF5_DEP_VERSION "5.58.0") # handled by release scripts project(KEmoticons VERSION ${KF5_VERSION}) include(FeatureSummary) -find_package(ECM 5.57.0 NO_MODULE) +find_package(ECM 5.58.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -47,6 +47,7 @@ # the strings throughout this library are used to search ressources # so they don't need translations add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x060000) +add_definitions(-DQT_NO_FOREACH) add_subdirectory(src) add_subdirectory(themes) if (BUILD_TESTING) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kemoticons-5.57.0/autotests/autotestbase.h new/kemoticons-5.58.0/autotests/autotestbase.h --- old/kemoticons-5.57.0/autotests/autotestbase.h 2019-04-07 09:18:05.000000000 +0200 +++ new/kemoticons-5.58.0/autotests/autotestbase.h 2019-05-05 00:43:16.000000000 +0200 @@ -34,7 +34,8 @@ themeDir.removeRecursively(); themeDir.mkpath(QStringLiteral(".")); - foreach (const QString &fileName, sourceThemeDir.entryList(QDir::Files)) { + const auto files = sourceThemeDir.entryList(QDir::Files); + for (const QString &fileName : files) { if (!QFile::copy(sourceThemeDir.filePath(fileName), themeDir.filePath(fileName))) { qWarning() << "couldn't copy" << dir << "/" << fileName; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kemoticons-5.57.0/src/core/kemoticons.cpp new/kemoticons-5.58.0/src/core/kemoticons.cpp --- old/kemoticons-5.57.0/src/core/kemoticons.cpp 2019-04-07 09:18:05.000000000 +0200 +++ new/kemoticons-5.58.0/src/core/kemoticons.cpp 2019-05-05 00:43:16.000000000 +0200 @@ -238,8 +238,8 @@ QStringList KEmoticons::installTheme(const QString &archiveName) { QStringList foundThemes; - KArchiveEntry *currentEntry = nullptr; - KArchiveDirectory *currentDir = nullptr; + const KArchiveEntry *currentEntry = nullptr; + const KArchiveDirectory *currentDir = nullptr; KArchive *archive = nullptr; const QString localThemesDir(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/emoticons")); @@ -285,7 +285,7 @@ currentEntry = const_cast<KArchiveEntry *>(rootDir->entry(*it)); if (currentEntry->isDirectory()) { - currentDir = dynamic_cast<KArchiveDirectory *>(currentEntry); + currentDir = dynamic_cast<const KArchiveDirectory *>(currentEntry); for (const KPluginMetaData &plugin : qAsConst(d->m_plugins)) { const QString fName = plugin.rawData().value(QStringLiteral("X-KDE-EmoticonsFileName")).toString(); @@ -319,7 +319,7 @@ } if (currentEntry->isDirectory()) { - currentDir = dynamic_cast<KArchiveDirectory *>(currentEntry); + currentDir = dynamic_cast<const KArchiveDirectory *>(currentEntry); if (currentDir == nullptr) { // qCDebug(KEMOTICONS_CORE) << "couldn't cast archive entry to KArchiveDirectory"; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kemoticons-5.57.0/src/core/kemoticonsprovider.cpp new/kemoticons-5.58.0/src/core/kemoticonsprovider.cpp --- old/kemoticons-5.57.0/src/core/kemoticonsprovider.cpp 2019-04-07 09:18:05.000000000 +0200 +++ new/kemoticons-5.58.0/src/core/kemoticonsprovider.cpp 2019-05-05 00:43:16.000000000 +0200 @@ -171,7 +171,7 @@ void KEmoticonsProvider::removeIndexItem(const QString &path, const QStringList &emoList) { - foreach (const QString &s, emoList) { + for (const QString &s : emoList) { QString escaped = s.toHtmlEscaped(); if (s.isEmpty() || escaped.isEmpty()) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kemoticons-5.57.0/src/core/kemoticonstheme.cpp new/kemoticons-5.58.0/src/core/kemoticonstheme.cpp --- old/kemoticons-5.57.0/src/core/kemoticonstheme.cpp 2019-04-07 09:18:05.000000000 +0200 +++ new/kemoticons-5.58.0/src/core/kemoticonstheme.cpp 2019-05-05 00:43:16.000000000 +0200 @@ -153,14 +153,14 @@ QString KEmoticonsTheme::parseEmoticons(const QString &text, ParseMode mode, const QStringList &exclude) const { - QList<Token> tokens = tokenize(text, mode | SkipHTML); + const QList<Token> tokens = tokenize(text, mode | SkipHTML); if (tokens.isEmpty() && !text.isEmpty()) { return text; } QString result; - foreach (const Token &token, tokens) { + for (const Token &token : tokens) { switch (token.type) { case Text: result += token.text;
