Hello community,
here is the log from the commit of package yast2-iscsi-client for
openSUSE:Factory checked in at 2019-05-21 10:36:11
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-client (Old)
and /work/SRC/openSUSE:Factory/.yast2-iscsi-client.new.5148 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-iscsi-client"
Tue May 21 10:36:11 2019 rev:124 rq:703454 version:4.2.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-iscsi-client/yast2-iscsi-client.changes
2019-03-28 22:47:06.935071042 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-iscsi-client.new.5148/yast2-iscsi-client.changes
2019-05-21 10:36:12.815249615 +0200
@@ -1,0 +2,6 @@
+Thu May 16 11:17:12 UTC 2019 - Steffen Winterfeldt <snw...@suse.com>
+
+- iscsiadm may have exit code 21 on success (bsc#1131049)
+- 4.2.0
+
+-------------------------------------------------------------------
Old:
----
yast2-iscsi-client-4.1.7.tar.bz2
New:
----
yast2-iscsi-client-4.2.0.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-iscsi-client.spec ++++++
--- /var/tmp/diff_new_pack.kMzGEC/_old 2019-05-21 10:36:13.463249194 +0200
+++ /var/tmp/diff_new_pack.kMzGEC/_new 2019-05-21 10:36:13.467249191 +0200
@@ -17,7 +17,7 @@
Name: yast2-iscsi-client
-Version: 4.1.7
+Version: 4.2.0
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-iscsi-client-4.1.7.tar.bz2 -> yast2-iscsi-client-4.2.0.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-iscsi-client-4.1.7/Dockerfile
new/yast2-iscsi-client-4.2.0/Dockerfile
--- old/yast2-iscsi-client-4.1.7/Dockerfile 2019-03-28 13:12:38.000000000
+0100
+++ new/yast2-iscsi-client-4.2.0/Dockerfile 2019-05-16 16:26:37.000000000
+0200
@@ -1,3 +1,3 @@
-FROM yastdevel/ruby
+FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest
COPY . /usr/src/app
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-4.1.7/package/yast2-iscsi-client.changes
new/yast2-iscsi-client-4.2.0/package/yast2-iscsi-client.changes
--- old/yast2-iscsi-client-4.1.7/package/yast2-iscsi-client.changes
2019-03-28 13:12:38.000000000 +0100
+++ new/yast2-iscsi-client-4.2.0/package/yast2-iscsi-client.changes
2019-05-16 16:26:37.000000000 +0200
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Thu May 16 11:17:12 UTC 2019 - Steffen Winterfeldt <snw...@suse.com>
+
+- iscsiadm may have exit code 21 on success (bsc#1131049)
+- 4.2.0
+
+-------------------------------------------------------------------
Wed Mar 27 11:44:33 UTC 2019 - jsr...@suse.cz
- further fixes of iscsiadm output parsing (bsc#1129946)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-4.1.7/package/yast2-iscsi-client.spec
new/yast2-iscsi-client-4.2.0/package/yast2-iscsi-client.spec
--- old/yast2-iscsi-client-4.1.7/package/yast2-iscsi-client.spec
2019-03-28 13:12:38.000000000 +0100
+++ new/yast2-iscsi-client-4.2.0/package/yast2-iscsi-client.spec
2019-05-16 16:26:37.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-iscsi-client
-Version: 4.1.7
+Version: 4.2.0
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-4.1.7/src/modules/IscsiClientLib.rb
new/yast2-iscsi-client-4.2.0/src/modules/IscsiClientLib.rb
--- old/yast2-iscsi-client-4.1.7/src/modules/IscsiClientLib.rb 2019-03-28
13:12:38.000000000 +0100
+++ new/yast2-iscsi-client-4.2.0/src/modules/IscsiClientLib.rb 2019-05-16
16:26:37.000000000 +0200
@@ -548,12 +548,10 @@
10.times do |i|
Builtins.sleep(1 * 1000)
cmd = SCR.Execute(path(".target.bash_output"), GetAdmCmd("-m session"))
- Builtins.y2internal(
- "iteration %1, retcode %2",
- i,
- Ops.get_integer(cmd, "exit", -1)
- )
- if Ops.get_integer(cmd, "exit", -1) == 0
+ Builtins.y2internal("iteration %1, retcode %2", i, cmd["exit"])
+ # Both exit codes 0 and 21 may indicate success.
+ # See discussion in bsc#1131049.
+ if [0, 21].include?(cmd["exit"])
Builtins.y2internal("Good response from daemon, exit.")
break
end
