Hello community, here is the log from the commit of package gsequencer for openSUSE:Factory checked in at 2019-06-03 18:54:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gsequencer (Old) and /work/SRC/openSUSE:Factory/.gsequencer.new.5148 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gsequencer" Mon Jun 3 18:54:07 2019 rev:39 rq:707022 version:2.1.74 Changes: -------- --- /work/SRC/openSUSE:Factory/gsequencer/gsequencer.changes 2019-05-21 10:38:47.563149120 +0200 +++ /work/SRC/openSUSE:Factory/.gsequencer.new.5148/gsequencer.changes 2019-06-03 18:54:53.748439415 +0200 @@ -1,0 +2,8 @@ +Sun Jun 2 15:23:40 UTC 2019 - Joël Krähemann <[email protected]> + +- new upstream v2.1.74 fixed potential SIGSEGV during restore from + XML file. +- fixed potential SIGSEGV in ags_synth_generator.c. +- fixed some memory-leaks. + +------------------------------------------------------------------- Old: ---- gsequencer-2.1.72.tar.gz New: ---- gsequencer-2.1.74.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gsequencer.spec ++++++ --- /var/tmp/diff_new_pack.yInJhE/_old 2019-06-03 18:54:55.240438862 +0200 +++ /var/tmp/diff_new_pack.yInJhE/_new 2019-06-03 18:54:55.240438862 +0200 @@ -21,7 +21,7 @@ # activated with --with run_functional_tests command line switch. %bcond_with run_functional_tests Name: gsequencer -Version: 2.1.72 +Version: 2.1.74 Release: 0 Summary: Audio processing engine License: GPL-3.0+ AND AGPL-3.0+ AND GFDL-1.3 ++++++ gsequencer-2.1.72.tar.gz -> gsequencer-2.1.74.tar.gz ++++++ ++++ 1647 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ChangeLog new/gsequencer-2.1.74/ChangeLog --- old/gsequencer-2.1.72/ChangeLog 2019-05-19 18:09:23.000000000 +0200 +++ new/gsequencer-2.1.74/ChangeLog 2019-06-01 20:43:53.000000000 +0200 @@ -1,3 +1,21 @@ +ags (2.1.74) + + [ Joël Krähemann (Maintainer of Advanced Gtk+ Sequencer) ] + * fixed ags-copy-pattern recall to proper free GError + * fixed ags_recycling_finalize() to free AgsUUID + * fixed ags_thread_finalize() to free AgsUUID and other memory-leaks + * fixed potential SIGSEGV in ags_simple_file.c + +ags (2.1.73) + + [ Joël Krähemann (Maintainer of Advanced Gtk+ Sequencer) ] + * implemented use g_error_free() + * improved ref-count of AgsInput:file-link in ags_audio_open_file_as_channel() + * improved ref-count of AgsInput:file-link in ags_open_sf2_instrument.c + * improved ref-count of AgsInput:file-link in ags_open_sf2_sample.c + * improved ref-count of AgsInput:file-link in ags_open_single_file.c + * fixed potential SIGSEGV cause by attack larger than buffer size in ags_synth_generator.c + ags (2.1.72) [ Joël Krähemann (Maintainer of Advanced Gtk+ Sequencer) ] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_link_collection_editor.c new/gsequencer-2.1.74/ags/X/ags_link_collection_editor.c --- old/gsequencer-2.1.72/ags/X/ags_link_collection_editor.c 2019-04-29 20:06:17.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_link_collection_editor.c 2019-06-01 20:20:05.000000000 +0200 @@ -456,8 +456,6 @@ guint first_line, count; guint i; - GError *error; - machine_editor = AGS_MACHINE_EDITOR(gtk_widget_get_ancestor(GTK_WIDGET(link_collection_editor), AGS_TYPE_MACHINE_EDITOR)); machine = machine_editor->machine; @@ -502,8 +500,6 @@ count = (guint) gtk_spin_button_get_value_as_int(link_collection_editor->count); - error = NULL; - if(link_machine == NULL){ next_channel = NULL; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_link_editor_callbacks.c new/gsequencer-2.1.74/ags/X/ags_link_editor_callbacks.c --- old/gsequencer-2.1.72/ags/X/ags_link_editor_callbacks.c 2019-04-29 20:06:17.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_link_editor_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -106,6 +106,8 @@ &iter); g_free(filename); + + g_object_unref(file_link); }else{ gtk_list_store_set(GTK_LIST_STORE(model), &iter, 0, "file://", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_machine_callbacks.c new/gsequencer-2.1.74/ags/X/ags_machine_callbacks.c --- old/gsequencer-2.1.72/ags/X/ags_machine_callbacks.c 2019-04-29 20:06:17.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_machine_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -683,10 +683,17 @@ /* adding lost files */ //TODO:JK: figure out if you need to copy the GSList of filenames gtk_file_chooser_select_all(GTK_FILE_CHOOSER(file_chooser)); - + + error = NULL; current_directory = g_dir_open(current_folder, 0, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } while((current_filename = (gchar *) g_dir_read_name(current_directory)) != NULL){ if(!g_strcmp0(".", current_filename) || diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_menu_action_callbacks.c new/gsequencer-2.1.74/ags/X/ags_menu_action_callbacks.c --- old/gsequencer-2.1.72/ags/X/ags_menu_action_callbacks.c 2019-04-29 20:06:17.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_menu_action_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -108,6 +108,12 @@ g_spawn_command_line_async(str, &error); + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } + g_free(filename); g_free(str); } @@ -141,8 +147,16 @@ ags_simple_file_rw_open(simple_file, TRUE, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } + ags_simple_file_write(simple_file); ags_simple_file_close(simple_file); + g_object_unref(G_OBJECT(simple_file)); }else{ AgsFile *file; @@ -156,8 +170,16 @@ ags_file_rw_open(file, TRUE, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } + ags_file_write(file); ags_file_close(file); + g_object_unref(G_OBJECT(file)); } } @@ -209,8 +231,16 @@ ags_simple_file_rw_open(simple_file, TRUE, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } + ags_simple_file_write(simple_file); ags_simple_file_close(simple_file); + g_object_unref(G_OBJECT(simple_file)); }else{ AgsFile *file; @@ -224,6 +254,13 @@ ags_file_rw_open(file, TRUE, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } + ags_file_write(file); ags_file_close(file); g_object_unref(G_OBJECT(file)); @@ -1287,6 +1324,12 @@ &error); //g_free(logo_filename); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_preferences.c new/gsequencer-2.1.74/ags/X/ags_preferences.c --- old/gsequencer-2.1.72/ags/X/ags_preferences.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_preferences.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2015 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -291,7 +291,6 @@ uid_t uid; gchar **argv; - GError *error; preferences = AGS_PREFERENCES(applicable); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_sequencer_editor.c new/gsequencer-2.1.74/ags/X/ags_sequencer_editor.c --- old/gsequencer-2.1.72/ags/X/ags_sequencer_editor.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_sequencer_editor.c 2019-06-01 20:20:05.000000000 +0200 @@ -432,9 +432,7 @@ guint nth; gboolean use_alsa; gboolean found_card; - - GError *error; - + sequencer_editor = AGS_SEQUENCER_EDITOR(applicable); sequencer = sequencer_editor->sequencer; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_sequencer_editor_callbacks.c new/gsequencer-2.1.74/ags/X/ags_sequencer_editor_callbacks.c --- old/gsequencer-2.1.72/ags/X/ags_sequencer_editor_callbacks.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_sequencer_editor_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2017 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -77,8 +77,6 @@ guint rate, rate_min, rate_max; guint buffer_size, buffer_size_min, buffer_size_max; - GError *error; - sequencer = sequencer_editor->sequencer; /* */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_soundcard_editor.c new/gsequencer-2.1.74/ags/X/ags_soundcard_editor.c --- old/gsequencer-2.1.72/ags/X/ags_soundcard_editor.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_soundcard_editor.c 2019-06-01 20:20:05.000000000 +0200 @@ -1040,6 +1040,10 @@ samplerate_max = 192000.0; buffer_size_min = 2.0; buffer_size_max = 65535.0; + + g_message("%s", error); + + g_error_free(error); } }else{ channels_min = 0.0; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_soundcard_editor_callbacks.c new/gsequencer-2.1.74/ags/X/ags_soundcard_editor_callbacks.c --- old/gsequencer-2.1.72/ags/X/ags_soundcard_editor_callbacks.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_soundcard_editor_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2017 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -162,6 +162,8 @@ gtk_spin_button_set_range(soundcard_editor->buffer_size, 1.0, 65535.0); soundcard_editor->flags &= (~AGS_SOUNDCARD_EDITOR_BLOCK_CARD); + + g_error_free(error); return; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_window.c new/gsequencer-2.1.74/ags/X/ags_window.c --- old/gsequencer-2.1.72/ags/X/ags_window.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_window.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2015 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -222,6 +222,10 @@ NULL); g_free(str); + if(error != NULL){ + g_error_free(error); + } + window->application_context = NULL; window->application_mutex = NULL; @@ -844,6 +848,10 @@ ags_simple_file_open(simple_file, &error); + if(error != NULL){ + g_error_free(error); + } + ags_simple_file_read(simple_file); ags_simple_file_close(simple_file); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/ags_window_callbacks.c new/gsequencer-2.1.74/ags/X/ags_window_callbacks.c --- old/gsequencer-2.1.72/ags/X/ags_window_callbacks.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/ags_window_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2015 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -70,8 +70,16 @@ ags_simple_file_rw_open(simple_file, TRUE, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } + ags_simple_file_write(simple_file); ags_simple_file_close(simple_file); + g_object_unref(G_OBJECT(simple_file)); }else{ AgsFile *file; @@ -87,8 +95,16 @@ ags_file_rw_open(file, TRUE, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } + ags_file_write(file); ags_file_close(file); + g_object_unref(G_OBJECT(file)); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/editor/ags_envelope_editor.c new/gsequencer-2.1.74/ags/X/editor/ags_envelope_editor.c --- old/gsequencer-2.1.72/ags/X/editor/ags_envelope_editor.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/editor/ags_envelope_editor.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2017 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -1141,6 +1141,8 @@ envelope_editor->flags &= (~AGS_ENVELOPE_EDITOR_NO_UPDATE); + g_error_free(error); + return; } @@ -1165,6 +1167,8 @@ envelope_editor->flags &= (~AGS_ENVELOPE_EDITOR_NO_UPDATE); + g_error_free(error); + return; } @@ -1189,6 +1193,8 @@ envelope_editor->flags &= (~AGS_ENVELOPE_EDITOR_NO_UPDATE); + g_error_free(error); + return; } @@ -1212,6 +1218,8 @@ g_warning("%s", error->message); envelope_editor->flags &= (~AGS_ENVELOPE_EDITOR_NO_UPDATE); + + g_error_free(error); return; } @@ -1237,6 +1245,8 @@ envelope_editor->flags &= (~AGS_ENVELOPE_EDITOR_NO_UPDATE); + g_error_free(error); + return; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/editor/ags_envelope_editor_callbacks.c new/gsequencer-2.1.74/ags/X/editor/ags_envelope_editor_callbacks.c --- old/gsequencer-2.1.72/ags/X/editor/ags_envelope_editor_callbacks.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/editor/ags_envelope_editor_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2017 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -154,6 +154,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -207,6 +209,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -260,6 +264,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -313,6 +319,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -366,6 +374,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -419,6 +429,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -472,6 +484,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -525,6 +539,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -578,6 +594,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/editor/ags_pattern_envelope.c new/gsequencer-2.1.74/ags/X/editor/ags_pattern_envelope.c --- old/gsequencer-2.1.72/ags/X/editor/ags_pattern_envelope.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/editor/ags_pattern_envelope.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -1391,6 +1391,8 @@ g_warning("%s", error->message); pattern_envelope->flags &= (~AGS_PATTERN_ENVELOPE_NO_UPDATE); + + g_error_free(error); return; } @@ -1415,6 +1417,8 @@ pattern_envelope->flags &= (~AGS_PATTERN_ENVELOPE_NO_UPDATE); + g_error_free(error); + return; } @@ -1438,6 +1442,8 @@ pattern_envelope->flags &= (~AGS_PATTERN_ENVELOPE_NO_UPDATE); + g_error_free(error); + return; } @@ -1461,6 +1467,8 @@ pattern_envelope->flags &= (~AGS_PATTERN_ENVELOPE_NO_UPDATE); + g_error_free(error); + return; } @@ -1484,6 +1492,8 @@ pattern_envelope->flags &= (~AGS_PATTERN_ENVELOPE_NO_UPDATE); + g_error_free(error); + return; } @@ -1698,6 +1708,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); continue; } @@ -1718,6 +1730,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); continue; } @@ -1739,6 +1753,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); continue; } @@ -1760,6 +1776,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); continue; } @@ -1781,6 +1799,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); continue; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/editor/ags_pattern_envelope_callbacks.c new/gsequencer-2.1.74/ags/X/editor/ags_pattern_envelope_callbacks.c --- old/gsequencer-2.1.72/ags/X/editor/ags_pattern_envelope_callbacks.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/editor/ags_pattern_envelope_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -361,6 +361,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -415,6 +417,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -469,6 +473,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -523,6 +529,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -577,6 +585,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -631,6 +641,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -685,6 +697,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -739,6 +753,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } @@ -793,6 +809,8 @@ if(error != NULL){ g_message("%s", error->message); + g_error_free(error); + return; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/editor/ags_sf2_chooser.c new/gsequencer-2.1.74/ags/X/editor/ags_sf2_chooser.c --- old/gsequencer-2.1.72/ags/X/editor/ags_sf2_chooser.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/editor/ags_sf2_chooser.c 2019-06-01 20:20:05.000000000 +0200 @@ -319,8 +319,6 @@ gchar **instrument; gchar **sample; - GError *error; - /* clear preset, instrument and sample*/ gtk_list_store_clear(GTK_LIST_STORE(sf2_chooser->preset)); gtk_list_store_clear(GTK_LIST_STORE(sf2_chooser->instrument)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/file/ags_simple_file.c new/gsequencer-2.1.74/ags/X/file/ags_simple_file.c --- old/gsequencer-2.1.72/ags/X/file/ags_simple_file.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/file/ags_simple_file.c 2019-06-01 20:45:29.000000000 +0200 @@ -1025,6 +1025,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } } @@ -4122,6 +4124,8 @@ "file-link", file_link, NULL); + g_object_unref(file_link); + if(audio_signal_list != NULL){ AGS_AUDIO_SIGNAL(audio_signal_list->data)->flags |= AGS_AUDIO_SIGNAL_TEMPLATE; @@ -4155,6 +4159,8 @@ if(error != NULL){ g_warning("ags_simple_file_read_line_launch() - %s", error->message); + + g_error_free(error); } break; @@ -4170,6 +4176,8 @@ if(error != NULL){ g_warning("ags_simple_file_read_line_launch() - %s", error->message); + + g_error_free(error); } break; @@ -4287,6 +4295,8 @@ "file-link", file_link, NULL); + g_object_unref(file_link); + if(audio_signal_list != NULL){ AGS_AUDIO_SIGNAL(audio_signal_list->data)->flags |= AGS_AUDIO_SIGNAL_TEMPLATE; @@ -4320,6 +4330,8 @@ if(error != NULL){ g_warning("ags_simple_file_read_line_launch() - %s", error->message); + + g_error_free(error); } break; @@ -4335,6 +4347,8 @@ if(error != NULL){ g_warning("ags_simple_file_read_line_launch() - %s", error->message); + + g_error_free(error); } break; @@ -4874,18 +4888,23 @@ if(str != NULL){ file_id_ref = ags_simple_file_find_id_ref_by_xpath((AgsSimpleFile *) file_launch->file, str); - machine = AGS_FILE_ID_REF(file_id_ref->data)->ref; + + if(file_id_ref != NULL && + file_id_ref->data != NULL && + AGS_FILE_ID_REF(file_id_ref->data)->ref != NULL){ + machine = AGS_FILE_ID_REF(file_id_ref->data)->ref; - ags_machine_selector_add_index(notation_editor->machine_selector); + ags_machine_selector_add_index(notation_editor->machine_selector); - list_start = gtk_container_get_children((GtkContainer *) notation_editor->machine_selector); - list = g_list_last(list_start); + list_start = gtk_container_get_children((GtkContainer *) notation_editor->machine_selector); + list = g_list_last(list_start); - gtk_button_clicked(list->data); - ags_machine_selector_link_index(notation_editor->machine_selector, - machine); + gtk_button_clicked(list->data); + ags_machine_selector_link_index(notation_editor->machine_selector, + machine); - g_list_free(list_start); + g_list_free(list_start); + } } }else{ g_object_set_property((GObject *) notation_editor, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/machine/ags_ffplayer.c new/gsequencer-2.1.74/ags/X/machine/ags_ffplayer.c --- old/gsequencer-2.1.72/ags/X/machine/ags_ffplayer.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/machine/ags_ffplayer.c 2019-06-01 20:20:05.000000000 +0200 @@ -647,8 +647,6 @@ gchar **preset, **instrument, *selected; - GError *error; - /* clear preset, instrument and sample*/ gtk_list_store_clear(GTK_LIST_STORE(gtk_combo_box_get_model(GTK_COMBO_BOX(ffplayer->instrument)))); @@ -1818,8 +1816,6 @@ gchar **preset; - GError *error; - if(!AGS_IS_FFPLAYER(ffplayer) || ffplayer->audio_container == NULL || ffplayer->audio_container->sound_container == NULL){ @@ -1851,8 +1847,6 @@ gint position; - GError *error; - if(!AGS_IS_FFPLAYER(ffplayer) || ffplayer->audio_container == NULL || ffplayer->audio_container->sound_container == NULL){ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/machine/ags_ffplayer_callbacks.c new/gsequencer-2.1.74/ags/X/machine/ags_ffplayer_callbacks.c --- old/gsequencer-2.1.72/ags/X/machine/ags_ffplayer_callbacks.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/machine/ags_ffplayer_callbacks.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -164,8 +164,6 @@ gint position; - GError *error; - if((AGS_FFPLAYER_NO_LOAD & (ffplayer->flags)) != 0 || ffplayer->audio_container == NULL|| ffplayer->audio_container->sound_container == NULL){ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/X/thread/ags_gui_thread.c new/gsequencer-2.1.74/ags/X/thread/ags_gui_thread.c --- old/gsequencer-2.1.72/ags/X/thread/ags_gui_thread.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/X/thread/ags_gui_thread.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2017 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -965,6 +965,10 @@ filename, error); ags_application_context_quit(application_context); + + g_message("%s", error->message); + + g_error_free(error); } /* autosave thread */ @@ -1110,6 +1114,11 @@ ags_gui_thread_show_file_error((AgsGuiThread *) gui_thread, filename, error); + + g_message("%s", error->message); + + g_error_free(error); + exit(-1); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/ags_audio.c new/gsequencer-2.1.74/ags/audio/ags_audio.c --- old/gsequencer-2.1.72/ags/audio/ags_audio.c 2019-05-04 17:18:16.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/ags_audio.c 2019-06-01 20:20:05.000000000 +0200 @@ -5674,6 +5674,8 @@ if(error != NULL){ g_error("%s", error->message); + + g_error_free(error); } channel = channel->next; @@ -5737,6 +5739,8 @@ if(error != NULL){ g_error("%s", error->message); + + g_error_free(error); } channel = channel->next; @@ -6570,6 +6574,8 @@ if(error != NULL){ g_error("%s", error->message); + + g_error_free(error); } channel = channel->next; @@ -6591,6 +6597,8 @@ if(error != NULL){ g_error("%s", error->message); + + g_error_free(error); } #endif @@ -11434,6 +11442,9 @@ if(error != NULL){ g_warning("%s", error->message); + + + g_error_free(error); } /* get channel mutex */ @@ -11460,6 +11471,8 @@ g_object_set(channel, "file-link", file_link, NULL); + + g_object_unref(file_link); } g_object_set(file_link, @@ -11562,8 +11575,10 @@ g_object_set(channel, "file-link", file_link, NULL); + + g_object_unref(file_link); } - + g_object_set(file_link, "filename", filename->data, "audio-channel", j, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/ags_devout.c new/gsequencer-2.1.74/ags/audio/ags_devout.c --- old/gsequencer-2.1.72/ags/audio/ags_devout.c 2019-04-29 20:06:18.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/ags_devout.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/ags_recycling.c new/gsequencer-2.1.74/ags/audio/ags_recycling.c --- old/gsequencer-2.1.72/ags/audio/ags_recycling.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/ags_recycling.c 2019-06-01 20:20:05.000000000 +0200 @@ -953,6 +953,8 @@ pthread_mutexattr_destroy(recycling->obj_mutexattr); free(recycling->obj_mutexattr); + ags_uuid_free(recycling->uuid); + /* channel */ if(recycling->channel != NULL){ g_object_unref(recycling->channel); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/ags_synth_generator.c new/gsequencer-2.1.74/ags/audio/ags_synth_generator.c --- old/gsequencer-2.1.72/ags/audio/ags_synth_generator.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/ags_synth_generator.c 2019-06-01 20:20:05.000000000 +0200 @@ -845,7 +845,16 @@ audio_buffer_util_format = ags_audio_buffer_util_format_from_soundcard(format); current_attack = attack; - current_count = buffer_size - attack; + current_count = buffer_size; + + if(attack < buffer_size){ + current_count = buffer_size - attack; + }else{ + stream = g_list_nth(stream_start, + (guint) floor((double) attack / (double) buffer_size)); + + current_count = buffer_size - (attack % buffer_size); + } offset = 0; last_sync = 0; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/file/ags_audio_file_link.c new/gsequencer-2.1.74/ags/audio/file/ags_audio_file_link.c --- old/gsequencer-2.1.72/ags/audio/file/ags_audio_file_link.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/file/ags_audio_file_link.c 2019-06-01 20:20:05.000000000 +0200 @@ -616,6 +616,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/file/ags_audio_file_xml.c new/gsequencer-2.1.74/ags/audio/file/ags_audio_file_xml.c --- old/gsequencer-2.1.72/ags/audio/file/ags_audio_file_xml.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/file/ags_audio_file_xml.c 2019-06-01 20:20:05.000000000 +0200 @@ -1205,6 +1205,12 @@ ags_channel_set_link(channel, (AgsChannel *) id_ref->ref, &error); + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } } } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/file/ags_ipatch.c new/gsequencer-2.1.74/ags/audio/file/ags_ipatch.c --- old/gsequencer-2.1.72/ags/audio/file/ags_ipatch.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/file/ags_ipatch.c 2019-06-01 20:20:05.000000000 +0200 @@ -401,6 +401,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } } #endif @@ -875,6 +877,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } if(handle == NULL){ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/file/ags_ipatch_sample.c new/gsequencer-2.1.74/ags/audio/file/ags_ipatch_sample.c --- old/gsequencer-2.1.72/ags/audio/file/ags_ipatch_sample.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/file/ags_ipatch_sample.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -938,6 +938,8 @@ if(error != NULL){ g_message("%s", error->message); + + g_error_free(error); } ags_audio_buffer_util_copy_buffer_to_buffer(dbuffer, daudio_channels, 0, @@ -1043,6 +1045,12 @@ } break; } + + if(error != NULL){ + g_message("%s", error->message); + + g_error_free(error); + } ipatch_sample->offset += frame_count; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/midi/ags_midi_builder.c new/gsequencer-2.1.74/ags/audio/midi/ags_midi_builder.c --- old/gsequencer-2.1.72/ags/audio/midi/ags_midi_builder.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/midi/ags_midi_builder.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2015 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/midi/ags_midi_parser.c new/gsequencer-2.1.74/ags/audio/midi/ags_midi_parser.c --- old/gsequencer-2.1.72/ags/audio/midi/ags_midi_parser.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/midi/ags_midi_parser.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2015 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/pulse/ags_pulse_devin.c new/gsequencer-2.1.74/ags/audio/pulse/ags_pulse_devin.c --- old/gsequencer-2.1.72/ags/audio/pulse/ags_pulse_devin.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/pulse/ags_pulse_devin.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/pulse/ags_pulse_devout.c new/gsequencer-2.1.74/ags/audio/pulse/ags_pulse_devout.c --- old/gsequencer-2.1.72/ags/audio/pulse/ags_pulse_devout.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/pulse/ags_pulse_devout.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/recall/ags_copy_pattern_channel_run.c new/gsequencer-2.1.74/ags/audio/recall/ags_copy_pattern_channel_run.c --- old/gsequencer-2.1.72/ags/audio/recall/ags_copy_pattern_channel_run.c 2019-04-29 20:06:19.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/recall/ags_copy_pattern_channel_run.c 2019-06-01 20:20:05.000000000 +0200 @@ -921,6 +921,8 @@ g_object_set_property((GObject *) copy_note, "attack", &value); + }else{ + g_error_free(error); } /* get decay */ @@ -935,6 +937,8 @@ g_object_set_property((GObject *) copy_note, "decay", &value); + }else{ + g_error_free(error); } /* get sustain */ @@ -949,6 +953,8 @@ g_object_set_property((GObject *) copy_note, "sustain", &value); + }else{ + g_error_free(error); } /* get release */ @@ -963,6 +969,8 @@ g_object_set_property((GObject *) copy_note, "release", &value); + }else{ + g_error_free(error); } /* get ratio */ @@ -977,6 +985,8 @@ g_object_set_property((GObject *) copy_note, "ratio", &value); + }else{ + g_error_free(error); } g_value_unset(&value); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/task/ags_open_sf2_instrument.c new/gsequencer-2.1.74/ags/audio/task/ags_open_sf2_instrument.c --- old/gsequencer-2.1.72/ags/audio/task/ags_open_sf2_instrument.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/task/ags_open_sf2_instrument.c 2019-06-01 20:20:05.000000000 +0200 @@ -556,6 +556,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } /* get recycling */ @@ -573,8 +575,6 @@ g_object_set(channel, "file-link", file_link, NULL); - }else{ - g_object_unref(file_link); } g_object_set(file_link, @@ -584,6 +584,8 @@ "sample", ipatch_sf2_sample_get_name(AGS_IPATCH_SAMPLE(list->data)->sample), "audio-channel", j, NULL); + + g_object_unref(file_link); /* replace template audio signal */ AGS_AUDIO_SIGNAL(audio_signal->data)->flags |= AGS_AUDIO_SIGNAL_TEMPLATE; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/task/ags_open_sf2_sample.c new/gsequencer-2.1.74/ags/audio/task/ags_open_sf2_sample.c --- old/gsequencer-2.1.72/ags/audio/task/ags_open_sf2_sample.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/task/ags_open_sf2_sample.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -558,6 +558,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } } @@ -574,8 +576,6 @@ g_object_set(channel, "file-link", file_link, NULL); - }else{ - g_object_unref(file_link); } g_object_set(file_link, @@ -585,6 +585,8 @@ "sample", open_sf2_sample->sample, "audio-channel", open_sf2_sample->audio_channel, NULL); + + g_object_unref(file_link); } /* add as template */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/task/ags_open_single_file.c new/gsequencer-2.1.74/ags/audio/task/ags_open_single_file.c --- old/gsequencer-2.1.72/ags/audio/task/ags_open_single_file.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/task/ags_open_single_file.c 2019-06-01 20:20:05.000000000 +0200 @@ -367,6 +367,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } } @@ -383,8 +385,6 @@ g_object_set(channel, "file-link", file_link, NULL); - }else{ - g_object_unref(file_link); } g_object_set(file_link, @@ -394,6 +394,8 @@ "sample", NULL, "audio-channel", open_single_file->audio_channel, NULL); + + g_object_unref(file_link); } /* add as template */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/thread/ags_sequencer_thread.c new/gsequencer-2.1.74/ags/audio/thread/ags_sequencer_thread.c --- old/gsequencer-2.1.72/ags/audio/thread/ags_sequencer_thread.c 2019-05-04 17:18:16.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/thread/ags_sequencer_thread.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2015 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -441,6 +441,8 @@ if(error != NULL){ g_warning("ags_sequencer_thread - %s", error->message); + + g_error_free(error); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/audio/thread/ags_soundcard_thread.c new/gsequencer-2.1.74/ags/audio/thread/ags_soundcard_thread.c --- old/gsequencer-2.1.72/ags/audio/thread/ags_soundcard_thread.c 2019-05-04 17:18:16.000000000 +0200 +++ new/gsequencer-2.1.74/ags/audio/thread/ags_soundcard_thread.c 2019-06-01 20:20:05.000000000 +0200 @@ -496,6 +496,8 @@ g_warning("%s", error->message); + + g_error_free(error); } } } @@ -514,6 +516,8 @@ g_warning("%s", error->message); + + g_error_free(error); } } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/file/ags_file.c new/gsequencer-2.1.74/ags/file/ags_file.c --- old/gsequencer-2.1.72/ags/file/ags_file.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/file/ags_file.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2015 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -1314,12 +1314,19 @@ ags_file_close(file); } - error = NULL; g_object_set(file, "filename", filename, NULL); + + error = NULL; ags_file_open(file, &error); + + if(error != NULL){ + g_warning("%s", error); + + g_error_free(error); + } } /** diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/object/ags_config.c new/gsequencer-2.1.74/ags/object/ags_config.c --- old/gsequencer-2.1.72/ags/object/ags_config.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/object/ags_config.c 2019-06-01 20:20:05.000000000 +0200 @@ -799,6 +799,8 @@ if(error != NULL){ g_warning("%s", error->message); + + g_error_free(error); } if(buffer != NULL){ @@ -869,6 +871,10 @@ &error); if(error != NULL){ + g_warning("%s", error->message); + + g_error_free(error); + //TODO:JK: do recovery goto ags_config_save_END; } @@ -881,6 +887,12 @@ length, &error); + if(error != NULL){ + g_warning("%s", error->message); + + g_error_free(error); + } + ags_config_save_END: g_free(filename); } @@ -953,6 +965,12 @@ str = g_key_file_get_value(config->key_file, group, key, &error); + if(error != NULL){ +// g_warning("%s", error->message); + + g_error_free(error); + } + pthread_mutex_unlock(config_mutex); return(str); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/plugin/ags_dssi_manager.c new/gsequencer-2.1.74/ags/plugin/ags_dssi_manager.c --- old/gsequencer-2.1.72/ags/plugin/ags_dssi_manager.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/plugin/ags_dssi_manager.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -646,6 +646,8 @@ dssi_path++; + g_error_free(error); + continue; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/plugin/ags_ladspa_manager.c new/gsequencer-2.1.74/ags/plugin/ags_ladspa_manager.c --- old/gsequencer-2.1.72/ags/plugin/ags_ladspa_manager.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/plugin/ags_ladspa_manager.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -650,6 +650,8 @@ ladspa_path++; + g_error_free(error); + continue; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/plugin/ags_lv2_manager.c new/gsequencer-2.1.74/ags/plugin/ags_lv2_manager.c --- old/gsequencer-2.1.72/ags/plugin/ags_lv2_manager.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/plugin/ags_lv2_manager.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -1133,6 +1133,8 @@ lv2_path++; + g_error_free(error); + continue; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/plugin/ags_lv2ui_manager.c new/gsequencer-2.1.74/ags/plugin/ags_lv2ui_manager.c --- old/gsequencer-2.1.72/ags/plugin/ags_lv2ui_manager.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/plugin/ags_lv2ui_manager.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2018 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -989,6 +989,8 @@ lv2ui_path++; + g_error_free(error); + continue; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/server/security/ags_authentication_manager.c new/gsequencer-2.1.74/ags/server/security/ags_authentication_manager.c --- old/gsequencer-2.1.72/ags/server/security/ags_authentication_manager.c 2019-04-29 20:06:20.000000000 +0200 +++ new/gsequencer-2.1.74/ags/server/security/ags_authentication_manager.c 2019-06-01 20:20:05.000000000 +0200 @@ -1,5 +1,5 @@ /* GSequencer - Advanced GTK Sequencer - * Copyright (C) 2005-2017 Joël Krähemann + * Copyright (C) 2005-2019 Joël Krähemann * * This file is part of GSequencer. * @@ -179,7 +179,9 @@ } if(error != NULL){ - g_warning("%s\0", error->message); + g_warning("%s", error->message); + + g_error_free(error); } authentication = authentication->next; @@ -212,7 +214,9 @@ } if(error != NULL){ - g_warning("%s\0", error->message); + g_warning("%s", error->message); + + g_error_free(error); } authentication = authentication->next; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/ags/thread/ags_thread-posix.c new/gsequencer-2.1.74/ags/thread/ags_thread-posix.c --- old/gsequencer-2.1.72/ags/thread/ags_thread-posix.c 2019-04-29 20:06:21.000000000 +0200 +++ new/gsequencer-2.1.74/ags/thread/ags_thread-posix.c 2019-06-01 20:20:06.000000000 +0200 @@ -484,6 +484,8 @@ if(str != NULL){ thread->max_precision = g_ascii_strtod(str, NULL); + + g_free(str); } thread->mutexattr = (pthread_mutexattr_t *) malloc(sizeof(pthread_mutexattr_t)); @@ -761,8 +763,13 @@ } /* */ + pthread_mutex_destroy(thread->obj_mutex); + free(thread->obj_mutex); + pthread_mutexattr_destroy(thread->obj_mutexattr); free(thread->obj_mutexattr); + + ags_uuid_free(thread->uuid); /* */ free(thread->computing_time); @@ -782,6 +789,8 @@ &stackaddr, &stacksize); pthread_mutexattr_destroy(thread->mutexattr); + free(thread->mutexattr); + pthread_mutex_destroy(thread->mutex); free(thread->mutex); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gsequencer-2.1.72/configure.ac new/gsequencer-2.1.74/configure.ac --- old/gsequencer-2.1.72/configure.ac 2019-05-19 18:09:36.000000000 +0200 +++ new/gsequencer-2.1.74/configure.ac 2019-06-01 21:28:55.000000000 +0200 @@ -8,7 +8,7 @@ # Process this file with autoconf to produce a configure script. AC_PREREQ([2.69]) -AC_INIT([gsequencer],[2.1.72],[[email protected]]) +AC_INIT([gsequencer],[2.1.74],[[email protected]]) AM_INIT_AUTOMAKE([subdir-objects]) AC_CONFIG_SRCDIR([ags/config.h.in]) AC_CONFIG_HEADERS([ags/config.h])
