Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2019-06-22 11:24:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.4615 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Sat Jun 22 11:24:59 2019 rev:196 rq:711380 version:2.1.0 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2019-06-12 13:15:54.636715294 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.4615/virt-manager.changes 2019-06-22 11:25:02.285438930 +0200 @@ -1,0 +2,9 @@ +Thu Jun 13 14:15:44 MDT 2019 - carn...@suse.com + +- bsc#1138110 - XEN guest can not be restored from virt-manager + after it is saved + virtman-fix-restore-vm-menu-selection.patch +- Upstream bug fix (bsc#1027942) + 578451fe-urldetect-Dont-run-regex-against-None-SUSE-product-name.patch + +------------------------------------------------------------------- @@ -5 +14 @@ - can't handle directl kernel boot. (bsc#1125725) + can't handle direct kernel boot. (bsc#1125725) New: ---- 578451fe-urldetect-Dont-run-regex-against-None-SUSE-product-name.patch virtman-fix-restore-vm-menu-selection.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.xDZtYO/_old 2019-06-22 11:25:04.513441150 +0200 +++ /var/tmp/diff_new_pack.xDZtYO/_new 2019-06-22 11:25:04.513441150 +0200 @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via https://bugs.opensuse.org/ +# Please submit bugfixes or comments via http://bugs.opensuse.org/ # @@ -62,6 +62,7 @@ Patch27: 7afbb90b-virt-xml-Handle-VM-names-that-look-like-id-uuid.patch Patch28: 8d9743d6-virt-install-Add-support-for-xenbus-controller.patch Patch29: a0ca387a-cli-Fix-pool-default-when-path-belongs-to-another-pool.patch +Patch30: 578451fe-urldetect-Dont-run-regex-against-None-SUSE-product-name.patch # SUSE Only Patch70: virtman-desktop.patch Patch71: virtman-kvm.patch @@ -93,6 +94,7 @@ Patch153: virtman-check-for-valid-display.patch Patch154: virtman-allow-creating-i686-vm.patch Patch155: virtman-dont-specify-vte-version.patch +Patch156: virtman-fix-restore-vm-menu-selection.patch Patch160: virtinst-xen-drive-type.patch Patch161: virtinst-xenbus-disk-index-fix.patch Patch162: virtinst-refresh_before_fetch_pool.patch @@ -217,6 +219,7 @@ %patch27 -p1 %patch28 -p1 %patch29 -p1 +%patch30 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 @@ -248,6 +251,7 @@ %patch153 -p1 %patch154 -p1 %patch155 -p1 +%patch156 -p1 %patch160 -p1 %patch161 -p1 %patch162 -p1 ++++++ 578451fe-urldetect-Dont-run-regex-against-None-SUSE-product-name.patch ++++++ Subject: urldetect: Don't run regex against None SUSE product name From: Cole Robinson crobi...@redhat.com Mon Jun 10 08:42:39 2019 -0400 Date: Mon Jun 10 08:44:20 2019 -0400: Git: 578451fe721f8df0cf81c7d510a51af8fbe8179d We are implicitly depending on random dict ordering for what order we process Distro matching. Our test suite mocking and different debian ordering revealed a case we could be trying to run a regex against None. Fix it. The dict ordering issue will be fixed separately Index: virt-manager-2.1.0/virtinst/urldetect.py =================================================================== --- virt-manager-2.1.0.orig/virtinst/urldetect.py +++ virt-manager-2.1.0/virtinst/urldetect.py @@ -499,7 +499,7 @@ class _SuseDistro(_RHELDistro): if not cache.suse_content: return False for regex in cls._suse_regex: - if re.match(regex, cache.suse_content.product_name): + if re.match(regex, cache.suse_content.product_name or ""): return True return False ++++++ virtman-fix-restore-vm-menu-selection.patch ++++++ References: bsc#1138110 virt-manager no longer tracks the saved state but leaves it up to libvirt. Libvirt returns libvirt.VIR_DOMAIN_PMSUSPENDED after a vm has been 'saved'. --- virt-manager-2.1.0/virtManager/domain.py.orig 2019-06-13 13:53:44.915571869 -0600 +++ virt-manager-2.1.0/virtManager/domain.py 2019-06-13 14:11:40.413147729 -0600 @@ -1599,7 +1599,8 @@ class vmmDomain(vmmLibvirtObject): return (self.is_stoppable() or self.status() in [libvirt.VIR_DOMAIN_CRASHED]) def is_runable(self): - return self.is_shutoff() + return self.status() in [libvirt.VIR_DOMAIN_SHUTOFF, + libvirt.VIR_DOMAIN_PMSUSPENDED] def is_pauseable(self): return self.status() in [libvirt.VIR_DOMAIN_RUNNING] def is_unpauseable(self):
