Hello community, here is the log from the commit of package sessreg for openSUSE:Factory checked in at 2019-06-24 21:49:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/sessreg (Old) and /work/SRC/openSUSE:Factory/.sessreg.new.4615 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "sessreg" Mon Jun 24 21:49:59 2019 rev:12 rq:710098 version:1.1.2 Changes: -------- --- /work/SRC/openSUSE:Factory/sessreg/sessreg.changes 2017-03-05 17:56:35.778726081 +0100 +++ /work/SRC/openSUSE:Factory/.sessreg.new.4615/sessreg.changes 2019-06-24 21:50:00.755950049 +0200 @@ -1,0 +2,10 @@ +Tue Jun 11 09:37:50 UTC 2019 - Stefan Dirsch <[email protected]> + +- Update to version 1.1.2 + * Update README for gitlab migration + * Update configure.ac bug URL for gitlab migration + * Add comment about why safe_strncpy isn't replaced with strlcpy + * Fix missing defines _PATH_WTMPX/_PATH_UTMPX in musl + * Replace strncpy calls with a sane version that always terminates + +------------------------------------------------------------------- Old: ---- sessreg-1.1.1.tar.bz2 New: ---- sessreg-1.1.2.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ sessreg.spec ++++++ --- /var/tmp/diff_new_pack.lJqaes/_old 2019-06-24 21:50:02.335951278 +0200 +++ /var/tmp/diff_new_pack.lJqaes/_new 2019-06-24 21:50:02.387951319 +0200 @@ -1,7 +1,7 @@ # # spec file for package sessreg # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,12 +12,12 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # Name: sessreg -Version: 1.1.1 +Version: 1.1.2 Release: 0 Summary: Utility to manage utmp/wtmp entries for X sessions License: MIT @@ -51,7 +51,8 @@ %files %defattr(-,root,root) -%doc AUTHORS ChangeLog COPYING README +%doc AUTHORS ChangeLog README.md +%license COPYING %{_bindir}/sessreg %{_mandir}/man1/sessreg.1%{?ext_man} ++++++ sessreg-1.1.1.tar.bz2 -> sessreg-1.1.2.tar.bz2 ++++++ ++++ 3032 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.1.1/ChangeLog new/sessreg-1.1.2/ChangeLog --- old/sessreg-1.1.1/ChangeLog 2017-02-28 03:26:06.000000000 +0100 +++ new/sessreg-1.1.2/ChangeLog 2019-06-09 20:40:44.000000000 +0200 @@ -1,3 +1,60 @@ +commit 3a91ab7d228f4c1a28970e447cff7d1a960db2fe +Author: Alan Coopersmith <[email protected]> +Date: Sun Jun 9 11:39:22 2019 -0700 + + sessreg 1.1.2 + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit 600d183bf6f6967b53a3f2a0e31e8d90a5c13f18 +Author: Alan Coopersmith <[email protected]> +Date: Sun Jun 9 11:08:08 2019 -0700 + + Add comment about why safe_strncpy isn't replaced with strlcpy + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit 5b403d124c32c20fddc73bc5ae3c7e1febdf1bc4 +Author: Fabrice Fontaine <[email protected]> +Date: Fri May 3 07:48:06 2019 +0200 + + Fix missing defines _PATH_WTMPX/_PATH_UTMPX in musl + + Downloaded from + https://cgit.gentoo.org/proj/musl.git/tree/x11-apps/sessreg/files/sessreg-1.1.0-missing_path_wtmpx.patch + + Signed-off-by: Bernd Kuhls <[email protected]> + [Retrieved from: + https://git.buildroot.net/buildroot/tree/package/x11r7/xapp_sessreg/0001-missing_path_wtmpx.patch] + Signed-off-by: Fabrice Fontaine <[email protected]> + +commit fd3c8491d9dbe20bab67dfc19ebcfe763e9a01d8 +Author: Alan Coopersmith <[email protected]> +Date: Wed Nov 21 16:56:46 2018 -0800 + + Update configure.ac bug URL for gitlab migration + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit 8c8e2321127d54e2729d4dc2cd08e8f34c35071e +Author: Alan Coopersmith <[email protected]> +Date: Fri Nov 16 20:44:21 2018 -0800 + + Update README for gitlab migration + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit 653dc1e61cd9d4d4921158a2c5dec49962bb9f0a +Author: Peter Hutterer <[email protected]> +Date: Wed Sep 12 14:46:05 2018 +1000 + + Replace strncpy calls with a sane version that always terminates + + Fixes coverity complaints about potentially unterminated strings + + Signed-off-by: Peter Hutterer <[email protected]> + Reviewed-by: Alan Coopersmith <[email protected]> + commit 5457109783ee82599aeb6c6a690cc921a881d6bf Author: Matt Turner <[email protected]> Date: Mon Feb 27 18:25:03 2017 -0800 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.1.1/Makefile.am new/sessreg-1.1.2/Makefile.am --- old/sessreg-1.1.1/Makefile.am 2017-02-28 03:24:47.000000000 +0100 +++ new/sessreg-1.1.2/Makefile.am 2019-06-09 20:40:29.000000000 +0200 @@ -46,3 +46,5 @@ $(CHANGELOG_CMD) dist-hook: ChangeLog INSTALL + +EXTRA_DIST = README.md diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.1.1/README new/sessreg-1.1.2/README --- old/sessreg-1.1.1/README 2017-02-28 03:24:47.000000000 +0100 +++ new/sessreg-1.1.2/README 1970-01-01 01:00:00.000000000 +0100 @@ -1,27 +0,0 @@ -Sessreg is a simple program for managing utmp/wtmp entries for X sessions. -It was originally written for use with xdm, but may also be used with -other display managers such as gdm or kdm. - -All questions regarding this software should be directed at the -Xorg mailing list: - - http://lists.freedesktop.org/mailman/listinfo/xorg - -Please submit bug reports to the Xorg bugzilla: - - https://bugs.freedesktop.org/enter_bug.cgi?product=xorg - -The master development code repository can be found at: - - git://anongit.freedesktop.org/git/xorg/app/sessreg - - http://cgit.freedesktop.org/xorg/app/sessreg - -For patch submission instructions, see: - - http://www.x.org/wiki/Development/Documentation/SubmittingPatches - -For more information on the git code manager, see: - - http://wiki.x.org/wiki/GitPage - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.1.1/README.md new/sessreg-1.1.2/README.md --- old/sessreg-1.1.1/README.md 1970-01-01 01:00:00.000000000 +0100 +++ new/sessreg-1.1.2/README.md 2019-06-09 20:40:29.000000000 +0200 @@ -0,0 +1,19 @@ +Sessreg is a simple program for managing utmp/wtmp entries for X sessions. +It was originally written for use with xdm, but may also be used with +other display managers such as gdm or kdm. + +All questions regarding this software should be directed at the +Xorg mailing list: + + https://lists.x.org/mailman/listinfo/xorg + +The master development code repository can be found at: + + https://gitlab.freedesktop.org/xorg/app/sessreg + +Please submit bug reports and requests to merge patches there. + +For patch submission instructions, see: + + https://www.x.org/wiki/Development/Documentation/SubmittingPatches + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.1.1/configure.ac new/sessreg-1.1.2/configure.ac --- old/sessreg-1.1.1/configure.ac 2017-02-28 03:25:01.000000000 +0100 +++ new/sessreg-1.1.2/configure.ac 2019-06-09 20:40:29.000000000 +0200 @@ -22,8 +22,8 @@ # Initialize Autoconf AC_PREREQ([2.60]) -AC_INIT([sessreg], [1.1.1], - [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg], [sessreg]) +AC_INIT([sessreg], [1.1.2], + [https://gitlab.freedesktop.org/xorg/app/sessreg/issues], [sessreg]) AC_CONFIG_SRCDIR([Makefile.am]) AC_CONFIG_HEADERS([config.h]) AC_USE_SYSTEM_EXTENSIONS diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.1.1/sessreg.c new/sessreg-1.1.2/sessreg.c --- old/sessreg-1.1.1/sessreg.c 2017-02-28 03:24:47.000000000 +0100 +++ new/sessreg-1.1.2/sessreg.c 2019-06-09 20:40:29.000000000 +0200 @@ -192,6 +192,20 @@ return x; } +/* + * While this looks like it could be replaced with strlcpy() on platforms + * that have it, we're sticking with strncpy() so that we zero out the + * whole buffer to avoid writing garbage to the fixed length fields in the + * utmp/wtmp files, since strlcpy() does not write past the \0 terminator. + */ +static void +safe_strncpy(char *dest, const char *src, size_t n) +{ + (void)strncpy(dest, src, n); + if (n > 0) + dest[n - 1] = '\0'; +} + int main (int argc, char **argv) { @@ -406,9 +420,9 @@ memset(&ll, 0, sizeof(ll)); ll.ll_time = current_time; if (line) - (void) strncpy (ll.ll_line, line, sizeof (ll.ll_line)); + safe_strncpy (ll.ll_line, line, sizeof (ll.ll_line)); if (host_name) - (void) strncpy (ll.ll_host, host_name, sizeof (ll.ll_host)); + safe_strncpy (ll.ll_host, host_name, sizeof (ll.ll_host)); sysnerr (write (llog, (char *) &ll, sizeof (ll)) == sizeof (ll), "write lastlog entry"); @@ -429,11 +443,11 @@ { memset (u, 0, sizeof (*u)); if (line) - (void) strncpy (u->ut_line, line, sizeof (u->ut_line)); + safe_strncpy (u->ut_line, line, sizeof (u->ut_line)); else memset (u->ut_line, 0, sizeof (u->ut_line)); if (addp && user) - (void) strncpy (u->ut_name, user, sizeof (u->ut_name)); + safe_strncpy (u->ut_name, user, sizeof (u->ut_name)); else memset (u->ut_name, 0, sizeof (u->ut_name)); #ifdef HAVE_STRUCT_UTMP_UT_ID @@ -451,7 +465,7 @@ i -= sizeof (u->ut_id); else i = 0; - (void) strncpy (u->ut_id, line + i, sizeof (u->ut_id)); + safe_strncpy (u->ut_id, line + i, sizeof (u->ut_id)); } else memset (u->ut_id, 0, sizeof (u->ut_id)); #endif @@ -469,7 +483,7 @@ #endif #ifdef HAVE_STRUCT_UTMP_UT_HOST if (addp && host) - (void) strncpy (u->ut_host, host, sizeof (u->ut_host)); + safe_strncpy (u->ut_host, host, sizeof (u->ut_host)); else memset (u->ut_host, 0, sizeof (u->ut_host)); #endif @@ -513,9 +527,9 @@ if(strcmp(line, ":0") == 0) (void) strcpy(u->ut_line, "console"); else - (void) strncpy (u->ut_line, line, sizeof (u->ut_line)); + safe_strncpy (u->ut_line, line, sizeof (u->ut_line)); - strncpy(u->ut_host, line, sizeof(u->ut_host)); + safe_strncpy(u->ut_host, line, sizeof(u->ut_host)); #ifdef HAVE_STRUCT_UTMPX_UT_SYSLEN u->ut_syslen = strlen(line); #endif @@ -523,7 +537,7 @@ else memset (u->ut_line, 0, sizeof (u->ut_line)); if (addp && user) - (void) strncpy (u->ut_user, user, sizeof (u->ut_user)); + safe_strncpy (u->ut_user, user, sizeof (u->ut_user)); else memset (u->ut_user, 0, sizeof (u->ut_user)); @@ -541,7 +555,7 @@ i -= sizeof (u->ut_id); else i = 0; - (void) strncpy (u->ut_id, line + i, sizeof (u->ut_id)); + safe_strncpy (u->ut_id, line + i, sizeof (u->ut_id)); /* make sure there is no entry using identical ut_id */ if (!UtmpxIdOpen(u->ut_id) && addp) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.1.1/sessreg.h new/sessreg-1.1.2/sessreg.h --- old/sessreg-1.1.1/sessreg.h 2017-02-28 03:24:47.000000000 +0100 +++ new/sessreg-1.1.2/sessreg.h 2019-06-09 20:40:29.000000000 +0200 @@ -103,6 +103,13 @@ # define TTYS_FILE "/etc/ttys" #endif +#ifndef _PATH_WTMPX +# define _PATH_WTMPX "/var/log/wtmp" +#endif +#ifndef _PATH_UTMPX +# define _PATH_UTMPX "/var/log/utmp" +#endif + #ifndef WTMPX_FILE # define WTMPX_FILE _PATH_WTMPX #endif
