Hello community, here is the log from the commit of package trinity for openSUSE:Factory checked in at 2019-06-27 15:26:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/trinity (Old) and /work/SRC/openSUSE:Factory/.trinity.new.4615 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "trinity" Thu Jun 27 15:26:18 2019 rev:56 rq:712154 version:1.9+git.20190614 Changes: -------- --- /work/SRC/openSUSE:Factory/trinity/trinity.changes 2019-06-19 21:01:57.518166617 +0200 +++ /work/SRC/openSUSE:Factory/.trinity.new.4615/trinity.changes 2019-06-27 15:26:19.777604575 +0200 @@ -1,0 +2,8 @@ +Wed Jun 26 14:20:56 UTC 2019 - Martin Pluskal <[email protected]> + +- Update to version 1.9+git.20190614: + * memfd build fixes for modern glibc + * cppcheck fixes + * strncpy -> memcpy + +------------------------------------------------------------------- Old: ---- trinity-1.9+git.20190124.tar.xz New: ---- trinity-1.9+git.20190614.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ trinity.spec ++++++ --- /var/tmp/diff_new_pack.yyLD2C/_old 2019-06-27 15:26:20.177605077 +0200 +++ /var/tmp/diff_new_pack.yyLD2C/_new 2019-06-27 15:26:20.181605082 +0200 @@ -16,9 +16,9 @@ # -%define version_unconverted 1.9+git.20190124 +%define version_unconverted 1.9+git.20190614 Name: trinity -Version: 1.9+git.20190124 +Version: 1.9+git.20190614 Release: 0 Summary: A Linux System call fuzz tester License: GPL-2.0-only ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.yyLD2C/_old 2019-06-27 15:26:20.217605127 +0200 +++ /var/tmp/diff_new_pack.yyLD2C/_new 2019-06-27 15:26:20.217605127 +0200 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">git://github.com/kernelslacker/trinity</param> - <param name="changesrevision">865d3fc2e9d402bf5c213706dc97939569fd606b</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">2d0c1817b57022072d2b7dae9ad8f1ac3127cd13</param></service></servicedata> \ No newline at end of file ++++++ trinity-1.9+git.20190124.tar.xz -> trinity-1.9+git.20190614.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/trinity-1.9+git.20190124/fds/memfd.c new/trinity-1.9+git.20190614/fds/memfd.c --- old/trinity-1.9+git.20190124/fds/memfd.c 2019-01-24 21:43:11.000000000 +0100 +++ new/trinity-1.9+git.20190614/fds/memfd.c 2019-06-14 18:40:20.000000000 +0200 @@ -18,6 +18,8 @@ #include "udp.h" #ifndef USE_MEMFD_CREATE + +#ifndef MFD_ALLOW_SEALING static int memfd_create(__unused__ const char *uname, __unused__ unsigned int flag) { #ifdef SYS_memfd_create @@ -27,6 +29,7 @@ #endif } #endif +#endif static void memfd_destructor(struct object *obj) { @@ -45,7 +48,7 @@ init_msgobjhdr(&objmsg.hdr, OBJ_CREATED_MEMFD, global, obj); objmsg.fd = mo->fd; len = strlen(mo->name); - strncpy(objmsg.name, mo->name, len); + memcpy(objmsg.name, mo->name, len); objmsg.flags = mo->flags; sendudp((char *) &objmsg, sizeof(objmsg)); } @@ -58,7 +61,7 @@ 0, MFD_CLOEXEC, MFD_CLOEXEC | MFD_ALLOW_SEALING, - MFD_ALLOW_SEALING, + MFD_ALLOW_SEALING, MFD_HUGETLB, }; head = get_objhead(OBJ_GLOBAL, OBJ_FD_MEMFD); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/trinity-1.9+git.20190124/include/memfd.h new/trinity-1.9+git.20190614/include/memfd.h --- old/trinity-1.9+git.20190124/include/memfd.h 2019-01-24 21:43:11.000000000 +0100 +++ new/trinity-1.9+git.20190614/include/memfd.h 2019-06-14 18:40:20.000000000 +0200 @@ -3,6 +3,7 @@ #ifndef MFD_CLOEXEC #define MFD_CLOEXEC 0x0001U #define MFD_ALLOW_SEALING 0x0002U +#define MFD_HUGETLB 0x0004U #endif // FIXME: Keep all this here until glibc supports it. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/trinity-1.9+git.20190124/mm/maps.c new/trinity-1.9+git.20190614/mm/maps.c --- old/trinity-1.9+git.20190124/mm/maps.c 2019-01-24 21:43:11.000000000 +0100 +++ new/trinity-1.9+git.20190614/mm/maps.c 2019-06-14 18:40:20.000000000 +0200 @@ -72,7 +72,7 @@ init_msgobjhdr(&objmsg.hdr, OBJ_CREATED_MAP, global, obj); objmsg.start = m->ptr; len = strlen(m->name); - strncpy(objmsg.name, m->name, len); + memcpy(objmsg.name, m->name, len); memset(objmsg.name + len, 0, MAPS_NAME_MAX_LEN - len); objmsg.prot = m->prot; objmsg.type = m->type; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/trinity-1.9+git.20190124/pathnames.c new/trinity-1.9+git.20190614/pathnames.c --- old/trinity-1.9+git.20190124/pathnames.c 2019-01-24 21:43:11.000000000 +0100 +++ new/trinity-1.9+git.20190614/pathnames.c 2019-06-14 18:40:20.000000000 +0200 @@ -117,7 +117,7 @@ int check_stat_file(const struct stat *sb) { - int openflag; + int openflag = 0; bool set_read = FALSE; bool set_write = FALSE; uid_t target_uid = orig_uid; @@ -295,13 +295,13 @@ len = strlen(pathname); if (RAND_BOOL()) - (void) strncpy(newpath, pathname, len); + (void) memcpy(newpath, pathname, len); else { if (len < MAX_PATH_LEN - 2) { /* make it look relative to cwd */ newpath[0] = '.'; newpath[1] = '/'; - (void) strncpy(newpath + 2, pathname, len); + (void) memcpy(newpath + 2, pathname, len); len += 2; } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/trinity-1.9+git.20190124/syscalls/mlockall.c new/trinity-1.9+git.20190614/syscalls/mlockall.c --- old/trinity-1.9+git.20190124/syscalls/mlockall.c 2019-01-24 21:43:11.000000000 +0100 +++ new/trinity-1.9+git.20190614/syscalls/mlockall.c 2019-06-14 18:40:20.000000000 +0200 @@ -18,19 +18,6 @@ #define MCL_ONFAULT 4 #endif -static void sanitise_mlockall(struct syscallrecord *rec) -{ - if (rec->a1 != 0) - return; - - /* - * There are two invalid bit patterns for MCL flags, 0, and MCL_ONFAULT - * alone. All other combinations should be valid. - */ - while (rec->a1 == 0 || rec->a1 == MCL_ONFAULT) - rec->a1 = (RAND_BYTE() & 0x07); -} - static unsigned long mlockall_flags[] = { MCL_CURRENT, MCL_FUTURE, MCL_ONFAULT, }; @@ -42,5 +29,4 @@ .arg1type = ARG_LIST, .arg1list = ARGLIST(mlockall_flags), .group = GROUP_VM, - .sanitise = sanitise_mlockall, };
