Hello community, here is the log from the commit of package slick-greeter for openSUSE:Factory checked in at 2019-07-16 08:41:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/slick-greeter (Old) and /work/SRC/openSUSE:Factory/.slick-greeter.new.1887 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "slick-greeter" Tue Jul 16 08:41:06 2019 rev:17 rq:715236 version:1.2.5 Changes: -------- --- /work/SRC/openSUSE:Factory/slick-greeter/slick-greeter.changes 2019-05-28 09:43:19.181843151 +0200 +++ /work/SRC/openSUSE:Factory/.slick-greeter.new.1887/slick-greeter.changes 2019-07-16 08:41:17.039035429 +0200 @@ -1,0 +2,9 @@ +Mon Jul 8 02:53:58 UTC 2019 - Dead Mozay <[email protected]> + +- Update to version 1.2.5: + * Packaging: Fix Debian build (#122) + * remove mlockall (#127) + * Remove slick-greeter-1.2.4-FTBFS-vala-0.43.patch -- Fix Upstream FTBFS with vala 0.43 (#131) + * Fixed default session for manual user entry. (#129) + +------------------------------------------------------------------- Old: ---- slick-greeter-1.2.4-FTBFS-vala-0.43.patch slick-greeter-1.2.4.tar.gz New: ---- slick-greeter-1.2.5.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ slick-greeter.spec ++++++ --- /var/tmp/diff_new_pack.iykaq0/_old 2019-07-16 08:41:17.723035658 +0200 +++ /var/tmp/diff_new_pack.iykaq0/_new 2019-07-16 08:41:17.723035658 +0200 @@ -18,7 +18,7 @@ %define _name lightdm-slick-greeter Name: slick-greeter -Version: 1.2.4 +Version: 1.2.5 Release: 0 Summary: The slick-looking login screen application License: GPL-3.0-only AND CC-BY-SA-3.0 @@ -29,12 +29,11 @@ Source1: README.GSettings-overrides # PATCH-FEATURE-OPENSUSE slick-greeter-gtk-3.20.patch -- Restore GTK+ 3.20 support. Patch0: slick-greeter-gtk-3.20.patch -# PATCH-FIX-UPSTREAM slick-greeter-1.2.4-FTBFS-vala-0.43.patch -- fix tumbleweed build -Patch1: slick-greeter-1.2.4-FTBFS-vala-0.43.patch BuildRequires: gnome-common BuildRequires: pkgconfig BuildRequires: vala >= 0.24 BuildRequires: pkgconfig(cairo-ft) +BuildRequires: pkgconfig(dbus-glib-1) BuildRequires: pkgconfig(freetype2) BuildRequires: pkgconfig(gdk-x11-3.0) BuildRequires: pkgconfig(gio-2.0) @@ -91,7 +90,6 @@ %setup -q cp -a %{SOURCE1} . %patch0 -p1 -%patch1 -p1 %build NOCONFIGURE=1 gnome-autogen.sh ++++++ slick-greeter-1.2.4.tar.gz -> slick-greeter-1.2.5.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/.circleci/config.yml new/slick-greeter-1.2.5/.circleci/config.yml --- old/slick-greeter-1.2.4/.circleci/config.yml 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/.circleci/config.yml 2019-07-01 10:11:59.000000000 +0200 @@ -51,8 +51,14 @@ docker: - image: linuxmintd/mint19-amd64 + "lmde3": + <<: *shared + docker: + - image: linuxmintd/lmde3-amd64 + workflows: version: 2 build: jobs: - "mint19" + - "lmde3" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/README.md new/slick-greeter-1.2.5/README.md --- old/slick-greeter-1.2.4/README.md 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/README.md 2019-07-01 10:11:59.000000000 +0200 @@ -24,10 +24,6 @@ - Slick Greeter started as a fork of Unity Greeter 16.04.2, a greeter developed for Ubuntu by Canonical, which used indicators and unity-settings-daemon. -# Notes - -- Debian's lightdm packaging differs from Ubuntu's. To compile under Debian, build-deps have to be changed: liblightdm-gobject-1-dev needs to be removed, and liblightdm-gobject-dev and lightdm-vala have to be added. - ---- Configuration file format for /etc/lightdm/slick-greeter.conf diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/configure.ac new/slick-greeter-1.2.5/configure.ac --- old/slick-greeter-1.2.4/configure.ac 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/configure.ac 2019-07-01 10:11:59.000000000 +0200 @@ -2,7 +2,7 @@ dnl Process this file with autoconf to produce a configure script. -AC_INIT(slick-greeter, 1.2.4) +AC_INIT(slick-greeter, 1.2.5) AC_CONFIG_MACRO_DIR(m4) AM_INIT_AUTOMAKE([1.11 no-dist-gzip dist-xz foreign subdir-objects]) AM_PROG_CC_C_O diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/debian/changelog new/slick-greeter-1.2.5/debian/changelog --- old/slick-greeter-1.2.4/debian/changelog 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/debian/changelog 2019-07-01 10:11:59.000000000 +0200 @@ -1,3 +1,19 @@ +slick-greeter (1.2.5) tina; urgency=medium + + [ Clement Lefebvre ] + * Packaging: Fix Debian build (#122) + + [ Leigh Scott ] + * remove mlockall (#127) + + [ David Mohammed ] + * Fix FTBFS with vala 0.43 (#131) + + [ mwileczka ] + * Fixed default session for manual user entry. (#129) + + -- Clement Lefebvre <[email protected]> Mon, 01 Jul 2019 10:11:40 +0200 + slick-greeter (1.2.4) tessa; urgency=medium * l10n: Update translations diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/debian/control new/slick-greeter-1.2.5/debian/control --- old/slick-greeter-1.2.4/debian/control 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/debian/control 2019-07-01 10:11:59.000000000 +0200 @@ -11,7 +11,8 @@ ttf-ubuntu-font-family, libcanberra-dev, libgtk-3-dev, - liblightdm-gobject-1-dev (>= 1.4.0), + liblightdm-gobject-1-dev | liblightdm-gobject-dev, + liblightdm-gobject-1-dev | lightdm-vala, libpixman-1-dev, valac (>= 0.20.0), xvfb diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/src/list-stack.vala new/slick-greeter-1.2.5/src/list-stack.vala --- old/slick-greeter-1.2.4/src/list-stack.vala 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/src/list-stack.vala 2019-07-01 10:11:59.000000000 +0200 @@ -72,7 +72,7 @@ return_if_fail (children != null); - unowned List<Gtk.Widget> prev = children.last ().prev; + unowned List<weak Gtk.Widget> prev = children.last ().prev; if (prev != null) (prev.data as GreeterList).greeter_box.pop (); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/src/slick-greeter.vala new/slick-greeter-1.2.5/src/slick-greeter.vala --- old/slick-greeter-1.2.4/src/slick-greeter.vala 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/src/slick-greeter.vala 2019-07-01 10:11:59.000000000 +0200 @@ -544,8 +544,30 @@ public static int main (string[] args) { - /* Protect memory from being paged to disk, as we deal with passwords */ - Posix.mlockall (Posix.MCL_CURRENT | Posix.MCL_FUTURE); + /* Protect memory from being paged to disk, as we deal with passwords + + According to systemd-dev, + + "mlockall() is generally a bad idea and certainly has no place in a graphical program. + A program like this uses lots of memory and it is crucial that this memory can be paged + out to relieve memory pressure." + + With systemd version 239 the ulimit for RLIMIT_MEMLOCK was set to 16 MiB + and therefore the mlockall call would fail. This is lucky becasue the subsequent mmap would not fail. + + With systemd version 240 the RLIMIT_MEMLOCK is now set to 64 MiB + and now the mlockall no longer fails. However, it not possible to mmap in all + the memory and because that would still exceed the MEMLOCK limit. + " + See https://bugzilla.redhat.com/show_bug.cgi?id=1662857 & + https://github.com/CanonicalLtd/lightdm/issues/55 + + RLIMIT_MEMLOCK = 64 MiB means, slick-greeter will most likely fail with 64 bit and + will always fail on 32 bit systems. + + Hence we better disable it. */ + + /*Posix.mlockall (Posix.MCL_CURRENT | Posix.MCL_FUTURE);*/ /* Disable global menubar */ Environment.unset_variable ("UBUNTU_MENUPROXY"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/slick-greeter-1.2.4/src/user-list.vala new/slick-greeter-1.2.5/src/user-list.vala --- old/slick-greeter-1.2.4/src/user-list.vala 2018-12-11 15:43:51.000000000 +0100 +++ new/slick-greeter-1.2.5/src/user-list.vala 2019-07-01 10:11:59.000000000 +0200 @@ -854,6 +854,10 @@ } e.background = background; e.is_active = is_active; + if ( session == null) + { + session = default_session; + } e.session = SlickGreeter.validate_session (session); e.label = label; e.set_show_message_icon (has_messages);
