Hello community, here is the log from the commit of package attica-qt5 for openSUSE:Factory checked in at 2019-07-26 12:06:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/attica-qt5 (Old) and /work/SRC/openSUSE:Factory/.attica-qt5.new.4126 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "attica-qt5" Fri Jul 26 12:06:58 2019 rev:69 rq:715847 version:5.60.0 Changes: -------- --- /work/SRC/openSUSE:Factory/attica-qt5/attica-qt5.changes 2019-06-22 11:06:45.516072763 +0200 +++ /work/SRC/openSUSE:Factory/.attica-qt5.new.4126/attica-qt5.changes 2019-07-26 12:07:00.650881736 +0200 @@ -1,0 +2,11 @@ +Sun Jul 14 06:41:36 UTC 2019 - [email protected] + +- Update to 5.60.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.60.0.php +- Changes since 5.59.0: + * Add some documentation for PlatformDependent + * Install in new logging directory when we use kf5 5.59.0 + +------------------------------------------------------------------- Old: ---- attica-5.59.0.tar.xz New: ---- attica-5.60.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ attica-qt5.spec ++++++ --- /var/tmp/diff_new_pack.J9CrP8/_old 2019-07-26 12:07:01.338881627 +0200 +++ /var/tmp/diff_new_pack.J9CrP8/_new 2019-07-26 12:07:01.338881627 +0200 @@ -19,13 +19,13 @@ %define sonum 5 %define rname attica %define _libname KF5Attica -%define _tar_path 5.59 +%define _tar_path 5.60 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: attica-qt5 -Version: 5.59.0 +Version: 5.60.0 Release: 0 Summary: Open Collaboration Service client library License: LGPL-2.1-or-later @@ -84,7 +84,7 @@ %files %license COPYING* %doc README* -%config %{_kf5_configdir}/attica.categories +%{_kf5_debugdir}/attica.categories %files -n lib%{_libname}%{sonum} %license COPYING* ++++++ attica-5.59.0.tar.xz -> attica-5.60.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.59.0/CMakeLists.txt new/attica-5.60.0/CMakeLists.txt --- old/attica-5.59.0/CMakeLists.txt 2019-06-01 18:35:20.000000000 +0200 +++ new/attica-5.60.0/CMakeLists.txt 2019-07-06 15:12:48.000000000 +0200 @@ -1,11 +1,11 @@ cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.59.0") # handled by release scripts +set(KF5_VERSION "5.60.0") # handled by release scripts project(Attica VERSION ${KF5_VERSION}) # ECM setup include(FeatureSummary) -find_package(ECM 5.59.0 NO_MODULE) +find_package(ECM 5.60.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -31,7 +31,7 @@ SOVERSION 5) # Dependencies -set(REQUIRED_QT_VERSION 5.10.0) +set(REQUIRED_QT_VERSION 5.11.0) # Required Qt5 components to build this framework find_package(Qt5 ${REQUIRED_QT_VERSION} NO_MODULE REQUIRED Core Network) @@ -85,7 +85,7 @@ DESTINATION "${KDE_INSTALL_INCLUDEDIR_KF5}" COMPONENT Devel) -install( FILES attica.categories DESTINATION ${KDE_INSTALL_CONFDIR}) +install(FILES attica.categories DESTINATION ${KDE_INSTALL_LOGGINGCATEGORIESDIR}) feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/attica-5.59.0/src/platformdependent.h new/attica-5.60.0/src/platformdependent.h --- old/attica-5.59.0/src/platformdependent.h 2019-06-01 18:35:20.000000000 +0200 +++ new/attica-5.60.0/src/platformdependent.h 2019-07-06 15:12:48.000000000 +0200 @@ -54,10 +54,33 @@ virtual void enableProvider(const QUrl &baseUrl, bool enabled) const = 0; virtual bool isEnabled(const QUrl &baseUrl) const = 0; + /** + * Asks the PlatformDependent plugin if it have a credentials for baseUrl + */ virtual bool hasCredentials(const QUrl &baseUrl) const = 0; + + /** + * Asks the PlatformDependent plugin to load credentials from storage, + * and save it in user, password. + */ virtual bool loadCredentials(const QUrl &baseUrl, QString &user, QString &password) = 0; + + /** + * Asks the PlatformDependent plugin to ask user to login and expects it to be stored in + * user and password. + * TODO KF6: Remove, askForCredentials and loadCredentials is essentially same, loadCredentials + * can itself ask for credentials if it is not present in store. + */ virtual bool askForCredentials(const QUrl &baseUrl, QString &user, QString &password) = 0; + + /** + * Method to be called by attica to store the user and password in storage used by PlatformDependent + * plugin. + * TODO KF6: Remove, if you let platform plugin ask for credentials, you don't want to save credentials + * yourself and let plugin handle it. + */ virtual bool saveCredentials(const QUrl &baseUrl, const QString &user, const QString &password) = 0; + virtual QNetworkReply *get(const QNetworkRequest &request) = 0; virtual QNetworkReply *post(const QNetworkRequest &request, QIODevice *data) = 0; virtual QNetworkReply *post(const QNetworkRequest &request, const QByteArray &data) = 0;
