Hello community, here is the log from the commit of package ignition for openSUSE:Factory checked in at 2019-07-26 12:44:55 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ignition (Old) and /work/SRC/openSUSE:Factory/.ignition.new.4126 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ignition" Fri Jul 26 12:44:55 2019 rev:3 rq:718776 version:2.0.1+git20190725.10b85d1 Changes: -------- --- /work/SRC/openSUSE:Factory/ignition/ignition.changes 2019-06-20 18:56:21.280924266 +0200 +++ /work/SRC/openSUSE:Factory/.ignition.new.4126/ignition.changes 2019-07-26 12:45:00.825818094 +0200 @@ -1,0 +2,12 @@ +Fri Jul 26 08:36:17 UTC 2019 - [email protected] + +- Update to version 2.0.1+git20190725.10b85d1: + * release-checklist: add step to submit to bodhi + * news: add news for v2.0.1 + * config/v*: run Node.Validate() as well + * doc/getting-started: rm online validator section + * providers/aws: get region after getting config. + * providers: allow FetchConfig to mutate the fetcher + * release-checklist: fix for new website and jenkins + +------------------------------------------------------------------- Old: ---- ignition-2.0.0+git20190603.0c1da80.tar.xz New: ---- ignition-2.0.1+git20190725.10b85d1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ignition.spec ++++++ --- /var/tmp/diff_new_pack.XHo3Nw/_old 2019-07-26 12:45:01.433817711 +0200 +++ /var/tmp/diff_new_pack.XHo3Nw/_new 2019-07-26 12:45:01.433817711 +0200 @@ -1,7 +1,7 @@ # # spec file for package ignition # -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,20 +12,22 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ +# + Name: ignition -Version: 2.0.0+git20190603.0c1da80 +Version: 2.0.1+git20190725.10b85d1 Release: 0 -Group: System/Management Summary: First boot installer and configuration tool License: Apache-2.0 +Group: System/Management URL: https://github.com/coreos/ignition Source: %{name}-%{version}.tar.xz Requires: dracut BuildRequires: dracut -BuildRequires: go BuildRequires: libblkid-devel +BuildRequires: golang(API) >= 1.12 %description Ignition is an utility to manipulate disks and configuration files ++++++ _service ++++++ --- /var/tmp/diff_new_pack.XHo3Nw/_old 2019-07-26 12:45:01.457817696 +0200 +++ /var/tmp/diff_new_pack.XHo3Nw/_new 2019-07-26 12:45:01.461817694 +0200 @@ -1,7 +1,7 @@ <services> <service name="tar_scm" mode="disabled"> - <param name="version">2.0.0</param> - <param name="versionformat">2.0.0+git%cd.%h</param> + <param name="version">2.0.1</param> + <param name="versionformat">2.0.1+git%cd.%h</param> <param name="url">git://github.com/coreos/ignition.git</param> <param name="scm">git</param> <param name="changesgenerate">enable</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.XHo3Nw/_old 2019-07-26 12:45:01.477817683 +0200 +++ /var/tmp/diff_new_pack.XHo3Nw/_new 2019-07-26 12:45:01.477817683 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">git://github.com/coreos/ignition.git</param> - <param name="changesrevision">f3054d67b590480ccb9fee2fe89914d25870ee0f</param> + <param name="changesrevision">7efe9588b06ff41147bc3a92236cf3bd44459fce</param> </service> </servicedata> \ No newline at end of file ++++++ ignition-2.0.0+git20190603.0c1da80.tar.xz -> ignition-2.0.1+git20190725.10b85d1.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/.github/ISSUE_TEMPLATE/release-checklist.md new/ignition-2.0.1+git20190725.10b85d1/.github/ISSUE_TEMPLATE/release-checklist.md --- old/ignition-2.0.0+git20190603.0c1da80/.github/ISSUE_TEMPLATE/release-checklist.md 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/.github/ISSUE_TEMPLATE/release-checklist.md 2019-07-25 23:20:11.000000000 +0200 @@ -17,11 +17,19 @@ - [ ] Vendor the new Ignition version in [mantle](https://github.com/coreos/mantle) For 0.x.y releases: - - [ ] [Sync the docs](https://jenkins.prod.coreos.systems/job/coreos.com/job/sync-docs/build) using `ignition` for `PROJECT` and the version `X.Y.Z` (not `vX.Y.Z`) for `RELEASE`. + - [ ] [Sync the docs](https://jenkins-container-linux.apps.ci.centos.org/job/os/job/sync-docs/build) using `ignition` for `PROJECT` and the version `X.Y.Z` (not `vX.Y.Z`) for `RELEASE`. - [ ] Review then merge the coreos-pages PR generated by the docs sync job. + - [ ] Build and deploy coreos.com - [ ] Bump the Ignition ebuild in [coreos-overlay](https://github.com/coreos/coreos-overlay) For 2.x.y+ releases: - [ ] Create a PR to bump the Ignition spec file in [Fedora](https://src.fedoraproject.org/rpms/ignition). - [ ] Once that PR merges to master, merge master into the other relevant branches (e.g. f30) then push those. - [ ] On each of those branches (including master) run `fedpkg build` + - [ ] Once the builds have finished, submit them to [bodhi](https://bodhi.fedoraproject.org/updates/new), filling in: + - `ignition` for `Packages` + - Selecting the build(s) that just completed, except for the rawhide one (which gets submitted automatically) + - Writing brief release notes like "New upstream release. See release notes at `link to NEWS on GH tag`" + - Leave `Update name` blank + - `Type`, `Severity` and `Suggestion` can be left as `unspecified` unless it is a security release. In that case select `security` which the appropriate severity. + - `Stable karma` and `Unstable` karma can be set to `2` and `-1`, respectively. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/NEWS new/ignition-2.0.1+git20190725.10b85d1/NEWS --- old/ignition-2.0.0+git20190603.0c1da80/NEWS 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/NEWS 2019-07-25 23:20:11.000000000 +0200 @@ -1,3 +1,10 @@ +24-Jul-2019 Ignition 2.0.1 + + Bug Fixes: + + - Fix getting AWS region when networking is slow to come up + - Validate file/directory paths correctly + 03-Jun-2019 Ignition 2.0.0 Bug Fixes: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/config/v3_0/types/directory.go new/ignition-2.0.1+git20190725.10b85d1/config/v3_0/types/directory.go --- old/ignition-2.0.0+git20190603.0c1da80/config/v3_0/types/directory.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/config/v3_0/types/directory.go 2019-07-25 23:20:11.000000000 +0200 @@ -22,6 +22,7 @@ ) func (d Directory) Validate(c path.ContextPath) (r report.Report) { + r.Merge(d.Node.Validate(c)) r.AddOnError(c.Append("mode"), validateMode(d.Mode)) if d.Mode == nil { r.AddOnWarn(c.Append("mode"), errors.ErrDirectoryPermissionsUnset) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/config/v3_0/types/file.go new/ignition-2.0.1+git20190725.10b85d1/config/v3_0/types/file.go --- old/ignition-2.0.0+git20190603.0c1da80/config/v3_0/types/file.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/config/v3_0/types/file.go 2019-07-25 23:20:11.000000000 +0200 @@ -22,6 +22,7 @@ ) func (f File) Validate(c path.ContextPath) (r report.Report) { + r.Merge(f.Node.Validate(c)) r.AddOnError(c.Append("mode"), validateMode(f.Mode)) if f.Mode == nil { r.AddOnWarn(c.Append("mode"), errors.ErrFilePermissionsUnset) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/config/v3_1_experimental/types/directory.go new/ignition-2.0.1+git20190725.10b85d1/config/v3_1_experimental/types/directory.go --- old/ignition-2.0.0+git20190603.0c1da80/config/v3_1_experimental/types/directory.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/config/v3_1_experimental/types/directory.go 2019-07-25 23:20:11.000000000 +0200 @@ -22,6 +22,7 @@ ) func (d Directory) Validate(c path.ContextPath) (r report.Report) { + r.Merge(d.Node.Validate(c)) r.AddOnError(c.Append("mode"), validateMode(d.Mode)) if d.Mode == nil { r.AddOnWarn(c.Append("mode"), errors.ErrDirectoryPermissionsUnset) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/config/v3_1_experimental/types/file.go new/ignition-2.0.1+git20190725.10b85d1/config/v3_1_experimental/types/file.go --- old/ignition-2.0.0+git20190603.0c1da80/config/v3_1_experimental/types/file.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/config/v3_1_experimental/types/file.go 2019-07-25 23:20:11.000000000 +0200 @@ -22,6 +22,7 @@ ) func (f File) Validate(c path.ContextPath) (r report.Report) { + r.Merge(f.Node.Validate(c)) r.AddOnError(c.Append("mode"), validateMode(f.Mode)) if f.Mode == nil { r.AddOnWarn(c.Append("mode"), errors.ErrFilePermissionsUnset) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/doc/getting-started.md new/ignition-2.0.1+git20190725.10b85d1/doc/getting-started.md --- old/ignition-2.0.0+git20190603.0c1da80/doc/getting-started.md 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/doc/getting-started.md 2019-07-25 23:20:11.000000000 +0200 @@ -34,7 +34,7 @@ ### Validating the Configuration -One common cause for Ignition failures is a malformed configuration (e.g. a misspelled section or incorrect hierarchy). Ignition will log errors, warnings, and other notes about the configuration that it parsed, so this can be used to debug issues with the configuration provided. As a convenience, CoreOS hosts an [online validator][validator] which can be used to quickly verify configurations. +One common cause for Ignition failures is a malformed configuration (e.g. a misspelled section or incorrect hierarchy). Ignition will log errors, warnings, and other notes about the configuration that it parsed, so this can be used to debug issues with the configuration provided. ### Enabling systemd Services @@ -50,4 +50,3 @@ [platforms]: supported-platforms.md [preset]: https://www.freedesktop.org/software/systemd/man/systemd.preset.html [troubleshooting]: #troubleshooting -[validator]: https://coreos.com/validate diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/exec/engine.go new/ignition-2.0.1+git20190725.10b85d1/internal/exec/engine.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/exec/engine.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/exec/engine.go 2019-07-25 23:20:11.000000000 +0200 @@ -192,7 +192,7 @@ var r report.Report var err error for _, fetcher := range fetchers { - cfg, r, err = fetcher(*e.Fetcher) + cfg, r, err = fetcher(e.Fetcher) if err != providers.ErrNoProvider { // successful, or failed on another error break diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/aws/aws.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/aws/aws.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/aws/aws.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/aws/aws.go 2019-07-25 23:20:11.000000000 +0200 @@ -40,7 +40,7 @@ } ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { data, err := f.FetchToBuffer(userdataUrl, resource.FetchOptions{ Headers: resource.ConfigHeaders, }) @@ -48,6 +48,13 @@ return types.Config{}, report.Report{}, err } + // Determine the partition and region this instance is in + regionHint, err := ec2metadata.New(f.AWSSession).Region() + if err != nil { + regionHint = "us-east-1" + } + f.S3RegionHint = regionHint + return util.ParseConfig(f.Logger, data) } @@ -58,14 +65,8 @@ } sess.Config.Credentials = ec2rolecreds.NewCredentials(sess) - // Determine the partition and region this instance is in - regionHint, err := ec2metadata.New(sess).Region() - if err != nil { - regionHint = "us-east-1" - } return resource.Fetcher{ - Logger: l, - AWSSession: sess, - S3RegionHint: regionHint, + Logger: l, + AWSSession: sess, }, nil } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/azure/azure.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/azure/azure.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/azure/azure.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/azure/azure.go 2019-07-25 23:20:11.000000000 +0200 @@ -52,7 +52,7 @@ CDS_DISC_OK ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { devicePath := filepath.Join(distro.DiskByIDDir(), configDeviceID) logger := f.Logger diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/cloudstack/cloudstack.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/cloudstack/cloudstack.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/cloudstack/cloudstack.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/cloudstack/cloudstack.go 2019-07-25 23:20:11.000000000 +0200 @@ -46,7 +46,7 @@ LeaseRetryInterval = 500 * time.Millisecond ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { var data []byte ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) @@ -192,7 +192,7 @@ return ioutil.ReadFile(filepath.Join(mnt, configDriveUserdataPath)) } -func fetchConfigFromMetadataService(f resource.Fetcher) ([]byte, error) { +func fetchConfigFromMetadataService(f *resource.Fetcher) ([]byte, error) { addr, err := getDHCPServerAddress() if err != nil { return nil, err diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/cmdline/cmdline.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/cmdline/cmdline.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/cmdline/cmdline.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/cmdline/cmdline.go 2019-07-25 23:20:11.000000000 +0200 @@ -36,7 +36,7 @@ cmdlineUrlFlag = "ignition.config.url" ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { url, err := readCmdline(f.Logger) if err != nil { return types.Config{}, report.Report{}, err diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/digitalocean/digitalocean.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/digitalocean/digitalocean.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/digitalocean/digitalocean.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/digitalocean/digitalocean.go 2019-07-25 23:20:11.000000000 +0200 @@ -35,7 +35,7 @@ } ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { data, err := f.FetchToBuffer(userdataUrl, resource.FetchOptions{ Headers: resource.ConfigHeaders, }) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/file/file.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/file/file.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/file/file.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/file/file.go 2019-07-25 23:20:11.000000000 +0200 @@ -30,7 +30,7 @@ defaultFilename = "config.ign" ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { filename := os.Getenv(cfgFilenameEnvVar) if filename == "" { filename = defaultFilename diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/gcp/gcp.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/gcp/gcp.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/gcp/gcp.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/gcp/gcp.go 2019-07-25 23:20:11.000000000 +0200 @@ -37,7 +37,7 @@ metadataHeaderVal = "Google" ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { headers := resource.ConfigHeaders headers.Set(metadataHeaderKey, metadataHeaderVal) data, err := f.FetchToBuffer(userdataUrl, resource.FetchOptions{ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/noop/noop.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/noop/noop.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/noop/noop.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/noop/noop.go 2019-07-25 23:20:11.000000000 +0200 @@ -24,7 +24,7 @@ "github.com/coreos/vcontext/report" ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { f.Logger.Debug("noop provider fetching empty config") return types.Config{}, report.Report{}, errors.ErrEmpty } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/openstack/openstack.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/openstack/openstack.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/openstack/openstack.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/openstack/openstack.go 2019-07-25 23:20:11.000000000 +0200 @@ -51,7 +51,7 @@ } ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { var data []byte ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) @@ -130,7 +130,7 @@ return ioutil.ReadFile(filepath.Join(mnt, configDriveUserdataPath)) } -func fetchConfigFromMetadataService(f resource.Fetcher) ([]byte, error) { +func fetchConfigFromMetadataService(f *resource.Fetcher) ([]byte, error) { res, err := f.FetchToBuffer(metadataServiceUrl, resource.FetchOptions{ Headers: resource.ConfigHeaders, }) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/packet/packet.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/packet/packet.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/packet/packet.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/packet/packet.go 2019-07-25 23:20:11.000000000 +0200 @@ -52,7 +52,7 @@ } ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { // Packet's metadata service returns "Not Acceptable" when queried // with the default Accept header. headers := resource.ConfigHeaders diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/providers.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/providers.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/providers.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/providers.go 2019-07-25 23:20:11.000000000 +0200 @@ -28,6 +28,6 @@ ErrNoProvider = errors.New("config provider was not online") ) -type FuncFetchConfig func(f resource.Fetcher) (types.Config, report.Report, error) +type FuncFetchConfig func(f *resource.Fetcher) (types.Config, report.Report, error) type FuncNewFetcher func(logger *log.Logger) (resource.Fetcher, error) type FuncPostStatus func(stageName string, f resource.Fetcher, e error) error diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/qemu/qemu.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/qemu/qemu.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/qemu/qemu.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/qemu/qemu.go 2019-07-25 23:20:11.000000000 +0200 @@ -33,7 +33,7 @@ firmwareConfigPath = "/sys/firmware/qemu_fw_cfg/by_name/opt/com.coreos/config/raw" ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { _, err := f.Logger.LogCmd(exec.Command("modprobe", "qemu_fw_cfg"), "loading QEMU firmware config module") if err != nil { return types.Config{}, report.Report{}, err diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/system/system.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/system/system.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/system/system.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/system/system.go 2019-07-25 23:20:11.000000000 +0200 @@ -38,7 +38,7 @@ return fetchConfig(logger, baseFilename) } -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { return fetchConfig(f.Logger, userFilename) } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/virtualbox/virtualbox.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/virtualbox/virtualbox.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/virtualbox/virtualbox.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/virtualbox/virtualbox.go 2019-07-25 23:20:11.000000000 +0200 @@ -36,7 +36,7 @@ partUUID = "99570a8a-f826-4eb0-ba4e-9dd72d55ea13" ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { f.Logger.Debug("Attempting to read config drive") rawConfig, err := ioutil.ReadFile(filepath.Join(distro.DiskByPartUUIDDir(), partUUID)) if os.IsNotExist(err) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/vmware/vmware_amd64.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/vmware/vmware_amd64.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/vmware/vmware_amd64.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/vmware/vmware_amd64.go 2019-07-25 23:20:11.000000000 +0200 @@ -29,7 +29,7 @@ "github.com/vmware/vmw-ovflib" ) -func FetchConfig(f resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { if isVM, err := vmcheck.IsVirtualWorld(); err != nil { return types.Config{}, report.Report{}, err } else if !isVM { @@ -51,7 +51,7 @@ return util.ParseConfig(f.Logger, decodedData) } -func fetchRawConfig(f resource.Fetcher) (config, error) { +func fetchRawConfig(f *resource.Fetcher) (config, error) { info := rpcvmx.NewConfig() var ovfData string diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ignition-2.0.0+git20190603.0c1da80/internal/providers/vmware/vmware_unsupported.go new/ignition-2.0.1+git20190725.10b85d1/internal/providers/vmware/vmware_unsupported.go --- old/ignition-2.0.0+git20190603.0c1da80/internal/providers/vmware/vmware_unsupported.go 2019-06-03 23:36:17.000000000 +0200 +++ new/ignition-2.0.1+git20190725.10b85d1/internal/providers/vmware/vmware_unsupported.go 2019-07-25 23:20:11.000000000 +0200 @@ -28,6 +28,6 @@ "github.com/coreos/vcontext/report" ) -func FetchConfig(_ resource.Fetcher) (types.Config, report.Report, error) { +func FetchConfig(_ *resource.Fetcher) (types.Config, report.Report, error) { return types.Config{}, report.Report{}, errors.New("vmware provider is not supported on this architecture") }
