Hello community,
here is the log from the commit of package yast2-iscsi-lio-server for
openSUSE:Factory checked in at 2019-08-01 15:48:09
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-lio-server (Old)
and /work/SRC/openSUSE:Factory/.yast2-iscsi-lio-server.new.4126 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-iscsi-lio-server"
Thu Aug 1 15:48:09 2019 rev:36 rq:707447 version:4.2.0
Changes:
--------
---
/work/SRC/openSUSE:Factory/yast2-iscsi-lio-server/yast2-iscsi-lio-server.changes
2019-03-05 12:23:44.648870298 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-iscsi-lio-server.new.4126/yast2-iscsi-lio-server.changes
2019-08-01 15:48:10.533742790 +0200
@@ -1,0 +2,13 @@
+Fri May 31 12:31:59 UTC 2019 - Stasiek Michalski <[email protected]>
+
+- Add metainfo (fate#319035)
+- Revamp spec
+- Replace GenericName with Comment
+- 4.2.0
+
+-------------------------------------------------------------------
+Tue Apr 2 12:48:33 UTC 2019 - [email protected]
+
+- update iscsi config changes between SLE-12 and SLE-15 (bsc#1129971)
+
+-------------------------------------------------------------------
Old:
----
yast2-iscsi-lio-server-4.1.6.tar.bz2
New:
----
yast2-iscsi-lio-server-4.2.0.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-iscsi-lio-server.spec ++++++
--- /var/tmp/diff_new_pack.xQBgnS/_old 2019-08-01 15:48:10.905742740 +0200
+++ /var/tmp/diff_new_pack.xQBgnS/_new 2019-08-01 15:48:10.905742740 +0200
@@ -17,53 +17,51 @@
Name: yast2-iscsi-lio-server
-Version: 4.1.6
+Version: 4.2.0
Release: 0
+Summary: Configuration of iSCSI LIO target
+License: GPL-2.0-only
+Group: System/YaST
+Url: https://github.com/yast/yast-iscsi-lio-server
-BuildRoot: %{_tmppath}/%{name}-%{version}-build
Source0: %{name}-%{version}.tar.bz2
BuildRequires: update-desktop-files
# Yast2::Execute.stdout
BuildRequires: yast2 >= 4.1.42
-BuildRequires: yast2-devtools >= 3.1.10
+BuildRequires: yast2-devtools >= 4.2.2
BuildRequires: rubygem(%rb_default_ruby_abi:rspec)
BuildRequires: rubygem(%rb_default_ruby_abi:yast-rake)
+
Requires: python3-configshell-fb
Requires: python3-rtslib-fb
Requires: python3-targetcli-fb
-
# Yast2::Execute.stdout
Requires: yast2 >= 4.1.42
-
-BuildArch: noarch
-
Requires: yast2-ruby-bindings >= 1.0.0
-Summary: Configuration of iSCSI LIO target
-License: GPL-2.0-only
-Group: System/YaST
+BuildArch: noarch
%description
This package contains configuration of iSCSI LIO target
%prep
-%setup -n %{name}-%{version}
+%setup -q
%build
%check
-rake test:unit
+%yast_check
%install
-rake install DESTDIR="%{buildroot}"
+%yast_install
+%yast_metainfo
%files
-%defattr(-,root,root)
-%dir %{yast_yncludedir}/iscsi-lio-server
-%{yast_yncludedir}/iscsi-lio-server/*
-%{yast_clientdir}/iscsi-lio-server.rb
-%{yast_desktopdir}/iscsi-lio-server.desktop
+%{yast_yncludedir}
+%{yast_clientdir}
+%{yast_desktopdir}
+%{yast_metainfodir}
%doc %{yast_docdir}
%{yast_icondir}
%license COPYING
++++++ yast2-iscsi-lio-server-4.1.6.tar.bz2 ->
yast2-iscsi-lio-server-4.2.0.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-iscsi-lio-server-4.1.6/Dockerfile
new/yast2-iscsi-lio-server-4.2.0/Dockerfile
--- old/yast2-iscsi-lio-server-4.1.6/Dockerfile 2019-03-04 14:58:36.000000000
+0100
+++ new/yast2-iscsi-lio-server-4.2.0/Dockerfile 2019-06-04 11:49:00.000000000
+0200
@@ -1,3 +1,3 @@
-FROM yastdevel/ruby
+FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest
COPY . /usr/src/app
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-iscsi-lio-server-4.1.6/configure.in.in
new/yast2-iscsi-lio-server-4.2.0/configure.in.in
--- old/yast2-iscsi-lio-server-4.1.6/configure.in.in 2019-03-04
14:58:36.000000000 +0100
+++ new/yast2-iscsi-lio-server-4.2.0/configure.in.in 1970-01-01
01:00:00.000000000 +0100
@@ -1,12 +0,0 @@
-## YCP module configure.in.in
-
-## Initialize
-@YAST2-INIT-COMMON@
-@YAST2-INIT-YCP@
-
-## some common checks
-@YAST2-CHECKS-COMMON@
-@YAST2-CHECKS-YCP@
-
-## and generate the output...
-@YAST2-OUTPUT@
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-lio-server-4.1.6/doc/iscsi-for-beginners.md
new/yast2-iscsi-lio-server-4.2.0/doc/iscsi-for-beginners.md
--- old/yast2-iscsi-lio-server-4.1.6/doc/iscsi-for-beginners.md 2019-03-04
14:58:36.000000000 +0100
+++ new/yast2-iscsi-lio-server-4.2.0/doc/iscsi-for-beginners.md 2019-06-04
11:49:00.000000000 +0200
@@ -9,13 +9,15 @@
Best seems to be to setup a dedicated vm to serve as target and to use another
one
as initiator.
-On the target, install `yast2-iscsi-lio-server` and `targetcli`.
+On the target, install packages `yast2-iscsi-lio-server` and `targetcli`
(SLE-12)
+resp. `python3-targetcli-fb` (SLE-15).
The initiator needs `open-iscsi` (and `yast2-iscsi-client`); both should
be installed by default.
-Read the SLES12 documentation on how to setup things
-[Mass Storage over IP Networks:
iSCSI](https://www.suse.com/documentation/sles-12/stor_admin/data/cha_iscsi.html)
+Read the documentation on how to setup things: 'Mass Storage over IP Networks:
iSCSI' for
+[SLE-12](https://www.suse.com/documentation/sles-12/stor_admin/data/cha_iscsi.html)
or
+[SLE-15](https://www.suse.com/documentation/sles-15/book_storage/data/cha_iscsi.html).
*Note that you must know the initiator name when creating the target config.
You can't just connect 'something' to the target. So look it up on your
@@ -27,21 +29,36 @@
*Disable firewall or open the iscsi port (3260).*
-*When you setup a vm with dhcp, make sure you have a stable ip address, else it
-will drive you mad, as the target ip is part of the config - see last step in
the
-`targetcli` example below.*
+> SLE-12 only
+>
+> When you setup a vm with dhcp, make sure you have a stable ip address, else
it
+> will drive you mad, as the target ip is part of the config - see last step
in the
+> `targetcli` example below.
+>
+> *For me, `/etc/target/lio_setup.sh` always failed when run the very first
time
+> (the initial `mkdir` in the script fails), restarting the `target` service
helped.*
The iscsi target is handled by kernel modules. Config goes to
`/sys/kernel/config/target/iscsi/`.
-But `/etc/target/` holds generated scripts that take care of kernel space
modifications.
-[*For me, `/etc/target/lio_setup.sh` always failed when run the very first time
-(the initial `mkdir` in the script fails), restarting the `target` service
helped.*]
+On SLE-12 `/etc/target/lio_setup.sh` is a generated shell script that takes
+care of kernel space modifications.
-Check that things work: `systemctl status target`.
+On SLE-15 the config is stored in a JSON file `/etc/target/saveconfig.json`.
Old (up to 10)
+versions of this file are kept in `/etc/target/backup/`.
-Instead of yast: use `targetcli` for config. `targetcli` is a rather
+Check that things work: `systemctl status target` (SLE-12) resp. `systemctl
status targetcli` (SLE-15).
+
+Instead of `yast2 iscsi-lio-server` you can use `targetcli` for config.
`targetcli` is a rather
peculiar tool. You basically navigate through a virtual filesystem (Use `ls`
often!).
-Basic syntax is `[PATH] CMD ARGS`. Just watch examples below.
+Basic syntax is `[PATH] COMMAND ARGS`. Just watch examples below.
+
+> Note that not all COMMANDs are available in all PATHs.
+
+Alternatively you can supply arguments to `targetcli` directly, like
+
+```sh
+targetcli /iscsi set discovery_auth enable=0
+```
Here's how to setup a target with it. Run `targetcli`, then
@@ -81,9 +98,20 @@
At this point the iscsi initiator should see the device (check with `iscsiadm
-m discovery ...`).
-To make changes persistent, stop the `target` service. This will `update
/etc/target/lio_setup.sh`.
+> Note SLE-15
+>
+> While you have to set boolean config variables with `set xxx enable=0|1`,
`targetcli` reports the setting
+> with `'True'` or `'False'`.
+
+To make changes persistent, on SLE-12 you have to stop the `target` service.
+This will update `/etc/target/lio_setup.sh`.
+
+On SLE-15, the config is auto-updated when you `exit` from `targetcli` or
+call `targetcli / saveconfig` directly.
``` sh
+# only needed for SLE-12
+#
systemctl stop target
systemctl start target
```
@@ -94,13 +122,15 @@
(`iqn.2003-01.org.linux-iscsi.e111.x8664:sn.18436556ef11` in the example
above).
Note that `create` accepts a WWN as argument.
-If you decide to simply clone the virtual machine don't forget that the
-config is stored in `/etc/target/lio_setup.sh` and contains the IP address of
the
-server. Replace it with the real IP address before starting the `target`
service.
-
-> If you inadvertently started with the wrong IP still in the config the
`target` service will fail. Do **NOT**
+> Note SLE-12
+>
+> If you decide to simply clone the virtual machine don't forget that the
+> config is stored in `/etc/target/lio_setup.sh` and contains the IP address
of the
+> server. Replace it with the real IP address before starting the `target`
service.
+>
+> *If you inadvertently started with the wrong IP still in the config the
`target` service will fail. Do **NOT**
> stop the service as that will overwrite `lio_setup.sh` with the half-done
> broken setup. Instead make a backup copy
-> of `lio_setup.sh` before stopping the service.
+> of `lio_setup.sh` before stopping the service.*
## iscsi initiator setup
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-lio-server-4.1.6/package/yast2-iscsi-lio-server.changes
new/yast2-iscsi-lio-server-4.2.0/package/yast2-iscsi-lio-server.changes
--- old/yast2-iscsi-lio-server-4.1.6/package/yast2-iscsi-lio-server.changes
2019-03-04 14:58:36.000000000 +0100
+++ new/yast2-iscsi-lio-server-4.2.0/package/yast2-iscsi-lio-server.changes
2019-06-04 11:49:00.000000000 +0200
@@ -1,4 +1,17 @@
-------------------------------------------------------------------
+Fri May 31 12:31:59 UTC 2019 - Stasiek Michalski <[email protected]>
+
+- Add metainfo (fate#319035)
+- Revamp spec
+- Replace GenericName with Comment
+- 4.2.0
+
+-------------------------------------------------------------------
+Tue Apr 2 12:48:33 UTC 2019 - [email protected]
+
+- update iscsi config changes between SLE-12 and SLE-15 (bsc#1129971)
+
+-------------------------------------------------------------------
Mon Mar 04 10:34:15 CET 2019 - [email protected]
- added error handling for loading discovery authentication data
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-lio-server-4.1.6/package/yast2-iscsi-lio-server.spec
new/yast2-iscsi-lio-server-4.2.0/package/yast2-iscsi-lio-server.spec
--- old/yast2-iscsi-lio-server-4.1.6/package/yast2-iscsi-lio-server.spec
2019-03-04 14:58:36.000000000 +0100
+++ new/yast2-iscsi-lio-server-4.2.0/package/yast2-iscsi-lio-server.spec
2019-06-04 11:49:00.000000000 +0200
@@ -12,58 +12,56 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
Name: yast2-iscsi-lio-server
-Version: 4.1.6
+Version: 4.2.0
Release: 0
+Summary: Configuration of iSCSI LIO target
+License: GPL-2.0-only
+Group: System/YaST
+Url: https://github.com/yast/yast-iscsi-lio-server
-BuildRoot: %{_tmppath}/%{name}-%{version}-build
Source0: %{name}-%{version}.tar.bz2
BuildRequires: update-desktop-files
# Yast2::Execute.stdout
BuildRequires: yast2 >= 4.1.42
-BuildRequires: yast2-devtools >= 3.1.10
+BuildRequires: yast2-devtools >= 4.2.2
BuildRequires: rubygem(%rb_default_ruby_abi:rspec)
BuildRequires: rubygem(%rb_default_ruby_abi:yast-rake)
+
Requires: python3-configshell-fb
Requires: python3-rtslib-fb
Requires: python3-targetcli-fb
-
# Yast2::Execute.stdout
Requires: yast2 >= 4.1.42
-
-BuildArch: noarch
-
Requires: yast2-ruby-bindings >= 1.0.0
-Summary: Configuration of iSCSI LIO target
-License: GPL-2.0-only
-Group: System/YaST
+BuildArch: noarch
%description
This package contains configuration of iSCSI LIO target
%prep
-%setup -n %{name}-%{version}
+%setup -q
%build
%check
-rake test:unit
+%yast_check
%install
-rake install DESTDIR="%{buildroot}"
+%yast_install
+%yast_metainfo
%files
-%defattr(-,root,root)
-%dir %{yast_yncludedir}/iscsi-lio-server
-%{yast_yncludedir}/iscsi-lio-server/*
-%{yast_clientdir}/iscsi-lio-server.rb
-%{yast_desktopdir}/iscsi-lio-server.desktop
+%{yast_yncludedir}
+%{yast_clientdir}
+%{yast_desktopdir}
+%{yast_metainfodir}
%doc %{yast_docdir}
%{yast_icondir}
%license COPYING
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-lio-server-4.1.6/src/desktop/iscsi-lio-server.desktop
new/yast2-iscsi-lio-server-4.2.0/src/desktop/iscsi-lio-server.desktop
--- old/yast2-iscsi-lio-server-4.1.6/src/desktop/iscsi-lio-server.desktop
2019-03-04 14:58:36.000000000 +0100
+++ new/yast2-iscsi-lio-server-4.2.0/src/desktop/iscsi-lio-server.desktop
1970-01-01 01:00:00.000000000 +0100
@@ -1,24 +0,0 @@
-[Desktop Entry]
-Type=Application
-Categories=Settings;System;Qt;X-SuSE-YaST;X-SuSE-YaST-Net_advanced;
-
-X-KDE-ModuleType=Library
-X-KDE-RootOnly=true
-X-KDE-HasReadOnlyMode=true
-X-SuSE-YaST-Call=iscsi-lio-server
-
-X-SuSE-YaST-Group=Net_advanced
-X-SuSE-YaST-Argument=
-X-SuSE-YaST-RootOnly=true
-X-SuSE-YaST-AutoInst=all
-X-SuSE-YaST-Geometry=
-X-SuSE-YaST-SortKey=
-X-SuSE-YaST-AutoInstResource=iscsi-lio-servers
-X-SuSE-YaST-Keywords=iscsi,lio,network,system
-
-Icon=yast-iscsi-server
-Exec=xdg-su -c "/sbin/yast2 iscsi-lio-server"
-Name=iSCSI LIO Target
-GenericName=Configure an iSCSI target via LIO
-X-KDE-SubstituteUID=true
-StartupNotify=true
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-lio-server-4.1.6/src/desktop/org.opensuse.yast.iSCILIOServer.desktop
new/yast2-iscsi-lio-server-4.2.0/src/desktop/org.opensuse.yast.iSCILIOServer.desktop
---
old/yast2-iscsi-lio-server-4.1.6/src/desktop/org.opensuse.yast.iSCILIOServer.desktop
1970-01-01 01:00:00.000000000 +0100
+++
new/yast2-iscsi-lio-server-4.2.0/src/desktop/org.opensuse.yast.iSCILIOServer.desktop
2019-06-04 11:49:00.000000000 +0200
@@ -0,0 +1,25 @@
+[Desktop Entry]
+Type=Application
+Categories=Settings;System;Qt;X-SuSE-YaST;X-SuSE-YaST-Net_advanced;
+
+X-KDE-ModuleType=Library
+X-KDE-RootOnly=true
+X-KDE-HasReadOnlyMode=true
+X-SuSE-YaST-Call=iscsi-lio-server
+
+X-SuSE-YaST-Group=Net_advanced
+X-SuSE-YaST-Argument=
+X-SuSE-YaST-RootOnly=true
+X-SuSE-YaST-AutoInst=all
+X-SuSE-YaST-Geometry=
+X-SuSE-YaST-SortKey=
+X-SuSE-YaST-AutoInstResource=iscsi-lio-servers
+X-SuSE-YaST-Keywords=iscsi,lio,network,system
+
+Icon=yast-iscsi-server
+Exec=xdg-su -c "/sbin/yast2 iscsi-lio-server"
+Name=YaST iSCSI LIO Target
+GenericName=iSCSI LIO Target
+Comment=Configure an iSCSI target via LIO
+X-KDE-SubstituteUID=true
+StartupNotify=true