Hello community, here is the log from the commit of package waybar for openSUSE:Factory checked in at 2019-08-20 11:00:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/waybar (Old) and /work/SRC/openSUSE:Factory/.waybar.new.22127 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "waybar" Tue Aug 20 11:00:07 2019 rev:12 rq:724706 version:0.7.2 Changes: -------- --- /work/SRC/openSUSE:Factory/waybar/waybar.changes 2019-07-13 14:00:44.206891777 +0200 +++ /work/SRC/openSUSE:Factory/.waybar.new.22127/waybar.changes 2019-08-20 11:00:16.448645243 +0200 @@ -1,0 +2,7 @@ +Tue Aug 20 07:28:07 UTC 2019 - [email protected] + +- Update to 0.7.2: + * Fixed crash on output unplug bb99e6c + * MediaPlayer script: Ignore selected player if not defined #421 + +------------------------------------------------------------------- Old: ---- 0.7.1.tar.gz New: ---- 0.7.2.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ waybar.spec ++++++ --- /var/tmp/diff_new_pack.BaXfWn/_old 2019-08-20 11:00:17.292645067 +0200 +++ /var/tmp/diff_new_pack.BaXfWn/_new 2019-08-20 11:00:17.296645066 +0200 @@ -17,7 +17,7 @@ Name: waybar -Version: 0.7.1 +Version: 0.7.2 Release: 0 Summary: Customizable Wayland bar for Sway and Wlroots based compositors License: MIT ++++++ 0.7.1.tar.gz -> 0.7.2.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Waybar-0.7.1/include/bar.hpp new/Waybar-0.7.2/include/bar.hpp --- old/Waybar-0.7.1/include/bar.hpp 2019-07-11 17:02:47.000000000 +0200 +++ new/Waybar-0.7.2/include/bar.hpp 2019-08-08 12:25:31.000000000 +0200 @@ -1,10 +1,10 @@ #pragma once #include <glibmm/refptr.h> +#include <gtkmm/box.h> #include <gtkmm/cssprovider.h> #include <gtkmm/main.h> #include <gtkmm/window.h> -#include <gtkmm/box.h> #include <json/json.h> #include "AModule.hpp" #include "idle-inhibit-unstable-v1-client-protocol.h" @@ -15,10 +15,10 @@ class Factory; struct waybar_output { - struct wl_output * output; + struct wl_output * output = nullptr; std::string name; uint32_t wl_name; - struct zxdg_output_v1 *xdg_output; + struct zxdg_output_v1 *xdg_output = nullptr; }; class Bar { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Waybar-0.7.1/meson.build new/Waybar-0.7.2/meson.build --- old/Waybar-0.7.1/meson.build 2019-07-11 17:02:47.000000000 +0200 +++ new/Waybar-0.7.2/meson.build 2019-08-08 12:25:31.000000000 +0200 @@ -1,6 +1,6 @@ project( 'waybar', 'cpp', 'c', - version: '0.7.1', + version: '0.7.2', license: 'MIT', default_options : [ 'cpp_std=c++17', diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Waybar-0.7.1/resources/config new/Waybar-0.7.2/resources/config --- old/Waybar-0.7.1/resources/config 2019-07-11 17:02:47.000000000 +0200 +++ new/Waybar-0.7.2/resources/config 2019-08-08 12:25:31.000000000 +0200 @@ -140,5 +140,6 @@ }, "escape": true, "exec": "$HOME/.config/waybar/mediaplayer.py 2> /dev/null" // Script in resources folder + // "exec": "$HOME/.config/waybar/mediaplayer.py --player spotify 2> /dev/null" // Filter player based on name } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Waybar-0.7.1/resources/custom_modules/mediaplayer.py new/Waybar-0.7.2/resources/custom_modules/mediaplayer.py --- old/Waybar-0.7.1/resources/custom_modules/mediaplayer.py 2019-07-11 17:02:47.000000000 +0200 +++ new/Waybar-0.7.2/resources/custom_modules/mediaplayer.py 2019-08-08 12:25:31.000000000 +0200 @@ -45,7 +45,7 @@ def on_player_appeared(manager, player, selected_player=None): - if player is not None and player.name == selected_player: + if player is not None and (selected_player is None or player.name == selected_player): init_player(manager, player) else: logger.debug("New player appeared, but it's not the selected player, skipping") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Waybar-0.7.1/src/client.cpp new/Waybar-0.7.2/src/client.cpp --- old/Waybar-0.7.1/src/client.cpp 2019-07-11 17:02:47.000000000 +0200 +++ new/Waybar-0.7.2/src/client.cpp 2019-08-08 12:25:31.000000000 +0200 @@ -65,8 +65,14 @@ client->outputs_.end(), [&name](const auto &output) { return output->wl_name == name; }); if (it != client->outputs_.end()) { - zxdg_output_v1_destroy((*it)->xdg_output); - wl_output_destroy((*it)->output); + if ((*it)->xdg_output != nullptr) { + zxdg_output_v1_destroy((*it)->xdg_output); + (*it)->xdg_output = nullptr; + } + if ((*it)->output != nullptr) { + wl_output_destroy((*it)->output); + (*it)->output = nullptr; + } client->outputs_.erase(it); } } @@ -151,8 +157,14 @@ output->name = name; auto configs = client->getOutputConfigs(output); if (configs.empty()) { - wl_output_destroy(output->output); - zxdg_output_v1_destroy(output->xdg_output); + if (output->output != nullptr) { + wl_output_destroy(output->output); + output->output = nullptr; + } + if (output->xdg_output != nullptr) { + zxdg_output_v1_destroy(output->xdg_output); + output->xdg_output = nullptr; + } } else { wl_display_roundtrip(client->wl_display); for (const auto &config : configs) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Waybar-0.7.1/src/modules/sni/tray.cpp new/Waybar-0.7.2/src/modules/sni/tray.cpp --- old/Waybar-0.7.1/src/modules/sni/tray.cpp 2019-07-11 17:02:47.000000000 +0200 +++ new/Waybar-0.7.2/src/modules/sni/tray.cpp 2019-08-08 12:25:31.000000000 +0200 @@ -10,7 +10,7 @@ host_(nb_hosts_, config, std::bind(&Tray::onAdd, this, std::placeholders::_1), std::bind(&Tray::onRemove, this, std::placeholders::_1)) { spdlog::warn( - "For a functionnal tray you must have libappindicator-* installed and export " + "For a functional tray you must have libappindicator-* installed and export " "XDG_CURRENT_DESKTOP=Unity"); box_.set_name("tray"); event_box_.add(box_);
