Hello community, here is the log from the commit of package telemetrics-client for openSUSE:Factory checked in at 2019-09-17 13:39:24 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/telemetrics-client (Old) and /work/SRC/openSUSE:Factory/.telemetrics-client.new.7948 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "telemetrics-client" Tue Sep 17 13:39:24 2019 rev:4 rq:731344 version:2.2.2+git20190903.a4774bd Changes: -------- --- /work/SRC/openSUSE:Factory/telemetrics-client/telemetrics-client.changes 2019-06-12 13:17:48.744595641 +0200 +++ /work/SRC/openSUSE:Factory/.telemetrics-client.new.7948/telemetrics-client.changes 2019-09-17 13:39:24.609823716 +0200 @@ -1,0 +2,45 @@ +Mon Sep 16 17:37:43 UTC 2019 - [email protected] + +- Rename telmctl-enable-disable.diff to telemctl-enable-disable.diff +- Update to version 2.2.2+git20190903.a4774bd: + * configure.ac: bump version to 2.2.2 + * crash_probe.c: improve error handling + * telemdaemon.c: sanity check for record size + * telemdaemon.c: modify handle_client + * telempostdaemon.c: fix unitialized variable + * telem_recoder_gen.c: remove redundant if statement + * telemctl.c: changed handling of opt_in/opt_out + * Fix build warning not used variable + * Allow record creation on opt-out + * journal.c: fix some resource leaks + * journal.c: deserialize_journal_entry fixes + * telemctl.c: avoid using fscanf + * telem_record_gen.c: fix a potential resource leak + * telemctl.c: allow deleting of files not owned by telemetry + * inifile.c: Check for NULL pointer + * oops_parser.c: remove needless check + * oops_parser.c: detect kernel panic + * iorecord.c: fix a potential race + * telemctl.c: fix resource leak + * telemetry.c: remove unneeded test + * telempostdaemon.c: avoid freeing of uninitialized variables + * telemdaemon.c: fix for a potential string overflow + * oops_parser.c: remove unneeded check + * telemdaemon.c: properly handle mkstemp error + * telem_recorde_gen.c: fix potential memory leaks + * telem_record_gen.c: return correct error in instanciate_record + * telemdaemon.c: don't assume correct machine_id length + * util.c: correct return value from "get_header_value" + * iorecord.c: fix memory allocation check + * Fix double free in deserialize_journal_entry and print_journal + * telemctl: binary version + * Add "ACPI Error:" pattern for ACPI issues. + * configure.ac: bump version to 2.2.1 + * man pages: remove references to telemd + * Fix build for logtype=systemd + * crash_probe: Limit the size of backtrace + * configure.ac: bump version to 2.2.0 + * telem_journal: improve usage message + * Updated AUTHORS + +------------------------------------------------------------------- Old: ---- telemetrics-client-2.1.1+git20190605.781d938.tar.xz telmctl-enable-disable.diff New: ---- telemctl-enable-disable.diff telemetrics-client-2.2.2+git20190903.a4774bd.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ telemetrics-client.spec ++++++ --- /var/tmp/diff_new_pack.5CuDgI/_old 2019-09-17 13:39:25.273823610 +0200 +++ /var/tmp/diff_new_pack.5CuDgI/_new 2019-09-17 13:39:25.277823610 +0200 @@ -17,7 +17,7 @@ Name: telemetrics-client -Version: 2.1.1+git20190605.781d938 +Version: 2.2.2+git20190903.a4774bd Release: 0 Summary: Telemetrics solution License: LGPL-2.1-or-later @@ -26,7 +26,7 @@ Source: %{name}-%{version}.tar.xz Source1: telemetrics-users.conf Patch: telemetrics.conf.patch -Patch1: telmctl-enable-disable.diff +Patch1: telemctl-enable-disable.diff Patch2: install-paths.diff BuildRequires: autoconf BuildRequires: automake ++++++ _service ++++++ --- /var/tmp/diff_new_pack.5CuDgI/_old 2019-09-17 13:39:25.301823606 +0200 +++ /var/tmp/diff_new_pack.5CuDgI/_new 2019-09-17 13:39:25.301823606 +0200 @@ -1,7 +1,7 @@ <services> <service name="tar_scm" mode="disabled"> - <param name="version">2.1.1</param> - <param name="versionformat">2.1.1+git%cd.%h</param> + <param name="version">2.2.2</param> + <param name="versionformat">2.2.2+git%cd.%h</param> <param name="url">git://github.com/clearlinux/telemetrics-client.git</param> <param name="scm">git</param> <param name="changesgenerate">enable</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.5CuDgI/_old 2019-09-17 13:39:25.317823603 +0200 +++ /var/tmp/diff_new_pack.5CuDgI/_new 2019-09-17 13:39:25.317823603 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">git://github.com/clearlinux/telemetrics-client.git</param> - <param name="changesrevision">781d9382d0c15abd2492ecc6f33126ddb7b21a5c</param> + <param name="changesrevision">a4774bde2e1938364add00e0e904352c9c4f3a71</param> </service> </servicedata> \ No newline at end of file ++++++ install-paths.diff ++++++ --- /var/tmp/diff_new_pack.5CuDgI/_old 2019-09-17 13:39:25.325823602 +0200 +++ /var/tmp/diff_new_pack.5CuDgI/_new 2019-09-17 13:39:25.325823602 +0200 @@ -1,8 +1,8 @@ diff --git a/configure.ac b/configure.ac -index 54a8558..0ac76ad 100644 +index d5b9bdf..6fe2dc1 100644 --- a/configure.ac +++ b/configure.ac -@@ -152,7 +152,9 @@ telemetrics-client $VERSION +@@ -157,7 +157,9 @@ telemetrics-client $VERSION prefix: $prefix exec_prefix: $exec_prefix libdir: $libdir @@ -12,15 +12,6 @@ datarootdir: $datarootdir compiler: $CC -diff --git a/scripts/local.mk b/scripts/local.mk -index a64bc1e..c12f901 100644 ---- a/scripts/local.mk -+++ b/scripts/local.mk -@@ -1,3 +1,3 @@ --dist_bin_SCRIPTS = %D%/telemctl -+dist_sbin_SCRIPTS = %D%/telemctl - - # vim: filetype=automake tabstop=8 shiftwidth=8 noexpandtab diff --git a/src/data/40-crash-probe.conf.in b/src/data/40-crash-probe.conf.in index 486067e..ea4d156 100644 --- a/src/data/40-crash-probe.conf.in @@ -94,7 +85,7 @@ [Install] WantedBy=multi-user.target diff --git a/src/data/local.mk b/src/data/local.mk -index 7beaf7e..e52a0c4 100644 +index a418afb..8bcd203 100644 --- a/src/data/local.mk +++ b/src/data/local.mk @@ -2,6 +2,8 @@ pathfix = @sed \ @@ -172,7 +163,7 @@ User=telemetry diff --git a/src/journal/local.mk b/src/journal/local.mk -index bb6175f..1e6a382 100644 +index b879e90..7bd46fd 100644 --- a/src/journal/local.mk +++ b/src/journal/local.mk @@ -1,4 +1,4 @@ @@ -182,16 +173,16 @@ %C%_telem_journal_SOURCES = %D%/cli.c \ diff --git a/src/local.mk b/src/local.mk -index 18a8156..3d2ea60 100644 +index 9b155f2..997480f 100644 --- a/src/local.mk +++ b/src/local.mk @@ -1,4 +1,4 @@ -bin_PROGRAMS = \ +sbin_PROGRAMS = \ %D%/telemprobd \ - %D%/telempostd - -@@ -15,7 +15,7 @@ bin_PROGRAMS = \ + %D%/telempostd \ + %D%/telemctl +@@ -25,7 +25,7 @@ bin_PROGRAMS = \ %D%/libtelemetry.la %C%_telemprobd_CFLAGS = \ @@ -200,7 +191,7 @@ %C%_telemprobd_LDFLAGS = \ $(AM_LDFLAGS) \ -@@ -56,7 +56,7 @@ endif +@@ -66,7 +66,7 @@ endif %D%/libtelemetry.la %C%_telempostd_CFLAGS = \ @@ -210,7 +201,7 @@ %C%_telempostd_LDFLAGS = \ $(AM_LDFLAGS) \ diff --git a/src/probes/local.mk b/src/probes/local.mk -index 0aeadce..e45cb98 100644 +index 28a0518..880a4c6 100644 --- a/src/probes/local.mk +++ b/src/probes/local.mk @@ -1,7 +1,8 @@ @@ -224,7 +215,7 @@ %D%/klogscanner \ %D%/pstoreprobe \ %D%/pythonprobe \ -@@ -131,7 +132,7 @@ endif +@@ -156,7 +157,7 @@ endif if HAVE_SYSTEMD_JOURNAL if HAVE_SYSTEMD_ID128 ++++++ telemctl-enable-disable.diff ++++++ diff --git a/docs/man/telemctl.1.rst b/docs/man/telemctl.1.rst index 2aef720..0ab7017 100644 --- a/docs/man/telemctl.1.rst +++ b/docs/man/telemctl.1.rst @@ -31,6 +31,9 @@ OPTIONS * ``start``|``stop``|``restart``: Starts, stops or restarts all running telemetry services. + * ``enable``|``disable``: + Enables or disables all telemetry services. + * ``opt-in``: Opts in to telemetry, and starts telemetry services. The opt-out file ``/etc/telemetrics/opt-out`` is removed. diff --git a/src/telemctl.c b/src/telemctl.c index 4df8dbb..ade3659 100644 --- a/src/telemctl.c +++ b/src/telemctl.c @@ -64,6 +64,8 @@ static char *SERVICES[] = { static int telemctl_start(void); static int telemctl_stop(void); static int telemctl_restart(void); +static int telemctl_enable(void); +static int telemctl_disable(void); static int telemctl_is_active(void); static int telemctl_opt_out(void); static int telemctl_opt_in(void); @@ -82,6 +84,8 @@ static struct telemcmd commands[] = { {"stop", {.f1=telemctl_stop}, "Stops all running telemetry services" }, {"start", {.f1=telemctl_start}, "Starts all telemetry services" }, {"restart", {.f1=telemctl_restart}, "Restarts all telemetry services" }, + {"enable", {.f1=telemctl_enable}, "Enable telemetry services" }, + {"disable", {.f1=telemctl_disable}, "Disable telemetry services" }, {"is-active", {.f1=telemctl_is_active},"Checks if telemprobd and telempostd are active" }, {"opt-in", {.f1=telemctl_opt_in}, "Opts in to telemetry, and starts telemetry services" }, {"opt-out", {.f1=telemctl_opt_out}, "Opts out of telemetry, and stops telemetry services" }, @@ -216,6 +220,38 @@ static int telemctl_restart(void) /* Script code: +telem_enable() { + for_each_service "enable" ${SPECIAL_UNITS[@]} +} +*/ +static int telemctl_enable(void) +{ + int ret; + + /* the units in SERVICES are activated as needed, so no need to enable them */ + ret = for_each_service("enable", SPECIAL_UNITS, NUM_SPECIAL_UNITS); + return ret; +} + +/* +Script code: + +telem_disable() { + for_each_service "disable" ${SPECIAL_UNITS[@]} +} +*/ +static int telemctl_disable(void) +{ + int ret; + + /* the units in SERVICES are only enabled, so only disable them, too. */ + ret = for_each_service("disable", SPECIAL_UNITS, NUM_SPECIAL_UNITS); + return ret; +} + +/* +Script code: + telem_is_active() { echo "telemprobd :" $(systemctl is-active telemprobd.socket) echo "telempostd :" $(systemctl is-active telempostd.path) ++++++ telemetrics-client-2.1.1+git20190605.781d938.tar.xz -> telemetrics-client-2.2.2+git20190903.a4774bd.tar.xz ++++++ ++++ 1902 lines of diff (skipped)
