Hello community,
here is the log from the commit of package qimgv for openSUSE:Factory checked
in at 2019-09-23 12:39:21
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/qimgv (Old)
and /work/SRC/openSUSE:Factory/.qimgv.new.7948 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "qimgv"
Mon Sep 23 12:39:21 2019 rev:10 rq:732425 version:0.8.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/qimgv/qimgv.changes 2019-09-20
14:56:01.526848825 +0200
+++ /work/SRC/openSUSE:Factory/.qimgv.new.7948/qimgv.changes 2019-09-23
12:39:51.533585861 +0200
@@ -1,0 +2,7 @@
+Sun Sep 22 04:49:34 UTC 2019 - Luigi Baldoni <aloi...@gmx.com>
+
+- Update to version 0.8.4
+ * fix rename window (regression)
+ * show error when a file operation fails
+
+-------------------------------------------------------------------
Old:
----
qimgv-0.8.3.tar.gz
New:
----
qimgv-0.8.4.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ qimgv.spec ++++++
--- /var/tmp/diff_new_pack.cMUi4p/_old 2019-09-23 12:39:52.033585779 +0200
+++ /var/tmp/diff_new_pack.cMUi4p/_new 2019-09-23 12:39:52.037585778 +0200
@@ -17,7 +17,7 @@
Name: qimgv
-Version: 0.8.3
+Version: 0.8.4
Release: 0
Summary: Qt5 image viewer
License: GPL-3.0-only
++++++ qimgv-0.8.3.tar.gz -> qimgv-0.8.4.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/README.md new/qimgv-0.8.4/README.md
--- old/qimgv-0.8.3/README.md 2019-09-19 17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/README.md 2019-09-21 22:52:26.000000000 +0200
@@ -1,4 +1,4 @@
-qimgv | Current version: 0.8.3
+qimgv | Current version: 0.8.4
=====
Qt5 image viewer. Fast, configurable, easy to use. Optional video support.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/appversion.cpp
new/qimgv-0.8.4/qimgv/appversion.cpp
--- old/qimgv-0.8.3/qimgv/appversion.cpp 2019-09-19 17:21:20.000000000
+0200
+++ new/qimgv-0.8.4/qimgv/appversion.cpp 2019-09-21 22:52:26.000000000
+0200
@@ -1,3 +1,3 @@
#include "appversion.h"
-QVersionNumber appVersion(0,8,3);
+QVersionNumber appVersion(0,8,4);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qimgv-0.8.3/qimgv/components/directorymanager/directorymanager.cpp
new/qimgv-0.8.4/qimgv/components/directorymanager/directorymanager.cpp
--- old/qimgv-0.8.3/qimgv/components/directorymanager/directorymanager.cpp
2019-09-19 17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/components/directorymanager/directorymanager.cpp
2019-09-21 22:52:26.000000000 +0200
@@ -121,6 +121,10 @@
return true;
}
+QString DirectoryManager::directory() {
+ return currentPath;
+}
+
int DirectoryManager::indexOf(QString fileName) const {
auto item = find_if(entryVec.begin(), entryVec.end(), [fileName](const
Entry& e) {
return e.path == fileName;
@@ -202,7 +206,7 @@
void DirectoryManager::moveToTrash(QString file) {
QFileInfo fileinfo( file );
if( !fileinfo.exists() )
- qDebug() << "File doesnt exists, cant move to trash";
+ return;
WCHAR from[ MAX_PATH ];
memset( from, 0, sizeof( from ));
int l = fileinfo.absoluteFilePath().toWCharArray( from );
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qimgv-0.8.3/qimgv/components/directorymanager/directorymanager.h
new/qimgv-0.8.4/qimgv/components/directorymanager/directorymanager.h
--- old/qimgv-0.8.3/qimgv/components/directorymanager/directorymanager.h
2019-09-19 17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/components/directorymanager/directorymanager.h
2019-09-21 22:52:26.000000000 +0200
@@ -64,6 +64,7 @@
DirectoryManager();
// ignored if the same dir is already opened
bool setDirectory(QString);
+ QString directory();
// returns index in file list
// -1 if not found
int indexOf(QString fileName) const;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qimgv-0.8.3/qimgv/components/directorymanager/watchers/windows/windowsworker.cpp
new/qimgv-0.8.4/qimgv/components/directorymanager/watchers/windows/windowsworker.cpp
---
old/qimgv-0.8.3/qimgv/components/directorymanager/watchers/windows/windowsworker.cpp
2019-09-19 17:21:20.000000000 +0200
+++
new/qimgv-0.8.4/qimgv/components/directorymanager/watchers/windows/windowsworker.cpp
2019-09-21 22:52:26.000000000 +0200
@@ -5,7 +5,7 @@
}
void WindowsWorker::setDirectoryHandle(HANDLE hDir) {
- qDebug() << "setHandle" << this->hDir << " -> " << hDir;
+ //qDebug() << "setHandle" << this->hDir << " -> " << hDir;
this->hDir = hDir;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/components/directorymodel.cpp
new/qimgv-0.8.4/qimgv/components/directorymodel.cpp
--- old/qimgv-0.8.3/qimgv/components/directorymodel.cpp 2019-09-19
17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/components/directorymodel.cpp 2019-09-21
22:52:26.000000000 +0200
@@ -66,8 +66,19 @@
return dirManager.contains(fileName);
}
-bool DirectoryModel::removeFile(QString fileName, bool trash) {
- return dirManager.removeFile(fileName, trash);
+void DirectoryModel::removeFile(QString fileName, bool trash, FileOpResult
&result) {
+ QFileInfo file(dirManager.directory() + "/" + fileName);
+ if(!file.exists()) {
+ result = FileOpResult::SOURCE_DOES_NOT_EXIST;
+ } else if(!file.isWritable()) {
+ result = FileOpResult::SOURCE_NOT_WRITABLE;
+ } else {
+ if(dirManager.removeFile(fileName, trash))
+ result = FileOpResult::SUCCESS;
+ else
+ result = FileOpResult::OTHER_ERROR;
+ }
+ return;
}
bool DirectoryModel::isEmpty() {
@@ -98,37 +109,88 @@
return dirManager.lastModified(fileName);
}
-bool DirectoryModel::copyTo(QString destDirectory, QString fileName) {
- return dirManager.copyTo(destDirectory, fileName);
+void DirectoryModel::copyTo(QString destDirectory, QString fileName,
FileOpResult &result) {
+ // error checks
+ if(destDirectory == dirManager.directory()) {
+ result = FileOpResult::COPY_TO_SAME_DIR;
+ return;
+ }
+ if(!dirManager.contains(fileName)) { // if this happens we have a bug
+ result = FileOpResult::SOURCE_DOES_NOT_EXIST;
+ return;
+ }
+ QFileInfo location(destDirectory);
+ if(!location.exists()) {
+ result = FileOpResult::DESTINATION_DOES_NOT_EXIST;
+ return;
+ }
+ if(!location.isWritable()) {
+ result = FileOpResult::DESTINATION_NOT_WRITABLE;
+ return;
+ }
+ location.setFile(destDirectory + "/" + fileName);
+ if(location.exists()) {
+ if(!location.isWritable())
+ result = FileOpResult::DESTINATION_NOT_WRITABLE;
+ result = FileOpResult::DESTINATION_FILE_EXISTS;
+ return;
+ }
+ // copy
+ if(!dirManager.copyTo(destDirectory, fileName))
+ result = FileOpResult::OTHER_ERROR;
+ return;
}
-bool DirectoryModel::moveTo(QString destDirectory, QString fileName) {
- if(!dirManager.contains(fileName)) {
- qDebug() << "[DirectoryModel] Error: source file does not exist.";
- return false;
- }
- QFileInfo file(destDirectory + "/" + fileName);
- if(file.exists()) {
- qDebug() << "[DirectoryModel] Error: destination file already exists.";
- //mw->showMessage("Error: destination file already exists.");
- return false;
+void DirectoryModel::moveTo(QString destDirectory, QString fileName,
FileOpResult &result) {
+ // error checks
+ if(destDirectory == dirManager.directory()) {
+ result = FileOpResult::COPY_TO_SAME_DIR;
+ return;
}
+ if(!dirManager.contains(fileName)) { // if this happens we have a bug
+ result = FileOpResult::SOURCE_DOES_NOT_EXIST;
+ return;
+ }
+ QFileInfo location(destDirectory);
+ if(!location.exists()) {
+ result = FileOpResult::DESTINATION_DOES_NOT_EXIST;
+ return;
+ }
+ if(!location.isWritable()) {
+ result = FileOpResult::DESTINATION_NOT_WRITABLE;
+ return;
+ }
+ location.setFile(destDirectory + "/" + fileName);
+ if(location.exists()) {
+ if(!location.isWritable())
+ result = FileOpResult::DESTINATION_NOT_WRITABLE;
+ result = FileOpResult::DESTINATION_FILE_EXISTS;
+ return;
+ }
+ location.setFile(this->currentFilePath());
+ if(!location.isWritable()) {
+ result = FileOpResult::SOURCE_NOT_WRITABLE;
+ return;
+ }
+ // move
if(dirManager.copyTo(destDirectory, fileName)) {
// remove original file
- if(!dirManager.removeFile(fileName, false)) {
- // revert on failure
- dirManager.removeFile(destDirectory + "/" + fileName, false);
- return false;
+ if(dirManager.removeFile(fileName, false)) {
+ // OK
+ result = FileOpResult::SUCCESS;
+ return;
}
- //mw->showMessage("File moved to: " + destDirectory);
- return true;
+ // revert on failure
+ result = FileOpResult::SOURCE_NOT_WRITABLE;
+ if(QFile::remove(destDirectory + "/" + fileName))
+ result = FileOpResult::OTHER_ERROR;
} else {
- //mw->showMessage("Error: could not write a file to " + destDirectory);
- qDebug() << "Error: could not write a file to " << destDirectory;
- return false;
+ // could not COPY
+ result = FileOpResult::OTHER_ERROR;
}
+ return;
}
-
+//
-----------------------------------------------------------------------------
void DirectoryModel::setDirectory(QString path) {
dirManager.setDirectory(path);
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/components/directorymodel.h
new/qimgv-0.8.4/qimgv/components/directorymodel.h
--- old/qimgv-0.8.3/qimgv/components/directorymodel.h 2019-09-19
17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/components/directorymodel.h 2019-09-21
22:52:26.000000000 +0200
@@ -8,6 +8,17 @@
#include "thumbnailer/thumbnailer.h"
#include "loader/loader.h"
+enum FileOpResult {
+ SUCCESS,
+ DESTINATION_FILE_EXISTS,
+ SOURCE_NOT_WRITABLE,
+ DESTINATION_NOT_WRITABLE,
+ SOURCE_DOES_NOT_EXIST,
+ DESTINATION_DOES_NOT_EXIST,
+ COPY_TO_SAME_DIR,
+ OTHER_ERROR
+};
+
class DirectoryModel : public QObject {
Q_OBJECT
public:
@@ -25,7 +36,7 @@
int indexOf(QString fileName);
QString fileNameAt(int index);
bool contains(QString fileName);
- bool removeFile(QString fileName, bool trash);
+ void removeFile(QString fileName, bool trash, FileOpResult &result);
bool isEmpty();
QString nextOf(QString fileName);
QString prevOf(QString fileName);
@@ -33,8 +44,8 @@
QString last();
QString absolutePath();
QDateTime lastModified(QString fileName);
- bool copyTo(QString destDirectory, QString fileName);
- bool moveTo(QString destDirectory, QString fileName);
+ void copyTo(QString destDirectory, QString fileName, FileOpResult &result);
+ void moveTo(QString destDirectory, QString fileName, FileOpResult &result);
void setDirectory(QString);
bool setIndex(int index);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/core.cpp
new/qimgv-0.8.4/qimgv/core.cpp
--- old/qimgv-0.8.3/qimgv/core.cpp 2019-09-19 17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/core.cpp 2019-09-21 22:52:26.000000000 +0200
@@ -360,9 +360,13 @@
// removes file at specified index within current directory
void Core::removeFile(QString fileName, bool trash) {
- if(model->removeFile(fileName, trash)) {
+ FileOpResult result;
+ model->removeFile(fileName, trash, result);
+ if(result == FileOpResult::SUCCESS) {
QString msg = trash?"Moved to trash: ":"File removed: ";
mw->showMessage(msg + fileName);
+ } else {
+ outputError(result);
}
}
@@ -407,12 +411,46 @@
}
}
+void Core::outputError(const FileOpResult &error) const {
+ switch (error) {
+ case FileOpResult::DESTINATION_FILE_EXISTS:
+ mw->showError("File already exists."); break;
+ case FileOpResult::SOURCE_NOT_WRITABLE:
+ mw->showError("Source file is not writable."); break;
+ case FileOpResult::DESTINATION_NOT_WRITABLE:
+ mw->showError("Directory is not writable."); break;
+ case FileOpResult::SOURCE_DOES_NOT_EXIST:
+ mw->showError("Source file does not exist."); break;
+ case FileOpResult::DESTINATION_DOES_NOT_EXIST:
+ mw->showError("Directory does not exist."); break;
+ case FileOpResult::COPY_TO_SAME_DIR:
+ mw->showError("Already in this directory."); break;
+ case FileOpResult::OTHER_ERROR:
+ mw->showError("Unknown error."); break;
+ default:
+ break;
+ }
+}
+
void Core::moveFile(QString destDirectory) {
- model->moveTo(destDirectory, model->currentFileName());
+ mw->closeImage();
+ FileOpResult result;
+ model->moveTo(destDirectory, model->currentFileName(), result);
+ if(result == FileOpResult::SUCCESS) {
+ mw->showMessageSuccess("File moved.");
+ } else {
+ displayImage(model->getItem(model->currentFileName()));
+ outputError(result);
+ }
}
void Core::copyFile(QString destDirectory) {
- model->copyTo(destDirectory, model->currentFileName());
+ FileOpResult result;
+ model->copyTo(destDirectory, model->currentFileName(), result);
+ if(result == FileOpResult::SUCCESS)
+ mw->showMessageSuccess("File copied.");
+ else
+ outputError(result);
}
void Core::toggleCropPanel() {
@@ -610,9 +648,6 @@
}
void Core::loadPath(QString path) {
-
- qDebug() << "loadPath(): " << path;
-
if(path.startsWith("file://", Qt::CaseInsensitive))
path.remove(0, 7);
@@ -627,7 +662,6 @@
qDebug() << "Could not open path: " << path;
return;
}
- qDebug() << "directoryPath: " << directoryPath;
// set model dir if needed
if(model->absolutePath() != directoryPath) {
this->reset();
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/core.h new/qimgv-0.8.4/qimgv/core.h
--- old/qimgv-0.8.3/qimgv/core.h 2019-09-19 17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/core.h 2019-09-21 22:52:26.000000000 +0200
@@ -119,6 +119,7 @@
void onDropIn(const QMimeData *mimeData, QObject* source);
void toggleShuffle();
void onModelLoaded();
+ void outputError(const FileOpResult &error) const;
};
#endif // CORE_H
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/gui/mainwindow.cpp
new/qimgv-0.8.4/qimgv/gui/mainwindow.cpp
--- old/qimgv-0.8.3/qimgv/gui/mainwindow.cpp 2019-09-19 17:21:20.000000000
+0200
+++ new/qimgv-0.8.4/qimgv/gui/mainwindow.cpp 2019-09-21 22:52:26.000000000
+0200
@@ -156,6 +156,7 @@
void MainWindow::setupRenameOverlay() {
renameOverlay = new RenameOverlay(this);
+ renameOverlay->setName(info.fileName);
connect(renameOverlay, &RenameOverlay::renameRequested, this,
&MainWindow::renameRequested);
}
@@ -634,25 +635,31 @@
}
}
-void MainWindow::setCurrentInfo(int fileIndex, int fileCount, QString
fileName, QSize imageSize, int fileSize) {
- if(renameOverlay) // TODO: use some global state for convenience?
- renameOverlay->setName(fileName);
- if(fileName.isEmpty()) {
+void MainWindow::setCurrentInfo(int _index, int _fileCount, QString _fileName,
QSize _imageSize, int _fileSize) {
+ info.index = _index;
+ info.fileCount = _fileCount;
+ info.fileName = _fileName;
+ info.imageSize = _imageSize;
+ info.fileSize = _fileSize;
+
+ if(renameOverlay)
+ renameOverlay->setName(info.fileName);
+ if(info.fileName.isEmpty()) {
setWindowTitle(qApp->applicationName());
infoBarFullscreen->setInfo("", "No file opened.", "");
infoBarWindowed->setInfo("", "No file opened.", "");
} else {
QString posString;
- if(fileCount)
- posString = "[ " + QString::number(fileIndex + 1) + "/" +
QString::number(fileCount) + " ]";
+ if(info.fileCount)
+ posString = "[ " + QString::number(info.index + 1) + "/" +
QString::number(info.fileCount) + " ]";
QString resString;
- if(imageSize.width())
- resString = QString::number(imageSize.width()) + " x " +
QString::number(imageSize.height());
+ if(info.imageSize.width())
+ resString = QString::number(info.imageSize.width()) + " x " +
QString::number(info.imageSize.height());
QString sizeString;
- if(fileSize)
- sizeString = QString::number(fileSize / 1024) + " KiB";
+ if(info.fileSize)
+ sizeString = QString::number(info.fileSize / 1024) + " KiB";
- QString windowTitle = fileName;
+ QString windowTitle = info.fileName;
if(settings->windowTitleExtendedInfo()) {
windowTitle.prepend(posString + " ");
if(!resString.isEmpty())
@@ -660,9 +667,9 @@
if(!sizeString.isEmpty())
windowTitle.append(" - " + sizeString);
}
- infoBarFullscreen->setInfo(posString, fileName, resString + " " +
sizeString);
+ infoBarFullscreen->setInfo(posString, info.fileName, resString + " "
+ sizeString);
setWindowTitle(windowTitle);
- infoBarWindowed->setInfo(posString, fileName, resString + " " +
sizeString);
+ infoBarWindowed->setInfo(posString, info.fileName, resString + " " +
sizeString);
}
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/gui/mainwindow.h
new/qimgv-0.8.4/qimgv/gui/mainwindow.h
--- old/qimgv-0.8.3/qimgv/gui/mainwindow.h 2019-09-19 17:21:20.000000000
+0200
+++ new/qimgv-0.8.4/qimgv/gui/mainwindow.h 2019-09-21 22:52:26.000000000
+0200
@@ -33,6 +33,14 @@
#include <KWindowEffects>
#endif
+struct CurrentInfo {
+ int index;
+ int fileCount;
+ QString fileName;
+ QSize imageSize;
+ int fileSize;
+};
+
enum ActiveSidePanel {
SIDEPANEL_CROP,
SIDEPANEL_NONE
@@ -89,6 +97,7 @@
PanelHPosition panelPosition;
QPoint lastMouseMovePos;
+ CurrentInfo info;
void saveWindowGeometry();
void restoreWindowGeometry();
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/gui/overlays/floatingmessage.cpp
new/qimgv-0.8.4/qimgv/gui/overlays/floatingmessage.cpp
--- old/qimgv-0.8.3/qimgv/gui/overlays/floatingmessage.cpp 2019-09-19
17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/gui/overlays/floatingmessage.cpp 2019-09-21
22:52:26.000000000 +0200
@@ -18,6 +18,7 @@
iconLeftEdge = QIcon(":/res/icons/message/dir_start20.png");
iconRightEdge = QIcon(":/res/icons/message/dir_end20.png");
iconSuccess = QIcon(":/res/icons/buttons/success16.png");
+ //iconError = QIcon(":/res/icons/buttons/error16.png");
setIcon(FloatingMessageIcon::NO_ICON);
this->setAccessibleName("FloatingMessage");
@@ -88,6 +89,9 @@
ui->iconLabel->show();
ui->iconLabel->setPixmap(iconSuccess.pixmap(16,16));
break;
+ case FloatingMessageIcon::ICON_ERROR:
+ ui->iconLabel->hide();
+ break;
}
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qimgv-0.8.3/qimgv/gui/viewers/videoplayerinitproxy.cpp
new/qimgv-0.8.4/qimgv/gui/viewers/videoplayerinitproxy.cpp
--- old/qimgv-0.8.3/qimgv/gui/viewers/videoplayerinitproxy.cpp 2019-09-19
17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/gui/viewers/videoplayerinitproxy.cpp 2019-09-21
22:52:26.000000000 +0200
@@ -30,11 +30,8 @@
#ifdef __linux
playerLib.setFileName("qimgv_player_mpv");
#else
- //playerLib.setFileName("qimgv_player_mpv");
playerLib.setFileName("libqimgv_player_mpv.dll");
-
//playerLib.setFileName("C:/packaging/build_exiv2_mpv/libqimgv_player_mpv.dll");
#endif
- qDebug() << playerLib.load();
typedef VideoPlayer* (*createPlayerWidgetFn)();
createPlayerWidgetFn fn = (createPlayerWidgetFn)
playerLib.resolve("CreatePlayerWidget");
if(fn) {
@@ -46,9 +43,7 @@
qDebug() << playerLib.fileName();
return false;
}
- qDebug() << "[VideoPlayerInitProxy] Library load success!";
-
-//#else
+ //qDebug() << "[VideoPlayerInitProxy] Library load success!";
player->setMuted(!settings->playVideoSounds());
player->setVideoUnscaled(!settings->expandImage());
@@ -61,7 +56,6 @@
connect(player.get(), SIGNAL(positionChanged(int)), this,
SIGNAL(positionChanged(int)));
connect(player.get(), SIGNAL(videoPaused(bool)), this,
SIGNAL(videoPaused(bool)));
return true;
-//#endif
}
bool VideoPlayerInitProxy::openMedia(QString file) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/main.cpp
new/qimgv-0.8.4/qimgv/main.cpp
--- old/qimgv-0.8.3/qimgv/main.cpp 2019-09-19 17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/main.cpp 2019-09-21 22:52:26.000000000 +0200
@@ -95,6 +95,7 @@
if(!arg1.isEmpty()) {
core.loadPath(arg1);
}
+ qApp->processEvents();
core.showGui();
return a.exec();
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/res/styles/dark.qss
new/qimgv-0.8.4/qimgv/res/styles/dark.qss
--- old/qimgv-0.8.3/qimgv/res/styles/dark.qss 2019-09-19 17:21:20.000000000
+0200
+++ new/qimgv-0.8.4/qimgv/res/styles/dark.qss 2019-09-21 22:52:26.000000000
+0200
@@ -116,6 +116,7 @@
padding: 5px 0px;
background-color: #232324;
border: 1px solid #373738;
+ outline: 0px;
}
[accessibleName="PanelComboBox"] QAbstractItemView::item {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qimgv-0.8.3/qimgv/settings.cpp
new/qimgv-0.8.4/qimgv/settings.cpp
--- old/qimgv-0.8.3/qimgv/settings.cpp 2019-09-19 17:21:20.000000000 +0200
+++ new/qimgv-0.8.4/qimgv/settings.cpp 2019-09-21 22:52:26.000000000 +0200
@@ -159,7 +159,7 @@
//------------------------------------------------------------------------------
bool Settings::playMp4() {
#ifdef USE_MPV
- return settings->s->value("playMp4", false).toBool();
+ return settings->s->value("playMp4", true).toBool();
#else
return false;
#endif
