Hello community,
here is the log from the commit of package perl-Perl-Critic-Freenode for
openSUSE:Factory checked in at 2019-09-27 14:53:57
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Perl-Critic-Freenode (Old)
and /work/SRC/openSUSE:Factory/.perl-Perl-Critic-Freenode.new.2352 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Perl-Critic-Freenode"
Fri Sep 27 14:53:57 2019 rev:9 rq:733629 version:0.031
Changes:
--------
---
/work/SRC/openSUSE:Factory/perl-Perl-Critic-Freenode/perl-Perl-Critic-Freenode.changes
2019-08-28 18:36:03.281277731 +0200
+++
/work/SRC/openSUSE:Factory/.perl-Perl-Critic-Freenode.new.2352/perl-Perl-Critic-Freenode.changes
2019-09-27 14:55:05.831727424 +0200
@@ -1,0 +2,10 @@
+Thu Sep 26 08:27:43 UTC 2019 - <[email protected]>
+
+- updated to 0.031
+ see /usr/share/doc/packages/perl-Perl-Critic-Freenode/Changes
+
+ 0.031 2019-09-25 19:00:39 EDT
+ - Add FindBin to DiscouragedModules policy (#31)
+ - Add MultidimensionalArrayEmulation policy (#35)
+
+-------------------------------------------------------------------
Old:
----
Perl-Critic-Freenode-0.030.tar.gz
New:
----
Perl-Critic-Freenode-0.031.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Perl-Critic-Freenode.spec ++++++
--- /var/tmp/diff_new_pack.XSHVWM/_old 2019-09-27 14:55:07.119724074 +0200
+++ /var/tmp/diff_new_pack.XSHVWM/_new 2019-09-27 14:55:07.119724074 +0200
@@ -17,7 +17,7 @@
Name: perl-Perl-Critic-Freenode
-Version: 0.030
+Version: 0.031
Release: 0
%define cpan_name Perl-Critic-Freenode
Summary: Perl::Critic policies inspired by #perl on
++++++ Perl-Critic-Freenode-0.030.tar.gz -> Perl-Critic-Freenode-0.031.tar.gz
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.030/Build.PL
new/Perl-Critic-Freenode-0.031/Build.PL
--- old/Perl-Critic-Freenode-0.030/Build.PL 2019-08-26 17:27:17.000000000
+0200
+++ new/Perl-Critic-Freenode-0.031/Build.PL 2019-09-26 01:00:42.000000000
+0200
@@ -84,7 +84,7 @@
"Dan Book <dbook\@cpan.org>"
],
"dist_name" => "Perl-Critic-Freenode",
- "dist_version" => "0.030",
+ "dist_version" => "0.031",
"license" => "artistic_2",
"module_name" => "Perl::Critic::Freenode",
"recursive_test_files" => 1,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.030/Changes
new/Perl-Critic-Freenode-0.031/Changes
--- old/Perl-Critic-Freenode-0.030/Changes 2019-08-26 17:27:17.000000000
+0200
+++ new/Perl-Critic-Freenode-0.031/Changes 2019-09-26 01:00:42.000000000
+0200
@@ -1,3 +1,7 @@
+0.031 2019-09-25 19:00:39 EDT
+ - Add FindBin to DiscouragedModules policy (#31)
+ - Add MultidimensionalArrayEmulation policy (#35)
+
0.030 2019-08-26 11:27:15 EDT
- Allow signature_enablers to be configured for Prototypes policy (#34)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.030/MANIFEST
new/Perl-Critic-Freenode-0.031/MANIFEST
--- old/Perl-Critic-Freenode-0.030/MANIFEST 2019-08-26 17:27:17.000000000
+0200
+++ new/Perl-Critic-Freenode-0.031/MANIFEST 2019-09-26 01:00:42.000000000
+0200
@@ -26,6 +26,7 @@
lib/Perl/Critic/Policy/Freenode/LexicalForeachIterator.pm
lib/Perl/Critic/Policy/Freenode/LoopOnHash.pm
lib/Perl/Critic/Policy/Freenode/ModPerl.pm
+lib/Perl/Critic/Policy/Freenode/MultidimensionalArrayEmulation.pm
lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
@@ -53,6 +54,7 @@
t/Freenode/LexicalForeachIterator.run
t/Freenode/LoopOnHash.run
t/Freenode/ModPerl.run
+t/Freenode/MultidimensionalArrayEmulation.run
t/Freenode/OpenArgs.run
t/Freenode/OverloadOptions.run
t/Freenode/POSIXImports.run
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.030/META.json
new/Perl-Critic-Freenode-0.031/META.json
--- old/Perl-Critic-Freenode-0.030/META.json 2019-08-26 17:27:17.000000000
+0200
+++ new/Perl-Critic-Freenode-0.031/META.json 2019-09-26 01:00:42.000000000
+0200
@@ -71,111 +71,115 @@
"provides" : {
"Perl::Critic::Freenode" : {
"file" : "lib/Perl/Critic/Freenode.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Freenode::Utils" : {
"file" : "lib/Perl/Critic/Freenode/Utils.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::AmpersandSubCalls" : {
"file" : "lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::ArrayAssignAref" : {
"file" : "lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::BarewordFilehandles" : {
"file" : "lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::ConditionalDeclarations" : {
"file" : "lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::ConditionalImplicitReturn" : {
"file" :
"lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::DeprecatedFeatures" : {
"file" : "lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::DiscouragedModules" : {
"file" : "lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::DollarAB" : {
"file" : "lib/Perl/Critic/Policy/Freenode/DollarAB.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::Each" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Each.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::EmptyReturn" : {
"file" : "lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::IndirectObjectNotation" : {
"file" : "lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::LexicalForeachIterator" : {
"file" : "lib/Perl/Critic/Policy/Freenode/LexicalForeachIterator.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::LoopOnHash" : {
"file" : "lib/Perl/Critic/Policy/Freenode/LoopOnHash.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::ModPerl" : {
"file" : "lib/Perl/Critic/Policy/Freenode/ModPerl.pm",
- "version" : "0.030"
+ "version" : "0.031"
+ },
+ "Perl::Critic::Policy::Freenode::MultidimensionalArrayEmulation" : {
+ "file" :
"lib/Perl/Critic/Policy/Freenode/MultidimensionalArrayEmulation.pm",
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::OpenArgs" : {
"file" : "lib/Perl/Critic/Policy/Freenode/OpenArgs.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::OverloadOptions" : {
"file" : "lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::POSIXImports" : {
"file" : "lib/Perl/Critic/Policy/Freenode/POSIXImports.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::PackageMatchesFilename" : {
"file" : "lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::PreferredAlternatives" : {
"file" : "lib/Perl/Critic/Policy/Freenode/PreferredAlternatives.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::Prototypes" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Prototypes.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::StrictWarnings" : {
"file" : "lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::Threads" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Threads.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::Wantarray" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Wantarray.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::WarningsSwitch" : {
"file" : "lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm",
- "version" : "0.030"
+ "version" : "0.031"
},
"Perl::Critic::Policy::Freenode::WhileDiamondDefaultAssignment" : {
"file" :
"lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm",
- "version" : "0.030"
+ "version" : "0.031"
}
},
"release_status" : "stable",
@@ -191,7 +195,7 @@
},
"x_IRC" : "irc://chat.freenode.net/#perl"
},
- "version" : "0.030",
+ "version" : "0.031",
"x_Dist_Zilla" : {
"perl" : {
"version" : "5.030000"
@@ -385,7 +389,7 @@
"branch" : null,
"changelog" : "Changes",
"signed" : 0,
- "tag" : "0.030",
+ "tag" : "0.031",
"tag_format" : "%v",
"tag_message" : "%v"
},
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.030/META.yml
new/Perl-Critic-Freenode-0.031/META.yml
--- old/Perl-Critic-Freenode-0.030/META.yml 2019-08-26 17:27:17.000000000
+0200
+++ new/Perl-Critic-Freenode-0.031/META.yml 2019-09-26 01:00:42.000000000
+0200
@@ -26,85 +26,88 @@
provides:
Perl::Critic::Freenode:
file: lib/Perl/Critic/Freenode.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Freenode::Utils:
file: lib/Perl/Critic/Freenode/Utils.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::AmpersandSubCalls:
file: lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::ArrayAssignAref:
file: lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::BarewordFilehandles:
file: lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::ConditionalDeclarations:
file: lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::ConditionalImplicitReturn:
file: lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::DeprecatedFeatures:
file: lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::DiscouragedModules:
file: lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::DollarAB:
file: lib/Perl/Critic/Policy/Freenode/DollarAB.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::Each:
file: lib/Perl/Critic/Policy/Freenode/Each.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::EmptyReturn:
file: lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::IndirectObjectNotation:
file: lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::LexicalForeachIterator:
file: lib/Perl/Critic/Policy/Freenode/LexicalForeachIterator.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::LoopOnHash:
file: lib/Perl/Critic/Policy/Freenode/LoopOnHash.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::ModPerl:
file: lib/Perl/Critic/Policy/Freenode/ModPerl.pm
- version: '0.030'
+ version: '0.031'
+ Perl::Critic::Policy::Freenode::MultidimensionalArrayEmulation:
+ file: lib/Perl/Critic/Policy/Freenode/MultidimensionalArrayEmulation.pm
+ version: '0.031'
Perl::Critic::Policy::Freenode::OpenArgs:
file: lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::OverloadOptions:
file: lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::POSIXImports:
file: lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::PackageMatchesFilename:
file: lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::PreferredAlternatives:
file: lib/Perl/Critic/Policy/Freenode/PreferredAlternatives.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::Prototypes:
file: lib/Perl/Critic/Policy/Freenode/Prototypes.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::StrictWarnings:
file: lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::Threads:
file: lib/Perl/Critic/Policy/Freenode/Threads.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::Wantarray:
file: lib/Perl/Critic/Policy/Freenode/Wantarray.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::WarningsSwitch:
file: lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
- version: '0.030'
+ version: '0.031'
Perl::Critic::Policy::Freenode::WhileDiamondDefaultAssignment:
file: lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
- version: '0.030'
+ version: '0.031'
requires:
Carp: '0'
Exporter: '0'
@@ -127,7 +130,7 @@
bugtracker: https://github.com/Grinnz/Perl-Critic-Freenode/issues
homepage: https://github.com/Grinnz/Perl-Critic-Freenode
repository: https://github.com/Grinnz/Perl-Critic-Freenode.git
-version: '0.030'
+version: '0.031'
x_Dist_Zilla:
perl:
version: '5.030000'
@@ -277,7 +280,7 @@
branch: ~
changelog: Changes
signed: 0
- tag: '0.030'
+ tag: '0.031'
tag_format: '%v'
tag_message: '%v'
Dist::Zilla::Role::Git::Repo:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.030/README
new/Perl-Critic-Freenode-0.031/README
--- old/Perl-Critic-Freenode-0.030/README 2019-08-26 17:27:17.000000000
+0200
+++ new/Perl-Critic-Freenode-0.031/README 2019-09-26 01:00:42.000000000
+0200
@@ -85,6 +85,10 @@
Don't use mod_perl to write web applications
+ Perl::Critic::Policy::Freenode::MultidimensionalArrayEmulation
+
+ Don't use multidimensional array emulation
+
Perl::Critic::Policy::Freenode::OpenArgs
Always use the three-argument form of open()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Freenode/Utils.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Freenode/Utils.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Freenode/Utils.pm
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Freenode/Utils.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Exporter 'import';
use Scalar::Util 'blessed';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
our @EXPORT_OK = qw(is_empty_return is_structural_block);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Freenode.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Freenode.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Freenode.pm 2019-08-26
17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Freenode.pm 2019-09-26
01:00:42.000000000 +0200
@@ -3,7 +3,7 @@
use strict;
use warnings;
-our $VERSION = '0.030';
+our $VERSION = '0.031';
1;
@@ -96,6 +96,10 @@
Don't use C<mod_perl> to write web applications
+=item L<Perl::Critic::Policy::Freenode::MultidimensionalArrayEmulation>
+
+Don't use multidimensional array emulation
+
=item L<Perl::Critic::Policy::Freenode::OpenArgs>
Always use the three-argument form of C<open()>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Subroutines::ProhibitAmpersandSigils';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub default_severity { $SEVERITY_HIGH }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent
'Perl::Critic::Policy::ValuesAndExpressions::ProhibitArrayAssignAref';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub default_severity { $SEVERITY_MEDIUM }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using bareword filehandles';
use constant EXPL => 'Bareword filehandles are a legacy feature, creating the
filehandles as package variables. Use lexical, scoped filehandles instead (open
my $fh, ...).';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub default_severity { $SEVERITY_HIGH }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
2019-09-26 01:00:42.000000000 +0200
@@ -9,7 +9,7 @@
use List::Util 'any';
use Perl::Critic::Freenode::Utils qw(is_empty_return is_structural_block);
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Subroutine may implicitly return a conditional
statement';
use constant EXPL => 'When the last statement in a subroutine is a
conditional, the return value may unexpectedly be the evaluated condition.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
2019-09-26 01:00:42.000000000 +0200
@@ -7,7 +7,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub supported_parameters { () }
sub default_severity { $SEVERITY_HIGH }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub supported_parameters { () }
sub default_severity { $SEVERITY_HIGH }
@@ -21,6 +21,7 @@
'Coro' => 'Coro no longer works on perl 5.22, you need to use the
author\'s forked version of Perl. Avoid at all costs.',
'Error' => 'Error.pm is overly magical and discouraged by its
maintainers. Try Throwable for exception classes in Moo/Moose, or
Exception::Class otherwise. Try::Tiny or Try are recommended for the try/catch
syntax.',
'File::Slurp' => 'File::Slurp gets file encodings all wrong, line
endings on win32 are messed up, and it was written before layers were properly
added. Use File::Slurper, Path::Tiny, Data::Munge, or Mojo::File.',
+ 'FindBin' => 'FindBin depends on the sometimes vague definition of
"initial script" and can\'t be updated to fix bugs in old Perls. Use Dir::Self
or lib::relative to work with the absolute path of the current source file
instead.',
'HTML::Template' => 'HTML::Template is an old and buggy module, try
Template Toolkit, HTML::Zoom, or Text::Template instead, or HTML::Template::Pro
if you must use the same syntax.',
'IO::Socket::INET6' => 'IO::Socket::INET6 is an old attempt at an IPv6
compatible version of IO::Socket::INET, but has numerous issues and is
discouraged by the maintainer in favor of IO::Socket::IP, which transparently
creates IPv4 and IPv6 sockets.',
'JSON::Any' => 'JSON::Any is deprecated. Use JSON::MaybeXS instead.',
@@ -95,6 +96,18 @@
otherwise. L<Try::Tiny> or L<Try> are recommended for the C<try>/C<catch>
syntax.
+=head2 FindBin
+
+L<FindBin> is often used to retrieve the absolute path to the directory
+containing the initially executed script, a mechanism which is not always
+logically clear. Additionally, it has serious bugs on old Perls and can't be
+updated from CPAN to fix them. The L<Dir::Self> module provides a
+straightforward C<__DIR__> constant for the absolute path to the directory
+containing the current source file. The L<lib::relative> module resolves passed
+relative paths to the current source file for the common case of adding local
+module include directories, and documents an example of achieving the same
+behavior with core modules.
+
=head2 File::Slurp
L<File::Slurp> gets file encodings all wrong, line endings on win32 are messed
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using $a or $b outside sort()';
use constant EXPL => '$a and $b are special package variables for use in
sort() and related functions. Declaring them as lexicals like "my $a" may break
sort(). Use different variable names.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Each.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Each.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Each.pm
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Each.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'each() called';
use constant EXPL => 'The each function may cause undefined behavior when
operating on the hash while iterating. Use a foreach loop over the hash\'s keys
or values instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
2019-09-26 01:00:42.000000000 +0200
@@ -9,7 +9,7 @@
use List::Util 'any';
use Perl::Critic::Freenode::Utils qw(is_empty_return is_structural_block);
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'return called with no arguments';
use constant EXPL => 'return with no arguments may return either undef or an
empty list depending on context. This can be surprising for the same reason as
other context-sensitive returns. Return undef or the empty list explicitly.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Objects::ProhibitIndirectSyntax';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub default_severity { $SEVERITY_HIGHEST }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/LexicalForeachIterator.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/LexicalForeachIterator.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/LexicalForeachIterator.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/LexicalForeachIterator.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Variables::RequireLexicalLoopIterators';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub default_severity { $SEVERITY_HIGH }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/LoopOnHash.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/LoopOnHash.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/LoopOnHash.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/LoopOnHash.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Variables::ProhibitLoopOnHash';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub default_severity { $SEVERITY_HIGH }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using mod_perl';
use constant EXPL => 'mod_perl is not designed for writing Perl web
applications. Try a Plack-based framework (Web::Simple, Dancer2, Catalyst) or
Mojolicious for a modern approach.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/MultidimensionalArrayEmulation.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/MultidimensionalArrayEmulation.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/MultidimensionalArrayEmulation.pm
1970-01-01 01:00:00.000000000 +0100
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/MultidimensionalArrayEmulation.pm
2019-09-26 01:00:42.000000000 +0200
@@ -0,0 +1,110 @@
+package Perl::Critic::Policy::Freenode::MultidimensionalArrayEmulation;
+
+use strict;
+use warnings;
+
+use Perl::Critic::Utils qw(:severities :classification :ppi);
+use parent 'Perl::Critic::Policy';
+
+use List::Util 'any';
+
+our $VERSION = '0.031';
+
+use constant DESC => 'Use of multidimensional array emulation in hash
subscript';
+use constant EXPL => 'A list in a hash subscript used with the $ sigil
triggers Perl 4 multidimensional array emulation. Nest structures using
references instead.';
+
+sub supported_parameters { () }
+sub default_severity { $SEVERITY_LOW }
+sub default_themes { 'freenode' }
+sub applies_to { 'PPI::Structure::Subscript' }
+
+sub violates {
+ my ($self, $elem) = @_;
+ return () unless $elem->complete and $elem->braces eq '{}';
+
+ my @contents = $elem->schildren;
+ @contents = $contents[0]->schildren if @contents == 1 and
$contents[0]->isa('PPI::Statement::Expression');
+
+ # check for function call with no parentheses; following args won't
trigger MAE
+ if (@contents > 1 and $contents[0]->isa('PPI::Token::Word') and
!$contents[1]->isa('PPI::Structure::List')
+ and !($contents[1]->isa('PPI::Token::Operator') and
($contents[1] eq ',' or $contents[1] eq '=>'))) {
+ return ();
+ }
+
+ # check if contains top level , or multi-word qw
+ return () unless any {
+ ($_->isa('PPI::Token::Operator') and ($_ eq ',' or $_ eq '=>'))
or
+ ($_->isa('PPI::Token::QuoteLike::Words') and (my @words =
$_->literal) > 1)
+ } @contents;
+
+ # check if it's a postderef slice
+ my $prev = $elem->sprevious_sibling;
+ return () if $prev and $prev->isa('PPI::Token::Cast') and ($prev eq '@'
or $prev eq '%');
+
+ # check if it's a slice
+ my ($cast, $found_symbol);
+ $prev = $elem;
+ while ($prev = $prev->sprevious_sibling) {
+ last if $found_symbol and !$prev->isa('PPI::Token::Cast');
+ if ($prev->isa('PPI::Token::Symbol')) {
+ $cast = $prev->raw_type;
+ $found_symbol = 1;
+ } elsif ($prev->isa('PPI::Structure::Block')) {
+ $found_symbol = 1;
+ } elsif ($found_symbol and $prev->isa('PPI::Token::Cast')) {
+ $cast = $prev;
+ } else {
+ last unless $prev->isa('PPI::Structure::Subscript')
+ or ($prev->isa('PPI::Token::Operator') and
$prev eq '->');
+ }
+ }
+ return () if $cast and ($cast eq '@' or $cast eq '%');
+
+ return $self->violation(DESC, EXPL, $elem);
+}
+
+1;
+
+=head1 NAME
+
+Perl::Critic::Policy::Freenode::MultidimensionalArrayEmulation - Don't use
+multidimensional array emulation
+
+=head1 DESCRIPTION
+
+When used with the C<@> or C<%> sigils, a list in a hash subscript (C<{}>) will
+access multiple elements of the hash as a slice. With the C<$> sigil however,
+it accesses the single element at the key defined by joining the list with the
+subscript separator C<$;>. This feature is known as
+L<perldata/"Multi-dimensional array emulation"> and provided a way to emulate
+a multidimensional structure before Perl 5 introduced references. Perl now
+supports true multidimensional structures, so this feature is now unnecessary
+in most cases.
+
+ $foo{$x,$y,$z} # not ok
+ $foo{qw(a b c)} # not ok
+ $foo{$x}{$y}{$z} # ok
+ @foo{$x,$y,$z} # ok
+
+=head1 AFFILIATION
+
+This policy is part of L<Perl::Critic::Freenode>.
+
+=head1 CONFIGURATION
+
+This policy is not configurable except for the standard options.
+
+=head1 AUTHOR
+
+Dan Book, C<[email protected]>
+
+=head1 COPYRIGHT AND LICENSE
+
+Copyright 2015, Dan Book.
+
+This library is free software; you may redistribute it and/or modify it under
+the terms of the Artistic License version 2.0.
+
+=head1 SEE ALSO
+
+L<Perl::Critic>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'open() called with less than 3 arguments';
use constant EXPL => 'The one- and two-argument forms of open() parse
functionality from the filename, use the three-argument form instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using overload.pm without a boolean overload or
fallback';
use constant EXPL => 'When using overload.pm to define overloads for an object
class, always define an overload on "bool" explicitly and set the fallback
option. This prevents objects from autogenerating a potentially surprising
boolean overload, and causes operators for which overloads can\'t be
autogenerated to act on the object as they normally would.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using POSIX.pm without an explicit import list';
use constant EXPL => 'Using the POSIX module without specifying an import list
results in importing hundreds of symbols. Import the functions or constants you
want explicitly, or prevent the import with ().';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
2019-09-26 01:00:42.000000000 +0200
@@ -7,7 +7,7 @@
use Path::Tiny 'path';
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'No package matching the module filename';
use constant EXPL => 'A Perl module file is expected to contain a matching
package name, so it can be used after loading it from the filesystem. A module
file that doesn\'t contain a matching package name usually indicates an error.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/PreferredAlternatives.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/PreferredAlternatives.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/PreferredAlternatives.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/PreferredAlternatives.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
sub supported_parameters { () }
sub default_severity { $SEVERITY_LOW }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using function prototypes';
use constant EXPL => 'Function prototypes (sub foo ($@) { ... }) will usually
not do what you want. Omit the prototype, or use signatures instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
2019-09-26 01:00:42.000000000 +0200
@@ -8,7 +8,7 @@
use parent 'Perl::Critic::Policy';
use version;
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Missing strict or warnings';
use constant EXPL => 'The strict and warnings pragmas are important to avoid
common pitfalls and deprecated/experimental functionality. Make sure each
script or module contains "use strict; use warnings;" or a module that does
this for you.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Threads.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Threads.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Threads.pm
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Threads.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using interpreter threads';
use constant EXPL => 'Interpreter threads are discouraged, they are not
lightweight and fast as other threads may be. Try an event loop, forks.pm, or
Parallel::Prefork.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
--- old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'wantarray() called';
use constant EXPL => 'Context-sensitive functions lead to unexpected errors or
vulnerabilities. Functions should explicitly return either a list or a scalar
value.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => 'Using -w switch';
use constant EXPL => 'Don\'t use -w (or -W), it\'s too eager. use warnings;
instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
---
old/Perl-Critic-Freenode-0.030/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
2019-08-26 17:27:17.000000000 +0200
+++
new/Perl-Critic-Freenode-0.031/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
2019-09-26 01:00:42.000000000 +0200
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.030';
+our $VERSION = '0.031';
use constant DESC => '<>/<<>>/readline/readdir/each result not explicitly
assigned in while condition';
use constant EXPL => 'When used alone in a while condition, the <>/<<>>
operator, readline, readdir, and each functions assign their result to $_, but
do not localize it. Assign the result to an explicit lexical variable instead
(my $line = <...>, my $dir = readdir ...)';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/t/Freenode/DiscouragedModules.run
new/Perl-Critic-Freenode-0.031/t/Freenode/DiscouragedModules.run
--- old/Perl-Critic-Freenode-0.030/t/Freenode/DiscouragedModules.run
2019-08-26 17:27:17.000000000 +0200
+++ new/Perl-Critic-Freenode-0.031/t/Freenode/DiscouragedModules.run
2019-09-26 01:00:42.000000000 +0200
@@ -2,9 +2,11 @@
## failures 0
## cut
+use lib::relative;
use Cpanel::JSON::XS;
use Dancer2;
use DBIx::Class;
+use Dir::Self;
use Exception::Class;
use File::Slurp::Tiny;
use IO::Async::Loop;
@@ -33,7 +35,7 @@
use XML::Twig;
## name BadModules
-## failures 14
+## failures 15
## cut
use Any::Moose;
@@ -43,6 +45,7 @@
use Coro;
use Error;
use File::Slurp;
+use FindBin;
use HTML::Template;
use IO::Socket::INET6;
use JSON::Any;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.030/t/Freenode/MultidimensionalArrayEmulation.run
new/Perl-Critic-Freenode-0.031/t/Freenode/MultidimensionalArrayEmulation.run
---
old/Perl-Critic-Freenode-0.030/t/Freenode/MultidimensionalArrayEmulation.run
1970-01-01 01:00:00.000000000 +0100
+++
new/Perl-Critic-Freenode-0.031/t/Freenode/MultidimensionalArrayEmulation.run
2019-09-26 01:00:42.000000000 +0200
@@ -0,0 +1,48 @@
+## name ScalarAccess
+## failures 0
+## cut
+
+$foo{bar};
+$foo{'bar'};
+$$foo{ bar };
+$foo{'bar,baz'};
+$foo{bar(1,2)};
+$foo{bar 1, 2};
+
+## name Slices
+## failures 0
+## cut
+
+@foo {'bar','baz'};
+@{foo}{qw(bar baz)};
+@{$foo{bar}}{a => 'b'};
+@{@foo[0]}{'a','b'};
+@$foo{'a','b'};
+$foo->@{'a','b'};
+%foo{'bar','baz'};
+%{foo}{'bar','baz'};
+%{$foo{bar}}{'a','b'};
+%{@foo[0]}{'a','b'};
+%$foo{'a','b'};
+$foo->%{'a','b'};
+
+## name MAE
+## failures 10
+## cut
+
+$foo{'bar','baz'};
+${foo} {qw(bar baz)};
+$foo{bar}{a => 'b'};
+${@foo[0]}{'a','b'};
+$$foo {'a','b'};
+{1,2}->{'bar','baz'};
+foo->[2]{'bar','baz'};
+$foo{bar (1),2};
+$foo{1,bar 2};
+$foo{bar, 2};
+
+## name Nested
+## failures 3
+## cut
+
+$foo->{ $bar->{'a','b'} => $baz->{qw(a b)} };
