Hello community, here is the log from the commit of package yast2-installation for openSUSE:Factory checked in at 2019-10-16 09:09:45 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-installation (Old) and /work/SRC/openSUSE:Factory/.yast2-installation.new.2352 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-installation" Wed Oct 16 09:09:45 2019 rev:435 rq:736848 version:4.2.17 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-installation/yast2-installation.changes 2019-10-03 14:06:40.692529569 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-installation.new.2352/yast2-installation.changes 2019-10-16 09:09:50.344309753 +0200 @@ -1,0 +2,6 @@ +Thu Oct 10 11:19:06 UTC 2019 - Josef Reidinger <[email protected]> + +- fix crash when os-release contain empty value (bsc#1139518) +- 4.2.17 + +------------------------------------------------------------------- Old: ---- yast2-installation-4.2.16.tar.bz2 New: ---- yast2-installation-4.2.17.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-installation.spec ++++++ --- /var/tmp/diff_new_pack.XR6I5o/_old 2019-10-16 09:09:52.008305464 +0200 +++ /var/tmp/diff_new_pack.XR6I5o/_new 2019-10-16 09:09:52.012305454 +0200 @@ -17,7 +17,7 @@ Name: yast2-installation -Version: 4.2.16 +Version: 4.2.17 Release: 0 Summary: YaST2 - Installation Parts License: GPL-2.0-only ++++++ yast2-installation-4.2.16.tar.bz2 -> yast2-installation-4.2.17.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-installation-4.2.16/package/yast2-installation.changes new/yast2-installation-4.2.17/package/yast2-installation.changes --- old/yast2-installation-4.2.16/package/yast2-installation.changes 2019-10-02 09:55:53.000000000 +0200 +++ new/yast2-installation-4.2.17/package/yast2-installation.changes 2019-10-10 14:15:54.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Thu Oct 10 11:19:06 UTC 2019 - Josef Reidinger <[email protected]> + +- fix crash when os-release contain empty value (bsc#1139518) +- 4.2.17 + +------------------------------------------------------------------- Tue Oct 1 16:09:07 UTC 2019 - Ladislav Slezák <[email protected]> - Support for the offline installation medium (jsc#SLE-7101) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-installation-4.2.16/package/yast2-installation.spec new/yast2-installation-4.2.17/package/yast2-installation.spec --- old/yast2-installation-4.2.16/package/yast2-installation.spec 2019-10-02 09:55:53.000000000 +0200 +++ new/yast2-installation-4.2.17/package/yast2-installation.spec 2019-10-10 14:15:54.000000000 +0200 @@ -16,7 +16,7 @@ # Name: yast2-installation -Version: 4.2.16 +Version: 4.2.17 Release: 0 Group: System/YaST License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-installation-4.2.16/src/lib/installation/ssh_config.rb new/yast2-installation-4.2.17/src/lib/installation/ssh_config.rb --- old/yast2-installation-4.2.16/src/lib/installation/ssh_config.rb 2019-10-02 09:55:53.000000000 +0200 +++ new/yast2-installation-4.2.17/src/lib/installation/ssh_config.rb 2019-10-10 14:15:54.000000000 +0200 @@ -87,6 +87,7 @@ next if line.empty? || line.start_with?("#") (key, value) = line.split("=") key.rstrip! + value ||= "" # handle case `KEY=` (bsc#1139518) value.gsub!(/^\s*"/, "") value.gsub!(/"\s*$/, "") content[key] = value diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-installation-4.2.16/test/fixtures/root1/etc/os-release new/yast2-installation-4.2.17/test/fixtures/root1/etc/os-release --- old/yast2-installation-4.2.16/test/fixtures/root1/etc/os-release 2019-10-02 09:55:53.000000000 +0200 +++ new/yast2-installation-4.2.17/test/fixtures/root1/etc/os-release 2019-10-10 14:15:54.000000000 +0200 @@ -1 +1,2 @@ PRETTY_NAME="Operating system 1" +EMPTY= diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-installation-4.2.16/test/ssh_config_test.rb new/yast2-installation-4.2.17/test/ssh_config_test.rb --- old/yast2-installation-4.2.16/test/ssh_config_test.rb 2019-10-02 09:55:53.000000000 +0200 +++ new/yast2-installation-4.2.17/test/ssh_config_test.rb 2019-10-10 14:15:54.000000000 +0200 @@ -46,6 +46,11 @@ expect(root1.system_name).to eq "Operating system 1" end + it "does not crash if /etc/os-release contains empty value" do + # root1 contains empty `EMPTY=` line + expect { described_class.from_dir(root1_dir) }.to_not raise_error + end + it "uses 'Linux' as name for systems without /etc/os-release file" do root2 = described_class.from_dir(root2_dir) expect(root2.system_name).to eq _("Linux")
