Hello community, here is the log from the commit of package zenity for openSUSE:Factory checked in at 2019-10-17 13:04:22 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/zenity (Old) and /work/SRC/openSUSE:Factory/.zenity.new.2352 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "zenity" Thu Oct 17 13:04:22 2019 rev:63 rq:736620 version:3.32.0 Changes: -------- --- /work/SRC/openSUSE:Factory/zenity/zenity.changes 2019-05-03 22:10:58.815343183 +0200 +++ /work/SRC/openSUSE:Factory/.zenity.new.2352/zenity.changes 2019-10-17 13:04:24.112527825 +0200 @@ -1,0 +2,6 @@ +Thu Sep 26 12:55:24 UTC 2019 - Bjørn Lie <[email protected]> + +- Add zenity-Fix-segfault-on-multiple-lists.patch: src/forms.c: Fix + segfault on multiple lists without values. + +------------------------------------------------------------------- New: ---- zenity-Fix-segfault-on-multiple-lists.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ zenity.spec ++++++ --- /var/tmp/diff_new_pack.9n9DNU/_old 2019-10-17 13:04:24.580526620 +0200 +++ /var/tmp/diff_new_pack.9n9DNU/_new 2019-10-17 13:04:24.580526620 +0200 @@ -24,6 +24,8 @@ Group: System/GUI/GNOME URL: https://wiki.gnome.org/Projects/Zenity Source0: https://download.gnome.org/sources/zenity/3.32/%{name}-%{version}.tar.xz +# PATCH-FIX-UPSTREAM zenity-Fix-segfault-on-multiple-lists.patch -- src/forms.c: Fix segfault on multiple lists without values. +Patch0: zenity-Fix-segfault-on-multiple-lists.patch BuildRequires: fdupes BuildRequires: pkgconfig ++++++ zenity-Fix-segfault-on-multiple-lists.patch ++++++ >From cd636315a5ff60567ff6a49ea10f326b69337029 Mon Sep 17 00:00:00 2001 From: quartenium <[email protected]> Date: Mon, 11 Sep 2017 17:59:11 +0300 Subject: [PATCH] src/forms.c: Fix segfault on multiple lists without values If was not provided enought list-values for add-list options then column_types is NULL. Therefore need set it to default value. If count of columns values less than count of list values then set column nubmer to zero. --- src/forms.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/forms.c b/src/forms.c index 4e6fca5..15df718 100644 --- a/src/forms.c +++ b/src/forms.c @@ -110,8 +110,15 @@ zenity_forms_create_and_fill_list ( tree_view = gtk_tree_view_new (); if (forms_data->column_values) { + int columns_values_count = + g_slist_length (forms_data->column_values); + int column_number = 0; + if (list_number < columns_values_count) { + column_number = list_number; + } + column_values = - g_slist_nth_data (forms_data->column_values, list_number); + g_slist_nth_data (forms_data->column_values, column_number); if (column_values) { gchar **values = g_strsplit_set (column_values, "|", -1); if (values) { @@ -130,6 +137,10 @@ zenity_forms_create_and_fill_list ( column_index++; } } + } else { + /* If no values available, add one with string type*/ + column_types = g_new (GType, n_columns); + column_types[0] = G_TYPE_STRING; } } -- 2.22.0
