Hello community, here is the log from the commit of package ktexteditor for openSUSE:Factory checked in at 2019-10-31 18:12:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ktexteditor (Old) and /work/SRC/openSUSE:Factory/.ktexteditor.new.2990 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ktexteditor" Thu Oct 31 18:12:59 2019 rev:72 rq:744291 version:5.63.0 Changes: -------- --- /work/SRC/openSUSE:Factory/ktexteditor/ktexteditor.changes 2019-10-14 13:38:55.921799359 +0200 +++ /work/SRC/openSUSE:Factory/.ktexteditor.new.2990/ktexteditor.changes 2019-10-31 18:12:59.313868389 +0100 @@ -1,0 +2,6 @@ +Wed Oct 30 16:19:58 UTC 2019 - Antonio Larrosa <[email protected]> + +- Add 0001-fix-crash-in-variableexpansionhelpers.patch to fix a crash + when adding a variable to swap file name (kde#413474) + +------------------------------------------------------------------- New: ---- 0001-fix-crash-in-variableexpansionhelpers.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ktexteditor.spec ++++++ --- /var/tmp/diff_new_pack.mDOicj/_old 2019-10-31 18:12:59.941869047 +0100 +++ /var/tmp/diff_new_pack.mDOicj/_new 2019-10-31 18:12:59.941869047 +0100 @@ -37,6 +37,8 @@ Source99: baselibs.conf # PATCH-MISFEATURE-OPENSUSE - Disliked by the security team (boo#1033055) Patch1: 0001-Disable-KAuth-integration.patch +# PATCH-FIX-UPSTREAM - fix crash (kde#413474) +Patch2: 0001-fix-crash-in-variableexpansionhelpers.patch BuildRequires: cmake >= 3.0 BuildRequires: extra-cmake-modules >= %{_kf5_bugfix_version} BuildRequires: fdupes ++++++ 0001-fix-crash-in-variableexpansionhelpers.patch ++++++ >From f6e72a23052339253daa79095391625cf01c96f1 Mon Sep 17 00:00:00 2001 From: Christoph Cullmann <[email protected]> Date: Mon, 28 Oct 2019 20:32:13 +0100 Subject: fix crash BUG: 413474 --- src/utils/katevariableexpansionhelpers.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/utils/katevariableexpansionhelpers.cpp b/src/utils/katevariableexpansionhelpers.cpp index db71d0f..89aab3d 100644 --- a/src/utils/katevariableexpansionhelpers.cpp +++ b/src/utils/katevariableexpansionhelpers.cpp @@ -278,7 +278,9 @@ KateVariableExpansionDialog::KateVariableExpansionDialog(QWidget *parent) connect(m_listView, &QAbstractItemView::activated, [this, lblDescription, lblCurrentValue](const QModelIndex &index) { if (index.isValid()) { const auto &var = m_variables[m_filterModel->mapToSource(index).row()]; - const auto name = QStringLiteral("%{") + var.name() + QLatin1Char('}'); + + // not auto, don't fall for string builder, see bug 413474 + const QString name = QStringLiteral("%{") + var.name() + QLatin1Char('}'); if (parentWidget() && parentWidget()->window()) { auto currentWidget = parentWidget()->window()->focusWidget(); -- cgit v1.1
