Hello community, here is the log from the commit of package lollypop for openSUSE:Factory checked in at 2019-10-31 22:23:14 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lollypop (Old) and /work/SRC/openSUSE:Factory/.lollypop.new.2990 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lollypop" Thu Oct 31 22:23:14 2019 rev:105 rq:744299 version:1.2.3 Changes: -------- --- /work/SRC/openSUSE:Factory/lollypop/lollypop.changes 2019-10-27 13:41:44.177319247 +0100 +++ /work/SRC/openSUSE:Factory/.lollypop.new.2990/lollypop.changes 2019-10-31 22:23:16.512156588 +0100 @@ -1,0 +2,13 @@ +Wed Oct 30 18:03:16 UTC 2019 - [email protected] + +- Update to version 1.2.3: + * Improve style of playback time (glgo#World/lollypop#2079). + * Fix a crash when adding a playlist section + (glgo#World/lollypop#2080). + * Fix several crashes in artist view (glgo#World/lollypop#2084, + glgo#World/lollypop#2095). + * Fix minor issues in radio view (glgo#World/lollypop#2089). + * Fix an issue with automatic playback + (glgo#World/lollypop#2092). + +------------------------------------------------------------------- Old: ---- lollypop-1.2.2.tar.xz New: ---- lollypop-1.2.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lollypop.spec ++++++ --- /var/tmp/diff_new_pack.p6YVRq/_old 2019-10-31 22:23:17.816158345 +0100 +++ /var/tmp/diff_new_pack.p6YVRq/_new 2019-10-31 22:23:17.832158366 +0100 @@ -17,7 +17,7 @@ Name: lollypop -Version: 1.2.2 +Version: 1.2.3 Release: 0 Summary: GNOME music playing application License: GPL-3.0-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.p6YVRq/_old 2019-10-31 22:23:17.920158485 +0100 +++ /var/tmp/diff_new_pack.p6YVRq/_new 2019-10-31 22:23:17.924158490 +0100 @@ -1,7 +1,7 @@ <services> <service mode="disabled" name="tar_scm"> <param name="changesgenerate">enable</param> - <param name="revision">1.2.2</param> + <param name="revision">1.2.3</param> <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> <param name="versionformat">@PARENT_TAG@</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.p6YVRq/_old 2019-10-31 22:23:18.036158641 +0100 +++ /var/tmp/diff_new_pack.p6YVRq/_new 2019-10-31 22:23:18.036158641 +0100 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> - <param name="changesrevision">e537b9953e4e992519fd4306d978037aff797a09</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">aea8d9b47c87ce8432806cbb0864da1e7fa39db8</param></service></servicedata> \ No newline at end of file ++++++ lollypop-1.2.2.tar.xz -> lollypop-1.2.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/data/TuneinPopover.ui new/lollypop-1.2.3/data/TuneinPopover.ui --- old/lollypop-1.2.2/data/TuneinPopover.ui 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/data/TuneinPopover.ui 2019-10-30 18:50:37.000000000 +0100 @@ -25,7 +25,7 @@ <property name="receives_default">True</property> <property name="tooltip_text" translatable="yes">Go back</property> <property name="halign">start</property> - <property name="valign">start</property> + <property name="valign">center</property> <property name="margin_start">5</property> <property name="margin_top">1</property> <property name="margin_bottom">3</property> @@ -57,6 +57,7 @@ <property name="receives_default">True</property> <property name="tooltip_text" translatable="yes">Go home</property> <property name="halign">start</property> + <property name="valign">center</property> <property name="margin_top">1</property> <property name="margin_bottom">3</property> <property name="hexpand">True</property> @@ -73,6 +74,9 @@ <object class="GtkSearchEntry"> <property name="visible">True</property> <property name="can_focus">True</property> + <property name="valign">center</property> + <property name="margin_top">5</property> + <property name="margin_bottom">5</property> <property name="primary_icon_name">edit-find-symbolic</property> <property name="primary_icon_activatable">False</property> <property name="primary_icon_sensitive">False</property> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/data/org.gnome.Lollypop.appdata.xml.in new/lollypop-1.2.3/data/org.gnome.Lollypop.appdata.xml.in --- old/lollypop-1.2.2/data/org.gnome.Lollypop.appdata.xml.in 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/data/org.gnome.Lollypop.appdata.xml.in 2019-10-30 18:50:37.000000000 +0100 @@ -17,7 +17,7 @@ </ul> </description> <releases> - <release version="1.2.2" date="2019-10-25"> + <release version="1.2.3" date="2019-10-30"> <description> </description> </release> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/menu_edit.py new/lollypop-1.2.3/lollypop/menu_edit.py --- old/lollypop-1.2.2/lollypop/menu_edit.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/menu_edit.py 2019-10-30 18:50:37.000000000 +0100 @@ -181,4 +181,4 @@ "MenuPopover::__on_edit_tag_action_activate(): %s", e) if not worked: App().notify.send("Lollypop", - _("Please install Easytag or Kid3")) + _("Please install EasyTAG or Kid3")) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/player_albums.py new/lollypop-1.2.3/lollypop/player_albums.py --- old/lollypop-1.2.2/lollypop/player_albums.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/player_albums.py 2019-10-30 18:50:37.000000000 +0100 @@ -17,7 +17,7 @@ from lollypop.logger import Logger from lollypop.objects_track import Track from lollypop.objects_album import Album -from lollypop.define import App +from lollypop.define import App, Repeat from lollypop.utils import emit_signal @@ -208,7 +208,19 @@ index = self.album_ids.index( App().player._current_playback_track.album.id) if index + 1 >= len(self._albums): - next_album = self._albums[0] + repeat = App().settings.get_enum("repeat") + if repeat == Repeat.AUTO: + genre_ids = self._current_track.genre_ids + if genre_ids: + album_ids = App().albums.get_randoms(genre_ids[0], + 1) + if album_ids: + next_album = Album(album_ids[0]) + self.add_album(next_album) + elif repeat == Repeat.ALL: + next_album = self._albums[0] + else: + self.stop() else: next_album = self._albums[index + 1] self.load(next_album.tracks[0]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/radios.py new/lollypop-1.2.3/lollypop/radios.py --- old/lollypop-1.2.2/lollypop/radios.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/radios.py 2019-10-30 18:50:37.000000000 +0100 @@ -61,12 +61,14 @@ @param uri as str @return radio id as int """ + lastrowid = 0 with SqlCursor(self, True) as sql: result = sql.execute("INSERT INTO radios (name, url, popularity)\ VALUES (?, ?, ?)", (name, uri, 0)) - emit_signal(self, "radio-changed", result.lastrowid) - return result.lastrowid + lastrowid = result.lastrowid + emit_signal(self, "radio-changed", lastrowid) + return lastrowid def exists(self, radio_id): """ @@ -104,7 +106,7 @@ sql.execute("DELETE FROM radios\ WHERE rowid=?", (radio_id,)) - emit_signal(self, "radio-changed", radio_id) + emit_signal(self, "radio-changed", radio_id) def get(self): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/shown.py new/lollypop-1.2.3/lollypop/shown.py --- old/lollypop-1.2.2/lollypop/shown.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/shown.py 2019-10-30 18:50:37.000000000 +0100 @@ -26,7 +26,7 @@ Type.RANDOMS: _("Random albums"), Type.LOVED: _("Loved albums"), Type.RECENTS: _("Recently added albums"), - Type.LITTLE: _("Little played albums"), + Type.LITTLE: _("Seldomly played albums"), Type.PLAYLISTS: _("Playlists"), Type.RADIOS: _("Radios"), Type.YEARS: _("Years"), @@ -69,7 +69,7 @@ Type.RANDOMS: _("Random tracks"), Type.LOVED: _("Loved tracks"), Type.RECENTS: _("Recently played tracks"), - Type.LITTLE: _("Little played tracks"), + Type.LITTLE: _("Seldomly played tracks"), Type.ALL: _("All tracks") } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/view_flowbox.py new/lollypop-1.2.3/lollypop/view_flowbox.py --- old/lollypop-1.2.2/lollypop/view_flowbox.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/view_flowbox.py 2019-10-30 18:50:37.000000000 +0100 @@ -58,14 +58,24 @@ """ LazyLoadingView.populate(self, items) - def add_value(self, item): + def add_value(self, item_id): """ Insert item - @param item as (int, str, str) + @param item_id as int """ # Setup sort on insert self._box.set_sort_func(self.__sort_func) - LazyLoadingView.populate(self, [item]) + LazyLoadingView.populate(self, [item_id]) + + def remove_value(self, item_id): + """ + Remove value + @param item_id as int + """ + for child in self._box.get_children(): + if child.data == item_id: + child.destroy() + break def activate_child(self): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/view_playlists_manager.py new/lollypop-1.2.3/lollypop/view_playlists_manager.py --- old/lollypop-1.2.2/lollypop/view_playlists_manager.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/view_playlists_manager.py 2019-10-30 18:50:37.000000000 +0100 @@ -42,7 +42,7 @@ self.__banner.set_view_type(self._view_type) self.add_widget(self._box, self.__banner) return [ - (App().playlists, "playlists-changed", "_on_playlist_changed") + (App().playlists, "playlists-changed", "_on_playlist_changed") ] def populate(self): @@ -59,15 +59,13 @@ App().task_helper.run(load, callback=(on_load,)) - def remove_value(self, item_id): + def add_value(self, item): """ - Remove value - @param item_id as int + Override FlowBox method to be compatible with SelectionList + Needed by SelectionListMenu + @param item as (int, str, str) """ - for child in self._box.get_children(): - if child.data == item_id: - child.destroy() - break + FlowBoxView.add_value(self, item[0]) @property def args(self): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/view_radios.py new/lollypop-1.2.3/lollypop/view_radios.py --- old/lollypop-1.2.2/lollypop/view_radios.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/view_radios.py 2019-10-30 18:50:37.000000000 +0100 @@ -131,7 +131,7 @@ item = child break if item is None: - self._add_items([radio_id]) + self.add_value(radio_id) else: name = App().radios.get_name(radio_id) item.rename(name) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/view_tracks.py new/lollypop-1.2.3/lollypop/view_tracks.py --- old/lollypop-1.2.2/lollypop/view_tracks.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/view_tracks.py 2019-10-30 18:50:37.000000000 +0100 @@ -102,8 +102,8 @@ label = Gtk.Label.new(text) label.get_style_context().add_class("text-large") label.show() - self._tracks_widget_left[-1].add(label) - self._tracks_widget_left[-1].show() + self.__responsive_widget.insert_row(0) + self.__responsive_widget.attach(label, 0, 0, 2, 1) def append_row(self, track): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/widgets_banner.py new/lollypop-1.2.3/lollypop/widgets_banner.py --- old/lollypop-1.2.2/lollypop/widgets_banner.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/widgets_banner.py 2019-10-30 18:50:37.000000000 +0100 @@ -64,6 +64,7 @@ @param view_type as ViewType """ Gtk.Revealer.__init__(self) + self._artwork = None self._view_type = view_type self.set_property("valign", Gtk.Align.START) if view_type & ViewType.OVERLAY: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/widgets_banner_album.py new/lollypop-1.2.3/lollypop/widgets_banner_album.py --- old/lollypop-1.2.2/lollypop/widgets_banner_album.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/widgets_banner_album.py 2019-10-30 18:50:37.000000000 +0100 @@ -127,7 +127,7 @@ @param allocation as Gtk.Allocation """ if BannerWidget._handle_width_allocate(self, allocation): - if self._view_type & ViewType.ALBUM: + if self._artwork is not None and self._view_type & ViewType.ALBUM: App().art_helper.set_album_artwork( self.__album, # +100 to prevent resize lag @@ -179,7 +179,8 @@ @param art as Art @param album_id as int """ - if album_id == self.__album.id and\ + if self._artwork is not None and\ + album_id == self.__album.id and\ self._view_type & ViewType.ALBUM and\ App().animations: App().art_helper.set_album_artwork( diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/widgets_player_label.py new/lollypop-1.2.3/lollypop/widgets_player_label.py --- old/lollypop-1.2.2/lollypop/widgets_player_label.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/widgets_player_label.py 2019-10-30 18:50:37.000000000 +0100 @@ -14,6 +14,7 @@ from lollypop.define import App from lollypop.helper_signals import SignalsHelper, signals +from lollypop.utils import on_query_tooltip class LabelPlayerWidget(Gtk.Label, SignalsHelper): @@ -31,6 +32,8 @@ self.__fullscreen = fullscreen self.__font_size = font_size self.set_ellipsize(Pango.EllipsizeMode.END) + self.set_has_tooltip(True) + self.connect("query-tooltip", on_query_tooltip) return [ (App().player, "current-changed", "_on_current_changed"), ] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/widgets_player_progress.py new/lollypop-1.2.3/lollypop/widgets_player_progress.py --- old/lollypop-1.2.2/lollypop/widgets_player_progress.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/widgets_player_progress.py 2019-10-30 18:50:37.000000000 +0100 @@ -34,7 +34,6 @@ self.__timeout_id = None self.__time_label = Gtk.Label.new() self.__time_label.show() - self.__time_label.get_style_context().add_class("monospace") self.__progress = Gtk.Scale.new(Gtk.Orientation.HORIZONTAL, None) self.__progress.show() self.__progress.set_hexpand(True) @@ -52,7 +51,6 @@ self.__event_controller.connect("scroll", self.__on_scroll) self.__total_time_label = Gtk.Label.new() self.__total_time_label.show() - self.__total_time_label.get_style_context().add_class("monospace") self.set_spacing(MARGIN_SMALL) self.pack_start(self.__time_label, False, False, 0) self.pack_start(self.__progress, False, True, 0) @@ -84,7 +82,9 @@ value = App().player.position / Gst.SECOND if value is not None and value >= 0: self.__progress.set_value(value) - self.__time_label.set_text(seconds_to_string(value)) + time_string = seconds_to_string(value) + self.__time_label.set_markup( + "<span font_features='tnum'>%s</span>" % time_string) return True ####################### @@ -103,12 +103,13 @@ return self.__progress.set_value(0.0) - self.__time_label.set_text("0:00") + self.__time_label.set_markup("<span font_features='tnum'>0:00</span>") if App().player.current_track.is_web: style_context.add_class("youtube-scale") self.__progress.set_range(0.0, App().player.current_track.duration) - self.__total_time_label.set_text( - seconds_to_string(App().player.current_track.duration)) + time_string = seconds_to_string(App().player.current_track.duration) + self.__total_time_label.set_markup( + "<span font_features='tnum'>%s</span>" % time_string) def _on_duration_changed(self, player, track_id): """ @@ -119,7 +120,9 @@ if track_id == player.current_track.id: duration = player.current_track.duration self.__progress.set_range(0.0, duration) - self.__total_time_label.set_text(seconds_to_string(duration)) + time_string = seconds_to_string(duration) + self.__total_time_label.set_markup( + "<span font_features='tnum'>%s</span>" % time_string) def _on_status_changed(self, player): """ @@ -152,7 +155,9 @@ @param scroll_type as Gtk.ScrollType @param value as float """ - self.__time_label.set_text(seconds_to_string(value)) + time_string = seconds_to_string(value) + self.__time_label.set_markup( + "<span font_features='tnum'>%s</span>" % time_string) def __on_multi_pressed(self, gesture, n_press, x, y): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/lollypop/widgets_radio.py new/lollypop-1.2.3/lollypop/widgets_radio.py --- old/lollypop-1.2.2/lollypop/widgets_radio.py 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/lollypop/widgets_radio.py 2019-10-30 18:50:37.000000000 +0100 @@ -193,7 +193,15 @@ Get name @return str """ - return self.__label.get_text() + return self._track.name + + @property + def sortname(self): + """ + Get sortname + @return str + """ + return self._track.name @property def data(self): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-1.2.2/meson.build new/lollypop-1.2.3/meson.build --- old/lollypop-1.2.2/meson.build 2019-10-25 22:05:36.000000000 +0200 +++ new/lollypop-1.2.3/meson.build 2019-10-30 18:50:37.000000000 +0100 @@ -1,5 +1,5 @@ project('lollypop', - version: '1.2.2', + version: '1.2.3', meson_version: '>= 0.40.0' ) i18n = import('i18n')
